GNU bug report logs - #72097
30.0.60; [PATCH] Don't add to Eshell history when aborting 'eshell-command'

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Sat, 13 Jul 2024 18:52:01 UTC

Severity: normal

Tags: patch

Found in version 30.0.60

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Jim Porter <jporterbugs <at> gmail.com>
To: 72097 <at> debbugs.gnu.org
Subject: bug#72097: 30.0.60; [PATCH] Don't add to Eshell history when aborting 'eshell-command'
Date: Sat, 13 Jul 2024 11:51:46 -0700

[Message part 1 (text/plain, inline)]
Steps to reproduce:

  emacs -Q
  M-x eshell-command RET oops C-g
  M-x eshell
  <up>

This will show the most-recent command in the Eshell history as "oops". 
That's because it was adding to the history in 'minibuffer-exit-hook', 
which runs regardless of *how* you exit the minibuffer. This regressed 
from 093a360251, and I misunderstood the conditions where 
'minibuffer-exit-hook' runs.

Attached is a patch to fix this. Is this ok for the release branch?
[0001-Don-t-save-to-history-from-eshell-command-when-abort.patch (text/plain, attachment)]
This bug report was last modified 311 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.