GNU bug report logs - #72097
30.0.60; [PATCH] Don't add to Eshell history when aborting 'eshell-command'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Subject: bug#72097: closed (Re: bug#72097: 30.0.60; [PATCH] Don't add to
 Eshell history when aborting 'eshell-command')
Date: Mon, 15 Jul 2024 16:15:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#72097: 30.0.60; [PATCH] Don't add to Eshell history when aborting 'eshell-command'

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 72097 <at> debbugs.gnu.org.

-- 
72097: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72097
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72097-done <at> debbugs.gnu.org
Subject: Re: bug#72097: 30.0.60; [PATCH] Don't add to Eshell history when
 aborting 'eshell-command'
Date: Mon, 15 Jul 2024 09:12:38 -0700

On 7/13/2024 9:42 PM, Eli Zaretskii wrote:
>> Attached is a patch to fix this. Is this ok for the release branch?
> 
> Yes, thanks.

Thanks. Merged to the release branch as 3407e274999, and closing this bug.

[Message part 3 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.60; [PATCH] Don't add to Eshell history when aborting
 'eshell-command'
Date: Sat, 13 Jul 2024 11:51:46 -0700

[Message part 4 (text/plain, inline)]

Steps to reproduce:

  emacs -Q
  M-x eshell-command RET oops C-g
  M-x eshell
  <up>

This will show the most-recent command in the Eshell history as "oops". 
That's because it was adding to the history in 'minibuffer-exit-hook', 
which runs regardless of *how* you exit the minibuffer. This regressed 
from 093a360251, and I misunderstood the conditions where 
'minibuffer-exit-hook' runs.

Attached is a patch to fix this. Is this ok for the release branch?

[0001-Don-t-save-to-history-from-eshell-command-when-abort.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.