Subject: bug#72091: closed (Re: bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 13 Jul 2024 12:21:02 +0000

Your bug report

#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
72091: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72091
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows
From: Eli Zaretskii <[email-masked]>
To: Raffael Stocker <[email-masked]>
Cc: [email-masked]
Date: Sat, 13 Jul 2024 15:20:39 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Raffael Stocker <[email-masked]>
> Date: Sat, 13 Jul 2024 13:37:22 +0200
> 
> the current Windows build of Emacs won't close notifications.  This is
> due to a typo recently introduced in ‘w32-notification-close’ that
> inverts a function pointer check.  See the attached patch.

Thanks, installed on the emacs-30 and closing the bug.

Subject: 30.0.60; [PATCH] Emacs won't close notifications on Windows
From: Raffael Stocker <[email-masked]>
To: [email-masked]
Date: Sat, 13 Jul 2024 13:37:22 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

the current Windows build of Emacs won't close notifications.  This is
due to a typo recently introduced in ‘w32-notification-close’ that
inverts a function pointer check.  See the attached patch.

Regards,
Raffael

>From c9996e0427762c264b6678269e83964e96ffd3ec Mon Sep 17 00:00:00 2001
From: Raffael Stocker <[email-masked]>
Date: Sat, 13 Jul 2024 13:26:23 +0200
Subject: [PATCH] ; * src/w32fns.c (Fw32_notification_close): fix typo

---
 src/w32fns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/w32fns.c b/src/w32fns.c
index 7fc2f598b3e..e5798fdd84f 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -10472,7 +10472,7 @@ DEFUN ("w32-notification-close",
 {
   struct frame *f = SELECTED_FRAME ();
 
-  if (FIXNUMP (id) && !pfnShell_NotifyIconW)
+  if (FIXNUMP (id) && pfnShell_NotifyIconW)
     delete_tray_notification (f, XFIXNUM (id));
 
   return Qnil;
-- 
2.45.2