From unknown Sun Jun 15 08:42:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows Resent-From: Raffael Stocker Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2024 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72091 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 72091@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172087066624638 (code B ref -1); Sat, 13 Jul 2024 11:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jul 2024 11:37:46 +0000 Received: from localhost ([127.0.0.1]:55233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSb4U-0006PK-2Y for submit@debbugs.gnu.org; Sat, 13 Jul 2024 07:37:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:42644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSb4R-0006P9-0I for submit@debbugs.gnu.org; Sat, 13 Jul 2024 07:37:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSb4P-0002rZ-S5 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 07:37:41 -0400 Received: from mail-out.m-online.net ([212.18.0.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSb4N-0004GX-O2 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 07:37:41 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4WLmfQ4Zxwz1syCl for ; Sat, 13 Jul 2024 13:37:34 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4WLmfQ0MYwz1qqlS for ; Sat, 13 Jul 2024 13:37:34 +0200 (CEST) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id pl34_RFmavA0 for ; Sat, 13 Jul 2024 13:37:26 +0200 (CEST) X-Auth-Info: 8/+GuOo/RCpn6CcPzqQtDheBMpJf5wlDtrxGDnuRRtzD37vP8QT0CPjep+73JcJb Received: from Whiteflame (ppp-212-114-182-234.dynamic.mnet-online.de [212.114.182.234]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA for ; Sat, 13 Jul 2024 13:37:26 +0200 (CEST) From: Raffael Stocker Date: Sat, 13 Jul 2024 13:37:22 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=212.18.0.10; envelope-from=r.stocker@mnet-mail.de; helo=mail-out.m-online.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, the current Windows build of Emacs won't close notifications. This is due to a typo recently introduced in =E2=80=98w32-notification-close=E2=80= =99 that inverts a function pointer check. See the attached patch. Regards, Raffael --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-src-w32fns.c-Fw32_notification_close-fix-typo.patch Content-Description: fixes typo in w32-notification-close >From c9996e0427762c264b6678269e83964e96ffd3ec Mon Sep 17 00:00:00 2001 From: Raffael Stocker Date: Sat, 13 Jul 2024 13:26:23 +0200 Subject: [PATCH] ; * src/w32fns.c (Fw32_notification_close): fix typo --- src/w32fns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/w32fns.c b/src/w32fns.c index 7fc2f598b3e..e5798fdd84f 100644 --- a/src/w32fns.c +++ b/src/w32fns.c @@ -10472,7 +10472,7 @@ DEFUN ("w32-notification-close", { struct frame *f = SELECTED_FRAME (); - if (FIXNUMP (id) && !pfnShell_NotifyIconW) + if (FIXNUMP (id) && pfnShell_NotifyIconW) delete_tray_notification (f, XFIXNUM (id)); return Qnil; -- 2.45.2 --=-=-=-- From unknown Sun Jun 15 08:42:56 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Raffael Stocker Subject: bug#72091: closed (Re: bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows) Message-ID: References: <86le25jxew.fsf@gnu.org> X-Gnu-PR-Message: they-closed 72091 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 72091@debbugs.gnu.org Date: Sat, 13 Jul 2024 12:21:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1720873262-29527-1" This is a multi-part message in MIME format... ------------=_1720873262-29527-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 72091@debbugs.gnu.org. --=20 72091: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72091 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1720873262-29527-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 72091-done) by debbugs.gnu.org; 13 Jul 2024 12:20:54 +0000 Received: from localhost ([127.0.0.1]:55270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSbkE-0007fp-Cr for submit@debbugs.gnu.org; Sat, 13 Jul 2024 08:20:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSbkC-0007fb-40 for 72091-done@debbugs.gnu.org; Sat, 13 Jul 2024 08:20:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSbk5-0007Ex-7z; Sat, 13 Jul 2024 08:20:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=kv8YKq0SfDFJSWZJuJthNAp9gibTWB79KYXMtiiXAcA=; b=pGP48P+WgMUYuUzRq+dI lvTiLL0YFFz/7OWJebOrWmxx25qRSip8gRGoLxlsNdPoDHeJKEWuFRssWZzGTidhZq1oHDm74VFo8 yhhHyhxrFWBx4ur10ATbjwjKGY+NadK9qMg/KPR391wQTf6ah89U9FLQXXD55QcIKDoApmg4nOefB XBuNHqU/+GvMNVFpNOHwZEh+SEotNbTPte0fMyNpw+g4ynZ3Yxpam3amTBFlUWiyqRqhld8QkRKZr 3myfoiI+pU21UCVr5uNYcrCI3r5P7dqor68l7/tgMw+rdhTkoj2VRFS2+JNvlepk+YK8O4oytxyU7 stvfj/mXaleU9Q==; Date: Sat, 13 Jul 2024 15:20:39 +0300 Message-Id: <86le25jxew.fsf@gnu.org> From: Eli Zaretskii To: Raffael Stocker In-Reply-To: (message from Raffael Stocker on Sat, 13 Jul 2024 13:37:22 +0200) Subject: Re: bug#72091: 30.0.60; [PATCH] Emacs won't close notifications on Windows References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72091-done Cc: 72091-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Raffael Stocker > Date: Sat, 13 Jul 2024 13:37:22 +0200 > > the current Windows build of Emacs won't close notifications. This is > due to a typo recently introduced in ‘w32-notification-close’ that > inverts a function pointer check. See the attached patch. Thanks, installed on the emacs-30 and closing the bug. ------------=_1720873262-29527-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jul 2024 11:37:46 +0000 Received: from localhost ([127.0.0.1]:55233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSb4U-0006PK-2Y for submit@debbugs.gnu.org; Sat, 13 Jul 2024 07:37:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:42644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSb4R-0006P9-0I for submit@debbugs.gnu.org; Sat, 13 Jul 2024 07:37:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSb4P-0002rZ-S5 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 07:37:41 -0400 Received: from mail-out.m-online.net ([212.18.0.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSb4N-0004GX-O2 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 07:37:41 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4WLmfQ4Zxwz1syCl for ; Sat, 13 Jul 2024 13:37:34 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4WLmfQ0MYwz1qqlS for ; Sat, 13 Jul 2024 13:37:34 +0200 (CEST) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id pl34_RFmavA0 for ; Sat, 13 Jul 2024 13:37:26 +0200 (CEST) X-Auth-Info: 8/+GuOo/RCpn6CcPzqQtDheBMpJf5wlDtrxGDnuRRtzD37vP8QT0CPjep+73JcJb Received: from Whiteflame (ppp-212-114-182-234.dynamic.mnet-online.de [212.114.182.234]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA for ; Sat, 13 Jul 2024 13:37:26 +0200 (CEST) From: Raffael Stocker To: bug-gnu-emacs@gnu.org Subject: 30.0.60; [PATCH] Emacs won't close notifications on Windows Date: Sat, 13 Jul 2024 13:37:22 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=212.18.0.10; envelope-from=r.stocker@mnet-mail.de; helo=mail-out.m-online.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, the current Windows build of Emacs won't close notifications. This is due to a typo recently introduced in =E2=80=98w32-notification-close=E2=80= =99 that inverts a function pointer check. See the attached patch. Regards, Raffael --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-src-w32fns.c-Fw32_notification_close-fix-typo.patch Content-Description: fixes typo in w32-notification-close >From c9996e0427762c264b6678269e83964e96ffd3ec Mon Sep 17 00:00:00 2001 From: Raffael Stocker Date: Sat, 13 Jul 2024 13:26:23 +0200 Subject: [PATCH] ; * src/w32fns.c (Fw32_notification_close): fix typo --- src/w32fns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/w32fns.c b/src/w32fns.c index 7fc2f598b3e..e5798fdd84f 100644 --- a/src/w32fns.c +++ b/src/w32fns.c @@ -10472,7 +10472,7 @@ DEFUN ("w32-notification-close", { struct frame *f = SELECTED_FRAME (); - if (FIXNUMP (id) && !pfnShell_NotifyIconW) + if (FIXNUMP (id) && pfnShell_NotifyIconW) delete_tray_notification (f, XFIXNUM (id)); return Qnil; -- 2.45.2 --=-=-=-- ------------=_1720873262-29527-1--