Subject: bug#72084: closed (Re: GUILE-VERSION changes don't propagate to .version and Makefile(s))

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 28 Jul 2024 19:41:02 +0000

Your bug report

#72084: GUILE-VERSION changes don't propagate to .version and Makefile(s)

which was filed against the guile package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
72084: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72084
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: GUILE-VERSION changes don't propagate to .version and Makefile(s)
From: Rob Browning <[email-masked]>
To: [email-masked]
Date: Sun, 28 Jul 2024 14:40:39 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Rob Browning <[email-masked]> writes:

> Changing GUILE-VERSION doesn't update these deriviative files.  This
> patch may fix that:

Pushed to main.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

Subject: GUILE-VERSION changes don't propagate to .version and Makefile(s)
From: Rob Browning <[email-masked]>
To: [email-masked]
Date: Fri, 12 Jul 2024 19:36:44 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Changing GUILE-VERSION doesn't update these deriviative files.  This
patch may fix that:

>From 485b9c282e0b4e6c6317666129e433e90acf4dea Mon Sep 17 00:00:00 2001
From: Rob Browning <[email-masked]>
Date: Sun, 30 Jun 2024 12:27:38 -0500
Subject: [PATCH 1/1] Ensure GUILE-VERSION changes propagate to .version and
 Makefiles

Have .version depend on the Makefile, and move our
CONFIG_STATUS_DEPENDENCIES setting to an AC_SUBST, as recommended by the
automake info pages "Rebuilding Makefiles" section, so that changes to
GUILE-VERSION will update the VERSION, etc. in the generated Makefiles.

* Makefile.am (CONFIG_STATUS_DEPENDENCIES): drop.
($(top_srcdir/.version)): depend on Makefile.
* configure: add GUILE-VERSION to CONFIG_STATUS_DEPENDENCIES via
AC_SUBST.
---
 Makefile.am  | 4 +---
 configure.ac | 1 +
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index b2ac5539e..c74761628 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -110,8 +110,6 @@ endif !HAVE_READLINE
 clean-local:
 	rm -rf cache/
 
-CONFIG_STATUS_DEPENDENCIES = GUILE-VERSION
-
 gen_start_rev = 61db429e251bfd2f75cb4632972e0238056eb24b
 .PHONY: gen-ChangeLog
 gen-ChangeLog:
@@ -133,7 +131,7 @@ assert-no-store-file-names:
 	fi
 
 BUILT_SOURCES += $(top_srcdir)/.version
-$(top_srcdir)/.version:
+$(top_srcdir)/.version: Makefile
 	echo $(VERSION) > $@-t && mv $@-t $@
 gen-tarball-version:
 	echo $(VERSION) > $(distdir)/.tarball-version
diff --git a/configure.ac b/configure.ac
index 0dcb71cce..262b171f1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -40,6 +40,7 @@ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])], [AC_SUBST([AM_DEFAULT_VERB
 AC_COPYRIGHT(GUILE_CONFIGURE_COPYRIGHT)
 AC_CONFIG_SRCDIR([GUILE-VERSION])
 
+AC_SUBST([CONFIG_STATUS_DEPENDENCIES], ['$(top_srcdir)/GUILE-VERSION'])
 . $srcdir/GUILE-VERSION
 GUILE_VERSION="$PACKAGE_VERSION"
 
-- 
2.43.0

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4