From unknown Sun Jun 15 08:55:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72084: GUILE-VERSION changes don't propagate to .version and Makefile(s) Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 13 Jul 2024 00:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72084 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 72084@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172083101115386 (code B ref -1); Sat, 13 Jul 2024 00:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jul 2024 00:36:51 +0000 Received: from localhost ([127.0.0.1]:54879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSQkt-000406-94 for submit@debbugs.gnu.org; Fri, 12 Jul 2024 20:36:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:38312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSQkq-0003zx-Qy for submit@debbugs.gnu.org; Fri, 12 Jul 2024 20:36:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSQkp-00085Q-UC for bug-guile@gnu.org; Fri, 12 Jul 2024 20:36:47 -0400 Received: from defaultvalue.org ([45.33.119.55]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSQkn-0006x0-Ba for bug-guile@gnu.org; Fri, 12 Jul 2024 20:36:47 -0400 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id C6837202C2 for ; Fri, 12 Jul 2024 19:36:44 -0500 (CDT) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 1B59414E05C; Fri, 12 Jul 2024 19:36:44 -0500 (CDT) From: Rob Browning Date: Fri, 12 Jul 2024 19:36:44 -0500 Message-ID: <87msmmw2jn.fsf@trouble.defaultvalue.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=45.33.119.55; envelope-from=rlb@defaultvalue.org; helo=defaultvalue.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Changing GUILE-VERSION doesn't update these deriviative files. This patch may fix that: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Ensure-GUILE-VERSION-changes-propagate-to-.version-a.patch Content-Description: 0001-Ensure-GUILE-VERSION-changes-propagate-to-.version-a.patch >From 485b9c282e0b4e6c6317666129e433e90acf4dea Mon Sep 17 00:00:00 2001 From: Rob Browning Date: Sun, 30 Jun 2024 12:27:38 -0500 Subject: [PATCH 1/1] Ensure GUILE-VERSION changes propagate to .version and Makefiles Have .version depend on the Makefile, and move our CONFIG_STATUS_DEPENDENCIES setting to an AC_SUBST, as recommended by the automake info pages "Rebuilding Makefiles" section, so that changes to GUILE-VERSION will update the VERSION, etc. in the generated Makefiles. * Makefile.am (CONFIG_STATUS_DEPENDENCIES): drop. ($(top_srcdir/.version)): depend on Makefile. * configure: add GUILE-VERSION to CONFIG_STATUS_DEPENDENCIES via AC_SUBST. --- Makefile.am | 4 +--- configure.ac | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index b2ac5539e..c74761628 100644 --- a/Makefile.am +++ b/Makefile.am @@ -110,8 +110,6 @@ endif !HAVE_READLINE clean-local: rm -rf cache/ -CONFIG_STATUS_DEPENDENCIES = GUILE-VERSION - gen_start_rev = 61db429e251bfd2f75cb4632972e0238056eb24b .PHONY: gen-ChangeLog gen-ChangeLog: @@ -133,7 +131,7 @@ assert-no-store-file-names: fi BUILT_SOURCES += $(top_srcdir)/.version -$(top_srcdir)/.version: +$(top_srcdir)/.version: Makefile echo $(VERSION) > $@-t && mv $@-t $@ gen-tarball-version: echo $(VERSION) > $(distdir)/.tarball-version diff --git a/configure.ac b/configure.ac index 0dcb71cce..262b171f1 100644 --- a/configure.ac +++ b/configure.ac @@ -40,6 +40,7 @@ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])], [AC_SUBST([AM_DEFAULT_VERB AC_COPYRIGHT(GUILE_CONFIGURE_COPYRIGHT) AC_CONFIG_SRCDIR([GUILE-VERSION]) +AC_SUBST([CONFIG_STATUS_DEPENDENCIES], ['$(top_srcdir)/GUILE-VERSION']) . $srcdir/GUILE-VERSION GUILE_VERSION="$PACKAGE_VERSION" -- 2.43.0 --=-=-= Content-Type: text/plain -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 --=-=-=-- From unknown Sun Jun 15 08:55:39 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Rob Browning Subject: bug#72084: closed (Re: GUILE-VERSION changes don't propagate to .version and Makefile(s)) Message-ID: References: <87jzh5s3t4.fsf@trouble.defaultvalue.org> <87msmmw2jn.fsf@trouble.defaultvalue.org> X-Gnu-PR-Message: they-closed 72084 X-Gnu-PR-Package: guile Reply-To: 72084@debbugs.gnu.org Date: Sun, 28 Jul 2024 19:41:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1722195662-7295-1" This is a multi-part message in MIME format... ------------=_1722195662-7295-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #72084: GUILE-VERSION changes don't propagate to .version and Makefile(s) which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 72084@debbugs.gnu.org. --=20 72084: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72084 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1722195662-7295-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 72084-done) by debbugs.gnu.org; 28 Jul 2024 19:40:57 +0000 Received: from localhost ([127.0.0.1]:44361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY9lJ-0001tF-5q for submit@debbugs.gnu.org; Sun, 28 Jul 2024 15:40:57 -0400 Received: from defaultvalue.org ([45.33.119.55]:33192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY9lF-0001t4-J3 for 72084-done@debbugs.gnu.org; Sun, 28 Jul 2024 15:40:56 -0400 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 3D017201CC for <72084-done@debbugs.gnu.org>; Sun, 28 Jul 2024 14:40:40 -0500 (CDT) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id ED0B614E05C; Sun, 28 Jul 2024 14:40:39 -0500 (CDT) From: Rob Browning To: 72084-done@debbugs.gnu.org Subject: Re: GUILE-VERSION changes don't propagate to .version and Makefile(s) In-Reply-To: <87msmmw2jn.fsf@trouble.defaultvalue.org> References: <87msmmw2jn.fsf@trouble.defaultvalue.org> Date: Sun, 28 Jul 2024 14:40:39 -0500 Message-ID: <87jzh5s3t4.fsf@trouble.defaultvalue.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 72084-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rob Browning writes: > Changing GUILE-VERSION doesn't update these deriviative files. This > patch may fix that: Pushed to main. -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 ------------=_1722195662-7295-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jul 2024 00:36:51 +0000 Received: from localhost ([127.0.0.1]:54879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSQkt-000406-94 for submit@debbugs.gnu.org; Fri, 12 Jul 2024 20:36:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:38312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSQkq-0003zx-Qy for submit@debbugs.gnu.org; Fri, 12 Jul 2024 20:36:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSQkp-00085Q-UC for bug-guile@gnu.org; Fri, 12 Jul 2024 20:36:47 -0400 Received: from defaultvalue.org ([45.33.119.55]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSQkn-0006x0-Ba for bug-guile@gnu.org; Fri, 12 Jul 2024 20:36:47 -0400 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id C6837202C2 for ; Fri, 12 Jul 2024 19:36:44 -0500 (CDT) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 1B59414E05C; Fri, 12 Jul 2024 19:36:44 -0500 (CDT) From: Rob Browning To: bug-guile@gnu.org Subject: GUILE-VERSION changes don't propagate to .version and Makefile(s) Date: Fri, 12 Jul 2024 19:36:44 -0500 Message-ID: <87msmmw2jn.fsf@trouble.defaultvalue.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=45.33.119.55; envelope-from=rlb@defaultvalue.org; helo=defaultvalue.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Changing GUILE-VERSION doesn't update these deriviative files. This patch may fix that: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Ensure-GUILE-VERSION-changes-propagate-to-.version-a.patch Content-Description: 0001-Ensure-GUILE-VERSION-changes-propagate-to-.version-a.patch >From 485b9c282e0b4e6c6317666129e433e90acf4dea Mon Sep 17 00:00:00 2001 From: Rob Browning Date: Sun, 30 Jun 2024 12:27:38 -0500 Subject: [PATCH 1/1] Ensure GUILE-VERSION changes propagate to .version and Makefiles Have .version depend on the Makefile, and move our CONFIG_STATUS_DEPENDENCIES setting to an AC_SUBST, as recommended by the automake info pages "Rebuilding Makefiles" section, so that changes to GUILE-VERSION will update the VERSION, etc. in the generated Makefiles. * Makefile.am (CONFIG_STATUS_DEPENDENCIES): drop. ($(top_srcdir/.version)): depend on Makefile. * configure: add GUILE-VERSION to CONFIG_STATUS_DEPENDENCIES via AC_SUBST. --- Makefile.am | 4 +--- configure.ac | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index b2ac5539e..c74761628 100644 --- a/Makefile.am +++ b/Makefile.am @@ -110,8 +110,6 @@ endif !HAVE_READLINE clean-local: rm -rf cache/ -CONFIG_STATUS_DEPENDENCIES = GUILE-VERSION - gen_start_rev = 61db429e251bfd2f75cb4632972e0238056eb24b .PHONY: gen-ChangeLog gen-ChangeLog: @@ -133,7 +131,7 @@ assert-no-store-file-names: fi BUILT_SOURCES += $(top_srcdir)/.version -$(top_srcdir)/.version: +$(top_srcdir)/.version: Makefile echo $(VERSION) > $@-t && mv $@-t $@ gen-tarball-version: echo $(VERSION) > $(distdir)/.tarball-version diff --git a/configure.ac b/configure.ac index 0dcb71cce..262b171f1 100644 --- a/configure.ac +++ b/configure.ac @@ -40,6 +40,7 @@ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])], [AC_SUBST([AM_DEFAULT_VERB AC_COPYRIGHT(GUILE_CONFIGURE_COPYRIGHT) AC_CONFIG_SRCDIR([GUILE-VERSION]) +AC_SUBST([CONFIG_STATUS_DEPENDENCIES], ['$(top_srcdir)/GUILE-VERSION']) . $srcdir/GUILE-VERSION GUILE_VERSION="$PACKAGE_VERSION" -- 2.43.0 --=-=-= Content-Type: text/plain -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 --=-=-=-- ------------=_1722195662-7295-1--