GNU bug report logs - #72069
[PATCH] Move configuration of auto-mode-alist out of js-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Damien Cassou <damien <at> cassou.me>
Subject: bug#72069: closed (Re: bug#72069: [PATCH] Move configuration of
 auto-mode-alist out of js-ts-mode)
Date: Tue, 11 Feb 2025 19:34:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#72069: [PATCH] Move configuration of auto-mode-alist out of js-ts-mode

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 72069 <at> debbugs.gnu.org.

-- 
72069: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72069
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Damien Cassou <damien <at> cassou.me>
Cc: Yuan Fu <casouri <at> gmail.com>, 72069-done <at> debbugs.gnu.org
Subject: Re: bug#72069: [PATCH] Move configuration of auto-mode-alist out of
 js-ts-mode
Date: Tue, 11 Feb 2025 11:33:09 -0800

Damien Cassou <damien <at> cassou.me> writes:

> Hi Stefan,
>
> thank you very much for your review.
>
> Stefan Kangas <stefankangas <at> gmail.com> writes:
>> Damien Cassou <damien <at> cassou.me> writes:
>> What about js-mode?  Shouldn't that be used out-of-the-box for these files?
>
>
> Definitely, I don't know what I was thinking. I'm not sure there is
> anything to save on this patch.
>
> If you believe I should wrap the call to `add-to-list' within a `(if
> (treesit-ready-p js) ...)' block I will do that but I don't think this
> is how things are done for other kinds of files. Otherwise, feel free to
> close this ticket and please forgive me.

OK, thanks, so I'm closing this bug now.

[Message part 3 (message/rfc822, inline)]

From: Damien Cassou <damien <at> cassou.me>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Move configuration of auto-mode-alist out of js-ts-mode
Date: Fri, 12 Jul 2024 09:58:45 +0200

[Message part 4 (text/plain, inline)]

Tags: patch

Hi,

The current version of the code requires the `js-ts-mode' function to
have already been executed for `auto-mode-alist' to contain an entry for
".jsx" files. The patch makes sure that `auto-mode-alist' is updates
when js.el is loaded.

Best

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[0001-Move-configuration-of-auto-mode-alist-out-of-js-ts-m.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.