GNU bug report logs - #7206
24.0.50; Bugs with minibuffer completion

Previous Next

Package: emacs;

Reported by: Tim Van Holder <tim.vanholder <at> gmail.com>

Date: Wed, 13 Oct 2010 11:58:02 UTC

Severity: normal

Found in version 24.0.50

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 7206 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Tim Van Holder <tim.vanholder <at> gmail.com>
Cc: 7206 <at> debbugs.gnu.org
Subject: Re: bug#7206: 24.0.50; Bugs with minibuffer completion
Date: Wed, 13 Oct 2010 20:40:13 +0200

[Message part 1 (text/plain, inline)]
On Wed, 13 Oct 2010 11:12:59 +0200 Tim Van Holder <tim.vanholder <at> gmail.com> wrote:

> Current bzr (r101947) has 2 issues with completion in the minibuffer:
>
> Recipe:
>
> $ emacs -Q
>   C-x C-f
>
> Issue #1:
>
>   Enter anything that has a non-unique completion (or don't enter
>   anything at all after ther default directory name prompt), and press
>   [tab]. Instead of getting the "[Complete, but not unique]" prompt, you
>   get an error instead:
>     minibuffer-completion-help: Wrong type argument: listp, 0
>   (the integer varies).
>   This also happens with non-path completions (e.g. C-h f).

This is due to this change:

2010-10-13  IRIE Shinsuke  <irieshinsuke <at> yahoo.co.jp>  (tiny change)

	* subr.el (last): Make it faster.  (Bug#7174)

Here is a fix:


[Message part 2 (text/x-patch, inline)]
*** /data/steve/bzr/emacs/trunk/lisp/subr.el	2010-10-13 14:41:39.000000000 +0200
--- /data/steve/bzr/emacs/quickfixes/lisp/subr.el	2010-10-13 20:34:46.000000000 +0200
***************
*** 290,299 ****
  If N is bigger than the length of LIST, return LIST."
    (if n
        (and (> n 0)
!            (let ((m (length list)))
               (if (< n m) (nthcdr (- m n) list) list)))
      (and list
!          (nthcdr (1- (length list)) list))))
  
  (defun butlast (list &optional n)
    "Return a copy of LIST with the last N elements removed."
--- 290,299 ----
  If N is bigger than the length of LIST, return LIST."
    (if n
        (and (> n 0)
!            (let ((m (safe-length list)))
               (if (< n m) (nthcdr (- m n) list) list)))
      (and list
!          (nthcdr (1- (safe-length list)) list))))
  
  (defun butlast (list &optional n)
    "Return a copy of LIST with the last N elements removed."

[Message part 3 (text/plain, inline)]
Steve Berman
This bug report was last modified 14 years and 225 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.