GNU bug report logs - #72018
30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed

Previous Next

Full log

Message #8 received at 72018 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 72018 <at> debbugs.gnu.org
Subject: Re: bug#72018: 30.0.60;
 [PATCH] Don't emit a prompt when a background Eshell process is killed
Date: Wed, 10 Jul 2024 14:16:05 +0300

> Date: Tue, 9 Jul 2024 11:04:05 -0700
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> This is a regression from Emacs 29, likely due to some changes I made to 
> improve support for complex background commands. Eli, is this ok to 
> merge to the release branch?

I don't think I understand the essence of the change, and thus cannot
appreciate its effects enough to be able to answer this.  What is the
significance of '(car command)' in this hunk:

> +          ;; Reset the prompt if the command we just aborted was in the
> +          ;; foreground.
> +          (unless (car command)
> +            (declare-function eshell-reset "esh-mode" (&optional no-hooks))
> +            (eshell-reset)))))))

IOW, why '(car command)' is used as an indication of a fore/background
command?  Also, why does the comment say "foreground" while your text
says we don't want the prompt if the killed program was in the
background?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.