GNU bug report logs - #72018
30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed

Previous Next

Full log

View this message in rfc822 format

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72018 <at> debbugs.gnu.org
Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed
Date: Wed, 10 Jul 2024 12:55:25 -0700

[Message part 1 (text/plain, inline)]

On 7/10/2024 10:34 AM, Eli Zaretskii wrote:
>> Date: Wed, 10 Jul 2024 09:16:11 -0700
>> Cc: 72018 <at> debbugs.gnu.org
>> From: Jim Porter <jporterbugs <at> gmail.com>
>>
>> We want to reset the prompt (this just emits a new command prompt) for
>> foreground commands, but for background commands, we don't need to do
>> anything. Would it be clearer if I inverted the wording in the comment,
>> like, "Don't reset the prompt if the command we just aborted was in the
>> background"?
> 
> I think these subtleties just warrant more detailed comments, and then
> we'll be fine.

How about this?

[0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.