From unknown Sat Jun 21 10:39:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2024 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 72018@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17205482567434 (code B ref -1); Tue, 09 Jul 2024 18:05:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Jul 2024 18:04:16 +0000 Received: from localhost ([127.0.0.1]:54042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRFCK-0001vq-DB for submit@debbugs.gnu.org; Tue, 09 Jul 2024 14:04:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:39894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRFCI-0001vi-52 for submit@debbugs.gnu.org; Tue, 09 Jul 2024 14:04:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRFCC-00045n-92 for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2024 14:04:08 -0400 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRFCA-0001Xc-EP for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2024 14:04:07 -0400 Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-3817084f7dbso25035845ab.2 for ; Tue, 09 Jul 2024 11:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720548245; x=1721153045; darn=gnu.org; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=zQ7+v9t2C2F6+a3q2/zafrYeZ/GhYO+C2vpjiNPpNso=; b=ZtOh9lhbmjNvWi80TWNYXOHGHIWZvy6IZOFXuO6m5KSg2jgR7ONH7B7AjdbWbaqjOZ 9s2DvDGOe5pwSnNg0S88DFI8RREPtrDHmUMfVc1zhBH7DZphZ3dQAWWixIudUAwuPjfE veRVQ1aElSBDCO2rWV8M2ZO7lPa5vR7h3gfWag6p357Am/EmMM7z3jcDNg6ovJ92aRiK DMp0RKFXnTK7x1c3NFCzCg3MmL5YbsRdTvkjhaOm0RKwW2QnhvDjrpADjqRdW3NPT24x u2CBEzr9G4VARVetCFHxJeBx34U9rkSbt5rSHwYRetfKJEMAZAnYr1dIvF8bvWVmiwqb 4uWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720548245; x=1721153045; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zQ7+v9t2C2F6+a3q2/zafrYeZ/GhYO+C2vpjiNPpNso=; b=o+t9Zdoy0c0Jkpfda38Brfk/qPMTcgHpHOemDAH92HZblOI8rHnXK/jiKyCIscYo5P vvjCxBErvwwsrBr4fBkmS+awABmgUyTyuVBU+pRlS7t4Uly0MFXDLx/mumVGgqvA/iQ8 +MyVzJsQ6IUmM9/bP0KPST12zussC+zFl5pdUFZf+NSMsqwxj3txO6nknasJVRX9r0yU ym2AiySZhARMnTKOLaWXuaHwQpg9zlkmafp6aj4CJzFdHHKLKmDmP/TJc952tCbxbkUb wBWer3UrPZMEuSkrR4GB9XM57s0zp0XGgASomaRyqgc+SUN49XIT24LscSUaQ2+pT5r3 Mp+g== X-Gm-Message-State: AOJu0YyDRGgD/bApWCLiPs1rcssCzuwqBy/XW9n6SjNrzKzN6Yc4KBsQ coRnDKM26dLj2p7aE+VmjOLXrk74IBhpSQhZws5lKdPm7I3tRfmQtb5KZQ== X-Google-Smtp-Source: AGHT+IGeVgjBBmi9NWYDKFCBuykzVJJg+K0RnucJ8Tm5fNTIVzxQjL49vanKKNajJOTFjoQaEgjZug== X-Received: by 2002:a05:6e02:19c6:b0:375:cad3:5eb2 with SMTP id e9e14a558f8ab-38a57215a5bmr35506315ab.13.1720548245002; Tue, 09 Jul 2024 11:04:05 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-77d62c4c7b0sm1701225a12.53.2024.07.09.11.04.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jul 2024 11:04:04 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------OLPez0swK1XLYct0OhuJJ91l" Message-ID: Date: Tue, 9 Jul 2024 11:04:05 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Received-SPF: pass client-ip=2607:f8b0:4864:20::12f; envelope-from=jporterbugs@gmail.com; helo=mail-il1-x12f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------OLPez0swK1XLYct0OhuJJ91l Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Steps to reproduce: emacs -Q -f eshell $ sleep 100 & $ kill -9 After this, you'll see two Eshell prompts get emitted (one with a "[9]" for the exit status of "sleep"). We don't want to emit prompts when background processes die though. This is a regression from Emacs 29, likely due to some changes I made to improve support for complex background commands. Eli, is this ok to merge to the release branch? --------------OLPez0swK1XLYct0OhuJJ91l Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.patch" Content-Disposition: attachment; filename*0="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzZTVhNzAyZjAxMzZjYzZhMDcxNTQ2YTg1NGFlYTU0NTM2Yzg3NzgzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgOSBKdWwgMjAyNCAxMDo0NTozNSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IGVtaXQgYSBwcm9tcHQgaW4gRXNoZWxsIHdoZW4gYSBiYWNrZ3JvdW5kIGNv bW1hbmQgaXMKIGtpbGxlZAoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtcmVz dW1lLWNvbW1hbmQpOiBDaGVjayBmb3IKYmFja2dyb3VuZC1uZXNzIGJlZm9yZSByZXNldHRp bmcgdGhlIHByb21wdC4KCiogdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCihl c2gtY21kLXRlc3QvYmFja2dyb3VuZC9zaW1wbGUtY29tbWFuZCk6IE1ha2UgdGhlIHJlZ2V4 cCBhIGJpdApzdHJpY3Rlci4KKGVzaC1jbWQtdGVzdC9iYWNrZ3JvdW5kL2tpbGwpOiBOZXcg dGVzdC4KLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgfCAgNyArKysr Ky0tCiB0ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwgfCAxNCArKysrKysrKysr KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwgYi9saXNwL2VzaGVsbC9l c2gtY21kLmVsCmluZGV4IDBiMzEzNzEyN2QyLi5kMGRlNmU1NWNlNiAxMDA2NDQKLS0tIGEv bGlzcC9lc2hlbGwvZXNoLWNtZC5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gtY21kLmVsCkBA IC0xMDQwLDggKzEwNDAsMTEgQEAgZXNoZWxsLXJlc3VtZS1jb21tYW5kCiAgICAgICAgICAg ICAgICAgIChub3QgKHN0cmluZy1tYXRjaCBlc2hlbGwtcmVzZXQtc2lnbmFscyBzdGF0dXMp KSkKICAgICAgICAgICAgIChlc2hlbGwtcmVzdW1lLWV2YWwgY29tbWFuZCkKICAgICAgICAg ICAoZXNoZWxsLXJlbW92ZS1jb21tYW5kIGNvbW1hbmQpCi0gICAgICAgICAgKGRlY2xhcmUt ZnVuY3Rpb24gZXNoZWxsLXJlc2V0ICJlc2gtbW9kZSIgKCZvcHRpb25hbCBuby1ob29rcykp Ci0gICAgICAgICAgKGVzaGVsbC1yZXNldCkpKSkpKQorICAgICAgICAgIDs7IFJlc2V0IHRo ZSBwcm9tcHQgaWYgdGhlIGNvbW1hbmQgd2UganVzdCBhYm9ydGVkIHdhcyBpbiB0aGUKKyAg ICAgICAgICA7OyBmb3JlZ3JvdW5kLgorICAgICAgICAgICh1bmxlc3MgKGNhciBjb21tYW5k KQorICAgICAgICAgICAgKGRlY2xhcmUtZnVuY3Rpb24gZXNoZWxsLXJlc2V0ICJlc2gtbW9k ZSIgKCZvcHRpb25hbCBuby1ob29rcykpCisgICAgICAgICAgICAoZXNoZWxsLXJlc2V0KSkp KSkpKQogCiAoZGVmdW4gZXNoZWxsLXJlc3VtZS1ldmFsIChjb21tYW5kKQogICAiRGVzdHJ1 Y3RpdmVseSBldmFsdWF0ZSBhIENPTU1BTkQgd2hpY2ggbWF5IG5lZWQgdG8gYmUgZGVmZXJy ZWQuCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwgYi90 ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwKaW5kZXggNzBlMTkwMWMxNjkuLmQ4 MTI0YTE5YWY2IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMu ZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCkBAIC0xMTMsNyAr MTEzLDcgQEAgZXNoLWNtZC10ZXN0L2JhY2tncm91bmQvc2ltcGxlLWNvbW1hbmQKICAgICAo d2l0aC10ZW1wLWVzaGVsbAogICAgICAoZXNoZWxsLW1hdGNoLWNvbW1hbmQtb3V0cHV0CiAg ICAgICAoZm9ybWF0ICIqZWNobyBoaSA+ICM8JXM+ICYiIGJ1Zm5hbWUpCi0gICAgICAocngg IltlY2hvIiAoPyAiLmV4ZSIpICJdICIgKCsgZGlnaXQpICJcbiIpKQorICAgICAgKHJ4IGJv cyAiW2VjaG8iICg/ICIuZXhlIikgIl0gIiAoKyBkaWdpdCkgIlxuIikpCiAgICAgIChlc2hl bGwtd2FpdC1mb3Itc3VicHJvY2VzcyB0KSkKICAgICAoc2hvdWxkIChlcXVhbCAoYnVmZmVy LXN0cmluZykgImhpXG4iKSkpKQogCkBAIC0xMjksNiArMTI5LDE4IEBAIGVzaC1jbWQtdGVz dC9iYWNrZ3JvdW5kL3N1YmNvbW1hbmQKICAgICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9j ZXNzIHQpKQogICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5nKSAib2xsZWhcbiIp KSkpCiAKKyhlcnQtZGVmdGVzdCBlc2gtY21kLXRlc3QvYmFja2dyb3VuZC9raWxsICgpCisg ICJNYWtlIHN1cmUgdGhhdCBhIGJhY2tncm91bmQgY29tbWFuZCB0aGF0IGdldHMga2lsbGVk IGRvZXNuJ3QgZW1pdCBhIHByb21wdC4iCisgIChza2lwLXVubGVzcyAoZXhlY3V0YWJsZS1m aW5kICJzbGVlcCIpKQorICAobGV0ICgoYmFja2dyb3VuZC1tZXNzYWdlIChyeCBib3MgIltz bGVlcCIgKD8gIi5leGUiKSAiXSAiICgrIGRpZ2l0KSAiXG4iKSkpCisgICAgKHdpdGgtdGVt cC1lc2hlbGwKKyAgICAgIChlc2hlbGwtbWF0Y2gtY29tbWFuZC1vdXRwdXQgIipzbGVlcCAx MCAmIiBiYWNrZ3JvdW5kLW1lc3NhZ2UpCisgICAgICAoa2lsbC1wcm9jZXNzIChjYWFyIGVz aGVsbC1wcm9jZXNzLWxpc3QpKQorICAgICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9jZXNz IHQpCisgICAgICA7OyBFbnN1cmUgd2UgZGlkbid0IGVtaXQgYW5vdGhlciBwcm9tcHQgYWZ0 ZXIga2lsbGluZyB0aGUKKyAgICAgIDs7IGJhY2tncm91bmQgcHJvY2Vzcy4KKyAgICAgIChz aG91bGQgKGVzaGVsbC1tYXRjaC1vdXRwdXQgYmFja2dyb3VuZC1tZXNzYWdlKSkpKSkKKwog DAogOzsgTGlzcCBmb3JtcwogCi0tIAoyLjI1LjEKCg== --------------OLPez0swK1XLYct0OhuJJ91l-- From unknown Sat Jun 21 10:39:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2024 11:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 72018@debbugs.gnu.org Received: via spool by 72018-submit@debbugs.gnu.org id=B72018.172061018316307 (code B ref 72018); Wed, 10 Jul 2024 11:17:01 +0000 Received: (at 72018) by debbugs.gnu.org; 10 Jul 2024 11:16:23 +0000 Received: from localhost ([127.0.0.1]:54988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRVJ9-0004Ev-9r for submit@debbugs.gnu.org; Wed, 10 Jul 2024 07:16:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRVJ7-0004ET-6d for 72018@debbugs.gnu.org; Wed, 10 Jul 2024 07:16:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRVIu-0004ML-MH; Wed, 10 Jul 2024 07:16:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j1WVJikiDBbRcwfeHkzKNHn+Ghi1flgpTmZ3l5A6OYc=; b=o0jYxd4kIQsC Z5tFIa9cgVqcq+6brQ/CSzXgGn7uRBPN0k1ruZId1pUWUWHoS9Q/kHEsjqBhexSGagWD7D58bqbKe grJHNNwBVjynU/2gkUiqlApVrVSIhVEba4nhZiWRF8LQKT7CHSsvuOp5GrtBDC9LTU6ya0BKSMTey FkG6N0kJkMlIsaO+DmrzytBpr+W8ulRg800ULrzc79d855RK2ADY1C/4jOMJLOZAwJ1nxCYNhSN4I 7NFAY4v5frKEDqvGOzPkhDQBYYCYOgLYPqXoj8L3cHZ8awOVWFW1aBmRMvzDMxxWtZQitwVNfHYZV VBsOqBxDF00kwNTUvxuWRg==; Date: Wed, 10 Jul 2024 14:16:05 +0300 Message-Id: <86frsho5u2.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Tue, 9 Jul 2024 11:04:05 -0700) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 9 Jul 2024 11:04:05 -0700 > From: Jim Porter > > This is a regression from Emacs 29, likely due to some changes I made to > improve support for complex background commands. Eli, is this ok to > merge to the release branch? I don't think I understand the essence of the change, and thus cannot appreciate its effects enough to be able to answer this. What is the significance of '(car command)' in this hunk: > + ;; Reset the prompt if the command we just aborted was in the > + ;; foreground. > + (unless (car command) > + (declare-function eshell-reset "esh-mode" (&optional no-hooks)) > + (eshell-reset))))))) IOW, why '(car command)' is used as an indication of a fore/background command? Also, why does the comment say "foreground" while your text says we don't want the prompt if the killed program was in the background? From unknown Sat Jun 21 10:39:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2024 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 72018@debbugs.gnu.org Received: via spool by 72018-submit@debbugs.gnu.org id=B72018.172062824528287 (code B ref 72018); Wed, 10 Jul 2024 16:18:01 +0000 Received: (at 72018) by debbugs.gnu.org; 10 Jul 2024 16:17:25 +0000 Received: from localhost ([127.0.0.1]:56985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRa0T-0007MB-EJ for submit@debbugs.gnu.org; Wed, 10 Jul 2024 12:17:25 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:52320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRa0R-0007Lm-BU for 72018@debbugs.gnu.org; Wed, 10 Jul 2024 12:17:23 -0400 Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1fb3cf78ff3so45153075ad.0 for <72018@debbugs.gnu.org>; Wed, 10 Jul 2024 09:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720628171; x=1721232971; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=nI79hCfF8wICgrEcXzIK+Tzai25m248Qs+sbos6yC4E=; b=kZj80hEKDY0LdhOU6iQ4Kn/lKY8K0v+nI4TIem2qzCD3JICLdps9Kj+Nj1Yfw4Czqa V6f3pbz4qmFm8tzwhLfmbwjOs5alu+tc3LsQu+qF37ULb45nTPHeSY/OmrHNl7l44h8N pWKyLJR0DGQCKyK5wCX8ab6cqPTn4z0pG8CuNATyr+U7urLFCDkCse/IWKMvYWNmj/jQ 6HCCFoRHwulsLoRFO48Kk8wLikst25tXXhlAPVgDv1goY8v34uXkwUme4VmJfbP7D07t 3S9gM6Fr+Rcw9G/oj7WFKh0sL9U9s03GXVKVYQYeBB2vJJTu0FImtLpNMWpGIOpJAc9P j4YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720628171; x=1721232971; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nI79hCfF8wICgrEcXzIK+Tzai25m248Qs+sbos6yC4E=; b=UQDH5Oi7Cq9iwCOFpk994VgAwzdxJ7fuygQUrCQJ8sq08DKb6NKi8jxY7xJrNcNquW baGPSAoVC77Uz6dhe7tpGPRF5/NV7zq6kP9gN2Xs9VEsU1eAT9ZHeHA/D/NjJyUcwWAn uj86YZsVWzBM8WGrEFNftAwGsQqg2x1g2sHqrP60wLeQT3K5pXL6n49+JfDt0TXJuThe GgVCxxaFRcUTWpANtFp1ViKc9z5SPXb2CEBzTHl/8DbYtk0XCtLmvmvPzDz3TmddxUjg 0FKsikOl1ww7OZBt43RJeDV516EK70eDfxHKf2RhOqanvlos8kMyUU7cJA29n3R4cSBL wpJQ== X-Gm-Message-State: AOJu0YzDiz8fuDHmKdfklwyRrX58p99HJNux6RAWcEe3hER7cd6VBB0b dUp43JA5P6rS79j+nvrdXYoDjom8qhcOi1fgL0WG5+4qCsRA//iR X-Google-Smtp-Source: AGHT+IHpSH0qYPXr8wcXRQTZDhfQdLtRsKbX+cO++jGjJ5hHbBsEKvHo7wayQna02+y7F/ReSW1xvw== X-Received: by 2002:a17:903:124d:b0:1fb:6d12:2c1c with SMTP id d9443c01a7336-1fbb6d0b6d3mr54064665ad.19.1720628171100; Wed, 10 Jul 2024 09:16:11 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1fbb6ab76aasm35430295ad.161.2024.07.10.09.16.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 09:16:10 -0700 (PDT) Message-ID: <6a233903-b1df-3d8b-1c25-e6b4b40b4cd5@gmail.com> Date: Wed, 10 Jul 2024 09:16:11 -0700 MIME-Version: 1.0 Content-Language: en-US References: <86frsho5u2.fsf@gnu.org> From: Jim Porter In-Reply-To: <86frsho5u2.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 7/10/2024 4:16 AM, Eli Zaretskii wrote: >> Date: Tue, 9 Jul 2024 11:04:05 -0700 >> From: Jim Porter >> >> This is a regression from Emacs 29, likely due to some changes I made to >> improve support for complex background commands. Eli, is this ok to >> merge to the release branch? > > I don't think I understand the essence of the change, and thus cannot > appreciate its effects enough to be able to answer this. What is the > significance of '(car command)' in this hunk: 'command' is a "command entry", and the result of 'eshell-commands-for-process', which returns a list of elements of the form: (BACKGROUND FORM PROCESSES) BACKGROUND is non-nil if the command is being run in the background. >> + ;; Reset the prompt if the command we just aborted was in the >> + ;; foreground. >> + (unless (car command) >> + (declare-function eshell-reset "esh-mode" (&optional no-hooks)) >> + (eshell-reset))))))) > > IOW, why '(car command)' is used as an indication of a fore/background > command? Also, why does the comment say "foreground" while your text > says we don't want the prompt if the killed program was in the > background? We want to reset the prompt (this just emits a new command prompt) for foreground commands, but for background commands, we don't need to do anything. Would it be clearer if I inverted the wording in the comment, like, "Don't reset the prompt if the command we just aborted was in the background"? From unknown Sat Jun 21 10:39:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2024 17:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 72018@debbugs.gnu.org Received: via spool by 72018-submit@debbugs.gnu.org id=B72018.172063295215025 (code B ref 72018); Wed, 10 Jul 2024 17:36:02 +0000 Received: (at 72018) by debbugs.gnu.org; 10 Jul 2024 17:35:52 +0000 Received: from localhost ([127.0.0.1]:57087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRbEN-0003uG-Ou for submit@debbugs.gnu.org; Wed, 10 Jul 2024 13:35:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRbEM-0003u2-7l for 72018@debbugs.gnu.org; Wed, 10 Jul 2024 13:35:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRbEA-0007Kl-MD; Wed, 10 Jul 2024 13:35:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XJChHqPjeEK/mYFFKFPcNfU+bNhT2CI51fLNbI6nULI=; b=kDJVzAiLRTcI CvI8MPMGPvPjaL19UFnnMyiMfmywR8De63l3EtV2DLnwue1V245RWnH4I1lvWlpqcizx9hd99zye4 GGAPCKYSBumDiAZwyUfdvSW3X+/HrbeYX2yoVzs/OaVOxcpK8ROB4TWhMujN1W1/6INGIksYyQteP k0QiPLgjAPO+AUJ3CyegtmdokMWaaX0qzSDIDmb5VYy5IVGhl3ZdTIhpDrfXApxbdDdYH5NoZe30e fkhdbrt7Trs8sOLQ3Taq3VfjLRdyHXHWHl5J0N2WJ3UChh6gioHDnw+MGDBHvh7KcnjXdIklTpcZX 1JDDSbsGfiF2/bls0lyODA==; Date: Wed, 10 Jul 2024 20:34:57 +0300 Message-Id: <86y169m9q6.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <6a233903-b1df-3d8b-1c25-e6b4b40b4cd5@gmail.com> (message from Jim Porter on Wed, 10 Jul 2024 09:16:11 -0700) References: <86frsho5u2.fsf@gnu.org> <6a233903-b1df-3d8b-1c25-e6b4b40b4cd5@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 10 Jul 2024 09:16:11 -0700 > Cc: 72018@debbugs.gnu.org > From: Jim Porter > > On 7/10/2024 4:16 AM, Eli Zaretskii wrote: > > > > I don't think I understand the essence of the change, and thus cannot > > appreciate its effects enough to be able to answer this. What is the > > significance of '(car command)' in this hunk: > > 'command' is a "command entry", and the result of > 'eshell-commands-for-process', which returns a list of elements of the form: > > (BACKGROUND FORM PROCESSES) > > BACKGROUND is non-nil if the command is being run in the background. > > >> + ;; Reset the prompt if the command we just aborted was in the > >> + ;; foreground. > >> + (unless (car command) > >> + (declare-function eshell-reset "esh-mode" (&optional no-hooks)) > >> + (eshell-reset))))))) > > > > IOW, why '(car command)' is used as an indication of a fore/background > > command? Also, why does the comment say "foreground" while your text > > says we don't want the prompt if the killed program was in the > > background? > > We want to reset the prompt (this just emits a new command prompt) for > foreground commands, but for background commands, we don't need to do > anything. Would it be clearer if I inverted the wording in the comment, > like, "Don't reset the prompt if the command we just aborted was in the > background"? I think these subtleties just warrant more detailed comments, and then we'll be fine. From unknown Sat Jun 21 10:39:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2024 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 72018@debbugs.gnu.org Received: via spool by 72018-submit@debbugs.gnu.org id=B72018.17206430422794 (code B ref 72018); Wed, 10 Jul 2024 20:25:02 +0000 Received: (at 72018) by debbugs.gnu.org; 10 Jul 2024 20:24:02 +0000 Received: from localhost ([127.0.0.1]:50388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRdr6-0000iq-4V for submit@debbugs.gnu.org; Wed, 10 Jul 2024 16:24:00 -0400 Received: from mail-qt1-f176.google.com ([209.85.160.176]:51209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRdqz-0000iZ-RJ for 72018@debbugs.gnu.org; Wed, 10 Jul 2024 16:23:55 -0400 Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-447ed27aea2so866391cf.2 for <72018@debbugs.gnu.org>; Wed, 10 Jul 2024 13:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720642969; x=1721247769; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=xFCvvdTv6nVrGf8zku9o+oHEXWVPLjU/TkVd4OZ7uoY=; b=Pksh46JLqx1tuoae5XZG6pz2BMn/MV3ZQExhW9ULii8j0Rc4GHVXCi9HIkrDfdgwGm q4lV+AOU0OU5WK5nK276BMDfMgh8ignlRlDCOIwfXrV4nOIYfOgi6ZSCTCKCW1c9mkgk mHqZFbH9GUmLC6UgKaoq5or8ZiQLzttPTNa0kDe8je0Vt1/PJxQAR69MoZD9mRgpcbkm T5c6WK/OZsVz8adraO1bBdk/T/l6HyuRDPORtoCzYTmXVRYzSP/e4VlqrzgFcWRzvpZV /+9U9ydAP/fD69Kt5kSF9lOdD+dtWu5IBauD9t9cTZVe1fXKR82kqBXzBzA1hobMLCDS RHhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720642969; x=1721247769; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xFCvvdTv6nVrGf8zku9o+oHEXWVPLjU/TkVd4OZ7uoY=; b=lvR9jczgvZAPnXf/1aHn8nvVj1iAN1jNwodesFaX4E99Cqkw/ot4GzqqoJ+YyPcaul /dpe9yjA4vKFFe4YrEnvTzMCVoGB4lcdY6oKpAK7VGNXo385u8lrepX5/L3g1vKsGpQ2 Fg9uotrY/kdEOZk5boGPYOPD4Oi9iclBuB2qyMPz1iKxolypheN/neAYhATfWrwRDNrm hsTD8M1lle0Rnb1Ep0MH6Lvh5rCkwQCVl5GCiqH7HxxxZW1TgkXASGGwGD/mgK6eck7y uzCc/HHMegoWzG2osjAM1WvHuy03NNVKd3wiEqZbVwblrhYbXSHuf0Jc79Z1ujkKPiBD 38JQ== X-Gm-Message-State: AOJu0Yx/x1LaMtLyNp8L78kpzKO1Eniu2CWQhjJGu3Lh3yLLsIFfkvNi BJYjnefM6ZBVnXAC5jIXyR3c5/aHgg3rJGOsoFVtFSth0k94cCuZCUqR6Q== X-Google-Smtp-Source: AGHT+IG9unb67x88NSAJUgCb9v++z8xSZ4toV2ZTwZ8fIl74HjiCIpkdogIa4PMn0d42UcsEJ7m+Lw== X-Received: by 2002:a05:6a00:2195:b0:70b:301d:ea68 with SMTP id d2e1a72fcca58-70b43670809mr7210806b3a.31.1720641326912; Wed, 10 Jul 2024 12:55:26 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-70b438cb305sm4201579b3a.49.2024.07.10.12.55.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 12:55:26 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------Yn7ySHAv59FLcIoGWnaxG4KZ" Message-ID: Date: Wed, 10 Jul 2024 12:55:25 -0700 MIME-Version: 1.0 Content-Language: en-US References: <86frsho5u2.fsf@gnu.org> <6a233903-b1df-3d8b-1c25-e6b4b40b4cd5@gmail.com> <86y169m9q6.fsf@gnu.org> From: Jim Porter In-Reply-To: <86y169m9q6.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------Yn7ySHAv59FLcIoGWnaxG4KZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/2024 10:34 AM, Eli Zaretskii wrote: >> Date: Wed, 10 Jul 2024 09:16:11 -0700 >> Cc: 72018@debbugs.gnu.org >> From: Jim Porter >> >> We want to reset the prompt (this just emits a new command prompt) for >> foreground commands, but for background commands, we don't need to do >> anything. Would it be clearer if I inverted the wording in the comment, >> like, "Don't reset the prompt if the command we just aborted was in the >> background"? > > I think these subtleties just warrant more detailed comments, and then > we'll be fine. How about this? --------------Yn7ySHAv59FLcIoGWnaxG4KZ Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.patch" Content-Disposition: attachment; filename*0="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4NGZiOTk3YTk0NTAzZTc2YTY1YTViOTYzMDFkOWZmMmJhYWMxZmMzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgOSBKdWwgMjAyNCAxMDo0NTozNSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IGVtaXQgYSBwcm9tcHQgaW4gRXNoZWxsIHdoZW4gYSBiYWNrZ3JvdW5kIGNv bW1hbmQgaXMKIGtpbGxlZAoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtcmVz dW1lLWNvbW1hbmQpOiBDaGVjayBmb3IKYmFja2dyb3VuZC1uZXNzIGJlZm9yZSByZXNldHRp bmcgdGhlIHByb21wdC4KCiogdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCihl c2gtY21kLXRlc3QvYmFja2dyb3VuZC9zaW1wbGUtY29tbWFuZCk6IE1ha2UgdGhlIHJlZ2V4 cCBhIGJpdApzdHJpY3Rlci4KKGVzaC1jbWQtdGVzdC9iYWNrZ3JvdW5kL2tpbGwpOiBOZXcg dGVzdC4KLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgfCAxMSArKysr KysrKystLQogdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsIHwgMTQgKysrKysr KysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsIGIvbGlzcC9lc2hl bGwvZXNoLWNtZC5lbAppbmRleCAwYjMxMzcxMjdkMi4uZTk3ZTRmNmQwNjcgMTAwNjQ0Ci0t LSBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5l bApAQCAtMTAzMCw2ICsxMDMwLDkgQEAgZXNoZWxsLXJlc3VtZS1jb21tYW5kCiBQUk9DIGlz IHRoZSBwcm9jZXNzIHRoYXQgaW52b2tlZCB0aGlzIGZyb20gaXRzIHNlbnRpbmVsLCBhbmQK IFNUQVRVUyBpcyBpdHMgc3RhdHVzLiIKICAgKHdoZW4gcHJvYworICAgIDs7IEl0ZXJhdGUg b3ZlciBhbGwgdGhlIGNvbW1hbmRzIGFzc29jaWF0ZWQgd2l0aCB0aGlzIHByb2Nlc3MuICBF YWNoCisgICAgOzsgZWxlbWVudCBpcyBhIGxpc3Qgb2YgdGhlIGZvcm0gKEJBQ0tHUk9VTkQg Rk9STSBQUk9DRVNTRVMpIChzZWUKKyAgICA7OyBgZXNoZWxsLWFkZC1jb21tYW5kJykuCiAg ICAgKGRvbGlzdCAoY29tbWFuZCAoZXNoZWxsLWNvbW1hbmRzLWZvci1wcm9jZXNzIHByb2Mp KQogICAgICAgKHVubGVzcyAoc2VxLXNvbWUgIydlc2hlbGwtcHJvY2Vzcy1hY3RpdmUtcCAo bnRoIDIgY29tbWFuZCkpCiAgICAgICAgIChzZXRmIChudGggMiBjb21tYW5kKSBuaWwpIDsg Q2xlYXIgcHJvY2Vzc2VzIGZyb20gY29tbWFuZC4KQEAgLTEwNDAsOCArMTA0MywxMiBAQCBl c2hlbGwtcmVzdW1lLWNvbW1hbmQKICAgICAgICAgICAgICAgICAgKG5vdCAoc3RyaW5nLW1h dGNoIGVzaGVsbC1yZXNldC1zaWduYWxzIHN0YXR1cykpKQogICAgICAgICAgICAgKGVzaGVs bC1yZXN1bWUtZXZhbCBjb21tYW5kKQogICAgICAgICAgIChlc2hlbGwtcmVtb3ZlLWNvbW1h bmQgY29tbWFuZCkKLSAgICAgICAgICAoZGVjbGFyZS1mdW5jdGlvbiBlc2hlbGwtcmVzZXQg ImVzaC1tb2RlIiAoJm9wdGlvbmFsIG5vLWhvb2tzKSkKLSAgICAgICAgICAoZXNoZWxsLXJl c2V0KSkpKSkpCisgICAgICAgICAgOzsgQ2hlY2sgaWYgdGhlIGNvbW1hbmQgd2UganVzdCBh Ym9ydGVkIGlzIG1hcmtlZCBhcyBhCisgICAgICAgICAgOzsgYmFja2dyb3VuZCBjb21tYW5k LiAgSWYgbm90LCB3ZSBuZWVkIHRvIHJlc2V0IHRoZSBwcm9tcHQgc28KKyAgICAgICAgICA7 OyB0aGUgdXNlciBjYW4gZW50ZXIgYW5vdGhlciBjb21tYW5kLgorICAgICAgICAgICh1bmxl c3MgKGNhciBjb21tYW5kKQorICAgICAgICAgICAgKGRlY2xhcmUtZnVuY3Rpb24gZXNoZWxs LXJlc2V0ICJlc2gtbW9kZSIgKCZvcHRpb25hbCBuby1ob29rcykpCisgICAgICAgICAgICAo ZXNoZWxsLXJlc2V0KSkpKSkpKQogCiAoZGVmdW4gZXNoZWxsLXJlc3VtZS1ldmFsIChjb21t YW5kKQogICAiRGVzdHJ1Y3RpdmVseSBldmFsdWF0ZSBhIENPTU1BTkQgd2hpY2ggbWF5IG5l ZWQgdG8gYmUgZGVmZXJyZWQuCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1j bWQtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwKaW5kZXgg NzBlMTkwMWMxNjkuLmQ4MTI0YTE5YWY2IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxs L2VzaC1jbWQtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3Rz LmVsCkBAIC0xMTMsNyArMTEzLDcgQEAgZXNoLWNtZC10ZXN0L2JhY2tncm91bmQvc2ltcGxl LWNvbW1hbmQKICAgICAod2l0aC10ZW1wLWVzaGVsbAogICAgICAoZXNoZWxsLW1hdGNoLWNv bW1hbmQtb3V0cHV0CiAgICAgICAoZm9ybWF0ICIqZWNobyBoaSA+ICM8JXM+ICYiIGJ1Zm5h bWUpCi0gICAgICAocnggIltlY2hvIiAoPyAiLmV4ZSIpICJdICIgKCsgZGlnaXQpICJcbiIp KQorICAgICAgKHJ4IGJvcyAiW2VjaG8iICg/ICIuZXhlIikgIl0gIiAoKyBkaWdpdCkgIlxu IikpCiAgICAgIChlc2hlbGwtd2FpdC1mb3Itc3VicHJvY2VzcyB0KSkKICAgICAoc2hvdWxk IChlcXVhbCAoYnVmZmVyLXN0cmluZykgImhpXG4iKSkpKQogCkBAIC0xMjksNiArMTI5LDE4 IEBAIGVzaC1jbWQtdGVzdC9iYWNrZ3JvdW5kL3N1YmNvbW1hbmQKICAgICAgKGVzaGVsbC13 YWl0LWZvci1zdWJwcm9jZXNzIHQpKQogICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3Ry aW5nKSAib2xsZWhcbiIpKSkpCiAKKyhlcnQtZGVmdGVzdCBlc2gtY21kLXRlc3QvYmFja2dy b3VuZC9raWxsICgpCisgICJNYWtlIHN1cmUgdGhhdCBhIGJhY2tncm91bmQgY29tbWFuZCB0 aGF0IGdldHMga2lsbGVkIGRvZXNuJ3QgZW1pdCBhIHByb21wdC4iCisgIChza2lwLXVubGVz cyAoZXhlY3V0YWJsZS1maW5kICJzbGVlcCIpKQorICAobGV0ICgoYmFja2dyb3VuZC1tZXNz YWdlIChyeCBib3MgIltzbGVlcCIgKD8gIi5leGUiKSAiXSAiICgrIGRpZ2l0KSAiXG4iKSkp CisgICAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgICAgIChlc2hlbGwtbWF0Y2gtY29tbWFuZC1v dXRwdXQgIipzbGVlcCAxMCAmIiBiYWNrZ3JvdW5kLW1lc3NhZ2UpCisgICAgICAoa2lsbC1w cm9jZXNzIChjYWFyIGVzaGVsbC1wcm9jZXNzLWxpc3QpKQorICAgICAgKGVzaGVsbC13YWl0 LWZvci1zdWJwcm9jZXNzIHQpCisgICAgICA7OyBFbnN1cmUgd2UgZGlkbid0IGVtaXQgYW5v dGhlciBwcm9tcHQgYWZ0ZXIga2lsbGluZyB0aGUKKyAgICAgIDs7IGJhY2tncm91bmQgcHJv Y2Vzcy4KKyAgICAgIChzaG91bGQgKGVzaGVsbC1tYXRjaC1vdXRwdXQgYmFja2dyb3VuZC1t ZXNzYWdlKSkpKSkKKwogDAogOzsgTGlzcCBmb3JtcwogCi0tIAoyLjI1LjEKCg== --------------Yn7ySHAv59FLcIoGWnaxG4KZ-- From unknown Sat Jun 21 10:39:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2024 04:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 72018@debbugs.gnu.org Received: via spool by 72018-submit@debbugs.gnu.org id=B72018.172067259616380 (code B ref 72018); Thu, 11 Jul 2024 04:37:02 +0000 Received: (at 72018) by debbugs.gnu.org; 11 Jul 2024 04:36:36 +0000 Received: from localhost ([127.0.0.1]:50659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRlXn-0004G8-U4 for submit@debbugs.gnu.org; Thu, 11 Jul 2024 00:36:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRlXl-0004Fv-Se for 72018@debbugs.gnu.org; Thu, 11 Jul 2024 00:36:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRlVb-0005ps-Os; Thu, 11 Jul 2024 00:34:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yIipisYpKoVo9Z7Y6ubd7r+ad1/F508LsCddhV9l8oE=; b=l2I66ae/gIBy GjMA+j1UOOuweg8jjhtXNM7VEItS6iOZBJQbiAdf/Jkgim5oWqKPtyvL8gpsQ1ooyHsguRkWiELAW 63Drs6P3plj6IS4lfDmzixj6WXtEEhgAOcshF9mOCVTuRbF+4r0m4WSMRGh9DA2fN/c0lwMN7afXh 8opNtz7V38MFDKAiAD756YpskHiafHBix0uhTHKQDcM+RMm+UV/wYGxM5rv6ruwfQv+uzUg/3lvtk R4nDgx480wHJepNEIFSKqS+ggmMRJyjEHI6+TA+9ihY5GQwQkZU8USjG794zDc3Sn7/LCD7O0Z+6P Mxc91SwnKQk3vABkDmwaIQ==; Date: Thu, 11 Jul 2024 07:34:16 +0300 Message-Id: <86plrkmtrr.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Wed, 10 Jul 2024 12:55:25 -0700) References: <86frsho5u2.fsf@gnu.org> <6a233903-b1df-3d8b-1c25-e6b4b40b4cd5@gmail.com> <86y169m9q6.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 10 Jul 2024 12:55:25 -0700 > Cc: 72018@debbugs.gnu.org > From: Jim Porter > > On 7/10/2024 10:34 AM, Eli Zaretskii wrote: > >> Date: Wed, 10 Jul 2024 09:16:11 -0700 > >> Cc: 72018@debbugs.gnu.org > >> From: Jim Porter > >> > >> We want to reset the prompt (this just emits a new command prompt) for > >> foreground commands, but for background commands, we don't need to do > >> anything. Would it be clearer if I inverted the wording in the comment, > >> like, "Don't reset the prompt if the command we just aborted was in the > >> background"? > > > > I think these subtleties just warrant more detailed comments, and then > > we'll be fine. > > How about this? LGTM, thanks. This is okay for emacs-30. From unknown Sat Jun 21 10:39:11 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Porter Subject: bug#72018: closed (Re: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed) Message-ID: References: X-Gnu-PR-Message: they-closed 72018 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 72018@debbugs.gnu.org Date: Thu, 11 Jul 2024 23:46:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1720741562-29312-1" This is a multi-part message in MIME format... ------------=_1720741562-29312-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell proce= ss is killed which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 72018@debbugs.gnu.org. --=20 72018: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72018 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1720741562-29312-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 72018-done) by debbugs.gnu.org; 11 Jul 2024 23:45:15 +0000 Received: from localhost ([127.0.0.1]:52855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sS3TO-0007bG-S5 for submit@debbugs.gnu.org; Thu, 11 Jul 2024 19:45:15 -0400 Received: from mail-pj1-f43.google.com ([209.85.216.43]:45390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sS3TM-0007b0-9T for 72018-done@debbugs.gnu.org; Thu, 11 Jul 2024 19:45:12 -0400 Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2c96187b3d1so1114615a91.3 for <72018-done@debbugs.gnu.org>; Thu, 11 Jul 2024 16:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720741446; x=1721346246; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=mnNgkcoooxaexWDz7uNhV2AubnsV6OCqZWw3izRWk8g=; b=DptwlOI/XHNRBGM4AiXsrFP6dsK9cdc+x+k9PZOIYuLiB+et9WltLlm8n+0PYd5N+k FjCzlXHq/Ujgr8RqkcC6HO6y+n3Yre2lWzPspT3fexn7XPc+a0+RQ+DweG6O2IbiuQy1 xvX5c/tpuytOZHgdZmzHWXN/TWXgBVfv4zfOj0occaWutYrdVIo63qSJV0/BR6dvskAz Y38t+v8VBJ679VAfDcZC6odP0Upfo2f5Ziu4AgSalbqQl4LBcIDWMmTLM+P+7bcpeF+2 9lCmncau6l1hmPrKr582zKEJrkCP8/9tyQiU5WkITLxsqaCy8quG9Zk1Q5QCLi+CbK4s qJ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720741446; x=1721346246; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mnNgkcoooxaexWDz7uNhV2AubnsV6OCqZWw3izRWk8g=; b=jCoPq9+nvR4GPRaiH4mW41YKLqnNzQCUzBsna8xBBColF2wGm5FHrgIRiLQB7C1zAg 6j9/cnEMascDNFTQMbIFAz9KmIJyamUQZoM57bSFtOaDbQV5E5XQwQ0vq1ANXyELTY/l lKFrtALucL2a7j/0PyJsrpprzMa74rVAT164au88n+JzA/hwN5vI+4v6bui3LzXDgKlv 8hVQ36cHa4Lhwo8bg4aaGhkjZcvSVa/LWD7JEoqGdaQBlnMuBeACz7Ldd/Yg2QHV37wL RNkWHlVNhFf6mKqeKgjWpsUo8u1SBVDW9TXVsXNEoBWmwP8zE0aNlQlK4bItPN6FlkSH WdHw== X-Gm-Message-State: AOJu0YyKqCI1jH0+4wwZlOCTksm+IHGhcsewYf12G10fzd9imABHGoGY C4IHTVzxwoPgXPI+oWAaE3K3nJLY7ayEs9NoDirBMRSXJZccbB+K X-Google-Smtp-Source: AGHT+IFjWfRGTf8jt2jCqFFV17/xIZ38/mRyFs11h0mIJm+T+1cvpCYS4qiFnQdK0J/nGYfZtM0NQg== X-Received: by 2002:a17:90a:c684:b0:2c9:616a:6a46 with SMTP id 98e67ed59e1d1-2ca35c29460mr7778782a91.17.1720741446045; Thu, 11 Jul 2024 16:44:06 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2cacd70376asm152405a91.50.2024.07.11.16.44.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 16:44:05 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 16:44:05 -0700 MIME-Version: 1.0 Subject: Re: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed To: Eli Zaretskii References: <86frsho5u2.fsf@gnu.org> <6a233903-b1df-3d8b-1c25-e6b4b40b4cd5@gmail.com> <86y169m9q6.fsf@gnu.org> <86plrkmtrr.fsf@gnu.org> Content-Language: en-US From: Jim Porter In-Reply-To: <86plrkmtrr.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72018-done Cc: 72018-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 7/10/2024 9:34 PM, Eli Zaretskii wrote: > LGTM, thanks. > > This is okay for emacs-30. Thanks. Pushed to the release branch as 0de0056fd6b, and closing this bug. ------------=_1720741562-29312-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Jul 2024 18:04:16 +0000 Received: from localhost ([127.0.0.1]:54042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRFCK-0001vq-DB for submit@debbugs.gnu.org; Tue, 09 Jul 2024 14:04:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:39894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRFCI-0001vi-52 for submit@debbugs.gnu.org; Tue, 09 Jul 2024 14:04:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRFCC-00045n-92 for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2024 14:04:08 -0400 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRFCA-0001Xc-EP for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2024 14:04:07 -0400 Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-3817084f7dbso25035845ab.2 for ; Tue, 09 Jul 2024 11:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720548245; x=1721153045; darn=gnu.org; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=zQ7+v9t2C2F6+a3q2/zafrYeZ/GhYO+C2vpjiNPpNso=; b=ZtOh9lhbmjNvWi80TWNYXOHGHIWZvy6IZOFXuO6m5KSg2jgR7ONH7B7AjdbWbaqjOZ 9s2DvDGOe5pwSnNg0S88DFI8RREPtrDHmUMfVc1zhBH7DZphZ3dQAWWixIudUAwuPjfE veRVQ1aElSBDCO2rWV8M2ZO7lPa5vR7h3gfWag6p357Am/EmMM7z3jcDNg6ovJ92aRiK DMp0RKFXnTK7x1c3NFCzCg3MmL5YbsRdTvkjhaOm0RKwW2QnhvDjrpADjqRdW3NPT24x u2CBEzr9G4VARVetCFHxJeBx34U9rkSbt5rSHwYRetfKJEMAZAnYr1dIvF8bvWVmiwqb 4uWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720548245; x=1721153045; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zQ7+v9t2C2F6+a3q2/zafrYeZ/GhYO+C2vpjiNPpNso=; b=o+t9Zdoy0c0Jkpfda38Brfk/qPMTcgHpHOemDAH92HZblOI8rHnXK/jiKyCIscYo5P vvjCxBErvwwsrBr4fBkmS+awABmgUyTyuVBU+pRlS7t4Uly0MFXDLx/mumVGgqvA/iQ8 +MyVzJsQ6IUmM9/bP0KPST12zussC+zFl5pdUFZf+NSMsqwxj3txO6nknasJVRX9r0yU ym2AiySZhARMnTKOLaWXuaHwQpg9zlkmafp6aj4CJzFdHHKLKmDmP/TJc952tCbxbkUb wBWer3UrPZMEuSkrR4GB9XM57s0zp0XGgASomaRyqgc+SUN49XIT24LscSUaQ2+pT5r3 Mp+g== X-Gm-Message-State: AOJu0YyDRGgD/bApWCLiPs1rcssCzuwqBy/XW9n6SjNrzKzN6Yc4KBsQ coRnDKM26dLj2p7aE+VmjOLXrk74IBhpSQhZws5lKdPm7I3tRfmQtb5KZQ== X-Google-Smtp-Source: AGHT+IGeVgjBBmi9NWYDKFCBuykzVJJg+K0RnucJ8Tm5fNTIVzxQjL49vanKKNajJOTFjoQaEgjZug== X-Received: by 2002:a05:6e02:19c6:b0:375:cad3:5eb2 with SMTP id e9e14a558f8ab-38a57215a5bmr35506315ab.13.1720548245002; Tue, 09 Jul 2024 11:04:05 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-77d62c4c7b0sm1701225a12.53.2024.07.09.11.04.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jul 2024 11:04:04 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------OLPez0swK1XLYct0OhuJJ91l" Message-ID: Date: Tue, 9 Jul 2024 11:04:05 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Jim Porter Subject: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Received-SPF: pass client-ip=2607:f8b0:4864:20::12f; envelope-from=jporterbugs@gmail.com; helo=mail-il1-x12f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------OLPez0swK1XLYct0OhuJJ91l Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Steps to reproduce: emacs -Q -f eshell $ sleep 100 & $ kill -9 After this, you'll see two Eshell prompts get emitted (one with a "[9]" for the exit status of "sleep"). We don't want to emit prompts when background processes die though. This is a regression from Emacs 29, likely due to some changes I made to improve support for complex background commands. Eli, is this ok to merge to the release branch? --------------OLPez0swK1XLYct0OhuJJ91l Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.patch" Content-Disposition: attachment; filename*0="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzZTVhNzAyZjAxMzZjYzZhMDcxNTQ2YTg1NGFlYTU0NTM2Yzg3NzgzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgOSBKdWwgMjAyNCAxMDo0NTozNSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IGVtaXQgYSBwcm9tcHQgaW4gRXNoZWxsIHdoZW4gYSBiYWNrZ3JvdW5kIGNv bW1hbmQgaXMKIGtpbGxlZAoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtcmVz dW1lLWNvbW1hbmQpOiBDaGVjayBmb3IKYmFja2dyb3VuZC1uZXNzIGJlZm9yZSByZXNldHRp bmcgdGhlIHByb21wdC4KCiogdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCihl c2gtY21kLXRlc3QvYmFja2dyb3VuZC9zaW1wbGUtY29tbWFuZCk6IE1ha2UgdGhlIHJlZ2V4 cCBhIGJpdApzdHJpY3Rlci4KKGVzaC1jbWQtdGVzdC9iYWNrZ3JvdW5kL2tpbGwpOiBOZXcg dGVzdC4KLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgfCAgNyArKysr Ky0tCiB0ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwgfCAxNCArKysrKysrKysr KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwgYi9saXNwL2VzaGVsbC9l c2gtY21kLmVsCmluZGV4IDBiMzEzNzEyN2QyLi5kMGRlNmU1NWNlNiAxMDA2NDQKLS0tIGEv bGlzcC9lc2hlbGwvZXNoLWNtZC5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gtY21kLmVsCkBA IC0xMDQwLDggKzEwNDAsMTEgQEAgZXNoZWxsLXJlc3VtZS1jb21tYW5kCiAgICAgICAgICAg ICAgICAgIChub3QgKHN0cmluZy1tYXRjaCBlc2hlbGwtcmVzZXQtc2lnbmFscyBzdGF0dXMp KSkKICAgICAgICAgICAgIChlc2hlbGwtcmVzdW1lLWV2YWwgY29tbWFuZCkKICAgICAgICAg ICAoZXNoZWxsLXJlbW92ZS1jb21tYW5kIGNvbW1hbmQpCi0gICAgICAgICAgKGRlY2xhcmUt ZnVuY3Rpb24gZXNoZWxsLXJlc2V0ICJlc2gtbW9kZSIgKCZvcHRpb25hbCBuby1ob29rcykp Ci0gICAgICAgICAgKGVzaGVsbC1yZXNldCkpKSkpKQorICAgICAgICAgIDs7IFJlc2V0IHRo ZSBwcm9tcHQgaWYgdGhlIGNvbW1hbmQgd2UganVzdCBhYm9ydGVkIHdhcyBpbiB0aGUKKyAg ICAgICAgICA7OyBmb3JlZ3JvdW5kLgorICAgICAgICAgICh1bmxlc3MgKGNhciBjb21tYW5k KQorICAgICAgICAgICAgKGRlY2xhcmUtZnVuY3Rpb24gZXNoZWxsLXJlc2V0ICJlc2gtbW9k ZSIgKCZvcHRpb25hbCBuby1ob29rcykpCisgICAgICAgICAgICAoZXNoZWxsLXJlc2V0KSkp KSkpKQogCiAoZGVmdW4gZXNoZWxsLXJlc3VtZS1ldmFsIChjb21tYW5kKQogICAiRGVzdHJ1 Y3RpdmVseSBldmFsdWF0ZSBhIENPTU1BTkQgd2hpY2ggbWF5IG5lZWQgdG8gYmUgZGVmZXJy ZWQuCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwgYi90 ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwKaW5kZXggNzBlMTkwMWMxNjkuLmQ4 MTI0YTE5YWY2IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMu ZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCkBAIC0xMTMsNyAr MTEzLDcgQEAgZXNoLWNtZC10ZXN0L2JhY2tncm91bmQvc2ltcGxlLWNvbW1hbmQKICAgICAo d2l0aC10ZW1wLWVzaGVsbAogICAgICAoZXNoZWxsLW1hdGNoLWNvbW1hbmQtb3V0cHV0CiAg ICAgICAoZm9ybWF0ICIqZWNobyBoaSA+ICM8JXM+ICYiIGJ1Zm5hbWUpCi0gICAgICAocngg IltlY2hvIiAoPyAiLmV4ZSIpICJdICIgKCsgZGlnaXQpICJcbiIpKQorICAgICAgKHJ4IGJv cyAiW2VjaG8iICg/ICIuZXhlIikgIl0gIiAoKyBkaWdpdCkgIlxuIikpCiAgICAgIChlc2hl bGwtd2FpdC1mb3Itc3VicHJvY2VzcyB0KSkKICAgICAoc2hvdWxkIChlcXVhbCAoYnVmZmVy LXN0cmluZykgImhpXG4iKSkpKQogCkBAIC0xMjksNiArMTI5LDE4IEBAIGVzaC1jbWQtdGVz dC9iYWNrZ3JvdW5kL3N1YmNvbW1hbmQKICAgICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9j ZXNzIHQpKQogICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5nKSAib2xsZWhcbiIp KSkpCiAKKyhlcnQtZGVmdGVzdCBlc2gtY21kLXRlc3QvYmFja2dyb3VuZC9raWxsICgpCisg ICJNYWtlIHN1cmUgdGhhdCBhIGJhY2tncm91bmQgY29tbWFuZCB0aGF0IGdldHMga2lsbGVk IGRvZXNuJ3QgZW1pdCBhIHByb21wdC4iCisgIChza2lwLXVubGVzcyAoZXhlY3V0YWJsZS1m aW5kICJzbGVlcCIpKQorICAobGV0ICgoYmFja2dyb3VuZC1tZXNzYWdlIChyeCBib3MgIltz bGVlcCIgKD8gIi5leGUiKSAiXSAiICgrIGRpZ2l0KSAiXG4iKSkpCisgICAgKHdpdGgtdGVt cC1lc2hlbGwKKyAgICAgIChlc2hlbGwtbWF0Y2gtY29tbWFuZC1vdXRwdXQgIipzbGVlcCAx MCAmIiBiYWNrZ3JvdW5kLW1lc3NhZ2UpCisgICAgICAoa2lsbC1wcm9jZXNzIChjYWFyIGVz aGVsbC1wcm9jZXNzLWxpc3QpKQorICAgICAgKGVzaGVsbC13YWl0LWZvci1zdWJwcm9jZXNz IHQpCisgICAgICA7OyBFbnN1cmUgd2UgZGlkbid0IGVtaXQgYW5vdGhlciBwcm9tcHQgYWZ0 ZXIga2lsbGluZyB0aGUKKyAgICAgIDs7IGJhY2tncm91bmQgcHJvY2Vzcy4KKyAgICAgIChz aG91bGQgKGVzaGVsbC1tYXRjaC1vdXRwdXQgYmFja2dyb3VuZC1tZXNzYWdlKSkpKSkKKwog DAogOzsgTGlzcCBmb3JtcwogCi0tIAoyLjI1LjEKCg== --------------OLPez0swK1XLYct0OhuJJ91l-- ------------=_1720741562-29312-1--