From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 15:30:32 2010 Received: (at submit) by debbugs.gnu.org; 12 Oct 2010 19:30:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5kYS-0003fI-AP for submit@debbugs.gnu.org; Tue, 12 Oct 2010 15:30:32 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5kYP-0003fC-QY for submit@debbugs.gnu.org; Tue, 12 Oct 2010 15:30:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5kbf-0002Gb-T1 for submit@debbugs.gnu.org; Tue, 12 Oct 2010 15:33:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:32838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5kbf-0002GW-Qc for submit@debbugs.gnu.org; Tue, 12 Oct 2010 15:33:51 -0400 Received: from [140.186.70.92] (port=55665 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5kbR-0005eO-HN for bug-coreutils@gnu.org; Tue, 12 Oct 2010 15:33:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5kbJ-0002CN-Vg for bug-coreutils@gnu.org; Tue, 12 Oct 2010 15:33:37 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:53533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5kbJ-0002CD-N3 for bug-coreutils@gnu.org; Tue, 12 Oct 2010 15:33:29 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id C771C39E80E1 for ; Tue, 12 Oct 2010 12:33:27 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l9w62V8EdSfl for ; Tue, 12 Oct 2010 12:33:27 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 13D5F39E80DB for ; Tue, 12 Oct 2010 12:33:27 -0700 (PDT) Message-ID: <4CB4B806.6020901@cs.ucla.edu> Date: Tue, 12 Oct 2010 12:33:26 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8 MIME-Version: 1.0 To: Bug-coreutils Subject: [PATCH] mbsalign: avoid warning with Solaris 10 cc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) For the Oct. 10 snapshot Solaris 10 cc issues this warning: "mbsalign.c", line 135: warning: initializer does not fit or is out of range: -1 This is just a warning and doesn't break anything, but it's trivial to fix: >From 879d26601a7423e847fbc566ff7cea83ec7ed4e9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 12 Oct 2010 12:31:13 -0700 Subject: [PATCH] mbsalign: avoid warning with Solaris 10 cc * gl/lib/mbsalign.c: Include for SIZE_MAX. Use SIZE_MAX rather than (size_t) -1, to avoid warning for "size_t x = -1" on Solaris 10 cc. * gl/modules/mbsalign (Depends-on): Add stdint. --- gl/lib/mbsalign.c | 9 +++++---- gl/modules/mbsalign | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gl/lib/mbsalign.c b/gl/lib/mbsalign.c index 117e4bf..d588432 100644 --- a/gl/lib/mbsalign.c +++ b/gl/lib/mbsalign.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include @@ -124,7 +125,7 @@ mbs_align_pad (char *dest, const char* dest_end, size_t n_spaces) Return the length in bytes required for the final result, not counting the trailing NUL. A return value of DEST_SIZE or larger means there wasn't enough space. DEST will be NUL terminated in any case. - Return (size_t) -1 upon error (invalid multi-byte sequence in SRC, + Return SIZE_MAX upon error (invalid multi-byte sequence in SRC, or malloc failure), unless MBA_UNIBYTE_FALLBACK is specified. Update *WIDTH to indicate how many columns were used before padding. */ @@ -132,7 +133,7 @@ size_t mbsalign (const char *src, char *dest, size_t dest_size, size_t *width, mbs_align_t align, int flags) { - size_t ret = -1; + size_t ret = SIZE_MAX; size_t src_size = strlen (src) + 1; char *newstr = NULL; wchar_t *str_wc = NULL; @@ -149,7 +150,7 @@ mbsalign (const char *src, char *dest, size_t dest_size, if (MB_CUR_MAX > 1) { size_t src_chars = mbstowcs (NULL, src, 0); - if (src_chars == (size_t) -1) + if (src_chars == SIZE_MAX) { if (flags & MBA_UNIBYTE_FALLBACK) goto mbsalign_unibyte; @@ -277,7 +278,7 @@ ambsalign (const char *src, size_t *width, mbs_align_t align, int flags) buf = nbuf; *width = orig_width; req = mbsalign (src, buf, size, width, align, flags); - if (req == (size_t) -1) + if (req == SIZE_MAX) { free (buf); buf = NULL; diff --git a/gl/modules/mbsalign b/gl/modules/mbsalign index 9d923b2..7f9c974 100644 --- a/gl/modules/mbsalign +++ b/gl/modules/mbsalign @@ -10,6 +10,7 @@ wchar wctype wcwidth mempcpy +stdint configure.ac: -- 1.7.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 15:54:51 2010 Received: (at 7200) by debbugs.gnu.org; 12 Oct 2010 19:54:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5kvy-0003qn-TC for submit@debbugs.gnu.org; Tue, 12 Oct 2010 15:54:51 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5kvx-0003qi-9N for 7200@debbugs.gnu.org; Tue, 12 Oct 2010 15:54:49 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 0EA32C73; Tue, 12 Oct 2010 21:58:17 +0200 (CEST) From: Jim Meyering To: Paul Eggert Subject: Re: bug#7200: [PATCH] mbsalign: avoid warning with Solaris 10 cc In-Reply-To: <4CB4B806.6020901@cs.ucla.edu> (Paul Eggert's message of "Tue, 12 Oct 2010 12:33:26 -0700") References: <4CB4B806.6020901@cs.ucla.edu> Date: Tue, 12 Oct 2010 21:58:17 +0200 Message-ID: <874ocr6v52.fsf@meyering.net> Lines: 16 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 7200 Cc: 7200@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) Paul Eggert wrote: > For the Oct. 10 snapshot Solaris 10 cc issues this warning: > > "mbsalign.c", line 135: warning: initializer does not fit or is out of range: -1 > > This is just a warning and doesn't break anything, but it's trivial to fix: This too looks safe enough. Feel free to push that. > Subject: [PATCH] mbsalign: avoid warning with Solaris 10 cc > > * gl/lib/mbsalign.c: Include for SIZE_MAX. > Use SIZE_MAX rather than (size_t) -1, to avoid warning for > "size_t x = -1" on Solaris 10 cc. > * gl/modules/mbsalign (Depends-on): Add stdint. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 17 04:57:24 2011 Received: (at 7200-done) by debbugs.gnu.org; 17 Apr 2011 08:57:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QBNnH-0000Jb-PP for submit@debbugs.gnu.org; Sun, 17 Apr 2011 04:57:23 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QBNnG-0000JQ-M8 for 7200-done@debbugs.gnu.org; Sun, 17 Apr 2011 04:57:23 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 42DF96012A; Sun, 17 Apr 2011 10:57:17 +0200 (CEST) From: Jim Meyering To: 7200-done@debbugs.gnu.org Subject: Re: bug#7200: [PATCH] mbsalign: avoid warning with Solaris 10 cc In-Reply-To: <874ocr6v52.fsf@meyering.net> (Jim Meyering's message of "Tue, 12 Oct 2010 21:58:17 +0200") References: <4CB4B806.6020901@cs.ucla.edu> <874ocr6v52.fsf@meyering.net> Date: Sun, 17 Apr 2011 10:57:17 +0200 Message-ID: <877hatdzma.fsf@rho.meyering.net> Lines: 19 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: 7200-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Jim Meyering wrote: > Paul Eggert wrote: >> For the Oct. 10 snapshot Solaris 10 cc issues this warning: >> >> "mbsalign.c", line 135: warning: initializer does not fit or is out of range: -1 >> >> This is just a warning and doesn't break anything, but it's trivial to fix: > > This too looks safe enough. > Feel free to push that. > >> Subject: [PATCH] mbsalign: avoid warning with Solaris 10 cc >> >> * gl/lib/mbsalign.c: Include for SIZE_MAX. >> Use SIZE_MAX rather than (size_t) -1, to avoid warning for >> "size_t x = -1" on Solaris 10 cc. >> * gl/modules/mbsalign (Depends-on): Add stdint. Patched 6 months ago. Closing. From unknown Mon Aug 18 21:49:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 15 May 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator