GNU bug report logs - #720
Patch to fix CVS Emacs compilation error on Windows XP SP2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 720 in the body.
You can then email your comments to 720 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Francis Litterio <flitterio <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Thu, 14 Aug 2008 12:57:56 -0400

When building CVS Emacs on Windows XP SP2 using Visual Studio 6.0, the
following patch is needed to prevent the compiler from displaying an
error about unsigned __int64 not being convertable to double.
--
Fran


--- w32.c~	2008-08-11 13:51:58.372421800 -0400
+++ w32.c	2008-08-14 12:54:29.192936600 -0400
@@ -3817,7 +3817,7 @@
                  attrs);
 
   if (global_memory_status_ex (&memstex))
-    totphys = memstex.ullTotalPhys / 1024.0;
+    totphys = (signed __int64)memstex.ullTotalPhys / 1024.0;
   else if (global_memory_status (&memst))
     totphys = memst.dwTotalPhys / 1024.0;
 

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Francis Litterio <flitterio <at> gmail.com>, 720 <at> debbugs.gnu.org
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Thu, 14 Aug 2008 22:24:32 +0300

> Date: Thu, 14 Aug 2008 12:57:56 -0400
> From: Francis Litterio <flitterio <at> gmail.com>
> Cc: 
> 
> When building CVS Emacs on Windows XP SP2 using Visual Studio 6.0, the
> following patch is needed to prevent the compiler from displaying an
> error about unsigned __int64 not being convertable to double.

Thank you for your report.  Can you show the error text?

> -    totphys = memstex.ullTotalPhys / 1024.0;
> +    totphys = (signed __int64)memstex.ullTotalPhys / 1024.0;

Does it help to use 1024.0L here instead of just 1024.0?

Message #20 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Francis Litterio <flitterio <at> gmail.com>
Cc: 720 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Thu, 14 Aug 2008 15:54:44 -0400

> When building CVS Emacs on Windows XP SP2 using Visual Studio 6.0, the
> following patch is needed to prevent the compiler from displaying an
> error about unsigned __int64 not being convertable to double.

Wouldn't it be better to cast to (double) ?


        Stefan

Message #30 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 720 <at> debbugs.gnu.org
Cc: flitterio <at> gmail.com, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Thu, 14 Aug 2008 23:20:07 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Thu, 14 Aug 2008 15:54:44 -0400
> Cc: bug-gnu-emacs <at> gnu.org, 720 <at> emacsbugs.donarmstrong.com
> 
> > When building CVS Emacs on Windows XP SP2 using Visual Studio 6.0, the
> > following patch is needed to prevent the compiler from displaying an
> > error about unsigned __int64 not being convertable to double.
> 
> Wouldn't it be better to cast to (double) ?

Wouldn't that be doing the same mistake?  The compiler probably has a
point: an unsigned 64-bit number has more bits than a simple double
can handle.

Message #40 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Francis Litterio <flitterio <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 720 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org,
        Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Thu, 14 Aug 2008 16:15:04 -0400

Eli Zaretskii wrote:

>> From: Francis Litterio
>> 
>> When building CVS Emacs on Windows XP SP2 using Visual Studio 6.0, the
>> following patch is needed to prevent the compiler from displaying an
>> error about unsigned __int64 not being convertable to double.
>
> Thank you for your report.  Can you show the error text?

Sorry for omitting that.  The error was:

	w32.c(3820) : error C2520: conversion from unsigned __int64 to double not implemented, use signed __int64

>> -    totphys = memstex.ullTotalPhys / 1024.0;
>> +    totphys = (signed __int64)memstex.ullTotalPhys / 1024.0;
>
> Does it help to use 1024.0L here instead of just 1024.0?

Nope.  Same error.

Else-thread, Stefan Monnier asked:

> Wouldn't it be better to cast to (double) ?

That doesn't help either.  Each of these variations causes the same error:

	    totphys = (double)(memstex.ullTotalPhys / 1024.0);

	    totphys = memstex.ullTotalPhys / (double)1024.0;

	    totphys = (double)memstex.ullTotalPhys / 1024.0L;

	    totphys = (double)memstex.ullTotalPhys / (double)1024.0;
--
Fran

Message #54 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Francis Litterio <flitterio <at> gmail.com>
Cc: 720 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org,
        monnier <at> iro.umontreal.ca
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Fri, 15 Aug 2008 11:22:07 +0300

> Cc: 720 <at> emacsbugs.donarmstrong.com, bug-gnu-emacs <at> gnu.org,
>         Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Thu, 14 Aug 2008 16:15:04 -0400
> From: Francis Litterio <flitterio <at> gmail.com>
> 
> 	w32.c(3820) : error C2520: conversion from unsigned __int64 to double not implemented, use signed __int64

"Not implemented"?  I'm not sure we want to support such a deficient
compiler.  How about this:

  DWORD tot_hi = memstex.ullTotalPhys >> 32;
  DWORD tot_md = (memstex.ullTotalPhys & 0x00000000ffffffffLL) >> 10;
  DWORD tot_lo = memstex.ullTotalPhys % 1024LL;
  totphys = tot_hi * 4194304.0 + tot_md + tot_lo / 1024.0;

Does this work?

Message #64 received at 720 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Francis Litterio <flitterio <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, 720 <at> debbugs.gnu.org
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Fri, 15 Aug 2008 09:22:31 -0400

Eli Zaretskii wrote:

>> From: Francis Litterio
>> 
>> 	w32.c(3820) : error C2520: conversion from unsigned __int64 to double not implemented, use signed __int64
>
> "Not implemented"?  I'm not sure we want to support such a deficient
> compiler.

I would happily use a newer compiler.  The file emacs/nt/INSTALL says
this:

   To compile Emacs, you will need either Microsoft Visual C++ 2.0, or
   later up to 7.0, and nmake

I didn't realize that I could use a version of VC++ newer than 6.0.  I
would be happy to abandon 6.0 for building Emacs on Windows.  Is VC++
7.0 the compiler that comes with Visual Studio 2003?

What compiler do the Emacs developers use to build on Windows?

> How about this:
>
>   DWORD tot_hi = memstex.ullTotalPhys >> 32;
>   DWORD tot_md = (memstex.ullTotalPhys & 0x00000000ffffffffLL) >> 10;
>   DWORD tot_lo = memstex.ullTotalPhys % 1024LL;
>   totphys = tot_hi * 4194304.0 + tot_md + tot_lo / 1024.0;
>
> Does this work?

Nope:

  w32.c(3823) : error C2059: syntax error : 'bad suffix on number'
  w32.c(3823) : error C2146: syntax error : missing ')' before identifier 'L'
  w32.c(3823) : error C2059: syntax error : ')'
  w32.c(3824) : error C2059: syntax error : 'bad suffix on number'
  w32.c(3824) : error C2146: syntax error : missing ';' before identifier 'L'
  w32.c(3824) : error C2065: 'L' : undeclared identifier

Here's the relevant code with line numbers:

  3819	  if (global_memory_status_ex (&memstex))
  3820	#if 1
  3821	  {
  3822	    DWORD tot_hi = memstex.ullTotalPhys >> 32;
  3823	    DWORD tot_md = (memstex.ullTotalPhys & 0x00000000ffffffffLL) >> 10;
  3824	    DWORD tot_lo = memstex.ullTotalPhys % 1024LL;
  3825	    totphys = tot_hi * 4194304.0 + tot_md + tot_lo / 1024.0;
  3826	  }
  3827	#else
  3828	    totphys = (signed __int64)memstex.ullTotalPhys / 1024.0;
  3829	#endif

--
Fran

Message #69 received at 720 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Francis Litterio <flitterio <at> gmail.com>
Cc: 720 <at> debbugs.gnu.org
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Fri, 15 Aug 2008 19:15:12 +0300

> Date: Fri, 15 Aug 2008 09:22:31 -0400
> From: Francis Litterio <flitterio <at> gmail.com>
> 
> Eli Zaretskii wrote:
> 
> >> From: Francis Litterio
> >> 
> >> 	w32.c(3820) : error C2520: conversion from unsigned __int64 to double not implemented, use signed __int64
> >
> > "Not implemented"?  I'm not sure we want to support such a deficient
> > compiler.
> 
> I would happily use a newer compiler.  The file emacs/nt/INSTALL says
> this:
> 
>    To compile Emacs, you will need either Microsoft Visual C++ 2.0, or
>    later up to 7.0, and nmake
> 
> I didn't realize that I could use a version of VC++ newer than 6.0.  I
> would be happy to abandon 6.0 for building Emacs on Windows.  Is VC++
> 7.0 the compiler that comes with Visual Studio 2003?

Yes.

> What compiler do the Emacs developers use to build on Windows?

The MinGW port of GCC.

> > How about this:
> >
> >   DWORD tot_hi = memstex.ullTotalPhys >> 32;
> >   DWORD tot_md = (memstex.ullTotalPhys & 0x00000000ffffffffLL) >> 10;
> >   DWORD tot_lo = memstex.ullTotalPhys % 1024LL;
> >   totphys = tot_hi * 4194304.0 + tot_md + tot_lo / 1024.0;
> >
> > Does this work?
> 
> Nope:
> 
>   w32.c(3823) : error C2059: syntax error : 'bad suffix on number'
>   w32.c(3823) : error C2146: syntax error : missing ')' before identifier 'L'
>   w32.c(3823) : error C2059: syntax error : ')'
>   w32.c(3824) : error C2059: syntax error : 'bad suffix on number'
>   w32.c(3824) : error C2146: syntax error : missing ';' before identifier 'L'
>   w32.c(3824) : error C2065: 'L' : undeclared identifier

Does it mean that the LL suffix is not supported in VS 6?  Can you try
the same without the 2 LL suffixes?

Message #74 received at 720 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Fran Litterio" <flitterio <at> gmail.com>
To: "Eli Zaretskii" <eliz <at> gnu.org>
Cc: 720 <at> debbugs.gnu.org
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Fri, 15 Aug 2008 13:11:45 -0400

[Message part 1 (text/plain, inline)]

On Fri, Aug 15, 2008 at 12:15 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > > How about this:
> > >
> > >   DWORD tot_hi = memstex.ullTotalPhys >> 32;
> > >   DWORD tot_md = (memstex.ullTotalPhys & 0x00000000ffffffffLL) >> 10;
> > >   DWORD tot_lo = memstex.ullTotalPhys % 1024LL;
> > >   totphys = tot_hi * 4194304.0 + tot_md + tot_lo / 1024.0;
> > >
> > > Does this work?
> >
> > Nope:
> >
> >   w32.c(3823) : error C2059: syntax error : 'bad suffix on number'
> >   w32.c(3823) : error C2146: syntax error : missing ')' before identifier
> 'L'
> >   w32.c(3823) : error C2059: syntax error : ')'
> >   w32.c(3824) : error C2059: syntax error : 'bad suffix on number'
> >   w32.c(3824) : error C2146: syntax error : missing ';' before identifier
> 'L'
> >   w32.c(3824) : error C2065: 'L' : undeclared identifier
>
> Does it mean that the LL suffix is not supported in VS 6?


I think so.


> Can you try
> the same without the 2 LL suffixes?
>

Yes, omitting the LL suffixes compiles with VS 6, though with several of
these warnings:

   warning C4244: '=' : conversion from 'long double ' to 'long ', possible
loss of data
--
Fran

[Message part 2 (text/html, inline)]

Message #79 received at 720 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Fran Litterio <flitterio <at> gmail.com>
Cc: 720 <at> debbugs.gnu.org
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Fri, 15 Aug 2008 20:37:05 +0300

> Date: Fri, 15 Aug 2008 13:11:45 -0400
> From: "Fran Litterio" <flitterio <at> gmail.com>
> Cc: 720 <at> emacsbugs.donarmstrong.com
> 
> > >   w32.c(3823) : error C2059: syntax error : 'bad suffix on number'
> > >   w32.c(3823) : error C2146: syntax error : missing ')' before identifier
> > 'L'
> > >   w32.c(3823) : error C2059: syntax error : ')'
> > >   w32.c(3824) : error C2059: syntax error : 'bad suffix on number'
> > >   w32.c(3824) : error C2146: syntax error : missing ';' before identifier
> > 'L'
> > >   w32.c(3824) : error C2065: 'L' : undeclared identifier
> >
> > Does it mean that the LL suffix is not supported in VS 6?
> 
> 
> I think so.
> 
> 
> > Can you try
> > the same without the 2 LL suffixes?
> >
> 
> Yes, omitting the LL suffixes compiles with VS 6, though with several of
> these warnings:
> 
>    warning C4244: '=' : conversion from 'long double ' to 'long ', possible
> loss of data

Thanks, I installed the version without LL suffixes.

Message #84 received at 720-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: 720-done <at> debbugs.gnu.org
Subject: Bug fixed
Date: Fri, 15 Aug 2008 20:39:57 +0300

This bug is fixed.

Message #89 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 720 <at> debbugs.gnu.org, flitterio <at> gmail.com, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Fri, 15 Aug 2008 15:31:49 -0400

>> > When building CVS Emacs on Windows XP SP2 using Visual Studio 6.0, the
>> > following patch is needed to prevent the compiler from displaying an
>> > error about unsigned __int64 not being convertable to double.
>> Wouldn't it be better to cast to (double) ?
> Wouldn't that be doing the same mistake?  The compiler probably has a
> point: an unsigned 64-bit number has more bits than a simple double
> can handle.

Yes, it's a good reason for not doing the conversion automatically, but
IIUC we need a double, so we don't have much of a choice, and that's
what the cast to (double) would tell the compiler.


        Stefan

Message #94 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Francis Litterio <flitterio <at> gmail.com>, 720 <at> debbugs.gnu.org,
        bug-gnu-emacs <at> gnu.org
Subject: Re: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Fri, 15 Aug 2008 15:34:36 -0400

> "Not implemented"?  I'm not sure we want to support such a deficient
> compiler.

Indeed we don't.

> How about this:

>   DWORD tot_hi = memstex.ullTotalPhys >> 32;
>   DWORD tot_md = (memstex.ullTotalPhys & 0x00000000ffffffffLL) >> 10;
>   DWORD tot_lo = memstex.ullTotalPhys % 1024LL;
>   totphys = tot_hi * 4194304.0 + tot_md + tot_lo / 1024.0;

> Does this work?

Please don't install such hideous code just to work around a deficiency
in an obsolete proprietary compiler.  Especially since there's
a perfectly good Free alternative available.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.