GNU bug report logs - #71998
31.0.50; Typescript grammar v0.21.2 causes test failure

Previous Next

Full log

Message #55 received at 71998-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 john muhl <jm <at> pub.pink>, Theodor Thornhill <theo <at> thornhill.no>,
 Eli Zaretskii <eliz <at> gnu.org>, 71998-done <at> debbugs.gnu.org
Subject: Re: bug#71998: 31.0.50; Typescript grammar v0.21.2 causes test failure
Date: Fri, 28 Feb 2025 17:42:30 -0800

Yuan Fu <casouri <at> gmail.com> writes:

>> On Feb 23, 2025, at 6:11 PM, john muhl <jm <at> pub.pink> wrote:
>>
>> Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:
>>
>>>> The newly released version 0.21.2 of the typescript grammar caused
>>> the typescript-ts-mode tests to start failing.
>>>
>>> I still get the exact same test error on master. Is this supposed to be fixed?
>>
>> I’m still seeing this test failure and a after a little poking
>> around I found that setting indent-tabs-mode to nil after changing
>> the major mode in the test setup fixes it for me. I don’t
>> understand why that’s a problem here and not in other tests but I
>> tested it on two different systems and they both pass now.
>
> Thanks Mattias, I applied you patch.
>
>> p.s. While looking around I noticed that tree-sitter reports
>> errors in the code of the “JSX indentation” test. Looks like the
>> values after the ? & : should be quoted but I don’t know anything
>> about TS/JSX.
>
> You’re right, they should be quoted. And there shouldn’t be a semi-colon at the
> end either, since the whole things is supposed to be an expression rather than a
> statement.
>
> I applied another patch that fixed it.

It seems like the patches were applied here, so I'm closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.