GNU bug report logs - #71998
31.0.50; Typescript grammar v0.21.2 causes test failure

Previous Next

Full log

Message #41 received at 71998 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Yuan Fu <casouri <at> gmail.com>, Theodor Thornhill <theo <at> thornhill.no>,
 Eli Zaretskii <eliz <at> gnu.org>, 71998 <at> debbugs.gnu.org
Subject: Re: bug#71998: 31.0.50; Typescript grammar v0.21.2 causes test failure
Date: Sun, 23 Feb 2025 20:11:50 -0600

[Message part 1 (text/plain, inline)]

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

>> The newly released version 0.21.2 of the typescript grammar caused
> the typescript-ts-mode tests to start failing.
>
> I still get the exact same test error on master. Is this supposed to be fixed?

I’m still seeing this test failure and a after a little poking
around I found that setting indent-tabs-mode to nil after changing
the major mode in the test setup fixes it for me. I don’t
understand why that’s a problem here and not in other tests but I
tested it on two different systems and they both pass now.

p.s. While looking around I noticed that tree-sitter reports
errors in the code of the “JSX indentation” test. Looks like the
values after the ? & : should be quoted but I don’t know anything
about TS/JSX.

[0001-Fix-typescript-ts-mode-indent-test.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.