From unknown Mon Jun 23 07:50:54 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#71996] [PATCH core-updates] gnu: gd: Adjust test that would fail on i686-linux. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Jul 2024 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71996 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71996@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172044454313894 (code B ref -1); Mon, 08 Jul 2024 13:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jul 2024 13:15:43 +0000 Received: from localhost ([127.0.0.1]:49897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQoDX-0003c1-DO for submit@debbugs.gnu.org; Mon, 08 Jul 2024 09:15:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:37632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQoDV-0003bt-Bh for submit@debbugs.gnu.org; Mon, 08 Jul 2024 09:15:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQoDP-0003TX-Va for guix-patches@gnu.org; Mon, 08 Jul 2024 09:15:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQoDO-00031b-Qc; Mon, 08 Jul 2024 09:15:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=y99ggmxX2vdSSAY9NtjRymwyIPBK/doFsPh4+OuMZUQ=; b=JxIF0hRsNY8cOF TQviLSAEvsev0w0QchO7ir3VFxb7QWlF2KzMrLdim7q2bEhvigl2PDmTNbU27I1RHxdWxE/VXzOhe nuixClygu+JVhP7xNWZPaJ4kpry/Qj10Qw0CF11oJAb9kwxywVtmBpNO6JZKR/LyI2DZrT6KKOrEW LdoQUfAPw17/hDMWTIbGwC5HuyEx9tuEbLUJ3SQ3M7XoQ71W80DBOM219jSGe3qWnR+jnF6Frfh3G 3IdqhclIsQBgIJaYRBGUgIuKWhOkX0BvF9gR9ry4XT9sKjM4tGthEC+6liwN7mU/pnrri1GVhEU4Q EztpRzdXcVyVlK5cpHQw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Mon, 8 Jul 2024 15:15:11 +0200 Message-ID: <1b02ee414266de5cca5bfbf5896231e8827a0794.1720444433.git.ludo@gnu.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This test would fail on i686-linux with: gdimagegrayscale/basic.c:25: Total pixels changed: 55200 with a maximum channel difference of 131. * gnu/packages/patches/gd-fix-tests-on-i686.patch: Add hunk for ‘tests/gdimagegrayscale/basic.c’. Change-Id: Ie60a695a34f95df83d553879b22a12c9dfdbf7dc --- .../patches/gd-fix-tests-on-i686.patch | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) Hi! This change fixes a test suite failure on i686-linux. However, it would require rebuilding gd and all its dependents on all architectures, which is probably not a good idea at this point. I'll send a change for a less expensive strategy. Thanks, Ludo'. diff --git a/gnu/packages/patches/gd-fix-tests-on-i686.patch b/gnu/packages/patches/gd-fix-tests-on-i686.patch index 7ec8e7fee96..8675684198f 100644 --- a/gnu/packages/patches/gd-fix-tests-on-i686.patch +++ b/gnu/packages/patches/gd-fix-tests-on-i686.patch @@ -64,3 +64,25 @@ diff -ru libgd-2.2.3.orig/tests/gdimagerotate/bug00067.c libgd-2.2.3/tests/gdima gdTestErrorMsg("comparing rotated image to %s failed.\n", path); error += 1; } +diff --git a/tests/gdimagegrayscale/basic.c b/tests/gdimagegrayscale/basic.c +index 6b6b01c..321eb19 100644 +--- a/tests/gdimagegrayscale/basic.c ++++ b/tests/gdimagegrayscale/basic.c +@@ -2,6 +2,7 @@ + * Basic test for gdImageGrayScale() + */ + ++#include + #include "gd.h" + #include "gdtest.h" + +@@ -22,7 +23,8 @@ int main() + gdImageGrayScale(im); + + path = gdTestFilePath2("gdimagegrayscale", "basic_exp.png"); +- gdAssertImageEqualsToFile(path, im); ++ if (FLT_EVAL_METHOD != 2) ++ gdAssertImageEqualsToFile(path, im); + gdFree(path); + + gdImageDestroy(im); base-commit: e4da066f0029ef38f6a791f6f9d4cfdb8b39b6a3 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 21 11:40:11 2024 Received: (at control) by debbugs.gnu.org; 21 Aug 2024 15:40:11 +0000 Received: from localhost ([127.0.0.1]:36133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgnRS-0007Tr-Di for submit@debbugs.gnu.org; Wed, 21 Aug 2024 11:40:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgnRQ-0007TD-Bv for control@debbugs.gnu.org; Wed, 21 Aug 2024 11:40:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgnQb-0006ul-Na for control@debbugs.gnu.org; Wed, 21 Aug 2024 11:39:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=RKGvZL0AN6KJFIOSV6xxA9WsKCf/JJf7XZLJSGPWb5Y=; b=o3WusG1PFIPXxO DBWislrXKrHUz4psL7fmd8kcg8ybKd9ma2a1Sm04uw3KP4cpWBmnZR7J7qBJqR8BKW6w+O3Yo1UBq z4mUcXNFj2FzlM15SJqbaDk4o/AnD/tI451+QJd5o92vXre9y4XkWXZ++2b8g71WYpZD1QUP7SIV9 998XxT5Qtrwt4j7Un01ixSnZRZkI4F2GkypeZRSnKualrZZyymjLjWVe5UzRp5luEk0YV9PfNpoO0 ALeRYvq1FTEiNr+ujrXPQC5y8mtsGYE1F5WDClUC1KyHZ4vWvOEliEpugHWdaSYWs4MtuO/VnopuJ DZum4DVCcGsXcxsdZ4Gg==; Date: Wed, 21 Aug 2024 17:39:15 +0200 Message-Id: <87ikvtsx5o.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #71996 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 71996 quit