GNU bug report logs - #71994
[PATCH] gnu: Add emacs-ob-racket.

Previous Next

Full log

Message #8 received at 71994 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Cc: 71994 <at> debbugs.gnu.org
Subject: Re: [bug#71994] [PATCH] gnu: Add emacs-ob-racket.
Date: Mon, 08 Jul 2024 12:51:19 +0200

Hello,

Sergiu Ivanov <sivanov <at> colimite.fr> writes:
>
> Here's a patch packaging emacs-ob-racket for Guix.

Thank you. Some comments follow.

> +(define-public emacs-ob-racket
> +  (let ((commit "c7b7eee58fcde2ad515b72288742e555e7ec7915")
> +	(version "1.3.0")
> +        (revision "0"))
> +    (package
> +      (name "emacs-ob-racket")
> +      (version (git-version version revision commit))

There's a "1.3.0" tag, so you can drop COMMIT and REVISION and use
(version "1.3.0").

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/hasu/emacs-ob-racket")
> +                      (commit commit)))

Here that will be (commit version).

> +                (sha256
> +                 (base32
> +                  "0bqhxi1nikxwc0gyqsnxc7ya2s41vc06w39s24qz64kja8zqzzya"))
> +                (file-name (git-file-name name version))))
> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/hasu/emacs-ob-racket")
> +      (synopsis "Org-babel support for Racket")

Nitpick Org Babel support for Racket

> +      (description
> +       "This package adds spport for working with Racket code blocks with
> +Org-babel in Org-mode.")

Likewise, Org Babel and Org mode.

I know, not every package definition follows that convention, but they
ARE WRONG! ;)

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.