GNU bug report logs - #71980
[3.0.10] posix.test uses depcrecated tmpnam

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Matt Wette <matt.wette <at> gmail.com>
Subject: bug#71980: closed (Re: bug#71980: [3.0.10] posix.test uses
 depcrecated tmpnam)
Date: Sun, 20 Oct 2024 19:28:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#71980: [3.0.10] posix.test uses depcrecated tmpnam

which was filed against the guile package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 71980 <at> debbugs.gnu.org.

-- 
71980: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71980
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 71980-done <at> debbugs.gnu.org, Matt Wette <matt.wette <at> gmail.com>
Subject: Re: bug#71980: [3.0.10] posix.test uses depcrecated tmpnam
Date: Sun, 20 Oct 2024 21:26:38 +0200

Tomas Volf <~@wolfsden.cz> skribis:

> On 2024-07-07 09:27:14 -0700, Matt Wette wrote:
>> With `--disable-tmpnam'  argument to configure, posix.test fails: missing
>> `tmpnam`.
>>
>> patch attached
>
> There also is #71796 as a possible patch (since June 27th), which is arguably
> bit smaller (albeit I am biased since I am the author over there ^_^ ).

Yes, I’ve just pushed it as ff256c356be9327c24a2d7fc0f007722422e6604.

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Matt Wette <matt.wette <at> gmail.com>
To: bug-guile <at> gnu.org
Subject: [3.0.10] posix.test uses depcrecated tmpnam
Date: Sun, 7 Jul 2024 09:27:14 -0700

[Message part 4 (text/plain, inline)]

With `--disable-tmpnam'  argument to configure, posix.test fails: 
missing `tmpnam`.

patch attached

--- test-suite/tests/posix.test-orig    2024-07-03 15:45:16.352132881 -0700
+++ test-suite/tests/posix.test    2024-07-07 09:21:53.342855356 -0700
@@ -361,20 +361,21 @@
       (status:exit-val (system* "something-that-does-not-exist"))))

   (pass-if-equal "https://bugs.gnu.org/52835"
-      "bong\n"
-    (let ((file (tmpnam)))
+    "bong\n"
+    (let ((port (mkstemp "T-XXXXXX")))
       ;; Redirect stdout and stderr to FILE.
       (define status
-        (call-with-output-file file
-          (lambda (port)
-            (with-output-to-port port
+        (with-output-to-port port
+          (lambda ()
+            (with-error-to-port port
               (lambda ()
-                (with-error-to-port port
-                  (lambda ()
-                    (system* "sh" "-c" "echo bong >&2"))))))))
+                (system* "sh" "-c" "echo bong >&2"))))))

       (and (zero? (status:exit-val status))
-           (call-with-input-file file get-string-all))))
+           (zero? (seek port 0 SEEK_SET))
+           (let ((contents (get-string-all port)))
+             (close-port port)
+             contents))))

   (pass-if-equal "https://bugs.gnu.org/63024"
       0

[PATCH (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.