From unknown Fri Sep 05 18:58:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#7198 <7198@debbugs.gnu.org> To: bug#7198 <7198@debbugs.gnu.org> Subject: Status: ls-misc failure with Oct 10 snapshot Reply-To: bug#7198 <7198@debbugs.gnu.org> Date: Sat, 06 Sep 2025 01:58:03 +0000 retitle 7198 ls-misc failure with Oct 10 snapshot reassign 7198 coreutils submitter 7198 Paul Eggert severity 7198 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 12:45:59 2010 Received: (at submit) by debbugs.gnu.org; 12 Oct 2010 16:45:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5hzD-0002Up-4E for submit@debbugs.gnu.org; Tue, 12 Oct 2010 12:45:59 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5hzB-0002Uk-3e for submit@debbugs.gnu.org; Tue, 12 Oct 2010 12:45:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5i2V-00033f-QV for submit@debbugs.gnu.org; Tue, 12 Oct 2010 12:49:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:43664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5i2V-00033Y-9q for submit@debbugs.gnu.org; Tue, 12 Oct 2010 12:49:23 -0400 Received: from [140.186.70.92] (port=56160 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5i2R-000156-Re for bug-coreutils@gnu.org; Tue, 12 Oct 2010 12:49:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5i2O-00032K-Ag for bug-coreutils@gnu.org; Tue, 12 Oct 2010 12:49:17 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:52847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5i2O-00031x-1B for bug-coreutils@gnu.org; Tue, 12 Oct 2010 12:49:16 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 18B6539E80E1 for ; Tue, 12 Oct 2010 09:49:14 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hh0RaVKA6BG5 for ; Tue, 12 Oct 2010 09:49:13 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 16F8339E80DC for ; Tue, 12 Oct 2010 09:49:13 -0700 (PDT) Message-ID: <4CB49188.1050406@cs.ucla.edu> Date: Tue, 12 Oct 2010 09:49:12 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8 MIME-Version: 1.0 To: Bug-coreutils Subject: ls-misc failure with Oct 10 snapshot References: <87pqvf8woh.fsf@meyering.net> <87d3rf8tnx.fsf@meyering.net> In-Reply-To: <87d3rf8tnx.fsf@meyering.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) I got this on RHEL 5 x86-64 compiled with my own GCC 4.5.1. Haven't had time to look into it. Those escape sequences are annoying.... FAIL: misc/ls-misc (exit: 1) ============================ ls (GNU coreutils) 8.5.188-9af44 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard M. Stallman and David MacKenzie. q-... q-N... q-q... q-Q... q-lit-q... q-qs-lit... q-qs-sh... q-qs-sh-a... q-qs-c... q-qs-esc... q-qs-c-1... emptydir... emptydir-x2... emptydir-R... R-dot... slink-dir-F... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. slink-dir-dF... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. slinkdir-dFH... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. slinkdir-dFL... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. sl-F-color... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. sl-dF-color... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. no-c-empty... no-c-reg... sl-target... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. sl-dangle... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. sl-dangle2... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. sl-dangle3... ls-misc: test sl-dangle3: stdout mismatch, comparing sl-dangle3.O (actual) and sl-dangle3.1 (expected) *** sl-dangle3.O Tue Oct 12 09:12:22 2010 --- sl-dangle3.1 Tue Oct 12 09:12:22 2010 *************** *** 1 **** ! lrwxrwxrwx 1 eggert 7 Oct 12 2010 l -> nowhere --- 1 ---- ! l -> nowhere Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. sl-dangle4... ls-misc: test sl-dangle4: stdout mismatch, comparing sl-dangle4.O (actual) and sl-dangle4.1 (expected) *** sl-dangle4.O Tue Oct 12 09:12:22 2010 --- sl-dangle4.1 Tue Oct 12 09:12:22 2010 *************** *** 1 **** ! lrwxrwxrwx 1 eggert 7 Oct 12 2010 l -> nowhere --- 1 ---- ! l -> nowhere Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. sl-dangle5... ls-misc: test sl-dangle5: stdout mismatch, comparing sl-dangle5.O (actual) and sl-dangle5.1 (expected) *** sl-dangle5.O Tue Oct 12 09:12:22 2010 --- sl-dangle5.1 Tue Oct 12 09:12:22 2010 *************** *** 1 **** ! lrwxrwxrwx 1 eggert 7 Oct 12 2010 l -> nowhere --- 1 ---- ! l -> nowhere Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. color-exe1... Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. no-a-isdir-b... recursive-2... setuid-etc... file-type... version-sort... multi-arg-U1... From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 13:54:31 2010 Received: (at 7198) by debbugs.gnu.org; 12 Oct 2010 17:54:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5j3X-0002wI-2r for submit@debbugs.gnu.org; Tue, 12 Oct 2010 13:54:31 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5j3U-0002wD-Ol for 7198@debbugs.gnu.org; Tue, 12 Oct 2010 13:54:30 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id C9FA3C73; Tue, 12 Oct 2010 19:57:55 +0200 (CEST) From: Jim Meyering To: Paul Eggert Subject: Re: bug#7198: ls-misc failure with Oct 10 snapshot In-Reply-To: <4CB49188.1050406@cs.ucla.edu> (Paul Eggert's message of "Tue, 12 Oct 2010 09:49:12 -0700") References: <87pqvf8woh.fsf@meyering.net> <87d3rf8tnx.fsf@meyering.net> <4CB49188.1050406@cs.ucla.edu> Date: Tue, 12 Oct 2010 19:57:55 +0200 Message-ID: <87lj6370po.fsf@meyering.net> Lines: 106 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 7198 Cc: 7198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) Paul Eggert wrote: > I got this on RHEL 5 x86-64 compiled with my own GCC 4.5.1. > Haven't had time to look into it. Those escape > sequences are annoying.... Hi Paul, Thanks for the report. What version of RHEL 5.N? I.e., what's "N"? I couldn't reproduce that on a 5.5 x86-based system using /usr/bin/gcc. Can you reproduce it with the standard compiler? What does perl -v print? > FAIL: misc/ls-misc (exit: 1) > ============================ > > ls (GNU coreutils) 8.5.188-9af44 > Copyright (C) 2010 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later . > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > > Written by Richard M. Stallman and David MacKenzie. > q-... > q-N... > q-q... > q-Q... > q-lit-q... > q-qs-lit... > q-qs-sh... > q-qs-sh-a... > q-qs-c... > q-qs-esc... > q-qs-c-1... > emptydir... > emptydir-x2... > emptydir-R... > R-dot... > slink-dir-F... > Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. Odd that you get those warnings and I don't. At first I thought I might be able to reproduce the warning by removing LS_COLORS from my environment, but that didn't work. Can you see if this gets rid of those warnings? diff --git a/tests/misc/ls-misc b/tests/misc/ls-misc index e663a5f..b0c5dce 100755 --- a/tests/misc/ls-misc +++ b/tests/misc/ls-misc @@ -27,7 +27,7 @@ my $saved_ls_colors; sub push_ls_colors($) { - $saved_ls_colors = $ENV{LS_COLORS}; + $saved_ls_colors = $ENV{LS_COLORS} || ''; $ENV{LS_COLORS} = $_[0]; } The failures make it look like ls is being run without the -o option. If you rerun the test with DEBUG=yes, e.g., make check -C tests TESTS=misc/ls-misc VERBOSE=yes DEBUG=yes that might give a hint... ... > ls-misc: test sl-dangle3: stdout mismatch, comparing sl-dangle3.O (actual) and sl-dangle3.1 (expected) > *** sl-dangle3.O Tue Oct 12 09:12:22 2010 > --- sl-dangle3.1 Tue Oct 12 09:12:22 2010 > *************** > *** 1 **** > ! lrwxrwxrwx 1 eggert 7 Oct 12 2010 l -> nowhere > --- 1 ---- > ! l -> nowhere > Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. > sl-dangle4... > ls-misc: test sl-dangle4: stdout mismatch, comparing sl-dangle4.O (actual) and sl-dangle4.1 (expected) > *** sl-dangle4.O Tue Oct 12 09:12:22 2010 > --- sl-dangle4.1 Tue Oct 12 09:12:22 2010 > *************** > *** 1 **** > ! lrwxrwxrwx 1 eggert 7 Oct 12 2010 l -> nowhere > --- 1 ---- > ! l -> nowhere > Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. > sl-dangle5... > ls-misc: test sl-dangle5: stdout mismatch, comparing sl-dangle5.O (actual) and sl-dangle5.1 (expected) > *** sl-dangle5.O Tue Oct 12 09:12:22 2010 > --- sl-dangle5.1 Tue Oct 12 09:12:22 2010 > *************** > *** 1 **** > ! lrwxrwxrwx 1 eggert 7 Oct 12 2010 l -> nowhere > --- 1 ---- > ! l -> nowhere > Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. > color-exe1... > Use of uninitialized value in scalar assignment at ./misc/ls-misc line 36. > no-a-isdir-b... > recursive-2... > setuid-etc... > file-type... > version-sort... > multi-arg-U1... From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 19:39:14 2010 Received: (at 7198) by debbugs.gnu.org; 12 Oct 2010 23:39:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5oR7-0005S1-Nq for submit@debbugs.gnu.org; Tue, 12 Oct 2010 19:39:13 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5oR5-0005Rv-Ol for 7198@debbugs.gnu.org; Tue, 12 Oct 2010 19:39:13 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 6D8F539E80E0; Tue, 12 Oct 2010 16:42:39 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ha3iRv-5n7Rr; Tue, 12 Oct 2010 16:42:38 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id B04E539E80DB; Tue, 12 Oct 2010 16:42:38 -0700 (PDT) Message-ID: <4CB4F26E.2020208@cs.ucla.edu> Date: Tue, 12 Oct 2010 16:42:38 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#7198: ls-misc failure with Oct 10 snapshot References: <87pqvf8woh.fsf@meyering.net> <87d3rf8tnx.fsf@meyering.net> <4CB49188.1050406@cs.ucla.edu> <87lj6370po.fsf@meyering.net> In-Reply-To: <87lj6370po.fsf@meyering.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 7198 Cc: 7198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On 10/12/10 10:57, Jim Meyering wrote: > What version of RHEL 5.N? I.e., what's "N"? /etc/issue says "Red Hat Enterprise Linux Server release 5.5 (Tikanga)". uname -a says "Linux lnxsrv01.seas.ucla.edu 2.6.18-194.17.1.el5 #1 SMP Mon Sep 20 07:12:06 EDT 2010 x86_64 GNU/Linux". > What does perl -v print? This is perl, v5.8.8 built for x86_64-linux-thread-multi > I couldn't reproduce that on a 5.5 x86-based system using > /usr/bin/gcc. Can you reproduce it with the standard compiler? Ouch. Now I can't reproduce the problem with either the standard compiler or with my GCC 4.5.1. However, with the standard compiler I get different problems. test-rand-isaac.c: In function 'main': test-rand-isaac.c:599: warning: passing argument 2 of 'strtol' makes pointer fr\ om integer without a cast test-rand-isaac.c:599: warning: passing argument 3 of 'strtol' makes integer fr\ om pointer without a cast Something odd is going on here, as that's an obvious typo in the test case that GCC 4.5.1 should also have caught. Dunno why it didn't, and don't know why you didn't notice that problem on your end, with the standard compiler. Oh, and when running atop an NFS file system I found another problem, which occurs with both the standard gcc and with my GCC 4.5.1: FAIL: test-rename (exit: 134) ============================= test-rename.h:121: assertion failed Here's the output of "strace ./test-rename" in gnulib-tests: mkdir("test-rename.tdir2", 0700) = 0 creat("test-rename.tdir/file", 0600) = 4 close(4) = 0 rename("test-rename.tdir2", "test-rename.tdir") = -1 ENOTEMPTY (Directory not empty) rename("test-rename.tdir2/", "test-rename.tdir") = -1 ENOTEMPTY (Directory not empty) rename("test-rename.tdir2", "test-rename.tdir/") = -1 ENOTEMPTY (Directory not empty) rename("test-rename.tdir", "test-rename.tdir2") = 0 stat("test-rename.tdir", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 write(2, "test-rename.h:121: assertion fai"..., 36test-rename.h:121: assertion failed ) = 36 The amusing thing is that, after the strace, "ls -l test-rename.t*" reports only this: $ ls -ltd test-rename.tdir* drwx------ 2 eggert csfac 4096 Oct 12 16:35 test-rename.tdir2 Perhaps there's a bug in the RHEL 5.5 NFS client? That might conceivably explain the misc/ls-misc problem that started this thread. I'll try to look into this more latter; gotta run now. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 03:05:57 2010 Received: (at 7198) by debbugs.gnu.org; 13 Oct 2010 07:05:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5vPQ-0008UJ-M6 for submit@debbugs.gnu.org; Wed, 13 Oct 2010 03:05:57 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5vPN-0008UE-73 for 7198@debbugs.gnu.org; Wed, 13 Oct 2010 03:05:54 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 3A000D819; Wed, 13 Oct 2010 09:09:21 +0200 (CEST) From: Jim Meyering To: Paul Eggert Subject: Re: bug#7198: ls-misc failure with Oct 10 snapshot In-Reply-To: <4CB4F26E.2020208@cs.ucla.edu> (Paul Eggert's message of "Tue, 12 Oct 2010 16:42:38 -0700") References: <87pqvf8woh.fsf@meyering.net> <87d3rf8tnx.fsf@meyering.net> <4CB49188.1050406@cs.ucla.edu> <87lj6370po.fsf@meyering.net> <4CB4F26E.2020208@cs.ucla.edu> Date: Wed, 13 Oct 2010 09:09:21 +0200 Message-ID: <87sk0a4li6.fsf@meyering.net> Lines: 62 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 7198 Cc: 7198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) Paul Eggert wrote: > On 10/12/10 10:57, Jim Meyering wrote: > >> What version of RHEL 5.N? I.e., what's "N"? > > /etc/issue says "Red Hat Enterprise Linux Server release 5.5 (Tikanga)". > uname -a says "Linux lnxsrv01.seas.ucla.edu 2.6.18-194.17.1.el5 #1 SMP Mon Sep 20 07:12:06 EDT 2010 x86_64 GNU/Linux". > >> What does perl -v print? > > This is perl, v5.8.8 built for x86_64-linux-thread-multi > >> I couldn't reproduce that on a 5.5 x86-based system using >> /usr/bin/gcc. Can you reproduce it with the standard compiler? > > Ouch. Now I can't reproduce the problem with either the standard > compiler or with my GCC 4.5.1. However, with the standard compiler > I get different problems. > > test-rand-isaac.c: In function 'main': > test-rand-isaac.c:599: warning: passing argument 2 of 'strtol' makes pointer fr\ > om integer without a cast > test-rand-isaac.c:599: warning: passing argument 3 of 'strtol' makes integer fr\ > om pointer without a cast > > Something odd is going on here, as that's an obvious typo in the > test case that GCC 4.5.1 should also have caught. Dunno why it > didn't, and don't know why you didn't notice that problem on your > end, with the standard compiler. Wow. That's pretty bad. Just goes to show (yet again) that we really should be using -Werror also in gnulib-tests. But not all maintainers of gnulib's tests have the same standards/tolerance/expectation for warning levels, so it'll take some work. I'm about to push this in your name: >From 9300fffcb54006bf471d96d70cf98081152c6fb1 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 13 Oct 2010 09:03:41 +0200 Subject: [PATCH] tests: fix rand-isaac test * gl/tests/test-rand-isaac.c (main): Fix swapped arguments to strtol. --- gl/tests/test-rand-isaac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gl/tests/test-rand-isaac.c b/gl/tests/test-rand-isaac.c index 03b004c..90acb4a 100644 --- a/gl/tests/test-rand-isaac.c +++ b/gl/tests/test-rand-isaac.c @@ -594,7 +594,7 @@ main (int argc, char **argv) /* If invoked with a positive argument, run a benchmark; if with a negative, run a do-nothing benchmark. */ - for (iterations = argc <= 1 ? 0 : strtol (argv[1], 10, NULL); + for (iterations = argc <= 1 ? 0 : strtol (argv[1], NULL, 10); iterations != 0; iterations += (iterations < 0 ? 1 : -1)) if (0 <= iterations) -- 1.7.3.1.104.gc752e From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 03:33:40 2010 Received: (at 7198) by debbugs.gnu.org; 13 Oct 2010 07:33:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5vqG-0000H7-3p for submit@debbugs.gnu.org; Wed, 13 Oct 2010 03:33:40 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5vqE-0000Gy-FE for 7198@debbugs.gnu.org; Wed, 13 Oct 2010 03:33:39 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id CA6B2D819; Wed, 13 Oct 2010 09:37:06 +0200 (CEST) From: Jim Meyering To: Paul Eggert Subject: Re: bug#7198: ls-misc failure with Oct 10 snapshot In-Reply-To: <4CB4F26E.2020208@cs.ucla.edu> (Paul Eggert's message of "Tue, 12 Oct 2010 16:42:38 -0700") References: <87pqvf8woh.fsf@meyering.net> <87d3rf8tnx.fsf@meyering.net> <4CB49188.1050406@cs.ucla.edu> <87lj6370po.fsf@meyering.net> <4CB4F26E.2020208@cs.ucla.edu> Date: Wed, 13 Oct 2010 09:37:06 +0200 Message-ID: <87mxqi4k7x.fsf@meyering.net> Lines: 54 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 7198 Cc: 7198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) Paul Eggert wrote: > On 10/12/10 10:57, Jim Meyering wrote: > >> What version of RHEL 5.N? I.e., what's "N"? > > /etc/issue says "Red Hat Enterprise Linux Server release 5.5 (Tikanga)". > uname -a says "Linux lnxsrv01.seas.ucla.edu 2.6.18-194.17.1.el5 #1 SMP Mon Sep 20 07:12:06 EDT 2010 x86_64 GNU/Linux". ... > Oh, and when running atop an NFS file system I found another problem, > which occurs with both the standard gcc and with my GCC 4.5.1: > > FAIL: test-rename (exit: 134) > ============================= > > test-rename.h:121: assertion failed > > Here's the output of "strace ./test-rename" in gnulib-tests: > > mkdir("test-rename.tdir2", 0700) = 0 > creat("test-rename.tdir/file", 0600) = 4 > close(4) = 0 > rename("test-rename.tdir2", "test-rename.tdir") = -1 ENOTEMPTY (Directory not empty) > rename("test-rename.tdir2/", "test-rename.tdir") = -1 ENOTEMPTY (Directory not empty) > rename("test-rename.tdir2", "test-rename.tdir/") = -1 ENOTEMPTY (Directory not empty) > rename("test-rename.tdir", "test-rename.tdir2") = 0 > stat("test-rename.tdir", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 > write(2, "test-rename.h:121: assertion fai"..., 36test-rename.h:121: assertion failed > ) = 36 That's not good. It looks like a race, where the client thinks the source of the rename is still there for some short interval after the rename succeeded. What is the server running? > The amusing thing is that, after the strace, "ls -l test-rename.t*" > reports only this: > > $ ls -ltd test-rename.tdir* > drwx------ 2 eggert csfac 4096 Oct 12 16:35 test-rename.tdir2 > > Perhaps there's a bug in the RHEL 5.5 NFS client? There's definitely something suspicious going on... > That might > conceivably explain the misc/ls-misc problem that started this thread. First step for that one should be to avoid the warnings from perl, e.g., via the patch I suggested. > I'll try to look into this more latter; gotta run now. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 14 02:42:30 2010 Received: (at 7198) by debbugs.gnu.org; 14 Oct 2010 06:42:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P6HWI-0003oq-8U for submit@debbugs.gnu.org; Thu, 14 Oct 2010 02:42:30 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P6HWF-0003ol-U4 for 7198@debbugs.gnu.org; Thu, 14 Oct 2010 02:42:29 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 1A8A839E80DF; Wed, 13 Oct 2010 23:45:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GVl0NxBfp3KQ; Wed, 13 Oct 2010 23:45:58 -0700 (PDT) Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E3B3739E80DB; Wed, 13 Oct 2010 23:45:57 -0700 (PDT) Message-ID: <4CB6A725.7020107@cs.ucla.edu> Date: Wed, 13 Oct 2010 23:45:57 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#7198: ls-misc failure with Oct 10 snapshot References: <87pqvf8woh.fsf@meyering.net> <87d3rf8tnx.fsf@meyering.net> <4CB49188.1050406@cs.ucla.edu> <87lj6370po.fsf@meyering.net> <4CB4F26E.2020208@cs.ucla.edu> <87mxqi4k7x.fsf@meyering.net> In-Reply-To: <87mxqi4k7x.fsf@meyering.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 7198 Cc: 7198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On 10/13/2010 12:37 AM, Jim Meyering wrote: > What is the server running? NetApp 6.5.6. NFS is configured to be NFSv3, running over TCP. > First step for that one should be to avoid the warnings from perl, > e.g., via the patch I suggested. Yes, thanks, somehow I missed the patch to tests/misc/ls-misc that you suggested in . I just tried it now, and it does fix the perl warnings. The problem goes away if I do the build on a local disk, so it does seem to be specific to NFS. I reproduced the problem with the standard RHEL tools, i.e., without using the newer versions of GCC etc. that I normally use. When I strace the make, the bug goes away. This indicates that it's timing-related, and may be hard to debug. Ooo! Ooo! The "timing-related" in the previous paragraph made the light bulb go on in my head. It's clock skew. The NFS server's clock is a tiny bit ahead of the NFS client's clock, and so the output of "ls -l" contains the date, not the time. I don't see how clock-skew could also explain the test-rename bug noted in , though. That part of NFS is not supposed to care about clock skew. Anyway, the following combined patch fixes the ls-misc failure: >From 1c1b06cbda069991be012f8171d41a713627b30f Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 13 Oct 2010 23:39:50 -0700 Subject: [PATCH] tests: work around portability and clock-skew problems * tests/misc/ls-misc (push_ls_colors): Don't assume LS_COLORS is set. This part of the fix is by Jim Meyering. (sl-dangle2, sl-dangle3, sl-dangle4, sl-dangle5): Don't assume that newly-created files will have time stamps in the past. They might not, due to clock skew, if the file systems are remote. --- tests/misc/ls-misc | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/misc/ls-misc b/tests/misc/ls-misc index e663a5f..9e38038 100755 --- a/tests/misc/ls-misc +++ b/tests/misc/ls-misc @@ -27,7 +27,7 @@ my $saved_ls_colors; sub push_ls_colors($) { - $saved_ls_colors = $ENV{LS_COLORS}; + $saved_ls_colors = $ENV{LS_COLORS} || ''; $ENV{LS_COLORS} = $_[0]; } @@ -186,8 +186,8 @@ my @Tests = ], # Test for a bug fixed after coreutils-8.2. - ['sl-dangle2', '-o --color=always l', - {OUT_SUBST => 's/.*[0-9][0-9]:[0-9][0-9] //'}, + ['sl-dangle2', '-o --time-style=+:TIME: --color=always l', + {OUT_SUBST => 's/.*:TIME: //'}, {OUT => "l -> nowhere\n"}, {PRE => sub {symlink 'nowhere', 'l' or die "l: $!\n"; push_ls_colors('ln=target') @@ -195,8 +195,8 @@ my @Tests = {POST => sub {unlink 'l' or die "l: $!\n"; restore_ls_colors; }}, ], - ['sl-dangle3', '-o --color=always l', - {OUT_SUBST => 's/.*[0-9][0-9]:[0-9][0-9] //'}, + ['sl-dangle3', '-o --time-style=+:TIME: --color=always l', + {OUT_SUBST => 's/.*:TIME: //'}, {OUT => "$e\e[40ml$e -> \e[34mnowhere$e\n"}, {PRE => sub {symlink 'nowhere', 'l' or die "l: $!\n"; push_ls_colors('ln=target:or=40:mi=34:') @@ -204,8 +204,8 @@ my @Tests = {POST => sub {unlink 'l' or die "l: $!\n"; restore_ls_colors; }}, ], - ['sl-dangle4', '-o --color=always l', - {OUT_SUBST => 's/.*[0-9][0-9]:[0-9][0-9] //'}, + ['sl-dangle4', '-o --time-style=+:TIME: --color=always l', + {OUT_SUBST => 's/.*:TIME: //'}, {OUT => "$e\e[36ml$e -> \e[35mnowhere$e\n"}, {PRE => sub {symlink 'nowhere', 'l' or die "l: $!\n"; push_ls_colors('ln=34:mi=35:or=36:') @@ -213,8 +213,8 @@ my @Tests = {POST => sub {unlink 'l' or die "l: $!\n"; restore_ls_colors; }}, ], - ['sl-dangle5', '-o --color=always l', - {OUT_SUBST => 's/.*[0-9][0-9]:[0-9][0-9] //'}, + ['sl-dangle5', '-o --time-style=+:TIME: --color=always l', + {OUT_SUBST => 's/.*:TIME: //'}, {OUT => "$e\e[34ml$e -> \e[35mnowhere$e\n"}, {PRE => sub {symlink 'nowhere', 'l' or die "l: $!\n"; push_ls_colors('ln=34:mi=35:') -- 1.7.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 14 03:22:32 2010 Received: (at 7198) by debbugs.gnu.org; 14 Oct 2010 07:22:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P6I92-000466-5T for submit@debbugs.gnu.org; Thu, 14 Oct 2010 03:22:32 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P6I90-000461-2t for 7198@debbugs.gnu.org; Thu, 14 Oct 2010 03:22:31 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 54D82D85B; Thu, 14 Oct 2010 09:26:01 +0200 (CEST) From: Jim Meyering To: Paul Eggert Subject: Re: bug#7198: ls-misc failure with Oct 10 snapshot In-Reply-To: <4CB6A725.7020107@cs.ucla.edu> (Paul Eggert's message of "Wed, 13 Oct 2010 23:45:57 -0700") References: <87pqvf8woh.fsf@meyering.net> <87d3rf8tnx.fsf@meyering.net> <4CB49188.1050406@cs.ucla.edu> <87lj6370po.fsf@meyering.net> <4CB4F26E.2020208@cs.ucla.edu> <87mxqi4k7x.fsf@meyering.net> <4CB6A725.7020107@cs.ucla.edu> Date: Thu, 14 Oct 2010 09:26:01 +0200 Message-ID: <8762x5s0ae.fsf@meyering.net> Lines: 47 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 7198 Cc: 7198@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) Paul Eggert wrote: > On 10/13/2010 12:37 AM, Jim Meyering wrote: > >> What is the server running? > > NetApp 6.5.6. NFS is configured to be NFSv3, running over TCP. > >> First step for that one should be to avoid the warnings from perl, >> e.g., via the patch I suggested. > > Yes, thanks, somehow I missed the patch to tests/misc/ls-misc > that you suggested in > . > I just tried it now, and it does fix the perl warnings. > > The problem goes away if I do the build on a local disk, so it does > seem to be specific to NFS. > > I reproduced the problem with the standard RHEL tools, i.e., without > using the newer versions of GCC etc. that I normally use. > > When I strace the make, the bug goes away. This indicates that it's > timing-related, and may be hard to debug. > > Ooo! Ooo! The "timing-related" in the previous paragraph made the > light bulb go on in my head. It's clock skew. The NFS server's > clock is a tiny bit ahead of the NFS client's clock, and so the output > of "ls -l" contains the date, not the time. Good catch! > I don't see how clock-skew could also explain the test-rename bug noted in > , > though. That part of NFS is not supposed to care about clock skew. > > Anyway, the following combined patch fixes the ls-misc failure: ... > Subject: [PATCH] tests: work around portability and clock-skew problems > > * tests/misc/ls-misc (push_ls_colors): Don't assume LS_COLORS > is set. This part of the fix is by Jim Meyering. > (sl-dangle2, sl-dangle3, sl-dangle4, sl-dangle5): Don't assume > that newly-created files will have time stamps in the past. They > might not, due to clock skew, if the file systems are remote. Thanks! I've pushed that. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 02 10:40:48 2011 Received: (at control) by debbugs.gnu.org; 2 Jul 2011 14:40:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qd1NI-00022a-M4 for submit@debbugs.gnu.org; Sat, 02 Jul 2011 10:40:48 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qd1NF-00022I-KZ for control@debbugs.gnu.org; Sat, 02 Jul 2011 10:40:46 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 1FF6360273; Sat, 2 Jul 2011 16:40:40 +0200 (CEST) From: Jim Meyering To: control@debbugs.gnu.org Subject: close a few old bugs and non-bugs Date: Sat, 02 Jul 2011 16:40:39 +0200 Message-ID: <87sjqo7nko.fsf@rho.meyering.net> Lines: 23 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) tags 6925 + notabug close 6925 tags 6924 + notabug close 6924 tags 7008 + notabug close 7008 tags 7093 + notabug close 7093 tags 7223 + notabug close 7223 tags 7247 + notabug close 7247 close 7198 close 7199 close 7324 thanks Back when we had just connected the bug tracker to bug-coreutils there were a lot of non-bug messages. This closes a few of those, and a few others that are merely resolved bugs. From unknown Fri Sep 05 18:58:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 31 Jul 2011 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator