GNU bug report logs - #71958
[PATCH] Improve `tab-line-tabs-fixed-window-buffers` sorting performance

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eval Exec <execvy <at> gmail.com>
Cc: 71958 <at> debbugs.gnu.org
Subject: bug#71958: [PATCH] Improve `tab-line-tabs-fixed-window-buffers` sorting performance
Date: Sat, 06 Jul 2024 09:23:36 +0300

> From: Eval Exec <execvy <at> gmail.com>
> Date: Fri, 5 Jul 2024 19:11:54 +0800

Thanks.  I'll leave it to Juri to review the code and comment, but
just minor nits on your commit log message:

> * lsp/tab-line.el (tab-line-tabs-fixed-window-buffers): Enhanced
> `tab-line-tabs-fixed-window-buffers` performance by optimizing buffer
> sorting mechanism. Replaced inefficient `seq-position` calls with a hash
> table to cache buffer positions, significantly improving speed when
> handling large buffer lists.

Our style is to say "Enhance" and "Replace", not "Enhanced" and
"Replaced".  Also, we use the US English convention of leaving two
spaces between sentences.  Finally, please quote symbols 'like this',
not `like this`.

In addition, I'd encourage you to start your legal paperwork of
assigning the copyright to the FSF at this time, so we could accept
your contributions without any restrictions.  If you are willing to
start the paperwork now, I will send you the form to fill and the
instructions to go with it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.