GNU bug report logs - #71944
[PATCH 0/2] gnu: lollypop: Update version and package style

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71944 in the body.
You can then email your comments to 71944 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: James Smith <jsubuntuxp <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: James Smith <jsubuntuxp <at> disroot.org>
Subject: [PATCH 0/2] gnu: lollypop: Update version and package style
Date: Thu,  4 Jul 2024 16:16:26 -0700

This patch series updates lollypop to the latest version, as well as update the
package style to use a list of G-Expressions.

James Smith (2):
  gnu: lollypop: Update to 1.4.40.
  gnu: lollypop: Update package style.

 gnu/packages/gnome.scm | 41 +++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 20 deletions(-)


base-commit: eeb24a50d2f1f78095bdb16b40ddb93bb51474bc
-- 
2.45.1

Message #8 received at 71944 <at> debbugs.gnu.org (full text, mbox):

From: James Smith <jsubuntuxp <at> disroot.org>
To: 71944 <at> debbugs.gnu.org
Cc: James Smith <jsubuntuxp <at> disroot.org>
Subject: [PATCH 1/2] gnu: lollypop: Update to 1.4.40.
Date: Thu,  4 Jul 2024 16:23:46 -0700

* gnu/packages/gnome.scm: (lollypop): Update to 1.4.40.

Change-Id: I8803c04f7ac2b8597920cc3e2a8371ada6a1dbab
---
 gnu/packages/gnome.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index b4caaf29a7..6a4d1babe3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -78,6 +78,7 @@
 ;;; Copyright © 2023 Dominik Delgado Steuter <d <at> delgado.nrw>
 ;;; Copyright © 2023 Zhu Zihao <all_but_last <at> 163.com>
 ;;; Copyright © 2024 Dariqq <dariqq <at> posteo.net>
+;;; Copyright © 2024 James Smith <jsubuntuxp <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -11555,14 +11556,14 @@ (define-public gnome-planner
 (define-public lollypop
   (package
     (name "lollypop")
-    (version "1.4.35")
+    (version "1.4.40")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://adishatz.org/lollypop/"
                            "lollypop-" version ".tar.xz"))
        (sha256
-        (base32 "0rvwj18x1gs7fgvniijzvlmgmzcgr7il22zclzsn5nkl8xbwgzk0"))))
+        (base32 "1laj5xwfz2bz29scga2ahhnhlgll4a0n21wwy8mlr4jsl81g0jsa"))))
     (build-system meson-build-system)
     (arguments
      `(#:imported-modules (,@%meson-build-system-modules
-- 
2.45.1

Message #11 received at 71944 <at> debbugs.gnu.org (full text, mbox):

From: James Smith <jsubuntuxp <at> disroot.org>
To: 71944 <at> debbugs.gnu.org
Cc: James Smith <jsubuntuxp <at> disroot.org>
Subject: [PATCH 2/2] gnu: lollypop: Update package style.
Date: Thu,  4 Jul 2024 16:23:47 -0700

* gnu/packages/gnome.scm (lollypop)[arguments]: Convert to list of
G-Expressions.

Change-Id: I2f7e0157f65bdd6776fbf15214093a837c5b0fd6
---
 gnu/packages/gnome.scm | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6a4d1babe3..3b95b20eef 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11566,24 +11566,24 @@ (define-public lollypop
         (base32 "1laj5xwfz2bz29scga2ahhnhlgll4a0n21wwy8mlr4jsl81g0jsa"))))
     (build-system meson-build-system)
     (arguments
-     `(#:imported-modules (,@%meson-build-system-modules
-                           (guix build python-build-system))
-       #:modules ((guix build meson-build-system)
-                  ((guix build python-build-system) #:prefix python:)
-                  (guix build utils))
-       #:glib-or-gtk? #t
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'disable-gtk-update-icon-cache
-           (lambda _
-             (setenv "DESTDIR" "/")))
-         (add-after 'install 'wrap-program
-           (lambda* (#:key outputs #:allow-other-keys)
-             (wrap-program (search-input-file outputs "bin/lollypop")
-               `("GI_TYPELIB_PATH" ":" prefix
-                 (,(getenv "GI_TYPELIB_PATH"))))))
-         (add-after 'install 'wrap-python
-           (assoc-ref python:%standard-phases 'wrap)))))
+     (list #:imported-modules `(,@%meson-build-system-modules
+                                (guix build python-build-system))
+           #:modules '((guix build meson-build-system)
+                       ((guix build python-build-system) #:prefix python:)
+                       (guix build utils))
+           #:glib-or-gtk? #t
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'disable-gtk-update-icon-cache
+                 (lambda _
+                   (setenv "DESTDIR" "/")))
+               (add-after 'install 'wrap-program
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (wrap-program (search-input-file outputs "bin/lollypop")
+                     (list "GI_TYPELIB_PATH" ":" 'prefix
+                           (list (getenv "GI_TYPELIB_PATH"))))))
+               (add-after 'install 'wrap-python
+                 (assoc-ref python:%standard-phases 'wrap)))))
     (native-inputs
      (list gettext-minimal
            `(,glib "bin")               ; For glib-compile-resources
-- 
2.45.1

Message #14 received at 71944 <at> debbugs.gnu.org (full text, mbox):

From: James Smith <jsubuntuxp <at> disroot.org>
To: 71944 <at> debbugs.gnu.org
Cc: liliana.prikler <at> gmail.com
Subject: Re: [PATCH 0/2] gnu: lollypop: Update version and package style
Date: Sat, 13 Jul 2024 06:21:26 -0700

Hi,

I noticed that this patch series were pushed to master as
947d44f1b3e7dd312f69847d2b7ecb1fd3ac7a4a and
aaf157deb36880e6f7fe8c057b98302dca04c1dc, but this issue hasn't been
closed yet. Do I need to close it or is that the responsibility of the
committer?

James Smith

Message #19 received at 71944-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: James Smith <jsubuntuxp <at> disroot.org>, 71944-done <at> debbugs.gnu.org
Subject: Re: [PATCH 0/2] gnu: lollypop: Update version and package style
Date: Sat, 13 Jul 2024 19:08:40 +0200

Am Samstag, dem 13.07.2024 um 06:21 -0700 schrieb James Smith:
> Hi,
> 
> I noticed that this patch series were pushed to master as
> 947d44f1b3e7dd312f69847d2b7ecb1fd3ac7a4a and
> aaf157deb36880e6f7fe8c057b98302dca04c1dc, but this issue hasn't been
> closed yet. Do I need to close it or is that the responsibility of
> the committer?
Rather than speak of responsibilities, I'd like to note that anyone
*may* close it.  For personal reasons, I just didn't find the time
directly after the push.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.