GNU bug report logs - #71927
29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input

Previous Next

Full log

Message #38 received at 71927 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Juri Linkov <juri <at> linkov.net>
Cc: jpw <at> gnu.org, Eshel Yaron <me <at> eshelyaron.com>, basil <at> contovou.net,
 71927 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, kickingvegas <at> gmail.com
Subject: Re: bug#71927: 29.4; ibuffer-do-isearch and
 ibuffer-do-isearch-regexp not prompting for input
Date: Thu, 04 Jul 2024 19:36:34 +0200

On Thu, 04 Jul 2024 19:04:42 +0300 Juri Linkov <juri <at> linkov.net> wrote:

>>>> FWIW, AFAICT everything is working correctly, it's just that the
>>>> "Operation finished" message hides the prompt.  ibuffer-do-isearch
>>>> should tell define-ibuffer-op not to display that message, somehow.
>>>
>>> I don't see how this could be considered "correct": the "Operation
>>> finished" message is supposed to be shown only after the Isearch is
>>> finished in all the marked buffer, not before.  It looks like we need
>>> a function that will not return until all the buffers where searched,
>>> because that's what define-ibuffer-op expects.  Don't you agree?
>
> It intentionally uses 'no-recursive-edit' set to t, so ibuffer-do-isearch
> correctly exits immediately while leaving isearch-mode enabled.
>
>> The attached patch appears to DTRT, but I only tested it briefly.
>> ...
>>  (define-ibuffer-op ibuffer-do-isearch ()
>>    "Perform a `isearch-forward' in marked buffers."
>>    (:interactive ()
>> -   :opstring "searched in"
>> +   :no-opstring t
>
> Thanks for the patch.  I confirm this is the right thing to do.
> Maybe instead of :no-opstring would be better to use some special value
> like :opstring 'no?  But I'm not sure if this is better than :no-opstring.

Suppressing the message when :opstring has the value 'no is fine with
me.  If Eli is willing to accept this approach, I can go ahead and
commit it (to master, presumably, since this is a longstanding issue).

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.