GNU bug report logs - #71927
29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: jpw <at> gnu.org, juri <at> linkov.net, me <at> eshelyaron.com, basil <at> contovou.net, 71927 <at> debbugs.gnu.org, kickingvegas <at> gmail.com
Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input
Date: Thu, 04 Jul 2024 15:50:56 +0300

> From: Stephen Berman <stephen.berman <at> gmx.net>
> Cc: Eshel Yaron <me <at> eshelyaron.com>,  kickingvegas <at> gmail.com,
>   71927 <at> debbugs.gnu.org,  basil <at> contovou.net,  jpw <at> gnu.org,
>   juri <at> linkov.net
> Date: Thu, 04 Jul 2024 12:06:40 +0200
> 
> >> FWIW, AFAICT everything is working correctly, it's just that the
> >> "Operation finished" message hides the prompt.  ibuffer-do-isearch
> >> should tell define-ibuffer-op not to display that message, somehow.
> >
> > I don't see how this could be considered "correct": the "Operation
> > finished" message is supposed to be shown only after the Isearch is
> > finished in all the marked buffer, not before.  It looks like we need
> > a function that will not return until all the buffers where searched,
> > because that's what define-ibuffer-op expects.  Don't you agree?
> 
> The attached patch appears to DTRT, but I only tested it briefly.

Thanks, but does it really make sense to change define-ibuffer-op to
fix the functions which (evidently) use it incorrectly?  I think the
fix needs to be in the same place where the bug is.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.