GNU bug report logs - #71927
29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input

Previous Next

Full log

View this message in rfc822 format

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jpw <at> gnu.org, juri <at> linkov.net, Eshel Yaron <me <at> eshelyaron.com>, basil <at> contovou.net, 71927 <at> debbugs.gnu.org, kickingvegas <at> gmail.com
Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input
Date: Thu, 04 Jul 2024 12:06:40 +0200

[Message part 1 (text/plain, inline)]

On Thu, 04 Jul 2024 12:59:24 +0300 Eli Zaretskii <eliz <at> gnu.org> wrote:

>> From: Eshel Yaron <me <at> eshelyaron.com>
>> Cc: Juri Linkov <juri <at> linkov.net>,  John Paul Wallington <jpw <at> gnu.org>,
>>   Basil L. Contovounesios <basil <at> contovou.net>,  kickingvegas <at> gmail.com,
>>   71927 <at> debbugs.gnu.org
>> Date: Thu, 04 Jul 2024 09:12:10 +0200
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> > I have a question: ibuffer-do-isearch just calls
>> > multi-isearch-buffers.  Does multi-isearch-buffers exit immediately,
>> > or does it exit only when the multi-isearch is done?  If the former, I
>> > guess this is why the problem happens.
>> >
>> >> So we need someone who knows ibuffer internals.
>> >
>> > I've added two people who might be able to help.
>>
>> FWIW, AFAICT everything is working correctly, it's just that the
>> "Operation finished" message hides the prompt.  ibuffer-do-isearch
>> should tell define-ibuffer-op not to display that message, somehow.
>
> I don't see how this could be considered "correct": the "Operation
> finished" message is supposed to be shown only after the Isearch is
> finished in all the marked buffer, not before.  It looks like we need
> a function that will not return until all the buffers where searched,
> because that's what define-ibuffer-op expects.  Don't you agree?

The attached patch appears to DTRT, but I only tested it briefly.

Steve Berman

[Message part 2 (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.