GNU bug report logs - #71927
29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input

Previous Next

Package: emacs;

Reported by: Charles Choi <kickingvegas <at> gmail.com>

Date: Wed, 3 Jul 2024 21:26:01 UTC

Severity: normal

Found in version 29.4

Fixed in version 30.1

Done: Eshel Yaron <me <at> eshelyaron.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eshel Yaron <me <at> eshelyaron.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: kickingvegas <at> gmail.com, 71927 <at> debbugs.gnu.org, "Basil L. Contovounesios" <basil <at> contovou.net>, John Paul Wallington <jpw <at> gnu.org>, Juri Linkov <juri <at> linkov.net>
Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input
Date: Thu, 04 Jul 2024 09:12:10 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 71927 <at> debbugs.gnu.org
>> From: Juri Linkov <juri <at> linkov.net>
>> Date: Thu, 04 Jul 2024 09:58:18 +0300
>> 
>> > The commands ibuffer-do-isearch and ibuffer-do-isearch-regexp
>> > do not prompt for an input search string.
>> 
>> They should not prompt because Isearch is interactive.
>> But the problem is that they exit Isearch immediately.
>> I tried to Edebug ibuffer-do-isearch, but this is
>> not possible.
>
> So did I, with the same results.
>
> I also see that this didn't work at least as far back as Emacs 25,
> maybe never.
>
> The function ibuffer-do-isearch was added by you, and was never
> changed before.  I guess it somehow violates the protocol of
> define-ibuffer-op or something?  Admittedly, that protocol is not
> described too well in the doc string.
>
> I have a question: ibuffer-do-isearch just calls
> multi-isearch-buffers.  Does multi-isearch-buffers exit immediately,
> or does it exit only when the multi-isearch is done?  If the former, I
> guess this is why the problem happens.
>
>> So we need someone who knows ibuffer internals.
>
> I've added two people who might be able to help.

FWIW, AFAICT everything is working correctly, it's just that the
"Operation finished" message hides the prompt.  ibuffer-do-isearch
should tell define-ibuffer-op not to display that message, somehow.


Best,

Eshel







This bug report was last modified 1 year and 2 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.