From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 11:25:30 2010 Received: (at submit) by debbugs.gnu.org; 11 Oct 2010 15:25:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5KFl-00017n-Vd for submit@debbugs.gnu.org; Mon, 11 Oct 2010 11:25:30 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5KFk-00017i-NJ for submit@debbugs.gnu.org; Mon, 11 Oct 2010 11:25:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5KJ0-0000Ka-Dz for submit@debbugs.gnu.org; Mon, 11 Oct 2010 11:28:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:39921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5KJ0-0000Js-4y for submit@debbugs.gnu.org; Mon, 11 Oct 2010 11:28:50 -0400 Received: from [140.186.70.92] (port=44916 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5KIu-0005Sg-JC for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2010 11:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5K50-0003fI-9C for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2010 11:14:23 -0400 Received: from mail-qy0-f176.google.com ([209.85.216.176]:55570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5K50-0003eR-6V for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2010 11:14:22 -0400 Received: by qyk29 with SMTP id 29so4299259qyk.0 for ; Mon, 11 Oct 2010 08:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=Y72JlfGIfyuLkNOHWIvVAAskkoIMrPefAXQEnVLVJ6g=; b=gDmJEeXif0bavXVeOf8JyKHuQJInZ+FdofZt94twTJytDLoopNOX/xsXHLcb4wosXH igQNMjraMV8GSiq5WByAhRyw9YLPzgNwko/YG62GPKw9R5F+Fq1HTNo2ahlqXAS84q8r NOzQDB47OsRfxedguvfkguCc8Voz6ONmg/Dfg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=CAuDNNabVJYYuio17cUHuCuy6dyCXyWJSlHCow/gozKzom+ttJFRFFbqC7mRo8XqYp tut2YqYk0GVRqvIHRblyWYSUCgcQiwajwW+KHpSKGS+bIcUZjQnbdnxQbynyaAq82FIA nBwXsKkue64o81OEBVQKGPFm7NnyX821V+X6k= Received: by 10.229.184.198 with SMTP id cl6mr3206371qcb.240.1286810061573; Mon, 11 Oct 2010 08:14:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Mon, 11 Oct 2010 08:13:55 -0700 (PDT) From: Lennart Borgman Date: Mon, 11 Oct 2010 17:13:55 +0200 Message-ID: Subject: Crash in menus on w32 To: Emacs Bugs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) Crash in menus on w32, my patched version of course. Any suggestions? warning: HEAP[emacs.exe]: warning: Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 ) Program received signal SIGTRAP, Trace/breakpoint trap. 0x7c90120f in ntdll!DbgUiConnectToDbg () from C:\WINDOWS\system32\ntdll.dll (gdb) bt #0 0x7c90120f in ntdll!DbgUiConnectToDbg () from C:\WINDOWS\system32\ntdll.dll #1 0x7c96e139 in ntdll!RtlpNtMakeTemporaryKey () from C:\WINDOWS\system32\ntdll.dll #2 0x7c96e576 in ntdll!RtlpNtMakeTemporaryKey () from C:\WINDOWS\system32\ntdll.dll #3 0x7c96f75e in ntdll!RtlpNtMakeTemporaryKey () from C:\WINDOWS\system32\ntdll.dll #4 0x7c94bc4c in ntdll!LdrFindEntryForAddress () from C:\WINDOWS\system32\ntdll.dll #5 0x00850000 in ?? () #6 0x7c927573 in ntdll!RtlPcToFileHeader () from C:\WINDOWS\system32\ntdll.dll #7 0x011c4e4b in w32_free_submenu_strings (menu=0x205e3) at w32menu.c:1701 #8 0x011c4e5f in w32_free_submenu_strings (menu=0x205f3) at w32menu.c:1706 #9 0x011c4e5f in w32_free_submenu_strings (menu=0xdd10145) at w32menu.c:1706 #10 0x011c4eaa in w32_free_menu_strings (hwnd=0x900ca) at w32menu.c:1723 #11 0x011c2b6e in menubar_selection_callback (f=0x3f63000, client_data=0x2510) at w32menu.c:353 #12 0x011dc6fc in w32_read_socket (terminal=0x3053c00, expected=0, hold_quit=0x82f6e0) at w32term.c:4624 #13 0x0100e484 in read_avail_input (expected=0) at keyboard.c:6986 #14 0x0100e38e in gobble_input (expected=0) at keyboard.c:6907 #15 0x0100e341 in get_input_pending (addr=0x13fab50, flags=1) at keyboard.c:6870 #16 0x0101489c in detect_input_pending_run_timers (do_display=0) at keyboard.c:10511 #17 0x01007d44 in read_char (commandflag=1, nmaps=22, maps=0x82f990, prev_event=45467674, used_mouse_menu=0x82fb6c, end_time=0x0) at keyboard.c:2556 #18 0x01011c8e in read_key_sequence (keybuf=0x82fc60, bufsize=30, prompt=45467674, dont_downcase_last=0, can_return_switch_frame=1, fix_current_buffer=1) at keyboard.c:9349 #19 0x010064a7 in command_loop_1 () at keyboard.c:1618 #20 0x01020721 in internal_condition_case (bfun=0x1006185 , handlers=45521258, hfun=0x1005b7a ) at eval.c:1460 #21 0x01005eea in command_loop_2 (ignore=45467674) at keyboard.c:1338 #22 0x01020212 in internal_catch (tag=45519378, func=0x1005ec7 , arg=45467674) at eval.c:1204 #23 0x01005ea2 in command_loop () at keyboard.c:1317 #24 0x01005796 in recursive_edit_1 () at keyboard.c:940 #25 0x010058fa in Frecursive_edit () at keyboard.c:1002 #26 0x0100264c in main (argc=1, argv=0xa928e8) at emacs.c:1704 (gdb) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 12:02:00 2010 Received: (at control) by debbugs.gnu.org; 11 Oct 2010 16:02:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5Kp6-0001Oi-AF for submit@debbugs.gnu.org; Mon, 11 Oct 2010 12:02:00 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5Kp5-0001Ob-5J for control@debbugs.gnu.org; Mon, 11 Oct 2010 12:01:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1P5KsM-00033l-Po; Mon, 11 Oct 2010 12:05:22 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19635.13762.624949.800007@fencepost.gnu.org> Date: Mon, 11 Oct 2010 12:05:22 -0400 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: magenta X-Ran: u&'b%Gc;z12M6S:~Wm*&G}_G2QNemNP9TfVk;*%T)X';X|82=Jer!yN;V.3Q2rd6|vucgz X-Debbugs-No-Ack: yes X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) merge 7170 7190 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 15:17:19 2010 Received: (at 7190) by debbugs.gnu.org; 11 Oct 2010 19:17:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5Ns7-0003OJ-0V for submit@debbugs.gnu.org; Mon, 11 Oct 2010 15:17:19 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5Ns4-0003OE-P1 for 7190@debbugs.gnu.org; Mon, 11 Oct 2010 15:17:17 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LA500G004BHUL00@a-mtaout22.012.net.il> for 7190@debbugs.gnu.org; Mon, 11 Oct 2010 21:20:39 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.134.44]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LA500GOR4EEUS00@a-mtaout22.012.net.il>; Mon, 11 Oct 2010 21:20:39 +0200 (IST) Date: Mon, 11 Oct 2010 21:20:43 +0200 From: Eli Zaretskii Subject: Re: bug#7190: Crash in menus on w32 In-reply-to: X-012-Sender: halo1@inter.net.il To: Lennart Borgman Message-id: <831v7wmt84.fsf@gnu.org> References: X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Lennart Borgman > Date: Mon, 11 Oct 2010 17:13:55 +0200 > Cc: > > Crash in menus on w32, my patched version of course. Any suggestions? > > > warning: HEAP[emacs.exe]: > warning: Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 ) > > > Program received signal SIGTRAP, Trace/breakpoint trap. > 0x7c90120f in ntdll!DbgUiConnectToDbg () from C:\WINDOWS\system32\ntdll.dll > (gdb) bt > #0 0x7c90120f in ntdll!DbgUiConnectToDbg () > from C:\WINDOWS\system32\ntdll.dll > #1 0x7c96e139 in ntdll!RtlpNtMakeTemporaryKey () > from C:\WINDOWS\system32\ntdll.dll > #2 0x7c96e576 in ntdll!RtlpNtMakeTemporaryKey () > from C:\WINDOWS\system32\ntdll.dll > #3 0x7c96f75e in ntdll!RtlpNtMakeTemporaryKey () > from C:\WINDOWS\system32\ntdll.dll > #4 0x7c94bc4c in ntdll!LdrFindEntryForAddress () > from C:\WINDOWS\system32\ntdll.dll > #5 0x00850000 in ?? () > #6 0x7c927573 in ntdll!RtlPcToFileHeader () > from C:\WINDOWS\system32\ntdll.dll > #7 0x011c4e4b in w32_free_submenu_strings (menu=0x205e3) at w32menu.c:1701 Looks identical to bug #7170. Why did you open a new one? And I don't understand what suggestion do you expect. This happened only for you so far, so you need to debug it on your machine. One thing to do would be to see, each time this happen, which menu, submenu, menu item(s) are involved. If they are the same every time, you will have to take a closer look at the code which creates them. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 11 17:18:27 2010 Received: (at 7190) by debbugs.gnu.org; 11 Oct 2010 21:18:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5PlK-0004Bt-Tz for submit@debbugs.gnu.org; Mon, 11 Oct 2010 17:18:27 -0400 Received: from mail-qy0-f179.google.com ([209.85.216.179]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5PlJ-0004Bo-2T for 7190@debbugs.gnu.org; Mon, 11 Oct 2010 17:18:25 -0400 Received: by qyk36 with SMTP id 36so1270710qyk.3 for <7190@debbugs.gnu.org>; Mon, 11 Oct 2010 14:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=Jx2kidJLDqGIOWpRJlpKypsPrkeaWiDIIu8jG2uqYGE=; b=sx5iffqMs9JQTZ3PRo3gute3e+Jk4ftb2spYrwSE0N+bvyKNtHFMvG0fppghHchHLA 2Dd/99iBmuXcr+ZcDEUrl9sJ9uiORQu4FmRFqmr6KSpd8lzWSvPrC7nQjO8gPQI9uqDi TBv3gb609D275BCp9f2YDu9V2h42+bYUkiezI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=qs+cgwA49ZYm6AFzND0T/m6HAHqbcxJ+yfNbPEUIObqTZvEWEctgH5FTq59UglLJQb eEjyb1uHjEdZXpCYH9G0xLaoP80OF4nOMlZaZW28RSYYI7EmZRqMy3N+k7XQZodHCFh8 YevydqwA8g2LIO2jYF87YGeWq+uP9F2z0Mvc0= Received: by 10.229.184.149 with SMTP id ck21mr5458745qcb.198.1286832107225; Mon, 11 Oct 2010 14:21:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Mon, 11 Oct 2010 14:21:27 -0700 (PDT) In-Reply-To: <831v7wmt84.fsf@gnu.org> References: <831v7wmt84.fsf@gnu.org> From: Lennart Borgman Date: Mon, 11 Oct 2010 23:21:27 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Mon, Oct 11, 2010 at 9:20 PM, Eli Zaretskii wrote: >> From: Lennart Borgman >> Date: Mon, 11 Oct 2010 17:13:55 +0200 >> Cc: >> >> Crash in menus on w32, my patched version of course. Any suggestions? >> >> >> warning: HEAP[emacs.exe]: >> warning: Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 ) >> >> >> Program received signal SIGTRAP, Trace/breakpoint trap. >> 0x7c90120f in ntdll!DbgUiConnectToDbg () from C:\WINDOWS\system32\ntdll.= dll >> (gdb) bt >> #0 =C2=A00x7c90120f in ntdll!DbgUiConnectToDbg () >> =C2=A0 =C2=A0from C:\WINDOWS\system32\ntdll.dll >> #1 =C2=A00x7c96e139 in ntdll!RtlpNtMakeTemporaryKey () >> =C2=A0 =C2=A0from C:\WINDOWS\system32\ntdll.dll >> #2 =C2=A00x7c96e576 in ntdll!RtlpNtMakeTemporaryKey () >> =C2=A0 =C2=A0from C:\WINDOWS\system32\ntdll.dll >> #3 =C2=A00x7c96f75e in ntdll!RtlpNtMakeTemporaryKey () >> =C2=A0 =C2=A0from C:\WINDOWS\system32\ntdll.dll >> #4 =C2=A00x7c94bc4c in ntdll!LdrFindEntryForAddress () >> =C2=A0 =C2=A0from C:\WINDOWS\system32\ntdll.dll >> #5 =C2=A00x00850000 in ?? () >> #6 =C2=A00x7c927573 in ntdll!RtlPcToFileHeader () >> =C2=A0 =C2=A0from C:\WINDOWS\system32\ntdll.dll >> #7 =C2=A00x011c4e4b in w32_free_submenu_strings (menu=3D0x205e3) at w32m= enu.c:1701 > > Looks identical to bug #7170. =C2=A0Why did you open a new one? Yes, it was a bit stupid to open a new one. > And I don't understand what suggestion do you expect. =C2=A0This happened > only for you so far, so you need to debug it on your machine. > > One thing to do would be to see, each time this happen, which menu, > submenu, menu item(s) are involved. =C2=A0If they are the same every time= , > you will have to take a closer look at the code which creates them. I will try to remember what I did next time. I was in a hurry when this happened so I am not quite sure. Maybe it would be useful to trace the order of events with DebPrint since they seem to be wrong? Any suggestions on what to trace? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 00:00:36 2010 Received: (at 7190) by debbugs.gnu.org; 12 Oct 2010 04:00:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5W2W-0008JN-4P for submit@debbugs.gnu.org; Tue, 12 Oct 2010 00:00:36 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5W2S-0008JI-EM for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 00:00:33 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LA500900SCI3B00@a-mtaout21.012.net.il> for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 06:03:57 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.134.44]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LA500873SMKY870@a-mtaout21.012.net.il>; Tue, 12 Oct 2010 06:03:57 +0200 (IST) Date: Tue, 12 Oct 2010 06:04:02 +0200 From: Eli Zaretskii Subject: Re: bug#7190: Crash in menus on w32 In-reply-to: To: Lennart Borgman Message-id: <83vd58kqfh.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <831v7wmt84.fsf@gnu.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Lennart Borgman > Date: Mon, 11 Oct 2010 23:21:27 +0200 > Cc: 7190@debbugs.gnu.org >=20 > > One thing to do would be to see, each time this happen, which men= u, > > submenu, menu item(s) are involved. =C2=A0If they are the same ev= ery time, > > you will have to take a closer look at the code which creates the= m. >=20 > I will try to remember what I did next time. I was in a hurry when > this happened so I am not quite sure. I didn't mean that you need to remember what you did. I meant to use the debugger _when_ it crashes to find out what was the menu in question. > Maybe it would be useful to trace the order of events with DebPrint > since they seem to be wrong? Any suggestions on what to trace? I have no idea, because I don't know how to guess that from the backtrace alone. At least some data regarding the reason(s) of the crash is needed, see above. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 05:42:40 2010 Received: (at 7190) by debbugs.gnu.org; 12 Oct 2010 09:42:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5bNY-000266-9o for submit@debbugs.gnu.org; Tue, 12 Oct 2010 05:42:40 -0400 Received: from mail-qy0-f179.google.com ([209.85.216.179]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5bNU-00025z-Oa for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 05:42:37 -0400 Received: by qyk36 with SMTP id 36so1935570qyk.3 for <7190@debbugs.gnu.org>; Tue, 12 Oct 2010 02:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=xuCHizuD9AE/7vKAAWdvDxJ6PGs6Xzta0rdycA6v5og=; b=SVSDMauYl+OcwMPsCAUtGP16SRofn1IJ0rvCFQcqregVqiSIu4qRsign/r4UeRnaav oWzqOF7+H5ojwsggFnnUGGjN4Eed8cT1jL26heahylatS+qS3mKRLrZzTNXtnoBADXP8 6otMlAsJxZuTle5NB/fvi0gigeIeuSvPQI/PI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=OGMMuvk48ucqsxL3BLF3LTkl+YGtfam3TRhmz0e863a9Xa00aqPR9Tbu+gl6N/j9Ri +uLyA73+mzqC0dr0Gz6z1Fk5SSYqOeE29OizjuaWouwO1nPGmJ5AHT0gunQszsLoDwaV xxSxLfY6MVHFlY0mwhv9Q8XwAfhtJjjhdDh0c= Received: by 10.229.236.8 with SMTP id ki8mr6085164qcb.102.1286876295264; Tue, 12 Oct 2010 02:38:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Tue, 12 Oct 2010 02:37:52 -0700 (PDT) In-Reply-To: <83vd58kqfh.fsf@gnu.org> References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> From: Lennart Borgman Date: Tue, 12 Oct 2010 11:37:52 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Tue, Oct 12, 2010 at 6:04 AM, Eli Zaretskii wrote: >> From: Lennart Borgman >> Date: Mon, 11 Oct 2010 23:21:27 +0200 >> Cc: 7190@debbugs.gnu.org >> >> > One thing to do would be to see, each time this happen, which menu, >> > submenu, menu item(s) are involved. =C2=A0If they are the same every t= ime, >> > you will have to take a closer look at the code which creates them. >> >> I will try to remember what I did next time. I was in a hurry when >> this happened so I am not quite sure. > > I didn't mean that you need to remember what you did. =C2=A0I meant to us= e > the debugger _when_ it crashes to find out what was the menu in > question. Exactly how do I see that? >> Maybe it would be useful to trace the order of events with DebPrint >> since they seem to be wrong? Any suggestions on what to trace? > > I have no idea, because I don't know how to guess that from the > backtrace alone. =C2=A0At least some data regarding the reason(s) of the > crash is needed, see above. I just meant adding some DebPrint statements and recompile. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 15:03:18 2010 Received: (at 7190) by debbugs.gnu.org; 12 Oct 2010 19:03:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5k86-0003RT-46 for submit@debbugs.gnu.org; Tue, 12 Oct 2010 15:03:18 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5k83-0003RO-BQ for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 15:03:16 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LA600A00YDNMB00@a-mtaout22.012.net.il> for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 21:05:49 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.93.189]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LA600A2YYDOJ330@a-mtaout22.012.net.il>; Tue, 12 Oct 2010 21:05:49 +0200 (IST) Date: Tue, 12 Oct 2010 21:05:55 +0200 From: Eli Zaretskii Subject: Re: bug#7190: Crash in menus on w32 In-reply-to: To: Lennart Borgman Message-id: <83tykrkz8s.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > From: Lennart Borgman > Date: Tue, 12 Oct 2010 11:37:52 +0200 > Cc: 7190@debbugs.gnu.org >=20 > > I didn't mean that you need to remember what you did. =C2=A0I mea= nt to use > > the debugger _when_ it crashes to find out what was the menu in > > question. >=20 > Exactly how do I see that? By looking at the menu data structures accessed by these functions: #7 0x011c4e4b in w32_free_submenu_strings (menu=3D0x205e3) at w32m= enu.c:1701 #8 0x011c4e5f in w32_free_submenu_strings (menu=3D0x205f3) at w32m= enu.c:1706 #9 0x011c4e5f in w32_free_submenu_strings (menu=3D0xdd10145) at w3= 2menu.c:1706 #10 0x011c4eaa in w32_free_menu_strings (hwnd=3D0x900ca) at w32menu= .c:1723 #11 0x011c2b6e in menubar_selection_callback (f=3D0x3f63000, client= _data=3D0x2510) at w32menu.c:353 In menubar_selection_callback, you will find that Emacs stores in the keyboard buffer a couple of events produced by a menu selection. If my reading of the code is correct, this code: =09 entry =3D AREF (vector, i + MENU_ITEMS_ITEM_VALUE); retrieves the selected menu item, and `vector' is the entire menu bar= , computed as vector =3D f->menu_bar_vector; See frame.h for the structure of this vector. By looking at `entry' you can find which menu item is being selected. Then in w32_free_submenu_strings, you can see the same info in its bare C form. > >> Maybe it would be useful to trace the order of events with DebPr= int > >> since they seem to be wrong? Any suggestions on what to trace? > > > > I have no idea, because I don't know how to guess that from the > > backtrace alone. =C2=A0At least some data regarding the reason(s)= of the > > crash is needed, see above. >=20 > I just meant adding some DebPrint statements and recompile. I wouldn't know where to add these statements, because we have no ide= a what is causing the memory corruption which leads to the crash. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 15:16:10 2010 Received: (at 7190) by debbugs.gnu.org; 12 Oct 2010 19:16:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5kKY-0003YI-JM for submit@debbugs.gnu.org; Tue, 12 Oct 2010 15:16:10 -0400 Received: from mail-qy0-f179.google.com ([209.85.216.179]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5kKX-0003YC-L6 for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 15:16:09 -0400 Received: by qyk36 with SMTP id 36so2586022qyk.3 for <7190@debbugs.gnu.org>; Tue, 12 Oct 2010 12:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=VUAFsLh67GGKgiiy59+KfqFvjOelqcv4b5NbkY8Ox8s=; b=sen+nSUYQcEe0yDO6oGJYRR9aWOkqK+F1ZxA6L31WM7/Hq/GfXO/mdA33bfZHcVXB4 YMLgnDcOWFV+KcLX6nUNIeDk3qURWlmRz/1xJOkkZmyE511jrbol8qOF73bcyVsvIwB4 X+PS9Bt1lY3wbvus5JBSSQvwxQsryaCRJOQd4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=EY7CkABGY6c4IfOkHQljTMRi8+5MCbzgPSO/9CP+PA8sli56cSvkNcEEtAIO9dUmwR U/PQyvLnBrtngYndeiHUvXPZc+xK8+we2gaEhK5L/Mqn1UG0M+isnV7JwcQddYHiDh0I K/UG+E6G9C4ZbFXH1K/RWD84Nqw9/MeIz9OZM= Received: by 10.224.204.136 with SMTP id fm8mr6105425qab.21.1286911177353; Tue, 12 Oct 2010 12:19:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Tue, 12 Oct 2010 12:13:08 -0700 (PDT) In-Reply-To: <83tykrkz8s.fsf@gnu.org> References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> <83tykrkz8s.fsf@gnu.org> From: Lennart Borgman Date: Tue, 12 Oct 2010 21:13:08 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Tue, Oct 12, 2010 at 9:05 PM, Eli Zaretskii wrote: > > Then in w32_free_submenu_strings, you can see the same info in its > bare C form. Thanks. I will use all this info you gave in the next crash. >> I just meant adding some DebPrint statements and recompile. > > I wouldn't know where to add these statements, because we have no idea > what is causing the memory corruption which leads to the crash. I would assume that is all happens within the menus. Is the menu code synched with the other code? Is it perhaps running in a separate thread and not in Emacs normal GUI thread? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 15:37:17 2010 Received: (at 7190) by debbugs.gnu.org; 12 Oct 2010 19:37:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5kez-0003iv-8O for submit@debbugs.gnu.org; Tue, 12 Oct 2010 15:37:17 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5kex-0003iq-8x for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 15:37:16 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LA600E00ZWCC800@a-mtaout21.012.net.il> for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 21:40:41 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.93.189]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LA600ETYZZM6S20@a-mtaout21.012.net.il>; Tue, 12 Oct 2010 21:40:35 +0200 (IST) Date: Tue, 12 Oct 2010 21:40:41 +0200 From: Eli Zaretskii Subject: Re: bug#7190: Crash in menus on w32 In-reply-to: X-012-Sender: halo1@inter.net.il To: Lennart Borgman Message-id: <83r5fvkxmu.fsf@gnu.org> References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> <83tykrkz8s.fsf@gnu.org> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > From: Lennart Borgman > Date: Tue, 12 Oct 2010 21:13:08 +0200 > Cc: 7190@debbugs.gnu.org > > >> I just meant adding some DebPrint statements and recompile. > > > > I wouldn't know where to add these statements, because we have no idea > > what is causing the memory corruption which leads to the crash. > > I would assume that is all happens within the menus. No, it happens within Emacs. We allocate the memory that we free when Emacs crashes. > Is the menu code synched with the other code? Is it perhaps running > in a separate thread and not in Emacs normal GUI thread? You can see in the backtrace that the code which crashes is called from command_loop -> read_key_sequence -> read_socket chain, which is part of the normal Emacs input processing of the main thread. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 16:06:18 2010 Received: (at 7190) by debbugs.gnu.org; 12 Oct 2010 20:06:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5l74-0003wh-4r for submit@debbugs.gnu.org; Tue, 12 Oct 2010 16:06:18 -0400 Received: from mail-qy0-f179.google.com ([209.85.216.179]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5l73-0003wc-6b for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 16:06:17 -0400 Received: by qyk36 with SMTP id 36so2642419qyk.3 for <7190@debbugs.gnu.org>; Tue, 12 Oct 2010 13:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=pGOdnbULR4pCkDepCaMAQrsp/azG5rA8r+NVnwaaI6U=; b=M96UMvWUHiei8i2iSYCxvGPb+/M6uc5Bp13PxbGGK1NtxKfHyxB71cwVu1eO7oGWfs cnMp2wKB7SPj1oJs7tq74fLoEV9Sjwj2PAUlsL69AkNqT/xtF4izLbC0KzEZmXVBRWaQ BlN85UEyUN5Ie+JWLXz/yAa9TFg82OKSKavmo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=gqHc1f12+OwQpPtbqW5IXp7/AXB5AHa9D4C97mbzNkmYlnqXa+0LCUKu/32tCf84op 3c7eHolQALYyRls6nkkoM1DZZuqEOPFi5CxErfTCycci557h7AOwp94iW8QvX/BnEuWn yb/Cwazc0lko9KmDUtvWoVaRaHn+es+z0eZeQ= Received: by 10.229.102.11 with SMTP id e11mr6622265qco.276.1286914184800; Tue, 12 Oct 2010 13:09:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Tue, 12 Oct 2010 13:09:24 -0700 (PDT) In-Reply-To: <83r5fvkxmu.fsf@gnu.org> References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> <83tykrkz8s.fsf@gnu.org> <83r5fvkxmu.fsf@gnu.org> From: Lennart Borgman Date: Tue, 12 Oct 2010 22:09:24 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Tue, Oct 12, 2010 at 9:40 PM, Eli Zaretskii wrote: >> From: Lennart Borgman >> Date: Tue, 12 Oct 2010 21:13:08 +0200 >> Cc: 7190@debbugs.gnu.org >> >> >> I just meant adding some DebPrint statements and recompile. >> > >> > I wouldn't know where to add these statements, because we have no idea >> > what is causing the memory corruption which leads to the crash. >> >> I would assume that is all happens within the menus. > > No, it happens within Emacs. =C2=A0We allocate the memory that we free wh= en > Emacs crashes. I mean that the failing code is among the code handling menus in Emacs. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 16:11:26 2010 Received: (at 7190) by debbugs.gnu.org; 12 Oct 2010 20:11:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5lC1-0003zf-RQ for submit@debbugs.gnu.org; Tue, 12 Oct 2010 16:11:25 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5lBz-0003za-Op for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 16:11:24 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LA700B001IQ9O00@a-mtaout22.012.net.il> for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 22:13:59 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.93.189]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LA7009P61J99JO0@a-mtaout22.012.net.il>; Tue, 12 Oct 2010 22:13:58 +0200 (IST) Date: Tue, 12 Oct 2010 22:14:04 +0200 From: Eli Zaretskii Subject: Re: bug#7190: Crash in menus on w32 In-reply-to: To: Lennart Borgman Message-id: <83pqvfkw37.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> <83tykrkz8s.fsf@gnu.org> <83r5fvkxmu.fsf@gnu.org> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > From: Lennart Borgman > Date: Tue, 12 Oct 2010 22:09:24 +0200 > Cc: 7190@debbugs.gnu.org >=20 > >> >> I just meant adding some DebPrint statements and recompile. > >> > > >> > I wouldn't know where to add these statements, because we have= no idea > >> > what is causing the memory corruption which leads to the crash= . > >> > >> I would assume that is all happens within the menus. > > > > No, it happens within Emacs. =C2=A0We allocate the memory that we= free when > > Emacs crashes. >=20 > I mean that the failing code is among the code handling menus in Em= acs. Yes. But how does that help with adding debug prints? The code that handles menus is spread across several nontrivial functions, and we have no idea which of them causes the problem and where. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 12 16:46:06 2010 Received: (at 7190) by debbugs.gnu.org; 12 Oct 2010 20:46:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5lja-0004GI-42 for submit@debbugs.gnu.org; Tue, 12 Oct 2010 16:46:06 -0400 Received: from mail-qy0-f172.google.com ([209.85.216.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5ljY-0004Fw-0g for 7190@debbugs.gnu.org; Tue, 12 Oct 2010 16:46:04 -0400 Received: by qyk8 with SMTP id 8so914791qyk.3 for <7190@debbugs.gnu.org>; Tue, 12 Oct 2010 13:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=z/zOCEA9ADTumtyeHRUOZswvC/RasTtGiNxdu47ACMA=; b=C5lHJW05saCVYPWKfS4DiRE0MhAAFVY9XiJvHS8SqpzTLaXRZ7z3OFQSvUDe9PvMpQ SnL+vOosaNy+fnNkWFFHWnPukyPd7RjyNjTqacwhWDSTHKCi66Aw6ax1G0jNPiYdz1dI c86H6fehwBrtMESZ6cN26GO9soJxNRzVMsoHc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=KuiTg2x7dImh/xaupR3dQT+5xzZ4NOPohRATjFk3Ut3Pj41bhf6fZm4unWsN8BL4fF OFdZaE4cRZZOmhlpZjWQcKhrim+z2+rkcISAC9uZtFoCSDvrwF5BvkLTHfvxfzWl6XgI 81gg9ulaxd+Z0Z+POHbYmHYDAOsd/92UIxlwA= Received: by 10.224.124.23 with SMTP id s23mr6012188qar.392.1286916571757; Tue, 12 Oct 2010 13:49:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Tue, 12 Oct 2010 13:49:11 -0700 (PDT) In-Reply-To: <83pqvfkw37.fsf@gnu.org> References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> <83tykrkz8s.fsf@gnu.org> <83r5fvkxmu.fsf@gnu.org> <83pqvfkw37.fsf@gnu.org> From: Lennart Borgman Date: Tue, 12 Oct 2010 22:49:11 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Tue, Oct 12, 2010 at 10:14 PM, Eli Zaretskii wrote: >> >> I mean that the failing code is among the code handling menus in Emacs. > > Yes. =C2=A0But how does that help with adding debug prints? =C2=A0The cod= e that > handles menus is spread across several nontrivial functions, and we > have no idea which of them causes the problem and where. I assume that their is either a logical problem with the code inside Emacs or a bad assumption on how menu callbacks are actually run. By adding DebPrint call we could perhaps see if some code where called in an order we did not expect. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 07:27:07 2010 Received: (at 7190) by debbugs.gnu.org; 13 Oct 2010 11:27:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5zUB-0001uu-1k for submit@debbugs.gnu.org; Wed, 13 Oct 2010 07:27:07 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5zU8-0001uW-6Y for 7190@debbugs.gnu.org; Wed, 13 Oct 2010 07:27:04 -0400 Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1P5zXV-0001V9-KV; Wed, 13 Oct 2010 07:30:33 -0400 From: Eli Zaretskii To: Lennart Borgman In-reply-to: (message from Lennart Borgman on Tue, 12 Oct 2010 22:49:11 +0200) Subject: Re: bug#7190: Crash in menus on w32 References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> <83tykrkz8s.fsf@gnu.org> <83r5fvkxmu.fsf@gnu.org> <83pqvfkw37.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-Id: Date: Wed, 13 Oct 2010 07:30:33 -0400 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) > From: Lennart Borgman > Date: Tue, 12 Oct 2010 22:49:11 +0200 > Cc: 7190@debbugs.gnu.org > > On Tue, Oct 12, 2010 at 10:14 PM, Eli Zaretskii wrote: > >> > >> I mean that the failing code is among the code handling menus in Emacs. > > > > Yes.  But how does that help with adding debug prints?  The code that > > handles menus is spread across several nontrivial functions, and we > > have no idea which of them causes the problem and where. > > I assume that their is either a logical problem with the code inside > Emacs or a bad assumption on how menu callbacks are actually run. By > adding DebPrint call we could perhaps see if some code where called in > an order we did not expect. Good luck doing that; without at least some idea where the problem happens, I would be unable to recommend where to put such DebPrint's or what to print. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 07:46:34 2010 Received: (at submit) by debbugs.gnu.org; 13 Oct 2010 11:46:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5zmz-0002iN-My for submit@debbugs.gnu.org; Wed, 13 Oct 2010 07:46:34 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5zmy-0002iI-GY for submit@debbugs.gnu.org; Wed, 13 Oct 2010 07:46:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5zq1-0004XC-SJ for submit@debbugs.gnu.org; Wed, 13 Oct 2010 07:50:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:59150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5zq1-0004Wr-K8 for submit@debbugs.gnu.org; Wed, 13 Oct 2010 07:49:41 -0400 Received: from [140.186.70.92] (port=35064 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5zpu-0006qV-OO for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 07:49:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5zCS-0000Ro-KZ for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 07:08:49 -0400 Received: from mail-qy0-f176.google.com ([209.85.216.176]:62576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5zCS-0000Ra-IU for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 07:08:48 -0400 Received: by qyk29 with SMTP id 29so7041664qyk.0 for ; Wed, 13 Oct 2010 04:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=EzuIAww9oPmUMfFFXDswK1WntwEHhT/4TL7euliS9ZY=; b=ehejpOY/4WyFDGxFECf2htygU2XiL3PSW0PGtQHk4bSqZ64GOudM3XUhoSSt3D4JIJ SfwumHjYCOc1OtO8FZXa1stMpjLcG6POOWC0ijgTMCX7DGXamcnhAImPjEUkh6X7fe1T 0Bjd7sDA/qDk+nCYLyhR5X1nXfZU9DuR6mj8U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=Ue9M5v97cJDaO3Gnca0CEIuXrdCw5qYV4bSTRLLrFiQaVn8s9nEmPMZ1Z4kJztpaie MuqqLTB60iPOgLNbN2JwA82GiG29bYNqfYbqaZuqtMQFqEEs3JqVoztn2xcrrfpOkrdu +haHT93+fI/9+8Lo/ypFMme7O84G8aBo1yayc= Received: by 10.224.208.134 with SMTP id gc6mr2294397qab.335.1286968128075; Wed, 13 Oct 2010 04:08:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Wed, 13 Oct 2010 04:08:26 -0700 (PDT) In-Reply-To: <4CB591BD.4060804@gmx.de> References: <4CB591BD.4060804@gmx.de> From: Lennart Borgman Date: Wed, 13 Oct 2010 13:08:26 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: grischka Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Wed, Oct 13, 2010 at 1:02 PM, grischka wrote: >> I assume that their is either a logical problem with the code inside >> Emacs or a bad assumption on how menu callbacks are actually run. > > Is there a difference between logical problem and bad assumption? Yes. The code could be correct under some bad assumptions regarding the way the interface to the OS works. Is not that an important difference? >> By >> adding DebPrint call we could perhaps see if some code where called in >> an order we did not expect. > > Perhaps see the information that you already have? =C2=A0For example > =C2=A0#7 =C2=A00x011c4e4b in w32_free_submenu_strings (menu=3D0x205e3) at= w32menu.c:1701 > is telling where is "some code", and > =C2=A0"Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 )" > is telling about "order we did not expect", as likely in: =C2=A0Called > twice for the same memory object. =C2=A0If in doubt, try to prove that > it can't happen. Yes, perhaps. But it could also be that memory objects are freed in an order we did not expect. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 10:09:20 2010 Received: (at submit) by debbugs.gnu.org; 13 Oct 2010 14:09:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P6218-0003o0-OZ for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:09:19 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P5zoC-0002ix-3s for submit@debbugs.gnu.org; Wed, 13 Oct 2010 07:47:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5zrU-000555-5P for submit@debbugs.gnu.org; Wed, 13 Oct 2010 07:51:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:60421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5zrU-00054z-3O for submit@debbugs.gnu.org; Wed, 13 Oct 2010 07:51:12 -0400 Received: from [140.186.70.92] (port=33660 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5zrN-000683-Jb for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 07:51:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5z6O-0005IL-17 for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 07:02:32 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:53139 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P5z6N-0005ID-LP for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 07:02:31 -0400 Received: (qmail invoked by alias); 13 Oct 2010 11:02:28 -0000 Received: from unknown (EHLO [10.75.223.123]) [82.113.106.206] by mail.gmx.net (mp020) with SMTP; 13 Oct 2010 13:02:28 +0200 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX18kMwhVcyckZ+vvNzA/wNPwtFoCEF70gQqT/h4IAS lnRyHUU9qyKFHI Message-ID: <4CB591BD.4060804@gmx.de> Date: Wed, 13 Oct 2010 13:02:21 +0200 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: lennart.borgman@gmail.com Subject: bug#7190: Crash in menus on w32 References: AANLkTikHRRt6nuO2HY8cenUF3qxbKzHeVzW9FO6nC2pQ@mail.gmail.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 13 Oct 2010 10:09:17 -0400 Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) > I assume that their is either a logical problem with the code inside > Emacs or a bad assumption on how menu callbacks are actually run. Is there a difference between logical problem and bad assumption? > By > adding DebPrint call we could perhaps see if some code where called in > an order we did not expect. Perhaps see the information that you already have? For example #7 0x011c4e4b in w32_free_submenu_strings (menu=0x205e3) at w32menu.c:1701 is telling where is "some code", and "Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 )" is telling about "order we did not expect", as likely in: Called twice for the same memory object. If in doubt, try to prove that it can't happen. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 10:09:22 2010 Received: (at submit) by debbugs.gnu.org; 13 Oct 2010 14:09:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P621B-0003o9-Tt for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:09:22 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P61sY-0003j0-L4 for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:00:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P61vr-00035f-7e for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:03:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:32851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P61vr-00035b-5U for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:03:51 -0400 Received: from [140.186.70.92] (port=55728 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P61vq-0003tb-5A for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 10:03:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P61vj-00034R-2c for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 10:03:49 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:36095 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P61vi-000349-Mk for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 10:03:43 -0400 Received: (qmail invoked by alias); 13 Oct 2010 14:03:40 -0000 Received: from unknown (EHLO [10.75.134.151]) [82.113.106.204] by mail.gmx.net (mp069) with SMTP; 13 Oct 2010 16:03:40 +0200 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX18Kaz4yS04KQ+mG3NX4aERxtJpNBq0jXsr3uLgjR2 kxPuGZ1xT5aXWZ Message-ID: <4CB5BC32.1030008@gmx.de> Date: Wed, 13 Oct 2010 16:03:30 +0200 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Lennart Borgman Subject: Re: bug#7190: Crash in menus on w32 References: <4CB591BD.4060804@gmx.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 13 Oct 2010 10:09:17 -0400 Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Lennart Borgman wrote: > On Wed, Oct 13, 2010 at 1:02 PM, grischka wrote: >>> I assume that their is either a logical problem with the code inside >>> Emacs or a bad assumption on how menu callbacks are actually run. >> Is there a difference between logical problem and bad assumption? > > Yes. The code could be correct under some bad assumptions regarding > the way the interface to the OS works. > > Is not that an important difference? Not if you want to fix the bug. >>> By >>> adding DebPrint call we could perhaps see if some code where called in >>> an order we did not expect. >> Perhaps see the information that you already have? For example >> #7 0x011c4e4b in w32_free_submenu_strings (menu=0x205e3) at w32menu.c:1701 >> is telling where is "some code", and >> "Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 )" >> is telling about "order we did not expect", as likely in: Called >> twice for the same memory object. If in doubt, try to prove that >> it can't happen. > > Yes, perhaps. But it could also be that memory objects are freed in an > order we did not expect. > Why should it matter in what order "Invalid Address" is passed to free? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 10:40:51 2010 Received: (at submit) by debbugs.gnu.org; 13 Oct 2010 14:40:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P62Vf-00043Z-84 for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:40:51 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P62Vc-00043R-Vh for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:40:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P62Z0-0002Bl-FH for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:44:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:47034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P62Z0-0002Bh-Cy for submit@debbugs.gnu.org; Wed, 13 Oct 2010 10:44:18 -0400 Received: from [140.186.70.92] (port=38309 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P62Yz-0001Sw-Ax for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 10:44:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P62Yy-0002B3-8C for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 10:44:17 -0400 Received: from mail-qy0-f176.google.com ([209.85.216.176]:34444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P62Yy-0002Ay-4l for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 10:44:16 -0400 Received: by qyk29 with SMTP id 29so7308133qyk.0 for ; Wed, 13 Oct 2010 07:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=xbHWtL0A/HGidizfIkbNDhWbV+nVaLPYMgOlyakjGw8=; b=HZKT/mRhbGBegtKpR1Ko3FGgPy8R158WEYLeWj5zYSrvBcNhnAgVn3Ru/Vp4GDFKHf kPMzMritWNyUkrfBvcO/1SJ7/k22tmmJNuO/GPzNk8AQQNqTz2aJdlTIHOAE7+hb21jZ M4Vx3frYaTiWGueY/USAw3gqo8RoQN/Qe9pxw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=QRvXfzcgOm7a5bz/Wv3gq+bVvuvjUjCw9sgdfm8j+5KAV+JLP2kO89ckyLqJShXOkH fgahPLBMzdyhDMv++ZjBtcf87zohi12pTyVe9dW5D8EIv5hyHrcMBRvRYA3EUywMEB2r Wu0GKU2XLCbgYkharNrCUxzq74vcbG7WLZTeE= Received: by 10.229.241.12 with SMTP id lc12mr7604677qcb.178.1286981055362; Wed, 13 Oct 2010 07:44:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Wed, 13 Oct 2010 07:43:55 -0700 (PDT) In-Reply-To: <4CB5BC32.1030008@gmx.de> References: <4CB591BD.4060804@gmx.de> <4CB5BC32.1030008@gmx.de> From: Lennart Borgman Date: Wed, 13 Oct 2010 16:43:55 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: grischka Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Wed, Oct 13, 2010 at 4:03 PM, grischka wrote: > Lennart Borgman wrote: >> >> On Wed, Oct 13, 2010 at 1:02 PM, grischka wrote: >>>> >>>> I assume that their is either a logical problem with the code inside >>>> Emacs or a bad assumption on how menu callbacks are actually run. >>> >>> Is there a difference between logical problem and bad assumption? >> >> Yes. The code could be correct under some bad assumptions regarding >> the way the interface to the OS works. >> >> Is not that an important difference? > > Not if you want to fix the bug. It looks like I am thinking nearly exactly the opposite. For a simple bug it does not matter. For a complicated bug you can not look at all possible places. That would take too long time. So putting some structure on the different places and evaluating them makes much sense to me. >>>> By >>>> adding DebPrint call we could perhaps see if some code where called in >>>> an order we did not expect. >>> >>> Perhaps see the information that you already have? =C2=A0For example >>> =C2=A0#7 =C2=A00x011c4e4b in w32_free_submenu_strings (menu=3D0x205e3) = at >>> w32menu.c:1701 >>> is telling where is "some code", and >>> =C2=A0"Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 )" >>> is telling about "order we did not expect", as likely in: =C2=A0Called >>> twice for the same memory object. =C2=A0If in doubt, try to prove that >>> it can't happen. >> >> Yes, perhaps. But it could also be that memory objects are freed in an >> order we did not expect. >> > > Why should it matter in what order "Invalid Address" is passed to free? Maybe I am misunderstanding, I do not know much about this part of the code. Are you saying that you could not get this error from calls to RtlFreeHeap coming in the wrong order? (That would perhaps help much to know.) From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 12:03:31 2010 Received: (at submit) by debbugs.gnu.org; 13 Oct 2010 16:03:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P63nf-0004dg-I4 for submit@debbugs.gnu.org; Wed, 13 Oct 2010 12:03:31 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P63nd-0004db-CM for submit@debbugs.gnu.org; Wed, 13 Oct 2010 12:03:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P63r0-0004SP-IQ for submit@debbugs.gnu.org; Wed, 13 Oct 2010 12:06:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:42546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P63r0-0004SL-Ff for submit@debbugs.gnu.org; Wed, 13 Oct 2010 12:06:58 -0400 Received: from [140.186.70.92] (port=36346 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P63qz-0000rq-HR for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 12:06:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P63qy-0004RV-1b for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 12:06:57 -0400 Received: from mail-qw0-f41.google.com ([209.85.216.41]:65052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P63qx-0004RL-Vc for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 12:06:56 -0400 Received: by qwb8 with SMTP id 8so3365741qwb.0 for ; Wed, 13 Oct 2010 09:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=rD2ehQV4A1YOeJyOCsnOfxCCEyxjxcl6k/+zjIRnAOs=; b=kDXg2NkPKmuchLzxv/8CpFGlx+ZoeOvU+hcwH8mEdOyJiPhnBRXnmAVNkU4Y+Fhm3c FkWx0O/NM7Y8r8oee/7E7f4dPHNJBQeOOQBJxvQOcO/2SfSMQEyiz0tFQjlYVOhlW37r TEhAqsfGqy1azYDIcSNI2ga7iQ6IdkpM+mfas= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=bef+nCjQtcTBt3tgqZLzVZCsKHPNFkyZN8D5OtdMX/6lxtG5j12v/uQFVZEqPBkC5g WWGGXlLLm0sPtvfLdIjtBiutsYM9XS0kWnBHRIbWVwKAIA5UcNgAdRhVJzA+18ivu955 G86ogkptaGsP/gPi929dnl8QPC3XVzDrdXv/I= Received: by 10.224.60.136 with SMTP id p8mr2778384qah.283.1286986015330; Wed, 13 Oct 2010 09:06:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Wed, 13 Oct 2010 09:06:35 -0700 (PDT) In-Reply-To: <4CB5D576.8080100@gmx.de> References: <4CB591BD.4060804@gmx.de> <4CB5BC32.1030008@gmx.de> <4CB5D576.8080100@gmx.de> From: Lennart Borgman Date: Wed, 13 Oct 2010 18:06:35 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: grischka Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Wed, Oct 13, 2010 at 5:51 PM, grischka wrote: > Lennart Borgman wrote: >>>> >>>> Is not that an important difference? >>> >>> Not if you want to fix the bug. >> >> It looks like I am thinking nearly exactly the opposite. >> >> For a simple bug it does not matter. For a complicated bug you can not >> look at all possible places. That would take too long time. So putting >> some structure on the different places and evaluating them makes much >> sense to me. > > This bug is simple. Didn't someone say life is easier for pessimists... ;-) >>>>>> By >>>>>> adding DebPrint call we could perhaps see if some code where called = in >>>>>> an order we did not expect. >>>>> >>>>> Perhaps see the information that you already have? =C2=A0For example >>>>> =C2=A0#7 =C2=A00x011c4e4b in w32_free_submenu_strings (menu=3D0x205e3= ) at >>>>> w32menu.c:1701 >>>>> is telling where is "some code", and >>>>> =C2=A0"Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 )= " >>>>> is telling about "order we did not expect", as likely in: =C2=A0Calle= d >>>>> twice for the same memory object. =C2=A0If in doubt, try to prove tha= t >>>>> it can't happen. >>>> >>>> Yes, perhaps. But it could also be that memory objects are freed in an >>>> order we did not expect. >>>> >>> Why should it matter in what order "Invalid Address" is passed to free? >> >> Maybe I am misunderstanding, I do not know much about this part of the >> code. Are you saying that you could not get this error from calls to >> RtlFreeHeap coming in the wrong order? (That would perhaps help much >> to know.) > > Yes, =C2=A0RtlFreeHeap (like any free) doesn't care about order. =C2=A0It= only > cares that it's a valid object (which it isn't if it was already freed). > Did not someone see corrupted first letters in menu strings and such? > That is also a symptom of premature free, often. =C2=A0Count 1+1 ... Thanks, that helps. It makes it easier for me to put in some trace messages in useful places. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 12:26:38 2010 Received: (at submit) by debbugs.gnu.org; 13 Oct 2010 16:26:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P64A1-0004o9-EE for submit@debbugs.gnu.org; Wed, 13 Oct 2010 12:26:38 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P63Yn-0004X2-6D for submit@debbugs.gnu.org; Wed, 13 Oct 2010 11:48:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P63cA-0000o8-EE for submit@debbugs.gnu.org; Wed, 13 Oct 2010 11:51:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:41932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P63cA-0000o2-An for submit@debbugs.gnu.org; Wed, 13 Oct 2010 11:51:38 -0400 Received: from [140.186.70.92] (port=51924 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P63c9-0008BT-7V for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 11:51:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P63c8-0000nU-4j for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 11:51:37 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:46097 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P63c7-0000nB-Q0 for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 11:51:36 -0400 Received: (qmail invoked by alias); 13 Oct 2010 15:51:32 -0000 Received: from unknown (EHLO [10.75.218.200]) [82.113.106.206] by mail.gmx.net (mp001) with SMTP; 13 Oct 2010 17:51:32 +0200 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX1/VqSkJMw7VrYWdtReQ8gVF99gKAE2ZlvvvS/0J5/ oacO5FH4R7/zhw Message-ID: <4CB5D576.8080100@gmx.de> Date: Wed, 13 Oct 2010 17:51:18 +0200 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Lennart Borgman Subject: Re: bug#7190: Crash in menus on w32 References: <4CB591BD.4060804@gmx.de> <4CB5BC32.1030008@gmx.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 13 Oct 2010 12:26:35 -0400 Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Lennart Borgman wrote: >>> Is not that an important difference? >> Not if you want to fix the bug. > > It looks like I am thinking nearly exactly the opposite. > > For a simple bug it does not matter. For a complicated bug you can not > look at all possible places. That would take too long time. So putting > some structure on the different places and evaluating them makes much > sense to me. This bug is simple. >>>>> By >>>>> adding DebPrint call we could perhaps see if some code where called in >>>>> an order we did not expect. >>>> Perhaps see the information that you already have? For example >>>> #7 0x011c4e4b in w32_free_submenu_strings (menu=0x205e3) at >>>> w32menu.c:1701 >>>> is telling where is "some code", and >>>> "Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 )" >>>> is telling about "order we did not expect", as likely in: Called >>>> twice for the same memory object. If in doubt, try to prove that >>>> it can't happen. >>> Yes, perhaps. But it could also be that memory objects are freed in an >>> order we did not expect. >>> >> Why should it matter in what order "Invalid Address" is passed to free? > > Maybe I am misunderstanding, I do not know much about this part of the > code. Are you saying that you could not get this error from calls to > RtlFreeHeap coming in the wrong order? (That would perhaps help much > to know.) Yes, RtlFreeHeap (like any free) doesn't care about order. It only cares that it's a valid object (which it isn't if it was already freed). Did not someone see corrupted first letters in menu strings and such? That is also a symptom of premature free, often. Count 1+1 ... From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 18 20:17:20 2010 Received: (at 7190) by debbugs.gnu.org; 19 Oct 2010 00:17:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P7ztH-0002pQ-Pm for submit@debbugs.gnu.org; Mon, 18 Oct 2010 20:17:20 -0400 Received: from mail-qy0-f179.google.com ([209.85.216.179]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P7ztG-0002pL-I3 for 7190@debbugs.gnu.org; Mon, 18 Oct 2010 20:17:19 -0400 Received: by qyk36 with SMTP id 36so399837qyk.3 for <7190@debbugs.gnu.org>; Mon, 18 Oct 2010 17:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=gPe/dvthd8vV3/7vci8NBpFwQJ+wCsDfA88B/xxs9qU=; b=pWj0iyszUyMx9/Jk4SdjzCij1BxczKqoJ3IWiS7HS3D3rgCI4pJyX5XaXgZSXxT4pt fgigkW9rAZ3/3u3pPTUBp+5kAR5UqNkrIUmiWQ6ObExPmP2DUwX6kFYyz/UBeNe3dlMY Fnd7suJ/sbD6DsSgPCmIpH/0U/K31UEkVtHe0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=uuZFY9CY6qKAiMyrGDtjHSkp94bgcDdpfnQbQWJWI1z65QCCnxuCIP6yqOuAb5avLR u2pJYUMSs+9CSPEW3NudCFk1sWbWfY7cTcCanx+E8PkZmWq4i409Oik0dhlA9JBjvv4y iJh29tohVrDMV1YvJRW2Q/F2iHFVuFOnjfOrE= Received: by 10.229.239.130 with SMTP id kw2mr4496191qcb.115.1287447662514; Mon, 18 Oct 2010 17:21:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Mon, 18 Oct 2010 17:20:42 -0700 (PDT) In-Reply-To: <83tykrkz8s.fsf@gnu.org> References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> <83tykrkz8s.fsf@gnu.org> From: Lennart Borgman Date: Tue, 19 Oct 2010 02:20:42 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Tue, Oct 12, 2010 at 9:05 PM, Eli Zaretskii wrote: >> From: Lennart Borgman >> Date: Tue, 12 Oct 2010 11:37:52 +0200 >> Cc: 7190@debbugs.gnu.org >> >> > I didn't mean that you need to remember what you did. =C2=A0I meant to= use >> > the debugger _when_ it crashes to find out what was the menu in >> > question. >> >> Exactly how do I see that? > > By looking at the menu data structures accessed by these functions: > > =C2=A0#7 =C2=A00x011c4e4b in w32_free_submenu_strings (menu=3D0x205e3) at= w32menu.c:1701 > =C2=A0#8 =C2=A00x011c4e5f in w32_free_submenu_strings (menu=3D0x205f3) at= w32menu.c:1706 > =C2=A0#9 =C2=A00x011c4e5f in w32_free_submenu_strings (menu=3D0xdd10145) = at w32menu.c:1706 > =C2=A0#10 0x011c4eaa in w32_free_menu_strings (hwnd=3D0x900ca) at w32menu= .c:1723 > =C2=A0#11 0x011c2b6e in menubar_selection_callback (f=3D0x3f63000, client= _data=3D0x2510) > =C2=A0 =C2=A0 =C2=A0at w32menu.c:353 > > In menubar_selection_callback, you will find that Emacs stores in the > keyboard buffer a couple of events produced by a menu selection. =C2=A0If > my reading of the code is correct, this code: > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0entry =3D AREF (vector, i + MENU_ITEMS_= ITEM_VALUE); > > retrieves the selected menu item, and `vector' is the entire menu bar, > computed as > > =C2=A0vector =3D f->menu_bar_vector; > > See frame.h for the structure of this vector. > > By looking at `entry' you can find which menu item is being selected. > > Then in w32_free_submenu_strings, you can see the same info in its > bare C form. I just got a new crash, but unfortunately I have still not understand how to look at those values. With "bt full" I get this (part of the bt): #6 0x7c927573 in ntdll!RtlPcToFileHeader () from C:\WINDOWS\system32\ntdll.dll No symbol table info available. #7 0x011c5399 in w32_free_submenu_strings (menu=3D0x9a05c5) at w32menu.c:1= 692 info =3D { cbSize =3D 44, fMask =3D 52, fType =3D 256, fState =3D 0, wID =3D 0, hSubMenu =3D 0x0, hbmpChecked =3D 0x0, hbmpUnchecked =3D 0x0, dwItemData =3D 8975208, dwTypeData =3D 0x0, cch =3D 0 } i =3D 6 num =3D 17 #8 0x011c53ad in w32_free_submenu_strings (menu=3D0x5e80611) at w32menu.c:= 1697 info =3D { cbSize =3D 44, fMask =3D 52, fType =3D 0, fState =3D 0, wID =3D 0, hSubMenu =3D 0x9a05c5, hbmpChecked =3D 0x0, hbmpUnchecked =3D 0x0, dwItemData =3D 0, dwTypeData =3D 0x0, cch =3D 10 } i =3D 10 num =3D 30 #9 0x011c53ad in w32_free_submenu_strings (menu=3D0x464d04eb) at w32menu.c= :1697 info =3D { cbSize =3D 44, fMask =3D 52, fType =3D 0, fState =3D 0, wID =3D 0, hSubMenu =3D 0x5e80611, hbmpChecked =3D 0x0, hbmpUnchecked =3D 0x0, dwItemData =3D 0, dwTypeData =3D 0x0, cch =3D 4 } i =3D 5 num =3D 10 #10 0x011c53f8 in w32_free_menu_strings (hwnd=3D0x220048) at w32menu.c:1714 menu =3D 0x464d04eb #11 0x011c311a in menubar_selection_callback (f=3D0x411dc00, client_data=3D= 0x184a) at w32menu.c:353 j =3D 1 buf =3D { kind =3D MENU_BAR_EVENT, code =3D 0, part =3D scroll_bar_above_handle, modifiers =3D 0, x =3D 0, y =3D 0, timestamp =3D 0, padding =3D {0x0, 0x0}, frame_or_window =3D 68279301, arg =3D 59691226 } frame =3D 68279301 prefix =3D 59691298 entry =3D 59691226 vector =3D 92061701 subprefix_stack =3D 0x825f00 submenu_depth =3D 1 i =3D 6218 #12 0x011dcc2c in w32_read_socket (terminal=3D0x2d04c00, expected=3D0, hold_quit=3D0x82f6e0) at w32term.c:4623 inev =3D { kind =3D NO_EVENT, code =3D 0, part =3D scroll_bar_above_handle, modifiers =3D 0, x =3D 0, y =3D 0, timestamp =3D 0, padding =3D {0x0, 0x0}, frame_or_window =3D 0, arg =3D 45484058 } do_help =3D 0 count =3D 0 check_visibility =3D 0 msg =3D { msg =3D { hwnd =3D 0x220048, message =3D 273, wParam =3D 6218, lParam =3D 0, time =3D 59842578, pt =3D { x =3D 7, y =3D 327687 } }, dwModifiers =3D 0, rect =3D { left =3D 545258848, top =3D 2118300673, right =3D 13317672, bottom =3D 0 } } f =3D 0x411dc00 dpyinfo =3D 0x14061b0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 01:56:08 2010 Received: (at 7190) by debbugs.gnu.org; 19 Oct 2010 05:56:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P85BA-0005FL-JM for submit@debbugs.gnu.org; Tue, 19 Oct 2010 01:56:08 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P85B8-0005Er-VQ for 7190@debbugs.gnu.org; Tue, 19 Oct 2010 01:56:07 -0400 Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1P85El-0001I0-RI; Tue, 19 Oct 2010 01:59:51 -0400 From: Eli Zaretskii To: Lennart Borgman In-reply-to: (message from Lennart Borgman on Tue, 19 Oct 2010 02:20:42 +0200) Subject: Re: bug#7190: Crash in menus on w32 References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> <83tykrkz8s.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-Id: Date: Tue, 19 Oct 2010 01:59:51 -0400 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) > From: Lennart Borgman > Date: Tue, 19 Oct 2010 02:20:42 +0200 > Cc: 7190@debbugs.gnu.org > > >          entry = AREF (vector, i + MENU_ITEMS_ITEM_VALUE); > > > > retrieves the selected menu item, and `vector' is the entire menu bar, > > computed as > > > >  vector = f->menu_bar_vector; > > > > See frame.h for the structure of this vector. > > > > By looking at `entry' you can find which menu item is being selected. > > > > Then in w32_free_submenu_strings, you can see the same info in its > > bare C form. > > I just got a new crash, but unfortunately I have still not understand > how to look at those values. Please be specific: what parts in the explanation above you don't understand? I don't know how to answer a question "I don't understand how to do X", when I already explained how to do it. > With "bt full" "bt full" is useless in this case, because the problem is a corruption of the heap. We need to establish which menu item(s) are corrupted, and the information about that is not in local variables displayed by "bt full", it's in the data structures manipulated by w32_free_submenu_strings and w32_free_menu_strings. I gave you above the way to start looking at these data structures. Please try using that as the starting point, and if the problem is not immediately obvious, come back and report your findings. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 06:30:27 2010 Received: (at 7190) by debbugs.gnu.org; 19 Oct 2010 10:30:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P89Sc-0007NX-Rt for submit@debbugs.gnu.org; Tue, 19 Oct 2010 06:30:27 -0400 Received: from mail-qy0-f179.google.com ([209.85.216.179]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P89Sa-0007NS-RJ for 7190@debbugs.gnu.org; Tue, 19 Oct 2010 06:30:25 -0400 Received: by qyk36 with SMTP id 36so805293qyk.3 for <7190@debbugs.gnu.org>; Tue, 19 Oct 2010 03:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=lszAGGJj9JKey5McBxifJJT8rJxYzcqAqwpzlQFBcAk=; b=Bufzc8CaYr0rq9YG+Nc/7DsMSXIzWww9wjB/KPjSWw9yJdgzk+A+GWtOQw3HIU3TcN uCRjLrqVSCTAPFklJXonlGtPkmZfDlX7veuJRbMuO7qJdak9P4U6AeEsB3SmbohgioZx eyXUaln8lEK9FuRf+MWci372HkNKSH7n55YsI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=JoYRshAhUfgT36uKVWY6/lpCSE4AGiR/WWQpRoqFY+U+PuL7j4Z3cgljyU3QbYRDgS RBPZoi9+W+WGqCo3E1zGBsntd8JVDNKqvM2rYpdgN+gn7xEVErbDRuhaIDkJCk7kIu7L 5/MDU3iW1ShFw19zjziGSVDYA1Tf0Jq12mYzk= Received: by 10.229.224.67 with SMTP id in3mr4983471qcb.91.1287484450043; Tue, 19 Oct 2010 03:34:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.220.195 with HTTP; Tue, 19 Oct 2010 03:33:49 -0700 (PDT) In-Reply-To: References: <831v7wmt84.fsf@gnu.org> <83vd58kqfh.fsf@gnu.org> <83tykrkz8s.fsf@gnu.org> From: Lennart Borgman Date: Tue, 19 Oct 2010 12:33:49 +0200 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Tue, Oct 19, 2010 at 7:59 AM, Eli Zaretskii wrote: >> From: Lennart Borgman >> Date: Tue, 19 Oct 2010 02:20:42 +0200 >> Cc: 7190@debbugs.gnu.org >> >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0entry =3D AREF (vector, i + MENU_ITE= MS_ITEM_VALUE); >> > >> > retrieves the selected menu item, and `vector' is the entire menu bar, >> > computed as >> > >> > =C2=A0vector =3D f->menu_bar_vector; >> > >> > See frame.h for the structure of this vector. >> > >> > By looking at `entry' you can find which menu item is being selected. >> > >> > Then in w32_free_submenu_strings, you can see the same info in its >> > bare C form. >> >> I just got a new crash, but unfortunately I have still not understand >> how to look at those values. > > Please be specific: what parts in the explanation above you don't > understand? =C2=A0I don't know how to answer a question "I don't understa= nd > how to do X", when I already explained how to do it. > >> With "bt full" > > "bt full" is useless in this case, because the problem is a corruption > of the heap. =C2=A0We need to establish which menu item(s) are corrupted, > and the information about that is not in local variables displayed by > "bt full", it's in the data structures manipulated by > w32_free_submenu_strings and w32_free_menu_strings. =C2=A0I gave you abov= e > the way to start looking at these data structures. Could you please tell me the exact commands to look at those data structure= s? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 21 07:07:59 2010 Received: (at submit) by debbugs.gnu.org; 21 Oct 2010 11:07:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8t02-0004bL-7i for submit@debbugs.gnu.org; Thu, 21 Oct 2010 07:07:58 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8szz-0004bE-AO for submit@debbugs.gnu.org; Thu, 21 Oct 2010 07:07:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8t3f-0004Gf-Ns for submit@debbugs.gnu.org; Thu, 21 Oct 2010 07:11:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:39542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8t3f-0004Gb-K0 for submit@debbugs.gnu.org; Thu, 21 Oct 2010 07:11:43 -0400 Received: from [140.186.70.92] (port=37084 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8t3d-0004DH-FC for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 07:11:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8t3b-0004Ew-NH for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 07:11:41 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:47321 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P8t3b-0004Dn-CK for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 07:11:39 -0400 Received: (qmail invoked by alias); 21 Oct 2010 11:11:35 -0000 Received: from unknown (EHLO [10.74.61.191]) [82.113.106.193] by mail.gmx.net (mp066) with SMTP; 21 Oct 2010 13:11:35 +0200 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX18TIgAzMloTFofgHr7WgcgWLWnVJpKw4OJEBEByo3 GatQYJyEosVeOR Message-ID: <4CC01FDD.5060707@gmx.de> Date: Thu, 21 Oct 2010 13:11:25 +0200 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: lennart.borgman@gmail.com Subject: bug#7190: Crash in menus on w32 References: AANLkTinuGH5MJ6Z4NMBUjkDpqJwmQy6mY4JBcWcVSuXS@mail.gmail.com Content-Type: multipart/mixed; boundary="------------060302020304000406010904" X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) This is a multi-part message in MIME format. --------------060302020304000406010904 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Here's a patch that fixes the bug. Actually 4 bugs: 1) the initial cause: was freeing items prematurely and trying to free already freed items 2) memory leak: was trying to free items from already deleted menu 3) memory leak: was trying to free menu from already deleted window 4) other: was trying to set cursor in window with no associated frame --- grischka --------------060302020304000406010904 Content-Type: text/plain; name="free-menu-strings.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="free-menu-strings.diff" Y29tbWl0IDA2NDIyNWRiNzg2NDBhMWZiNDhiNjhhYWM2MDNjOGUwNWNjNjliODAKQXV0aG9y OiBncmlzY2hrYSA8Z3Jpc2Noa2E+CkRhdGU6ICAgVGh1IE9jdCAxNCAxMzoyMzozOCAyMDEw ICswMjAwCgogICAgZml4IHczMm1lbnUgb3duZXJkcmF3IHN0cmluZyBhbGxvYy9mcmVlCgpk aWZmIC0tZ2l0IGEvc3JjL3czMmZucy5jIGIvc3JjL3czMmZucy5jCmluZGV4IDgwODUwMzUu LjgzZDU3N2UgMTAwNjQ0Ci0tLSBhL3NyYy93MzJmbnMuYworKysgYi9zcmMvdzMyZm5zLmMK QEAgLTc2LDcgKzc2LDYgQEAgZXh0ZXJuIHZvaWQgZnJlZV9mcmFtZV9tZW51YmFyIChzdHJ1 Y3QgZnJhbWUgKik7CiBleHRlcm4gZG91YmxlIGF0b2YgKGNvbnN0IGNoYXIgKik7CiBleHRl cm4gaW50IHczMl9jb25zb2xlX3RvZ2dsZV9sb2NrX2tleSAoaW50LCBMaXNwX09iamVjdCk7 CiBleHRlcm4gdm9pZCB3MzJfbWVudV9kaXNwbGF5X2hlbHAgKEhXTkQsIEhNRU5VLCBVSU5U LCBVSU5UKTsKLWV4dGVybiB2b2lkIHczMl9mcmVlX21lbnVfc3RyaW5ncyAoSFdORCk7CiBl eHRlcm4gY29uc3QgY2hhciAqbWFwX3czMl9maWxlbmFtZSAoY29uc3QgY2hhciAqLCBjb25z dCBjaGFyICoqKTsKIAogZXh0ZXJuIGludCBxdWl0X2NoYXI7CkBAIC0yODAsMTIgKzI3OSw3 IEBAIHVuc2lnbmVkIGludCBtc2hfbW91c2V3aGVlbCA9IDA7CiAvKiBUaW1lcnMgKi8KICNk ZWZpbmUgTU9VU0VfQlVUVE9OX0lECTEKICNkZWZpbmUgTU9VU0VfTU9WRV9JRAkyCi0jZGVm aW5lIE1FTlVfRlJFRV9JRCAzCiAjZGVmaW5lIEhPVVJHTEFTU19JRCA0Ci0vKiBUaGUgZGVs YXkgKG1pbGxpc2Vjb25kcykgYmVmb3JlIGEgbWVudSBpcyBmcmVlZCBhZnRlciBXTV9FWElU TUVOVUxPT1AKLSAgIGlzIHJlY2VpdmVkLiAgKi8KLSNkZWZpbmUgTUVOVV9GUkVFX0RFTEFZ IDEwMDAKLXN0YXRpYyB1bnNpZ25lZCBtZW51X2ZyZWVfdGltZXIgPSAwOwogCiAvKiBJbiBk aXNwbmV3LmMgKi8KIApAQCAtMzM4NywyMSArMzM4MSw2IEBAIHczMl93bmRfcHJvYyAoSFdO RCBod25kLCBVSU5UIG1zZywgV1BBUkFNIHdQYXJhbSwgTFBBUkFNIGxQYXJhbSkKIAkgIEtp bGxUaW1lciAoaHduZCwgbW91c2VfbW92ZV90aW1lcik7CiAJICBtb3VzZV9tb3ZlX3RpbWVy ID0gMDsKIAl9Ci0gICAgICBlbHNlIGlmICh3UGFyYW0gPT0gbWVudV9mcmVlX3RpbWVyKQot CXsKLQkgIEtpbGxUaW1lciAoaHduZCwgbWVudV9mcmVlX3RpbWVyKTsKLQkgIG1lbnVfZnJl ZV90aW1lciA9IDA7Ci0JICBmID0geF93aW5kb3dfdG9fZnJhbWUgKGRweWluZm8sIGh3bmQp OwotICAgICAgICAgIC8qIElmIGEgcG9wdXAgbWVudSBpcyBhY3RpdmUsIGRvbid0IHdpcGUg aXRzIHN0cmluZ3MuICAqLwotCSAgaWYgKG1lbnViYXJfaW5fdXNlCi0gICAgICAgICAgICAg ICYmIGN1cnJlbnRfcG9wdXBfbWVudSA9PSBOVUxMKQotCSAgICB7Ci0JICAgICAgLyogRnJl ZSBtZW1vcnkgdXNlZCBieSBvd25lci1kcmF3biBhbmQgaGVscC1lY2hvIHN0cmluZ3MuICAq LwotCSAgICAgIHczMl9mcmVlX21lbnVfc3RyaW5ncyAoaHduZCk7Ci0JICAgICAgZi0+b3V0 cHV0X2RhdGEudzMyLT5tZW51YmFyX2FjdGl2ZSA9IDA7Ci0gICAgICAgICAgICAgIG1lbnVi YXJfaW5fdXNlID0gMDsKLQkgICAgfQotCX0KICAgICAgIGVsc2UgaWYgKHdQYXJhbSA9PSBo b3VyZ2xhc3NfdGltZXIpCiAJewogCSAgS2lsbFRpbWVyIChod25kLCBob3VyZ2xhc3NfdGlt ZXIpOwpAQCAtMzQ2NSwxNCArMzQ0NCwxMSBAQCB3MzJfd25kX3Byb2MgKEhXTkQgaHduZCwg VUlOVCBtc2csIFdQQVJBTSB3UGFyYW0sIExQQVJBTSBsUGFyYW0pCiAgICAgY2FzZSBXTV9F WElUTUVOVUxPT1A6CiAgICAgICBmID0geF93aW5kb3dfdG9fZnJhbWUgKGRweWluZm8sIGh3 bmQpOwogCi0gICAgICAvKiBJZiBhIG1lbnUgaXMgc3RpbGwgYWN0aXZlLCBjaGVjayBhZ2Fp biBhZnRlciBhIHNob3J0IGRlbGF5LAotCSBzaW5jZSBXaW5kb3dzIG9mdGVuIChhbHdheXM/ KSBzZW5kcyB0aGUgV01fRVhJVE1FTlVMT09QCi0JIGJlZm9yZSB0aGUgY29ycmVzcG9uZGlu ZyBXTV9DT01NQU5EIG1lc3NhZ2UuCi0gICAgICAgICBEb24ndCBkbyB0aGlzIGlmIGEgcG9w dXAgbWVudSBpcyBhY3RpdmUsIHNpbmNlIGl0IGlzIG9ubHkKLSAgICAgICAgIG1lbnViYXIg bWVudXMgdGhhdCByZXF1aXJlIGNsZWFuaW5nIHVwIGluIHRoaXMgd2F5LgotICAgICAgKi8K ICAgICAgIGlmIChmICYmIG1lbnViYXJfaW5fdXNlICYmIGN1cnJlbnRfcG9wdXBfbWVudSA9 PSBOVUxMKQotCW1lbnVfZnJlZV90aW1lciA9IFNldFRpbWVyIChod25kLCBNRU5VX0ZSRUVf SUQsIE1FTlVfRlJFRV9ERUxBWSwgTlVMTCk7CisgICAgICAgeworICAgICAgICAgZi0+b3V0 cHV0X2RhdGEudzMyLT5tZW51YmFyX2FjdGl2ZSA9IDA7CisgICAgICAgICBtZW51YmFyX2lu X3VzZSA9IDA7CisgICAgICAgfQogCiAgICAgICAvKiBJZiBob3VyZ2xhc3MgY3Vyc29yIHNo b3VsZCBiZSBkaXNwbGF5ZWQsIGRpc3BsYXkgaXQgbm93LiAgKi8KICAgICAgIGlmIChmICYm IGYtPm91dHB1dF9kYXRhLnczMi0+aG91cmdsYXNzX3ApCkBAIC0zNjMyLDE1ICszNjA4LDYg QEAgdzMyX3duZF9wcm9jIChIV05EIGh3bmQsIFVJTlQgbXNnLCBXUEFSQU0gd1BhcmFtLCBM UEFSQU0gbFBhcmFtKQogICAgICAgZ290byBjb21tYW5kOwogICAgIGNhc2UgV01fQ09NTUFO RDoKICAgICAgIG1lbnViYXJfaW5fdXNlID0gMDsKLSAgICAgIGYgPSB4X3dpbmRvd190b19m cmFtZSAoZHB5aW5mbywgaHduZCk7Ci0gICAgICBpZiAoZiAmJiBISVdPUkQgKHdQYXJhbSkg PT0gMCkKLQl7Ci0JICBpZiAobWVudV9mcmVlX3RpbWVyKQotCSAgICB7Ci0JICAgICAgS2ls bFRpbWVyIChod25kLCBtZW51X2ZyZWVfdGltZXIpOwotCSAgICAgIG1lbnVfZnJlZV90aW1l ciA9IDA7Ci0JICAgIH0KLQl9CiAgICAgY2FzZSBXTV9NT1ZFOgogICAgIGNhc2UgV01fU0la RToKICAgICBjb21tYW5kOgpAQCAtMzc0OCw2ICszNzE1LDggQEAgdzMyX3duZF9wcm9jIChI V05EIGh3bmQsIFVJTlQgbXNnLCBXUEFSQU0gd1BhcmFtLCBMUEFSQU0gbFBhcmFtKQogICAg ICAgaWYgKExPV09SRCAobFBhcmFtKSA9PSBIVENMSUVOVCkKIAl7CiAJICBmID0geF93aW5k b3dfdG9fZnJhbWUgKGRweWluZm8sIGh3bmQpOworCSAgaWYgKCFmKQorCSAgICByZXR1cm4g MDsKIAkgIGlmIChmLT5vdXRwdXRfZGF0YS53MzItPmhvdXJnbGFzc19wICYmICFtZW51YmFy X2luX3VzZQogCSAgICAgICYmICFjdXJyZW50X3BvcHVwX21lbnUpCiAJICAgIFNldEN1cnNv ciAoZi0+b3V0cHV0X2RhdGEudzMyLT5ob3VyZ2xhc3NfY3Vyc29yKTsKZGlmZiAtLWdpdCBh L3NyYy93MzJtZW51LmMgYi9zcmMvdzMybWVudS5jCmluZGV4IGZmNmJkOTcuLjc4ZDU5ZmMg MTAwNjQ0Ci0tLSBhL3NyYy93MzJtZW51LmMKKysrIGIvc3JjL3czMm1lbnUuYwpAQCAtMTA4 LDcgKzEwOCw3IEBAIHN0YXRpYyBMaXNwX09iamVjdCBzaW1wbGVfZGlhbG9nX3Nob3cgKEZS QU1FX1BUUiwgTGlzcF9PYmplY3QsIExpc3BfT2JqZWN0KTsKIHN0YXRpYyB2b2lkIHV0Zjh0 bzE2ICh1bnNpZ25lZCBjaGFyICosIGludCwgV0NIQVIgKik7CiBzdGF0aWMgaW50IGZpbGxf aW5fbWVudSAoSE1FTlUsIHdpZGdldF92YWx1ZSAqKTsKIAotdm9pZCB3MzJfZnJlZV9tZW51 X3N0cmluZ3MgKEhXTkQpOworc3RhdGljIHZvaWQgdzMyX2ZyZWVfbWVudV9zdHJpbmdzIChI TUVOVSk7CiAMCiAKIC8qIFRoaXMgaXMgc2V0IG5vbnplcm8gYWZ0ZXIgdGhlIHVzZXIgYWN0 aXZhdGVzIHRoZSBtZW51IGJhciwgYW5kIHNldApAQCAtMzQ3LDggKzM0Nyw2IEBAIG1lbnVi YXJfc2VsZWN0aW9uX2NhbGxiYWNrIChGUkFNRV9QVFIgZiwgdm9pZCAqIGNsaWVudF9kYXRh KQogCSAgICAgIGJ1Zi5raW5kID0gTUVOVV9CQVJfRVZFTlQ7CiAJICAgICAgYnVmLmZyYW1l X29yX3dpbmRvdyA9IGZyYW1lOwogCSAgICAgIGJ1Zi5hcmcgPSBlbnRyeTsKLQkgICAgICAv KiBGcmVlIG1lbW9yeSB1c2VkIGJ5IG93bmVyLWRyYXduIGFuZCBoZWxwLWVjaG8gc3RyaW5n cy4gICovCi0JICAgICAgdzMyX2ZyZWVfbWVudV9zdHJpbmdzIChGUkFNRV9XMzJfV0lORE9X IChmKSk7CiAJICAgICAga2JkX2J1ZmZlcl9zdG9yZV9ldmVudCAoJmJ1Zik7CiAKIAkgICAg ICBmLT5vdXRwdXRfZGF0YS53MzItPm1lbnViYXJfYWN0aXZlID0gMDsKQEAgLTM1Nyw4ICsz NTUsNiBAQCBtZW51YmFyX3NlbGVjdGlvbl9jYWxsYmFjayAoRlJBTUVfUFRSIGYsIHZvaWQg KiBjbGllbnRfZGF0YSkKIAkgIGkgKz0gTUVOVV9JVEVNU19JVEVNX0xFTkdUSDsKIAl9CiAg ICAgfQotICAvKiBGcmVlIG1lbW9yeSB1c2VkIGJ5IG93bmVyLWRyYXduIGFuZCBoZWxwLWVj aG8gc3RyaW5ncy4gICovCi0gIHczMl9mcmVlX21lbnVfc3RyaW5ncyAoRlJBTUVfVzMyX1dJ TkRPVyAoZikpOwogICBmLT5vdXRwdXRfZGF0YS53MzItPm1lbnViYXJfYWN0aXZlID0gMDsK IH0KIApAQCAtNTg4LDYgKzU4NCw3IEBAIHNldF9mcmFtZV9tZW51YmFyIChGUkFNRV9QVFIg ZiwgaW50IGZpcnN0X3RpbWUsIGludCBkZWVwX3ApCiAKICAgaWYgKG1lbnViYXJfd2lkZ2V0 KQogICAgIHsKKyAgICAgIHczMl9mcmVlX21lbnVfc3RyaW5ncyAobWVudWJhcl93aWRnZXQp OwogICAgICAgLyogRW1wdHkgY3VycmVudCBtZW51YmFyLCByYXRoZXIgdGhhbiBjcmVhdGlu ZyBhIGZyZXNoIG9uZS4gICovCiAgICAgICB3aGlsZSAoRGVsZXRlTWVudSAobWVudWJhcl93 aWRnZXQsIDAsIE1GX0JZUE9TSVRJT04pKQogCTsKQEAgLTY0Myw2ICs2NDAsNyBAQCBmcmVl X2ZyYW1lX21lbnViYXIgKEZSQU1FX1BUUiBmKQogICAgIEhNRU5VIG9sZCA9IEdldE1lbnUg KEZSQU1FX1czMl9XSU5ET1cgKGYpKTsKICAgICBTZXRNZW51IChGUkFNRV9XMzJfV0lORE9X IChmKSwgTlVMTCk7CiAgICAgZi0+b3V0cHV0X2RhdGEudzMyLT5tZW51YmFyX3dpZGdldCA9 IE5VTEw7CisgICAgdzMyX2ZyZWVfbWVudV9zdHJpbmdzIChvbGQpOwogICAgIERlc3Ryb3lN ZW51IChvbGQpOwogICB9CiAKQEAgLTg5OCwxMCArODk2LDExIEBAIHczMl9tZW51X3Nob3cg KEZSQU1FX1BUUiBmLCBpbnQgeCwgaW50IHksIGludCBmb3JfY2xpY2ssIGludCBrZXltYXBz LAogICAvKiBGcmVlIHRoZSB3aWRnZXRfdmFsdWUgb2JqZWN0cyB3ZSB1c2VkIHRvIHNwZWNp ZnkgdGhlIGNvbnRlbnRzLiAgKi8KICAgZnJlZV9tZW51YmFyX3dpZGdldF92YWx1ZV90cmVl IChmaXJzdF93dik7CiAKKyAgLyogRnJlZSB0aGUgb3duZXItZHJhd24gYW5kIGhlbHAtZWNo byBtZW51IHN0cmluZ3MuICAqLworICB3MzJfZnJlZV9tZW51X3N0cmluZ3MgKG1lbnUpOwog ICBEZXN0cm95TWVudSAobWVudSk7CisgIGN1cnJlbnRfcG9wdXBfbWVudSA9IE5VTEw7CiAK LSAgLyogRnJlZSB0aGUgb3duZXItZHJhd24gYW5kIGhlbHAtZWNobyBtZW51IHN0cmluZ3Mu ICAqLwotICB3MzJfZnJlZV9tZW51X3N0cmluZ3MgKEZSQU1FX1czMl9XSU5ET1cgKGYpKTsK ICAgZi0+b3V0cHV0X2RhdGEudzMyLT5tZW51YmFyX2FjdGl2ZSA9IDA7CiAKICAgLyogRmlu ZCB0aGUgc2VsZWN0ZWQgaXRlbSwgYW5kIGl0cyBwYW5lLCB0byByZXR1cm4KQEAgLTE2NTEs OSArMTY1MCwxMSBAQCB3MzJfbWVudV9kaXNwbGF5X2hlbHAgKEhXTkQgb3duZXIsIEhNRU5V IG1lbnUsIFVJTlQgaXRlbSwgVUlOVCBmbGFncykKIAogLyogRnJlZSBtZW1vcnkgdXNlZCBi eSBvd25lci1kcmF3biBzdHJpbmdzLiAgKi8KIHN0YXRpYyB2b2lkCi13MzJfZnJlZV9zdWJt ZW51X3N0cmluZ3MgKEhNRU5VIG1lbnUpCit3MzJfZnJlZV9tZW51X3N0cmluZ3MgKEhNRU5V IG1lbnUpCiB7CiAgIGludCBpLCBudW0gPSBHZXRNZW51SXRlbUNvdW50IChtZW51KTsKKyAg aWYgKCFnZXRfbWVudV9pdGVtX2luZm8pCisgICAgcmV0dXJuOwogICBmb3IgKGkgPSAwOyBp IDwgbnVtOyBpKyspCiAgICAgewogICAgICAgTUVOVUlURU1JTkZPIGluZm87CkBAIC0xNjc0 LDI5ICsxNjc1LDEwIEBAIHczMl9mcmVlX3N1Ym1lbnVfc3RyaW5ncyAoSE1FTlUgbWVudSkK IAogICAgICAgLyogUmVjdXJzZSBkb3duIHN1Ym1lbnVzLiAgKi8KICAgICAgIGlmIChpbmZv LmhTdWJNZW51KQotCXczMl9mcmVlX3N1Ym1lbnVfc3RyaW5ncyAoaW5mby5oU3ViTWVudSk7 CisJdzMyX2ZyZWVfbWVudV9zdHJpbmdzIChpbmZvLmhTdWJNZW51KTsKICAgICB9CiB9CiAK LXZvaWQKLXczMl9mcmVlX21lbnVfc3RyaW5ncyAoSFdORCBod25kKQotewotICBITUVOVSBt ZW51ID0gY3VycmVudF9wb3B1cF9tZW51OwotCi0gIGlmIChnZXRfbWVudV9pdGVtX2luZm8p Ci0gICAgewotICAgICAgLyogSWYgdGhlcmUgaXMgbm8gcG9wdXAgbWVudSBhY3RpdmUsIGZy ZWUgdGhlIHN0cmluZ3MgZnJvbSB0aGUgZnJhbWUncwotCSBtZW51YmFyLiAgKi8KLSAgICAg IGlmICghbWVudSkKLQltZW51ID0gR2V0TWVudSAoaHduZCk7Ci0KLSAgICAgIGlmIChtZW51 KQotCXczMl9mcmVlX3N1Ym1lbnVfc3RyaW5ncyAobWVudSk7Ci0gICAgfQotCi0gIGN1cnJl bnRfcG9wdXBfbWVudSA9IE5VTEw7Ci19Ci0KICNlbmRpZiAvKiBIQVZFX01FTlVTICovCiAK IC8qIFRoZSBmb2xsb3dpbmcgaXMgdXNlZCBieSBkZWxheWVkIHdpbmRvdyBhdXRvc2VsZWN0 aW9uLiAgKi8KZGlmZiAtLWdpdCBhL3NyYy93MzJ0ZXJtLmMgYi9zcmMvdzMydGVybS5jCmlu ZGV4IDFmNTM4NjAuLjBjZWYxYjcgMTAwNjQ0Ci0tLSBhL3NyYy93MzJ0ZXJtLmMKKysrIGIv c3JjL3czMnRlcm0uYwpAQCAtNTczNCwxMSArNTczNCwxMSBAQCB4X2ZyZWVfZnJhbWVfcmVz b3VyY2VzIChzdHJ1Y3QgZnJhbWUgKmYpCiAgIGlmIChGUkFNRV9GQUNFX0NBQ0hFIChmKSkK ICAgICBmcmVlX2ZyYW1lX2ZhY2VzIChmKTsKIAorICBmcmVlX2ZyYW1lX21lbnViYXIgKGYp OworCiAgIGlmIChGUkFNRV9XMzJfV0lORE9XIChmKSkKICAgICBteV9kZXN0cm95X3dpbmRv dyAoZiwgRlJBTUVfVzMyX1dJTkRPVyAoZikpOwogCi0gIGZyZWVfZnJhbWVfbWVudWJhciAo Zik7Ci0KICAgdW5sb2FkX2NvbG9yIChmLCBGUkFNRV9GT1JFR1JPVU5EX1BJWEVMIChmKSk7 CiAgIHVubG9hZF9jb2xvciAoZiwgRlJBTUVfQkFDS0dST1VORF9QSVhFTCAoZikpOwogICB1 bmxvYWRfY29sb3IgKGYsIGYtPm91dHB1dF9kYXRhLnczMi0+Y3Vyc29yX3BpeGVsKTsK --------------060302020304000406010904-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 21 11:23:33 2010 Received: (at submit) by debbugs.gnu.org; 21 Oct 2010 15:23:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8wzM-0007Nr-Jl for submit@debbugs.gnu.org; Thu, 21 Oct 2010 11:23:32 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8wzK-0007Nj-Ev for submit@debbugs.gnu.org; Thu, 21 Oct 2010 11:23:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8x32-0005Zu-M2 for submit@debbugs.gnu.org; Thu, 21 Oct 2010 11:27:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:38087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8x32-0005Zo-Jd for submit@debbugs.gnu.org; Thu, 21 Oct 2010 11:27:20 -0400 Received: from [140.186.70.92] (port=51443 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8x31-0006nK-Fl for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 11:27:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8x30-0005Z7-3k for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 11:27:19 -0400 Received: from mail-iw0-f169.google.com ([209.85.214.169]:55560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8x2z-0005Yf-Ss for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 11:27:18 -0400 Received: by iwn1 with SMTP id 1so5892550iwn.0 for ; Thu, 21 Oct 2010 08:27:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:from:to:cc :subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=KBpUH+hukazPJHYSJbKybUpAc6z3EyQJSnu/+9xRR5s=; b=qr9GEZJZOmT8+3qUY6azSKIZhytnS5BhWu6J1puX1VbkELl6H9NSjzn/hXWHtlCZdv TQ+8Nzud65CtuVQhx2ZZqGEhTSQLRst2MX4PA2+mn0036GikuKppVjWUgmBX0DlCKJaz rs9XQiIl5i7SLVK/k73B29iEJY/iTfBJ8QDy4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=Fmz90zgiHygxAmh10899aJ+UvBgARQqq+UkAeg1GWOD1nnXw3HBFcIVIXh+Kirz6tM 1j748TJg4eFB7qvUI9CD9294ZAWf/bcPoVOmZYubBEZVbAEyDZDd4ScA/JDyZKqwAn6t vU1D+r/qjoq7oDyydtUOllIcZJLLVTPXo8elY= Received: by 10.231.38.13 with SMTP id z13mr1045073ibd.169.1287674836209; Thu, 21 Oct 2010 08:27:16 -0700 (PDT) Received: from home.jasonrumney.net ([202.87.221.130]) by mx.google.com with ESMTPS id in12sm1881870ibb.3.2010.10.21.08.27.13 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 21 Oct 2010 08:27:15 -0700 (PDT) Received: by home.jasonrumney.net (Postfix, from userid 1000) id 8BACB7AC; Thu, 21 Oct 2010 23:27:10 +0800 (MYT) From: Jason Rumney To: grischka Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> Date: Thu, 21 Oct 2010 23:27:10 +0800 In-Reply-To: <4CC01FDD.5060707@gmx.de> (grischka's message of "Thu, 21 Oct 2010 13:11:25 +0200") Message-ID: <877hhb4ldd.fsf@home.jasonrumney.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, lennart.borgman@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) grischka writes: > case WM_EXITMENULOOP: > f = x_window_to_frame (dpyinfo, hwnd); > > - /* If a menu is still active, check again after a short delay, > - since Windows often (always?) sends the WM_EXITMENULOOP > - before the corresponding WM_COMMAND message. > - Don't do this if a popup menu is active, since it is only > - menubar menus that require cleaning up in this way. > - */ > if (f && menubar_in_use && current_popup_menu == NULL) > - menu_free_timer = SetTimer (hwnd, MENU_FREE_ID, MENU_FREE_DELAY, NULL); > + { > + f->output_data.w32->menubar_active = 0; > + menubar_in_use = 0; > + } I don't see anything in your change to handle freeing of the menubar structures in the case where the user clicks on the menubar then clicks away without selecting anything. The above code was to fix a memory and resource leak in that case. Jason From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 21 13:04:14 2010 Received: (at submit) by debbugs.gnu.org; 21 Oct 2010 17:04:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8yYm-00087W-OV for submit@debbugs.gnu.org; Thu, 21 Oct 2010 13:04:13 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8yYk-00087R-Bd for submit@debbugs.gnu.org; Thu, 21 Oct 2010 13:04:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8ycQ-0006Ky-Ss for submit@debbugs.gnu.org; Thu, 21 Oct 2010 13:08:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:37615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8ycQ-0006Kt-OV for submit@debbugs.gnu.org; Thu, 21 Oct 2010 13:07:58 -0400 Received: from [140.186.70.92] (port=52898 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8ycP-0008I9-Fr for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 13:07:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8ycN-0006KC-JJ for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 13:07:57 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:37493 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P8ycN-0006Jh-6k for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2010 13:07:55 -0400 Received: (qmail invoked by alias); 21 Oct 2010 17:07:53 -0000 Received: from unknown (EHLO [10.44.157.233]) [82.113.121.196] by mail.gmx.net (mp005) with SMTP; 21 Oct 2010 19:07:53 +0200 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX18bqhpVHN0bGiwNZDBxdLx+L4IF+/XGvoLAwCes5v QIgw8/bXQduYIB Message-ID: <4CC0735E.5080406@gmx.de> Date: Thu, 21 Oct 2010 19:07:42 +0200 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Jason Rumney Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> In-Reply-To: <877hhb4ldd.fsf@home.jasonrumney.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.8 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, lennart.borgman@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.8 (-----) Jason Rumney wrote: > I don't see anything in your change to handle freeing of the menubar > structures in the case where the user clicks on the menubar then clicks > away without selecting anything. This is correct. The patch frees the item-string always when (and in the same place where) the MENUITEM structure itself is destroyed. Since this structure is the only place that has the pointer, it is hence impossible by design to access the pointer after it was freed. > The above code was to fix a memory and resource leak in that case. With the patch, leaking these strings cannot happen by design also provided the MENUITEMs themselves are destroyed correctly always which is made sure by bugs 2/3 fixed: >> 2) memory leak: was trying to free items from already deleted menu >> 3) memory leak: was trying to free menu from already deleted window --- grischka From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 22 10:05:55 2010 Received: (at submit) by debbugs.gnu.org; 22 Oct 2010 14:05:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9IFn-00034z-EM for submit@debbugs.gnu.org; Fri, 22 Oct 2010 10:05:55 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9IFk-00034t-MM for submit@debbugs.gnu.org; Fri, 22 Oct 2010 10:05:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9IJR-0002GM-M5 for submit@debbugs.gnu.org; Fri, 22 Oct 2010 10:09:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:39996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9IJR-0002GI-K3 for submit@debbugs.gnu.org; Fri, 22 Oct 2010 10:09:41 -0400 Received: from [140.186.70.92] (port=53703 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9IJQ-0005op-51 for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 10:09:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9IJM-0002FL-4B for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 10:09:39 -0400 Received: from mail-iw0-f180.google.com ([209.85.214.180]:56767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9IJM-0002F3-0Y for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 10:09:36 -0400 Received: by iwn37 with SMTP id 37so1057471iwn.39 for ; Fri, 22 Oct 2010 07:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:from:to:cc :subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=+LxsbM6Hk58wKHxTbG1cN2xP6eThOC9i54FK2tmSmyk=; b=j9vZOsIWcfKeYUUs7nKauetjiE8f1KQg6HPQt3Y8esox7kRek3rkAl1nR6fwjwdvlW wn3bdyat23P0QWZwXhRSuy5TRhVSC46G65EZkI56bNAD2qu7i3tTI0Jvr3NyaqMZzTsc X0T6kFocZNqKAIo2i6+DdSFhfTX/tU3RHxg78= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=omHJ6fFkdPW1/C28XaPOfScGkc3XjB6TENztDdr9nOmqKpRwrAmZnJQgXw2sz+52Mp jgbk1HBHyqHOW23dskfO1H3Cmz+C3hcI5wiv8UodtJK+m/SguVbeTYvysxrpDaYm5iEJ PDfpwwjZA4Hzgfb2FBx5Ok2ejWiynd7oh+tYY= Received: by 10.231.157.9 with SMTP id z9mr2643268ibw.48.1287756575445; Fri, 22 Oct 2010 07:09:35 -0700 (PDT) Received: from home.jasonrumney.net ([202.87.221.130]) by mx.google.com with ESMTPS id gy41sm3341175ibb.11.2010.10.22.07.09.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 22 Oct 2010 07:09:33 -0700 (PDT) Received: by home.jasonrumney.net (Postfix, from userid 1000) id 7B17B10D1; Fri, 22 Oct 2010 22:09:29 +0800 (MYT) From: Jason Rumney To: grischka Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> Date: Fri, 22 Oct 2010 22:09:29 +0800 In-Reply-To: <4CC0735E.5080406@gmx.de> (grischka's message of "Thu, 21 Oct 2010 19:07:42 +0200") Message-ID: <871v7iz5d2.fsf@home.jasonrumney.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, lennart.borgman@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) grischka writes: >> The above code was to fix a memory and resource leak in that case. > > With the patch, leaking these strings cannot happen by design also > provided the MENUITEMs themselves are destroyed correctly always which > is made sure by bugs 2/3 fixed: >>> 2) memory leak: was trying to free items from already deleted menu >>> 3) memory leak: was trying to free menu from already deleted window OK, I understand now - it seems you have fixed the underlying bug that caused that memory leak to happen in the first place, so the timer kludge is no longer neccesary. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 22 12:42:45 2010 Received: (at submit) by debbugs.gnu.org; 22 Oct 2010 16:42:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9KhY-0004wL-L0 for submit@debbugs.gnu.org; Fri, 22 Oct 2010 12:42:44 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9KhV-0004wE-SV for submit@debbugs.gnu.org; Fri, 22 Oct 2010 12:42:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9KlB-0000IN-K1 for submit@debbugs.gnu.org; Fri, 22 Oct 2010 12:46:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:55422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9KlA-0000HR-Dq for submit@debbugs.gnu.org; Fri, 22 Oct 2010 12:46:29 -0400 Received: from [140.186.70.92] (port=59479 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9Kl4-0001Ju-Ee for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 12:46:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9KMo-00032s-No for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 12:21:19 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:34092 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P9KMo-00032O-Az for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 12:21:18 -0400 Received: (qmail invoked by alias); 22 Oct 2010 16:21:14 -0000 Received: from unknown (EHLO [10.75.252.66]) [82.113.106.207] by mail.gmx.net (mp033) with SMTP; 22 Oct 2010 18:21:14 +0200 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX1+ilyVooT2i/zaHczdpOIeVGIKJy5riZlB0Dec/73 +Nqz8tQP3T8ZCC Message-ID: <4CC1B9E0.8070302@gmx.de> Date: Fri, 22 Oct 2010 18:20:48 +0200 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Jason Rumney Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> In-Reply-To: <871v7iz5d2.fsf@home.jasonrumney.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, lennart.borgman@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) Jason Rumney wrote: > grischka writes: > >>> The above code was to fix a memory and resource leak in that case. >> With the patch, leaking these strings cannot happen by design also >> provided the MENUITEMs themselves are destroyed correctly always which >> is made sure by bugs 2/3 fixed: >>>> 2) memory leak: was trying to free items from already deleted menu >>>> 3) memory leak: was trying to free menu from already deleted window > > OK, I understand now - it seems you have fixed the underlying bug that > caused that memory leak to happen in the first place, so the timer > kludge is no longer neccesary. > Just tried to be less clever. "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." -- Brian Kernighan From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 07 20:45:39 2010 Received: (at submit) by debbugs.gnu.org; 8 Nov 2010 01:45:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFGni-0007Wf-QU for submit@debbugs.gnu.org; Sun, 07 Nov 2010 20:45:39 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFGnh-0007Wa-4w for submit@debbugs.gnu.org; Sun, 07 Nov 2010 20:45:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFGs9-0007UB-Dp for submit@debbugs.gnu.org; Sun, 07 Nov 2010 20:50:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:37212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFGs9-0007U6-B7 for submit@debbugs.gnu.org; Sun, 07 Nov 2010 20:50:13 -0500 Received: from [140.186.70.92] (port=57830 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFGs8-0002H3-BU for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2010 20:50:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFGs7-0007T6-0y for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2010 20:50:12 -0500 Received: from mail-ew0-f41.google.com ([209.85.215.41]:45972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFGs6-0007Sb-N0; Sun, 07 Nov 2010 20:50:10 -0500 Received: by ewy25 with SMTP id 25so2636113ewy.0 for ; Sun, 07 Nov 2010 17:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=OdQaorULUjrPHS8w1XnF7HuEzKny+SLKsCUx4baxDYQ=; b=JCwwvnPwVj3jfeVNNUEfcuB5dRuJmdu6PUmKIZdVw7sN4Q4PjRY5NffaXIl2yVjtw8 dLtMuhoFxKfvYw1dKXOcLuSUoITMOA3SupM0o6LJk8qhrqZxk0iVWLX9GR+1YZBvUcJs tmUwNwzUbVn11T2Q+0oCRfJoQEnFTQQ9ofb08= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=kVqulAIPmussGgHtwEC32ofnkCYxYMotkODBsMJszlgCIYv9YuezsmPFXWcH20iBXl rWSYbUtW2kFaCHVf7QZIwlzlq+MnyY8KiIUZWIkCCcPlFYlWW8cDUtWIy0k/uQe2OG2p LfO7Vup+P2ZlZmctOXxkQpiMHrqMjDiYcGURo= Received: by 10.213.25.143 with SMTP id z15mr494745ebb.62.1289181009023; Sun, 07 Nov 2010 17:50:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.213.36.8 with HTTP; Sun, 7 Nov 2010 17:49:48 -0800 (PST) In-Reply-To: <4CC1B9E0.8070302@gmx.de> References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> From: Lennart Borgman Date: Mon, 8 Nov 2010 02:49:48 +0100 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: grischka Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Jason Rumney X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Fri, Oct 22, 2010 at 6:20 PM, grischka wrote: > > Just tried to be less clever. > > "Debugging is twice as hard as writing the code in the first place. > Therefore, if you write the code as cleverly as possible, you are, > by definition, not smart enough to debug it." -- Brian Kernighan What is the status of this? I just got a crash using my patched Emacs with sources as below. This Emacs was built from sources in bazaar identified as: Nick 'trunk' info: revision id: yamaoka@jpl.org-20101019081945-8auglqcd1ne2o0rb revno: 101998 date: 2010-10-19 08:19:45 +0000 Nick 'emacsw32' (from 'trunk') info: revision id: lennart.borgman@gmail.com-20101019140903-0x7gubo4o0c9voai revno: 99341 date: 2010-10-19 16:09:03 +0200 From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 05:11:29 2010 Received: (at submit) by debbugs.gnu.org; 8 Nov 2010 10:11:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFOhF-0002wz-Lp for submit@debbugs.gnu.org; Mon, 08 Nov 2010 05:11:29 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFOhD-0002wu-GZ for submit@debbugs.gnu.org; Mon, 08 Nov 2010 05:11:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFOlg-0008FV-Mc for submit@debbugs.gnu.org; Mon, 08 Nov 2010 05:16:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:58594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFOlg-0008FR-KX for submit@debbugs.gnu.org; Mon, 08 Nov 2010 05:16:04 -0500 Received: from [140.186.70.92] (port=45404 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFOlf-0002Ks-77 for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 05:16:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFOld-0008F7-Fp for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 05:16:03 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]:55055 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PFOld-0008Eg-45 for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 05:16:01 -0500 Received: (qmail invoked by alias); 08 Nov 2010 10:15:58 -0000 Received: from 192.106.113.82.net.de.o2.com (EHLO [10.74.30.245]) [82.113.106.192] by mail.gmx.net (mp064) with SMTP; 08 Nov 2010 11:15:58 +0100 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX18tzAIF1b0t/N4C1w55TXJbwn8ac+Y8E6+LLN6nNF QYGED8baDp/mkM Message-ID: <4CD7CDD9.3080004@gmx.de> Date: Mon, 08 Nov 2010 11:15:53 +0100 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Lennart Borgman Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Jason Rumney X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) Lennart Borgman wrote: > What is the status of this? I just got a crash using my patched Emacs > with sources as below. You're using the patch from above and still get the crash??? > > This Emacs was built from sources in bazaar identified as: > > Nick 'trunk' info: > revision id: yamaoka@jpl.org-20101019081945-8auglqcd1ne2o0rb > revno: 101998 > date: 2010-10-19 08:19:45 +0000 > > Nick 'emacsw32' (from 'trunk') info: > revision id: lennart.borgman@gmail.com-20101019140903-0x7gubo4o0c9voai > revno: 99341 > date: 2010-10-19 16:09:03 +0200 > From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 06:14:54 2010 Received: (at submit) by debbugs.gnu.org; 8 Nov 2010 11:14:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFPgb-0003Oe-Nn for submit@debbugs.gnu.org; Mon, 08 Nov 2010 06:14:54 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFPga-0003OY-Mi for submit@debbugs.gnu.org; Mon, 08 Nov 2010 06:14:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFPkz-0005fe-Ui for submit@debbugs.gnu.org; Mon, 08 Nov 2010 06:19:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:37221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFPkz-0005fZ-Sg for submit@debbugs.gnu.org; Mon, 08 Nov 2010 06:19:25 -0500 Received: from [140.186.70.92] (port=36036 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFPkw-0003TF-R7 for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 06:19:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFPku-0005ci-VR for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 06:19:22 -0500 Received: from mail-ew0-f41.google.com ([209.85.215.41]:43880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFPku-0005bK-MV; Mon, 08 Nov 2010 06:19:20 -0500 Received: by ewy25 with SMTP id 25so2740879ewy.0 for ; Mon, 08 Nov 2010 03:19:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=9F6zvh2HBsz/JZO0GhuuoLhIpnAw8exPzyn0l4aPahA=; b=C80nSLHktY+cRMeFq43SGtZ5LjfeYtBEVbsGYpPF0K8ULTEFJtpJ8/ZfKlJ1NqSkZz Qwi3q1AzvC8W0QcpKNttTBUx0aKsFC7A+nD+xLWOlhiNDsBrdhACsiDsgArIbUR7L6Mf mX0skkpmdFzWGFiFsnY4+/D8LwZmrphaV/93o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=l3lt7VxUq0p4X7Lw+KfiW0V1FPQXxYAvXVghWs+G4IKNfm3aKU13HjkZije8zTmqHs bKyYmX+mxkIv9dehXctpPG55CdSWaIbxEZgDIgc20hFHN/gEaWtiJwKNLXdxHp/ag6r9 k/aB++xwdvOjyrB+2Sf83TxWJHSbuPQ+bDuUA= Received: by 10.213.27.79 with SMTP id h15mr3553022ebc.88.1289215158604; Mon, 08 Nov 2010 03:19:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.213.36.8 with HTTP; Mon, 8 Nov 2010 03:18:58 -0800 (PST) In-Reply-To: <4CD7CDD9.3080004@gmx.de> References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> From: Lennart Borgman Date: Mon, 8 Nov 2010 12:18:58 +0100 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: grischka Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Jason Rumney X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Mon, Nov 8, 2010 at 11:15 AM, grischka wrote: > Lennart Borgman wrote: >> >> What is the status of this? I just got a crash using my patched Emacs >> with sources as below. > > You're using the patch from above and still get the crash??? > >> >> This Emacs was built from sources in bazaar identified as: >> >> Nick 'trunk' info: >> =C2=A0revision id: yamaoka@jpl.org-20101019081945-8auglqcd1ne2o0rb >> =C2=A0 =C2=A0 =C2=A0 =C2=A0revno: 101998 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 date: 2010-10-19 08:19:45 +0000 >> >> Nick 'emacsw32' (from 'trunk') info: >> =C2=A0revision id: lennart.borgman@gmail.com-20101019140903-0x7gubo4o0c9= voai >> =C2=A0 =C2=A0 =C2=A0 =C2=A0revno: 99341 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 date: 2010-10-19 16:09:03 +0200 I do not know if I am using it, that is what I am asking ;-) I have not applied it myself. Should it be in the checkout I have made? (How do I see that?) From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 14:46:41 2010 Received: (at submit) by debbugs.gnu.org; 8 Nov 2010 19:46:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFXft-0007od-K0 for submit@debbugs.gnu.org; Mon, 08 Nov 2010 14:46:41 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFXfs-0007oY-Fv for submit@debbugs.gnu.org; Mon, 08 Nov 2010 14:46:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFXkM-00073B-NN for submit@debbugs.gnu.org; Mon, 08 Nov 2010 14:51:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:53355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFXkM-000733-LD for submit@debbugs.gnu.org; Mon, 08 Nov 2010 14:51:18 -0500 Received: from [140.186.70.92] (port=44403 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFXkL-0005d8-RI for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 14:51:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFXkK-000729-V7 for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 14:51:17 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:38143 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PFXkK-00071U-EA for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 14:51:16 -0500 Received: (qmail invoked by alias); 08 Nov 2010 19:51:13 -0000 Received: from unknown (EHLO [10.75.206.130]) [82.113.106.206] by mail.gmx.net (mp015) with SMTP; 08 Nov 2010 20:51:13 +0100 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX1+XLAY9BAWXtEyjBgW2i0uLW3uLNLQENGN52uSkG7 JpCvq6Cm/VcHIF Message-ID: <4CD854AC.3070007@gmx.de> Date: Mon, 08 Nov 2010 20:51:08 +0100 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Lennart Borgman Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Jason Rumney X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) Lennart Borgman wrote: > I do not know if I am using it, that is what I am asking ;-) > > I have not applied it myself. Should it be in the checkout I have > made? (How do I see that?) To know that you're using the patch, apply it. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 18:07:18 2010 Received: (at submit) by debbugs.gnu.org; 8 Nov 2010 23:07:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFao1-0002xz-Ma for submit@debbugs.gnu.org; Mon, 08 Nov 2010 18:07:18 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFao0-0002xu-31 for submit@debbugs.gnu.org; Mon, 08 Nov 2010 18:07:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFasU-0004Fb-LE for submit@debbugs.gnu.org; Mon, 08 Nov 2010 18:11:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:49638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFasU-0004FX-JG for submit@debbugs.gnu.org; Mon, 08 Nov 2010 18:11:54 -0500 Received: from [140.186.70.92] (port=40802 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFasT-0004zH-Q5 for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 18:11:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFasS-0004FH-G3 for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 18:11:53 -0500 Received: from mail-ew0-f41.google.com ([209.85.215.41]:57640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFasS-0004FB-9C; Mon, 08 Nov 2010 18:11:52 -0500 Received: by ewy25 with SMTP id 25so3287525ewy.0 for ; Mon, 08 Nov 2010 15:11:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=sFIYPMACN7dOZ05Rr9euukyDfR3CJYtb2Sb6169xeEQ=; b=YBKmhKDIjt4rv5EQsxvW0sgCzoqu3fMLvdaqARpgaFzxjIuhMJDTXBovz4R2XGc4zU XXpwbDYoB193E8ZjR6A8HAoKIzxnQsTqh//IwJ7Mj/s5n3NRTfYxZOLYI6F0skwwea0r 4XXuLGLsDqJ8KSWVektUQkLJ0vUs5w2d2BrW0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=dlTD1avOuqAp6Up3msFmgS1oYuRpYmVrMqsiCaEi7Dwqh8LQKqze2Xuy3s22NyoYkl 0s1yR0m0p9eR7n3kQgVyfeuhWiKvlhM83JQsU8hKRQPZyflWGDZ8gsu6yfR9ACx4ttNR KjUfA9WPDgb+bw6oS/a7a27hi8F+zNGCJycqI= Received: by 10.213.34.20 with SMTP id j20mr4463188ebd.71.1289257911332; Mon, 08 Nov 2010 15:11:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.213.22.135 with HTTP; Mon, 8 Nov 2010 15:11:30 -0800 (PST) In-Reply-To: <4CD854AC.3070007@gmx.de> References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> From: Lennart Borgman Date: Tue, 9 Nov 2010 00:11:30 +0100 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: grischka Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Jason Rumney X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Mon, Nov 8, 2010 at 8:51 PM, grischka wrote: > Lennart Borgman wrote: >> >> I do not know if I am using it, that is what I am asking ;-) >> >> I have not applied it myself. Should it be in the checkout I have >> made? (How do I see that?) > > To know that you're using the patch, apply it. Has it been applied to the trunk yet? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 11:12:24 2010 Received: (at submit) by debbugs.gnu.org; 9 Nov 2010 16:12:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFqo4-0002tx-6o for submit@debbugs.gnu.org; Tue, 09 Nov 2010 11:12:24 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFqny-0002ts-Gl for submit@debbugs.gnu.org; Tue, 09 Nov 2010 11:12:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFqsU-0002uS-Lz for submit@debbugs.gnu.org; Tue, 09 Nov 2010 11:16:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:42357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFqsU-0002uN-Jm for submit@debbugs.gnu.org; Tue, 09 Nov 2010 11:16:58 -0500 Received: from [140.186.70.92] (port=36662 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFqsT-00016R-3z for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 11:16:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFqsS-0002t5-0o for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 11:16:57 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]:51007 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PFqsR-0002rg-Fq for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 11:16:55 -0500 Received: (qmail invoked by alias); 09 Nov 2010 16:16:52 -0000 Received: from unknown (EHLO [10.75.227.247]) [82.113.106.207] by mail.gmx.net (mp056) with SMTP; 09 Nov 2010 17:16:52 +0100 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX18O1CRKY1MOTBtM4nlPnb9OCZP0NaIYIqz0NdPLR2 Oqr0qMoMHD2McT Message-ID: <4CD973EE.5030900@gmx.de> Date: Tue, 09 Nov 2010 17:16:46 +0100 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Lennart Borgman Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Jason Rumney X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) Lennart Borgman wrote: > On Mon, Nov 8, 2010 at 8:51 PM, grischka wrote: >> Lennart Borgman wrote: >>> I do not know if I am using it, that is what I am asking ;-) >>> >>> I have not applied it myself. Should it be in the checkout I have >>> made? (How do I see that?) >> To know that you're using the patch, apply it. > > Has it been applied to the trunk yet? > Obviously, if you want that and don't have commit rights yourself you need to find someone else who understands the patch and is willing to commit it. Also, before doing so it might make sense if you test the patch esp. since you seem to be the only person who sees this bug due to your personal setup (i.e. ownerdrawn items in the menu-bar menu). Of course the patch is correct but there is no reason to believe me ;) --- grischka From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 12:04:16 2010 Received: (at submit) by debbugs.gnu.org; 9 Nov 2010 17:04:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFrcG-0003GK-7i for submit@debbugs.gnu.org; Tue, 09 Nov 2010 12:04:16 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFrcF-0003GF-30 for submit@debbugs.gnu.org; Tue, 09 Nov 2010 12:04:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFrgl-0007Ky-Es for submit@debbugs.gnu.org; Tue, 09 Nov 2010 12:08:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:38630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFrgl-0007Ku-5t for submit@debbugs.gnu.org; Tue, 09 Nov 2010 12:08:55 -0500 Received: from [140.186.70.92] (port=58102 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFrgk-0004eb-1V for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 12:08:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFrgh-0007Ka-Os for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 12:08:53 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:50225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFrgh-0007KS-ES for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 12:08:51 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LBM00700NL5JU00@a-mtaout22.012.net.il> for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 19:08:49 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.249.126]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LBM005UZNMOX0H0@a-mtaout22.012.net.il>; Tue, 09 Nov 2010 19:08:49 +0200 (IST) Date: Tue, 09 Nov 2010 19:08:49 +0200 From: Eli Zaretskii Subject: Re: bug#7190: Crash in menus on w32 In-reply-to: <4CD973EE.5030900@gmx.de> X-012-Sender: halo1@inter.net.il To: grischka Message-id: <83y692mnku.fsf@gnu.org> References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> <4CD973EE.5030900@gmx.de> X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, lennart.borgman@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.4 (----) > Date: Tue, 09 Nov 2010 17:16:46 +0100 > From: grischka > Cc: bug-gnu-emacs@gnu.org > > Obviously, if you want that and don't have commit rights yourself > you need to find someone else who understands the patch and is willing > to commit it. I think it's too large to be committed without your signing legal papers. And I don't see your name on file with the FSF copyright assignments list. If you want your patch to be installed, please contact Stefan or Chong and ask them for instructions. (They could also decide that I'm wrong, and the patch can be treated as "tiny", which doesn't need papers.) TIA From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 13:34:39 2010 Received: (at submit) by debbugs.gnu.org; 9 Nov 2010 18:34:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFt1j-0003uf-5W for submit@debbugs.gnu.org; Tue, 09 Nov 2010 13:34:39 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFt1h-0003ua-8o for submit@debbugs.gnu.org; Tue, 09 Nov 2010 13:34:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFt6D-00041U-WE for submit@debbugs.gnu.org; Tue, 09 Nov 2010 13:39:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:48324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFt6D-00041N-U2 for submit@debbugs.gnu.org; Tue, 09 Nov 2010 13:39:17 -0500 Received: from [140.186.70.92] (port=54379 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFt6C-0001Lh-Vu for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 13:39:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFt6B-00040f-Mc for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 13:39:16 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:38485 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PFt6B-00040N-9e for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2010 13:39:15 -0500 Received: (qmail invoked by alias); 09 Nov 2010 18:39:12 -0000 Received: from unknown (EHLO [10.74.179.59]) [82.113.106.197] by mail.gmx.net (mp055) with SMTP; 09 Nov 2010 19:39:12 +0100 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX1+RMjYAb3mRrkbaFCGAWJfX5IZahoKDU03aTX1O0b pI9hqoTIrCLXxS Message-ID: <4CD9954D.7070701@gmx.de> Date: Tue, 09 Nov 2010 19:39:09 +0100 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> <4CD973EE.5030900@gmx.de> <83y692mnku.fsf@gnu.org> In-Reply-To: <83y692mnku.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, lennart.borgman@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Eli Zaretskii wrote: >> Date: Tue, 09 Nov 2010 17:16:46 +0100 >> From: grischka >> Cc: bug-gnu-emacs@gnu.org >> >> Obviously, if you want that and don't have commit rights yourself >> you need to find someone else who understands the patch and is willing >> to commit it. > > I think it's too large to be committed without your signing legal > papers. And I don't see your name on file with the FSF copyright > assignments list. If you want your patch to be installed, please > contact Stefan or Chong and ask them for instructions. (They could > also decide that I'm wrong, and the patch can be treated as "tiny", > which doesn't need papers.) I will not assign my copyright to someone else however I do not claim copyright for this patch. Anyway it does not add one single new line. (~50 lines removed, ~20 lines moved to other places.) --- grischka > > TIA > From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 10 05:29:01 2010 Received: (at submit) by debbugs.gnu.org; 10 Nov 2010 10:29:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PG7vJ-0002LT-84 for submit@debbugs.gnu.org; Wed, 10 Nov 2010 05:29:01 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PG7vH-0002LC-Nz for submit@debbugs.gnu.org; Wed, 10 Nov 2010 05:29:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PG7zq-0000C8-2I for submit@debbugs.gnu.org; Wed, 10 Nov 2010 05:33:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:48551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PG7zq-0000C4-0J for submit@debbugs.gnu.org; Wed, 10 Nov 2010 05:33:42 -0500 Received: from [140.186.70.92] (port=33692 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PG7zo-0003Il-W4 for bug-gnu-emacs@gnu.org; Wed, 10 Nov 2010 05:33:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PG7zo-0000Bg-2w for bug-gnu-emacs@gnu.org; Wed, 10 Nov 2010 05:33:40 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]:52427 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PG7zn-0000BR-LB for bug-gnu-emacs@gnu.org; Wed, 10 Nov 2010 05:33:40 -0500 Received: (qmail invoked by alias); 10 Nov 2010 10:33:37 -0000 Received: from unknown (EHLO [10.74.108.38]) [82.113.106.195] by mail.gmx.net (mp068) with SMTP; 10 Nov 2010 11:33:37 +0100 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX1/i6AEHlJ3iDEBx9yUkYwNZwhcPdYOoHgW06oEvEx SB3t8kNLqwWW2e Message-ID: <4CDA74FD.2020301@gmx.de> Date: Wed, 10 Nov 2010 11:33:33 +0100 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> <4CD973EE.5030900@gmx.de> <83y692mnku.fsf@gnu.org> <4CD9954D.7070701@gmx.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit Cc: cyd@stupidchicken.com, bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.6 (-----) Stefan Monnier wrote: >> I will not assign my copyright to someone else however I do not claim >> copyright for this patch. Anyway it does not add one single new line. >> (~50 lines removed, ~20 lines moved to other places.) > > As you know, programming is not just writing the lines, but also putting > them in the right order ;-). Then again even more programming effort is required to put lines in wrong order ;). > Your patch is much too non-trivial to be accepted as a "tiny change", > which means we need you to sign some paperwork before we can install it. > > If you're willing to do that, then please fill the form below and email > it as instructed so the FSF can send you the relevant paperwork to sign. > Thank you very much for your help in improving Emacs, > Well, thanks very much too for developing emacs. Please understand that in order to preserve rsp. encourage symmetry and transparency in the meta-code I give this patch to you as I give it to anyone else who wants it, that is under the same terms and conditions as I received your code and without any further agreements beyond those terms with certain parties. --- grischka From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 12 02:48:58 2010 Received: (at submit) by debbugs.gnu.org; 12 Nov 2010 07:48:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGoNV-0002Lc-Vf for submit@debbugs.gnu.org; Fri, 12 Nov 2010 02:48:58 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGoNU-0002LX-15 for submit@debbugs.gnu.org; Fri, 12 Nov 2010 02:48:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGoS7-0001X6-Gd for submit@debbugs.gnu.org; Fri, 12 Nov 2010 02:53:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:50784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGoS7-0001X1-Eu for submit@debbugs.gnu.org; Fri, 12 Nov 2010 02:53:43 -0500 Received: from [140.186.70.92] (port=37789 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGoS6-0005zS-LP for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2010 02:53:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGoS5-0001WZ-Ix for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2010 02:53:42 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:57872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGoS5-0001WV-GD for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2010 02:53:41 -0500 Received: from localhost ([127.0.0.1]:50510) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PGoS0-0005B2-E6; Fri, 12 Nov 2010 02:53:36 -0500 To: grischka Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> <4CD973EE.5030900@gmx.de> <83y692mnku.fsf@gnu.org> <4CD9954D.7070701@gmx.de> From: Glenn Morris X-Spook: secure Bosnia bomb Jiang Zemin KGB MD5 credit card Roswell X-Ran: 4bBHJml.VRPnwsa-m0j{NGP=M~X{o,nCOaRK^K/k X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 12 Nov 2010 02:53:35 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: submit Cc: Eli Zaretskii , bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) grischka wrote: > I will not assign my copyright to someone else however I do not claim > copyright for this patch. Would you be willing to sign a copyright disclaimer to put this change in the public domain? (You seem to be saying that, but we need a signed piece of paper to that effect to be able to use it.) (It sounds like this may be being discussed off-list.) From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 12 17:37:06 2010 Received: (at submit) by debbugs.gnu.org; 12 Nov 2010 22:37:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PH2F0-0001BS-Cw for submit@debbugs.gnu.org; Fri, 12 Nov 2010 17:37:06 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PH2Ex-0001B4-DK for submit@debbugs.gnu.org; Fri, 12 Nov 2010 17:37:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PH2Jc-0000nT-JV for submit@debbugs.gnu.org; Fri, 12 Nov 2010 17:41:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:60368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PH2Jc-0000nP-HQ for submit@debbugs.gnu.org; Fri, 12 Nov 2010 17:41:52 -0500 Received: from [140.186.70.92] (port=35577 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PH2Jb-0001nQ-EG for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2010 17:41:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PH2JX-0000mj-W0 for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2010 17:41:51 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:49178 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PH2JX-0000la-IH for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2010 17:41:47 -0500 Received: (qmail invoked by alias); 12 Nov 2010 22:41:34 -0000 Received: from unknown (EHLO [10.45.231.168]) [82.113.121.207] by mail.gmx.net (mp011) with SMTP; 12 Nov 2010 23:41:34 +0100 X-Authenticated: #18588216 X-Provags-ID: V01U2FsdGVkX1/gfcd+lcng4bLoP76lkt+q5fdmE0Tg+r2m9lOkah K6KtKV3A9JA1Kc Message-ID: <4CDDC25A.9090104@gmx.de> Date: Fri, 12 Nov 2010 23:40:26 +0100 From: grischka User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Glenn Morris Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> <4CD973EE.5030900@gmx.de> <83y692mnku.fsf@gnu.org> <4CD9954D.7070701@gmx.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit Cc: Eli Zaretskii , bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.6 (-----) Glenn Morris wrote: > grischka wrote: > >> I will not assign my copyright to someone else however I do not claim >> copyright for this patch. > > Would you be willing to sign a copyright disclaimer to put this change > in the public domain? > > (You seem to be saying that, but we need a signed piece of paper to > that effect to be able to use it.) Yes, I was saying that because to me there was no content with copyright really. If you say there is then I do not disclaim it. Note that giving up my copyright (if any) would allow you to bypass the GPL with the patch. As it is based on code that I received under GPL myself, this is not possible. --- grischka > > (It sounds like this may be being discussed off-list.) > From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 13 12:04:19 2010 Received: (at submit) by debbugs.gnu.org; 13 Nov 2010 17:04:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PHJWV-0002jI-7F for submit@debbugs.gnu.org; Sat, 13 Nov 2010 12:04:19 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PHJWS-0002jD-UI for submit@debbugs.gnu.org; Sat, 13 Nov 2010 12:04:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHJb9-0000kE-Sm for submit@debbugs.gnu.org; Sat, 13 Nov 2010 12:09:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:58450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHJb9-0000kA-Qu for submit@debbugs.gnu.org; Sat, 13 Nov 2010 12:09:07 -0500 Received: from [140.186.70.92] (port=36467 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHJb8-000274-Ov for bug-gnu-emacs@gnu.org; Sat, 13 Nov 2010 12:09:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHJb7-0000jc-An for bug-gnu-emacs@gnu.org; Sat, 13 Nov 2010 12:09:06 -0500 Received: from pantheon-po42.its.yale.edu ([130.132.50.101]:44487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHJb0-0000id-TV; Sat, 13 Nov 2010 12:08:58 -0500 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by pantheon-po42.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id oADH8uN4027949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 13 Nov 2010 12:08:56 -0500 Received: by furball (Postfix, from userid 1000) id 9A47716062F; Sat, 13 Nov 2010 12:08:55 -0500 (EST) From: Chong Yidong To: grischka Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> <4CD973EE.5030900@gmx.de> <83y692mnku.fsf@gnu.org> <4CD9954D.7070701@gmx.de> <4CDDC25A.9090104@gmx.de> Date: Sat, 13 Nov 2010 12:08:55 -0500 In-Reply-To: <4CDDC25A.9090104@gmx.de> (grischka's message of "Fri, 12 Nov 2010 23:40:26 +0100") Message-ID: <87bp5tm9qw.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit Cc: Glenn Morris , Eli Zaretskii , bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) grischka writes: > Note that giving up my copyright (if any) would allow you to bypass > the GPL with the patch. No it doesn't. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 17 21:24:45 2013 Received: (at 7190) by debbugs.gnu.org; 18 Feb 2013 02:24:46 +0000 Received: from localhost ([127.0.0.1]:33521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7GPM-0000NM-HS for submit@debbugs.gnu.org; Sun, 17 Feb 2013 21:24:45 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:41760) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7GPJ-0000NC-ML for 7190@debbugs.gnu.org; Sun, 17 Feb 2013 21:24:42 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U7GOO-0000hR-6p; Sun, 17 Feb 2013 21:23:44 -0500 From: Glenn Morris To: 7190@debbugs.gnu.org Subject: Re: bug#7190: Crash in menus on w32 References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> <4CD973EE.5030900@gmx.de> <83y692mnku.fsf@gnu.org> <4CD9954D.7070701@gmx.de> <4CDDC25A.9090104@gmx.de> <87bp5tm9qw.fsf@stupidchicken.com> X-Spook: munitions illuminati unclassified high security Crypto AG X-Ran: r$[]$=2PrC)`K:=b]}2ayluL.tYh=7Aia9F*wM4WiW$GDxXdK.v2.^Ybbe[&kea^H~&0qU X-Hue: black X-Attribution: GM Date: Sun, 17 Feb 2013 21:23:44 -0500 In-Reply-To: <87bp5tm9qw.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 13 Nov 2010 12:08:55 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: 7190 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.6 (-----) So IIUC there is some kind of issue here, and someone wrote a patch. However, they don't want to assign copyright for it (which is their prerogative, of course). But given this, I don't see how any progress can be made. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 17 21:40:39 2013 Received: (at 7190) by debbugs.gnu.org; 18 Feb 2013 02:40:39 +0000 Received: from localhost ([127.0.0.1]:33528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7Gel-0000ja-3n for submit@debbugs.gnu.org; Sun, 17 Feb 2013 21:40:39 -0500 Received: from mail-we0-f173.google.com ([74.125.82.173]:47571) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7Gej-0000jT-0c for 7190@debbugs.gnu.org; Sun, 17 Feb 2013 21:40:38 -0500 Received: by mail-we0-f173.google.com with SMTP id r5so4311063wey.32 for <7190@debbugs.gnu.org>; Sun, 17 Feb 2013 18:39:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=uBFKUGxELBwNkmvn+hhI2CNy14+m7t99dpI2UPTB9B4=; b=x2EdGTPArxYJ17uAKuqdnOn/xjetpMt5LHWhUXXaPvpgkAaN3WFPQGEfYFmVYcIcAe XauwVZh/jyUJezTIcHMIIHB9bdsBDYsd2LGmEd2e/DKCNMnV6wZA3QVwEzDS8bUO0rBa hfRd+KFgXqbDtvMNmHzE+/QwBIJhMB4WBg2XU+zz7XVIF5dBkHfxpd0rCGxsLUL/N8Bo Lv1SO8uS9sXq+e3PIc7tx37KWPftuIL8gD0xkypfyMJ+sBJJEreJ1TUkMyxJQNPnI1F8 vcpXwQ7XQa9ua/imsPZRvQaXf9Aw29TJZ8KJ9phW6IjAELJhVmwSPhvipLuJagy3ktAg urfw== X-Received: by 10.180.97.233 with SMTP id ed9mr17109261wib.32.1361155179199; Sun, 17 Feb 2013 18:39:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.194.124.71 with HTTP; Sun, 17 Feb 2013 18:39:09 -0800 (PST) In-Reply-To: References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> <4CD973EE.5030900@gmx.de> <83y692mnku.fsf@gnu.org> <4CD9954D.7070701@gmx.de> <4CDDC25A.9090104@gmx.de> <87bp5tm9qw.fsf@stupidchicken.com> From: Lennart Borgman Date: Mon, 18 Feb 2013 03:39:09 +0100 Message-ID: Subject: Re: bug#7190: Crash in menus on w32 To: Glenn Morris Content-Type: multipart/alternative; boundary=f46d044306aaf0bc1604d5f6a2db X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) --f46d044306aaf0bc1604d5f6a2db Content-Type: text/plain; charset=UTF-8 My old suggestion was adding checks for all system calls. I started doing that, but since those checks were not added to the core I found the merging to difficult. I ran out of time and had to skip it. I still suggest adding checks for all system calls. Maybe someone else have time to catch the error now. On Mon, Feb 18, 2013 at 3:23 AM, Glenn Morris wrote: > > So IIUC there is some kind of issue here, and someone wrote a patch. > However, they don't want to assign copyright for it (which is their > prerogative, of course). But given this, I don't see how any progress > can be made. > > > > --f46d044306aaf0bc1604d5f6a2db Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
My old suggestion was adding checks for all system calls. = I started doing that, but since those checks were not added to the core I f= ound the merging to difficult. I ran out of time and had to skip it.
I still suggest adding checks for all system calls. Maybe someone else have= time to catch the error now.


On Mon, Feb 18, 2013 at 3:23 AM, Glenn Morris <rgm@gnu.org= > wrote:

So IIUC there is some kind of issue here, and someone wrote a patch.
However, they don't want to assign copyright for it (which is their
prerogative, of course). But given this, I don't see how any progress can be made.




--f46d044306aaf0bc1604d5f6a2db-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 17 22:44:50 2013 Received: (at 7190) by debbugs.gnu.org; 18 Feb 2013 03:44:50 +0000 Received: from localhost ([127.0.0.1]:33583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7Her-0002Et-Uj for submit@debbugs.gnu.org; Sun, 17 Feb 2013 22:44:50 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:52971) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7Hen-0002Eh-5N for 7190@debbugs.gnu.org; Sun, 17 Feb 2013 22:44:47 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MIE00200CZF1O00@a-mtaout20.012.net.il> for 7190@debbugs.gnu.org; Mon, 18 Feb 2013 05:43:45 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MIE001HGD0XQ080@a-mtaout20.012.net.il>; Mon, 18 Feb 2013 05:43:45 +0200 (IST) Date: Mon, 18 Feb 2013 05:43:52 +0200 From: Eli Zaretskii Subject: Re: bug#7190: Crash in menus on w32 In-reply-to: X-012-Sender: halo1@inter.net.il To: Glenn Morris Message-id: <837gm6qoav.fsf@gnu.org> References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> <871v7iz5d2.fsf@home.jasonrumney.net> <4CC1B9E0.8070302@gmx.de> <4CD7CDD9.3080004@gmx.de> <4CD854AC.3070007@gmx.de> <4CD973EE.5030900@gmx.de> <83y692mnku.fsf@gnu.org> <4CD9954D.7070701@gmx.de> <4CDDC25A.9090104@gmx.de> <87bp5tm9qw.fsf@stupidchicken.com> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Glenn Morris > Date: Sun, 17 Feb 2013 21:23:44 -0500 > > > So IIUC there is some kind of issue here, and someone wrote a patch. > However, they don't want to assign copyright for it (which is their > prerogative, of course). But given this, I don't see how any progress > can be made. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.166 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4888] X-Debbugs-Envelope-To: 7190 Cc: 7190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > From: Glenn Morris > Date: Sun, 17 Feb 2013 21:23:44 -0500 > > > So IIUC there is some kind of issue here, and someone wrote a patch. > However, they don't want to assign copyright for it (which is their > prerogative, of course). But given this, I don't see how any progress > can be made. Please close. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 18 14:22:56 2013 Received: (at control) by debbugs.gnu.org; 18 Feb 2013 19:22:56 +0000 Received: from localhost ([127.0.0.1]:35114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7WIh-0003Tl-Uv for submit@debbugs.gnu.org; Mon, 18 Feb 2013 14:22:56 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56150) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7WIg-0003Tf-Kf for control@debbugs.gnu.org; Mon, 18 Feb 2013 14:22:55 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U7WHh-00006b-Db for control@debbugs.gnu.org; Mon, 18 Feb 2013 14:21:53 -0500 Date: Mon, 18 Feb 2013 14:21:53 -0500 Message-Id: Subject: control message for bug 7190 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) tag 7190 wontfix close 7190 From unknown Fri Jun 20 20:01:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Mar 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator