GNU bug report logs - #71899
[PATCH v2] gnu: erlang-lfe: Make LFE compiler deterministic.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrew Tropin <andrew <at> trop.in>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71899: closed ([PATCH v2] gnu: erlang-lfe: Make LFE compiler
 deterministic.)
Date: Wed, 03 Jul 2024 03:32:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 03 Jul 2024 07:30:57 +0400
with message-id <87tth7nocu.fsf <at> trop.in>
and subject line Re: [bug#71899] [PATCH v2] gnu: erlang-lfe: Make LFE compiler deterministic.
has caused the debbugs.gnu.org bug report #71899,
regarding [PATCH v2] gnu: erlang-lfe: Make LFE compiler deterministic.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71899: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71899
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Igor Goryachev <igor <at> goryachev.org>
To: guix-patches <at> gnu.org
Cc: Igor Goryachev <igor <at> goryachev.org>, Andrew Tropin <andrew <at> trop.in>
Subject: [PATCH v2] gnu: erlang-lfe: Make LFE compiler deterministic.
Date: Tue,  2 Jul 2024 15:46:15 +0300

* gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.

Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
---
 gnu/packages/erlang.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index dd07c1a617..a236722474 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -792,6 +792,13 @@ (define-public erlang-lfe
       #:phases
       #~(modify-phases %standard-phases
           (delete 'configure)
+          ;; By default LFE compiler itself is not deterministic. We fix it
+          ;; here. For more details see: https://github.com/lfe/lfe/issues/492.
+          (add-after 'unpack 'make-deterministic
+           (lambda _
+             (substitute* "src/lfe_env.erl"
+                 (("maps:fold\\(F, A, D\\)")
+                  "lists:sort(maps:fold(F, A, D))"))))
           ;; The following is inspired by rebar-build-system.scm
           (add-before 'check 'erlang-depends
             (lambda* (#:key inputs #:allow-other-keys)

base-commit: 4b3a553ca5ba5ac190739309eb5f7aa8170cf2a8
-- 
2.45.2

[Message part 3 (message/rfc822, inline)]

From: Andrew Tropin <andrew <at> trop.in>
To: Igor Goryachev via Guix-patches via <guix-patches <at> gnu.org>,
 71899-done <at> debbugs.gnu.org
Cc: Igor Goryachev <igor <at> goryachev.org>
Subject: Re: [bug#71899] [PATCH v2] gnu: erlang-lfe: Make LFE compiler
 deterministic.
Date: Wed, 03 Jul 2024 07:30:57 +0400

[Message part 4 (text/plain, inline)]

On 2024-07-02 15:46, Igor Goryachev via Guix-patches via wrote:

> * gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.
>
> Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
> ---
>  gnu/packages/erlang.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index dd07c1a617..a236722474 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -792,6 +792,13 @@ (define-public erlang-lfe
>        #:phases
>        #~(modify-phases %standard-phases
>            (delete 'configure)
> +          ;; By default LFE compiler itself is not deterministic. We fix it
> +          ;; here. For more details see: https://github.com/lfe/lfe/issues/492.
> +          (add-after 'unpack 'make-deterministic
> +           (lambda _
> +             (substitute* "src/lfe_env.erl"
> +                 (("maps:fold\\(F, A, D\\)")
> +                  "lists:sort(maps:fold(F, A, D))"))))
>            ;; The following is inspired by rebar-build-system.scm
>            (add-before 'check 'erlang-depends
>              (lambda* (#:key inputs #:allow-other-keys)
>
> base-commit: 4b3a553ca5ba5ac190739309eb5f7aa8170cf2a8

Thank you for making guix even more reproducible :)

Applied, pushed as
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=972c06dc79

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.