From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 08:46:34 2024 Received: (at submit) by debbugs.gnu.org; 2 Jul 2024 12:46:34 +0000 Received: from localhost ([127.0.0.1]:36219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOcu1-0007u4-Tm for submit@debbugs.gnu.org; Tue, 02 Jul 2024 08:46:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:57418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOcu0-0007tx-Lj for submit@debbugs.gnu.org; Tue, 02 Jul 2024 08:46:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOctw-0000VZ-MV for guix-patches@gnu.org; Tue, 02 Jul 2024 08:46:31 -0400 Received: from mail.goryachev.org ([104.248.201.73]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOctu-0001Qz-Bw for guix-patches@gnu.org; Tue, 02 Jul 2024 08:46:28 -0400 Received: from localhost.localdomain (213-91-248-88.ip.btc-net.bg [213.91.248.88]) by mail.goryachev.org (Postfix) with ESMTPSA id 35405120042; Tue, 2 Jul 2024 15:46:24 +0300 (MSK) From: Igor Goryachev To: guix-patches@gnu.org Subject: [PATCH v2] gnu: erlang-lfe: Make LFE compiler deterministic. Date: Tue, 2 Jul 2024 15:46:15 +0300 Message-ID: <8a8d2696560e1dfb51d106a1c5e7c9034a5e5c39.1719924375.git.igor@goryachev.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=goryachev.org; s=dkim; t=1719924384; bh=7mUFsSlA6t29mY3Jtyuh3zS+RxbfPTXr7gFB2NKvDDw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Transfer-Encoding; b=2TJ2JxY4YkDwE4yOkHssfAgjy2BWLXECCKWyGrWrWtQiI0JIUfPyeO8cQxgovCadqRW+UI5TFf00rMlMCxnmYr9L0nGiddU84w35rHjR3y+vWynW9rm+7OxYnSK52pewhVMDf6TdA/wJ5rNC9NxHUoRadzbXKLaAtTqRkw/GqVA= Received-SPF: pass client-ip=104.248.201.73; envelope-from=igor@goryachev.org; helo=mail.goryachev.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Igor Goryachev , Andrew Tropin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic. Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b --- gnu/packages/erlang.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm index dd07c1a617..a236722474 100644 --- a/gnu/packages/erlang.scm +++ b/gnu/packages/erlang.scm @@ -792,6 +792,13 @@ (define-public erlang-lfe #:phases #~(modify-phases %standard-phases (delete 'configure) + ;; By default LFE compiler itself is not deterministic. We fix it + ;; here. For more details see: https://github.com/lfe/lfe/issues/492. + (add-after 'unpack 'make-deterministic + (lambda _ + (substitute* "src/lfe_env.erl" + (("maps:fold\\(F, A, D\\)") + "lists:sort(maps:fold(F, A, D))")))) ;; The following is inspired by rebar-build-system.scm (add-before 'check 'erlang-depends (lambda* (#:key inputs #:allow-other-keys) base-commit: 4b3a553ca5ba5ac190739309eb5f7aa8170cf2a8 -- 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 23:31:15 2024 Received: (at submit) by debbugs.gnu.org; 3 Jul 2024 03:31:15 +0000 Received: from localhost ([127.0.0.1]:38293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOqiB-0004Bi-4F for submit@debbugs.gnu.org; Tue, 02 Jul 2024 23:31:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:52256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOqi9-0004BZ-7N for submit@debbugs.gnu.org; Tue, 02 Jul 2024 23:31:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOqi6-0005yL-Pg for guix-patches@gnu.org; Tue, 02 Jul 2024 23:31:11 -0400 Received: from out-184.mta1.migadu.com ([2001:41d0:203:375::b8]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOqi2-0001kK-Tm for guix-patches@gnu.org; Tue, 02 Jul 2024 23:31:10 -0400 X-Envelope-To: guix-patches@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=key1; t=1719977462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CtB18L38pg31naY2Pf51Aj7rnPlOGWMDymbMGNB/8Pk=; b=mFOoWkuwCENS05wx28gKZj7TNDBdQJpFDK6sywMQlR5ffxwapMsMQFSytWlZUZU9vRD3EZ mtH1UK1gzkwC+iUYp7rt/UXmnUfZv6doOOgJIllZSAGb/PjIm3NXa82ITQ6/3hK6pgI411 JXVPNvshtWeDwuBkN0nMRG4dZbVlGshLhyZLHVnreqlV3n4fixDL/dw1ftLfGkx7dP2dQA E3BKKrarpczYY++LC9r6Trx++rXnzsRglTOOhngCW3WufvxaJfNJmJh5oAwCFJNPqWOm2b tmB+qh/zDc/9U+hHI5R75lL03nqd/lPtYHL6W+jzZlrOJnjxjezZsbR4cFfCHA== X-Envelope-To: 71899-done@debbugs.gnu.org X-Envelope-To: igor@goryachev.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Tropin To: Igor Goryachev via Guix-patches via , 71899-done@debbugs.gnu.org Subject: Re: [bug#71899] [PATCH v2] gnu: erlang-lfe: Make LFE compiler deterministic. In-Reply-To: <8a8d2696560e1dfb51d106a1c5e7c9034a5e5c39.1719924375.git.igor@goryachev.org> References: <8a8d2696560e1dfb51d106a1c5e7c9034a5e5c39.1719924375.git.igor@goryachev.org> Date: Wed, 03 Jul 2024 07:30:57 +0400 Message-ID: <87tth7nocu.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::b8; envelope-from=andrew@trop.in; helo=out-184.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Igor Goryachev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2024-07-02 15:46, Igor Goryachev via Guix-patches via wrote: > * gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic. > > Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b > --- > gnu/packages/erlang.scm | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm > index dd07c1a617..a236722474 100644 > --- a/gnu/packages/erlang.scm > +++ b/gnu/packages/erlang.scm > @@ -792,6 +792,13 @@ (define-public erlang-lfe > #:phases > #~(modify-phases %standard-phases > (delete 'configure) > + ;; By default LFE compiler itself is not deterministic. We fix= it > + ;; here. For more details see: https://github.com/lfe/lfe/issu= es/492. > + (add-after 'unpack 'make-deterministic > + (lambda _ > + (substitute* "src/lfe_env.erl" > + (("maps:fold\\(F, A, D\\)") > + "lists:sort(maps:fold(F, A, D))")))) > ;; The following is inspired by rebar-build-system.scm > (add-before 'check 'erlang-depends > (lambda* (#:key inputs #:allow-other-keys) > > base-commit: 4b3a553ca5ba5ac190739309eb5f7aa8170cf2a8 Thank you for making guix even more reproducible :) Applied, pushed as https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D972c06dc79 =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmaExfEACgkQIgjSCVjB 3rCRcw//etikTt5ox0fhMaAwpeZKbLY9M51pZI3/rBaD5s6q+PrDKhqxPQkNTTL5 Em3NQcT9M3AklgA9iufREulYTKqohwFJ3mtBnUWdqL5U6h5FtwikZFu5jFE3yXTp vYrRWMbb+C3oFdwOKUh6m22sXNn//odikhCCZhBrugcmjuXYP5qLeV+NPeceATNa 4PzfinU5hglwDSbJxYtTB3LJBOHBwnLpmzyle7UiVHzQ1KVPf70RRyvIWb+4q7Qd eR8v26iKXUtgJLkDbOp+KJ4a/LOA+5Xp4wdn6OIicDCQM+AavZOjHtXr5MYHBROm qIp+ihagfWrdFFZePYE+gzbQIyrMSpGd48IHBa/JqViorVmCgxIP0ugmDVZP0lFo LtvPlaC/SGVpasRC5ZhXUW7O9jVAxXW++3h4sFwMrK2+XmDD0hBbG+EASOBu6ncV FGSlCx+1jYmacQc9XivEaximvRUbPAA3YpupRv2KFDQ7BgrjOvZoZ0FAa1meb+dT 4yAZU7BDI83cvyaReO3fFc+rzxpwEDWytkYnCAlFZtOj9PNlVz3aMAq+OSmVybCh V3BBpGf8s9aNCnBWahBU23SKw/V/QiIMZ+mFHXRVWe8VvQSO9moSzk+arBHvIXUC vAffUqS4fNm+c3Xym8tzNJbBi61FT/kWWjKn1HHKfkarhXvb3Ow= =Fs6T -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Aug 16 18:31:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 31 Jul 2024 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator