Subject: bug#71898: closed (Re: [bug#71898] [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 07 Jul 2024 07:53:02 +0000

Your bug report

#71898: [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
71898: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71898
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#71898] [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic.
From: Andrew Tropin <[email-masked]>
To: Igor Goryachev via Guix-patches via <[email-masked]>, [email-masked]
Cc: Igor Goryachev <[email-masked]>
Date: Sun, 07 Jul 2024 11:52:13 +0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On 2024-07-02 11:57, Igor Goryachev via Guix-patches via wrote:

> * gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.
>
> Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
> ---
>  gnu/packages/erlang.scm | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index dd07c1a617..58aac2bead 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -792,6 +792,11 @@ (define-public erlang-lfe
>        #:phases
>        #~(modify-phases %standard-phases
>            (delete 'configure)
> +          (add-after 'unpack 'make-deterministic
> +           (lambda _
> +             (substitute* "src/lfe_env.erl"
> +                 (("maps:fold\\(F, A, D\\)")
> +                  "lists:sort(maps:fold(F, A, D))"))))
>            ;; The following is inspired by rebar-build-system.scm
>            (add-before 'check 'erlang-depends
>              (lambda* (#:key inputs #:allow-other-keys)
>
> base-commit: 5f1e4e4c0242af6bcba656aedf8b49afbe7247b7

Superseded by 71899.

-- 
Best regards,
Andrew Tropin

Subject: [PATCH] gnu: erlang-lfe: Make LFE compiler deterministic.
From: Igor Goryachev <[email-masked]>
To: [email-masked]
Cc: Igor Goryachev <[email-masked]>, Andrew Tropin <[email-masked]>
Date: Tue, 2 Jul 2024 11:57:17 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.

Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
---
 gnu/packages/erlang.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index dd07c1a617..58aac2bead 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -792,6 +792,11 @@ (define-public erlang-lfe
       #:phases
       #~(modify-phases %standard-phases
           (delete 'configure)
+          (add-after 'unpack 'make-deterministic
+           (lambda _
+             (substitute* "src/lfe_env.erl"
+                 (("maps:fold\\(F, A, D\\)")
+                  "lists:sort(maps:fold(F, A, D))"))))
           ;; The following is inspired by rebar-build-system.scm
           (add-before 'check 'erlang-depends
             (lambda* (#:key inputs #:allow-other-keys)

base-commit: 5f1e4e4c0242af6bcba656aedf8b49afbe7247b7
-- 
2.45.2