Subject: Re: [bug#71897] [PATCH v8 8/8] gnu: telegram-desktop: Update to 5.5.5.

From: dan <[email-masked]>
Date: Sun, 22 Sep 2024 12:14:44 +0800

Maxim Cournoyer <[email-masked]> writes:

> Hi,
>
> dan <[email-masked]> writes:
>
>> * 
>> gnu/packages/patches/telegram-desktop-allow-disable-libtgvoip.patch:
>> Update patch file to match upstream changes.
>> *
>> gnu/packages/patches/webrtc-for-telegram-desktop-unbundle-libsrtp.patch:
>> Update patch file to match upstream changes.
>> * gnu/packages/patches/telegram-desktop-unbundle-cppgir.patch: 
>> New file.
>> * gnu/packages/patches/telegram-desktop-unbundle-gsl.patch: New 
>> file.
>
> I suppose these patches are from upstream?  For extra origin 
> tracking, I
> like to add a URL to the upstream URL they were fetched from, or 
> at
> least a comment mentioning this is committed but unreleased in 
> the main
> repo.
>
> [...]
>
>>  (define-public webrtc-for-telegram-desktop
>> -  (let ((commit "0532942ac6176a66ef184fb728a4cbb02958fc0b")
>> -        (revision "389"))
>> +  (let ((commit "c425281150317753d7bc5182c6572abe20f9a784")
>> +        (revision "456"))
>>      (hidden-package
>>       (package
>>         (name "webrtc-for-telegram-desktop")
>> @@ -285,7 +291,7 @@ (define-public webrtc-for-telegram-desktop
>>            (file-name
>>             (git-file-name name version))
>>            (sha256
>> -           (base32 
>> "0fary99yl1ddk5zjpfy0pyb5brd268j41plcnvv9qjyf0wj9hf2k"))
>> +           (base32 
>> "1fj48iq56awnrckncy1qc3zhdzifl725hbb6an7wg2v3zmagvrwn"))
>>            (patches
>>             (search-patches
>>              ;; https://github.com/desktop-app/tg_owt/pull/123
>> @@ -407,7 +413,7 @@ (define libprisma-for-telegram-desktop
>>           (url "https://github.com/desktop-app/libprisma")
>>           (commit "23b0d70f9709da9b38561d5706891a134d18df76")))

The upstream pull request URLs were added as comments in the 
package definition.  Do you think this is sufficient? Or do you 
suggest me adding them in the patch file directly, or in the 
commit message?

-- 
dan