GNU bug report logs - #71888
[PATCH] nnfeed: (Mostly) fix group descriptions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71888: closed ([PATCH] nnfeed: (Mostly) fix group descriptions)
Date: Sun, 03 Nov 2024 06:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 2 Nov 2024 23:10:44 -0700
with message-id <CADwFkmk+r_b+PsqcWb64NtrdW0mVRJsBagvC0=gzwPU8ym5uSw <at> mail.gmail.com>
and subject line Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions
has caused the debbugs.gnu.org bug report #71888,
regarding [PATCH] nnfeed: (Mostly) fix group descriptions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71888: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71888
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Daniel Semyonov <daniel <at> dsemy.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Tue, 02 Jul 2024 02:43:29 +0300

[Message part 3 (text/plain, inline)]

Tags: patch

Hi,

I realized a few days ago I barely tested group descriptions in nnatom
(and by extension nnfeed), and turns out they were in fact broken.
Attached is a patch which should fix them.

Also, while working on this patch I found out the Gnus backend interface
docs are slightly misleading on this subject - Gnus reads a group
description per line inserted in the " *nntpd*" buffer, with each line
containing a group's name followed by its description.
Contrary to the docs, the separator between the name and its associated
description is either a space or a tab (the docs only mention a tab).
This is why this is "mostly" fixed, as groups with a space in their name
will incorrectly include any part of the name after the first space in
the description.

I don't currently have time to go over all other backends to see if
changing this to reflect the docs will break anything, so I just added a
comment about it.

Daniel



In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-06-12 built on coldharbour
Repository revision: 3905db6e3aa947b847c072259ad6d08c8a15e10e
Repository branch: master
System Description: Void Linux

Configured using:
 'configure -C --prefix=/opt/Emacs --without-x --with-pgtk
 --with-small-ja-dic --with-native-compilation 'CFLAGS=-march=native
 -O2''

[0001-nnfeed-Mostly-fix-group-descriptions.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Daniel Semyonov <daniel <at> dsemy.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 71888-done <at> debbugs.gnu.org
Subject: Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions
Date: Sat, 2 Nov 2024 23:10:44 -0700

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Daniel Semyonov <daniel <at> dsemy.com> writes:
>
>> Sorry but no, I really hoped I would have more time to spend on this but
>> life has been getting in the way lately unfortunately. (Also, sorry for
>> taking this long to respond)
>
> Thanks, and no worries.  We're all volunteers here.
>
>> I don't think there are many issues remaining in the code FWIW, as I've
>> been using it for years at this point so hopefully I already found and
>> fixed most of them; I was mostly worried about parts of Gnus I don't use
>> frequently interacting with my code in weird ways (and I have had time
>> to test some of these parts at least, and they seem to work as
>> expected).
>
> Should we perhaps close this bug, then?  You could always open a new one
> if any new issues should arise.

That was 2 weeks ago, so I'm closing this bug report now.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.