From unknown Sat Aug 09 05:04:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions Resent-From: Daniel Semyonov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Jul 2024 23:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 71888@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171987746516456 (code B ref -1); Mon, 01 Jul 2024 23:45:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jul 2024 23:44:25 +0000 Received: from localhost ([127.0.0.1]:35123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOQh6-0004HM-Rb for submit@debbugs.gnu.org; Mon, 01 Jul 2024 19:44:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:57092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOQh4-0004HB-LD for submit@debbugs.gnu.org; Mon, 01 Jul 2024 19:44:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOQh3-0008AF-CG for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2024 19:44:21 -0400 Received: from dsemy.com ([46.23.89.208]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOQgy-000358-Qt for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2024 19:44:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=dkim; bh=agTdbxNOPFDwf +biaGXnXAn+Eef+eWpMo9rxj5UrqVo=; h=date:subject:to:from; d=dsemy.com; b=lkeOmZUSOya4wvR9wTMUvMdZmgfRFUK0Ep1XELETeqT64Dq2ZYYh7kmO34wVgofd3aOJ K4k6/xLNBYqeJ4Rn6nKa68LL38UE5fJHY3QsFvklVszHJiG7w/N7cRnhr/2r4JZPMlupSP jAvO++BWM5f99JjOQm6KlQXFh9lH6DGNh8VAyiThZIK4G2zZf46Gfl88kjt+mny6/oe2ML PUemOUyu/q9Fb+ugb2ULdsQWMKPi0IJdMm1DrP82OA6npMAQjQwWmQ6Z1KzNQfdxANRMdX Gi6oorc5EApZ961I5W74zx4JOBEsxLMsVK3+Fu2Zq4kHfymdNrFJl/45dj96xw8A== Received: from coldharbour ( [2a06:c701:4840:6800:1231:246:5c8b:b4ed]) by dsemy.com (OpenSMTPD) with ESMTPSA id eca93307 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 2 Jul 2024 01:44:11 +0200 (CEST) From: Daniel Semyonov Date: Tue, 02 Jul 2024 02:43:29 +0300 Message-ID: <871q4c7k66.fsf@dsemy.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=46.23.89.208; envelope-from=daniel@dsemy.com; helo=dsemy.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch Hi, I realized a few days ago I barely tested group descriptions in nnatom (and by extension nnfeed), and turns out they were in fact broken. Attached is a patch which should fix them. Also, while working on this patch I found out the Gnus backend interface docs are slightly misleading on this subject - Gnus reads a group description per line inserted in the " *nntpd*" buffer, with each line containing a group's name followed by its description. Contrary to the docs, the separator between the name and its associated description is either a space or a tab (the docs only mention a tab). This is why this is "mostly" fixed, as groups with a space in their name will incorrectly include any part of the name after the first space in the description. I don't currently have time to go over all other backends to see if changing this to reflect the docs will break anything, so I just added a comment about it. Daniel In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-06-12 built on coldharbour Repository revision: 3905db6e3aa947b847c072259ad6d08c8a15e10e Repository branch: master System Description: Void Linux Configured using: 'configure -C --prefix=/opt/Emacs --without-x --with-pgtk --with-small-ja-dic --with-native-compilation 'CFLAGS=-march=native -O2'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-nnfeed-Mostly-fix-group-descriptions.patch >From b7cbb2d58cab74eb6137ad05d64466b249cbadf4 Mon Sep 17 00:00:00 2001 From: Daniel Semyonov Date: Tue, 2 Jul 2024 01:42:26 +0300 Subject: [PATCH] nnfeed: (Mostly) fix group descriptions * lisp/gnus/nnfeed.el (nnfeed--group-description): New function. (nnfeed-request-group-description) (nnfeed-request-list-newsgroups): Use `nnfeed--group-description' and always return t if group data is found. --- lisp/gnus/nnfeed.el | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lisp/gnus/nnfeed.el b/lisp/gnus/nnfeed.el index d6963b2e929..2d33d4c813b 100644 --- a/lisp/gnus/nnfeed.el +++ b/lisp/gnus/nnfeed.el @@ -630,12 +630,21 @@ nnfeed-retrieve-groups (deffoo nnfeed-request-type (_group &optional _article) 'unknown) +;; FIXME: Works incorrectly when a group name contains spaces as Gnus actually +;; separates the group name from the description with either a tab or a space. +(defun nnfeed--group-description (name group) + "Return a description line for a GROUP called NAME." + (when-let ((desc (aref group 5)) + ((not (string-blank-p desc)))) + (insert name "\t" desc "\n"))) + (deffoo nnfeed-request-group-description (group &optional server) (when-let ((server (or server (nnfeed--current-server-no-prefix))) (g (nnfeed--group-data group server))) (with-current-buffer nntp-server-buffer (erase-buffer) - (insert group " " (aref g 5) "\n")))) + (nnfeed--group-description group g) + t))) (deffoo nnfeed-request-list-newsgroups (&optional server) (when-let ((server (or server (nnfeed--current-server-no-prefix))) @@ -643,9 +652,8 @@ nnfeed-request-list-newsgroups ((hash-table-p s))) (with-current-buffer nntp-server-buffer (erase-buffer) - (maphash (lambda (group g) - (insert group " " (aref g 5) "\n")) - s)))) + (maphash #'nnfeed--group-description s) + t))) (deffoo nnfeed-request-rename-group (group new-name &optional server) (when-let ((server (or server (nnfeed--current-server-no-prefix))) -- 2.45.2 --=-=-=-- From unknown Sat Aug 09 05:04:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2024 12:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Semyonov Cc: 71888@debbugs.gnu.org Received: via spool by 71888-submit@debbugs.gnu.org id=B71888.171992228726769 (code B ref 71888); Tue, 02 Jul 2024 12:12:01 +0000 Received: (at 71888) by debbugs.gnu.org; 2 Jul 2024 12:11:27 +0000 Received: from localhost ([127.0.0.1]:36154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOcM3-0006xh-B8 for submit@debbugs.gnu.org; Tue, 02 Jul 2024 08:11:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOcM0-0006xQ-TL for 71888@debbugs.gnu.org; Tue, 02 Jul 2024 08:11:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOcLu-0004HS-BS; Tue, 02 Jul 2024 08:11:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=w4l5t9YaO/qFdWUL3UoL0rXBVd5uD2SMiW9/LKhX9nU=; b=o0XK153pBEJ3 lnHODYgOpxkyPy1NgNCW/AGhHgUtMsXVAG2H2jqT/MeSElzI6zFJHawa7EwIJUQ/434fI9r0jaglC CAqNY9wfGtQKgKsXGjIRwBVz3arbtAkEvo7fGjOosfXN5KuD3rvu3brfUw8QVpBNfiUtWrOQ58HJ4 9PSTQ6t5URUCJJiUCKzgzvvR37+VGMFCD09yU7pYhXjWAg/MeYVcdoiK6myJUhgsWrqSjxhUX2Vvn 7xuhsSC6U1Mavyl1KQsrrcOeusW95ikzG+xQCEeGc5QMQfz/R6nZosYURlVapwmiETvKMOxOBxDLy L6UQbVBpR1DtDJzptwtT1w==; Date: Tue, 02 Jul 2024 15:11:14 +0300 Message-Id: <86wmm4c7tp.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <871q4c7k66.fsf@dsemy.com> (bug-gnu-emacs@gnu.org) References: <871q4c7k66.fsf@dsemy.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 02 Jul 2024 02:43:29 +0300 > From: Daniel Semyonov via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I realized a few days ago I barely tested group descriptions in nnatom > (and by extension nnfeed), and turns out they were in fact broken. > Attached is a patch which should fix them. Thanks, but please tell whether this is for the emacs-30 release branch or for master. IOW, does the problem exist on emacs-30 or only on master? From unknown Sat Aug 09 05:04:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions Resent-From: Daniel Semyonov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2024 21:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 71888@debbugs.gnu.org Received: via spool by 71888-submit@debbugs.gnu.org id=B71888.17199541708207 (code B ref 71888); Tue, 02 Jul 2024 21:03:02 +0000 Received: (at 71888) by debbugs.gnu.org; 2 Jul 2024 21:02:50 +0000 Received: from localhost ([127.0.0.1]:37915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOkeH-00028J-S4 for submit@debbugs.gnu.org; Tue, 02 Jul 2024 17:02:50 -0400 Received: from dsemy.com ([46.23.89.208]:1964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOkeF-000284-TE for 71888@debbugs.gnu.org; Tue, 02 Jul 2024 17:02:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=dkim; bh=otKza3j44htvd 3pjgNQ6bAYJaX6CHqmOsb2ZXKmACSE=; h=date:references:in-reply-to: subject:cc:to:from; d=dsemy.com; b=CwgSGRt78/eS+MVAoB4WVfTOHfBnyrOjuw/ 6Dd1ZU3OR7X+4fhiqRrzqTWLuWHUEX0mBzr1EHbMZycAKv9MNgqDBUAWqA9INrR3/pcYwJ duRthOqelYlgAryij5yzZ+NTNbXHV3ZbkXk5HCuBkMmLRBtlOPSfnagDWcklOgF4es+7V5 S+91UIMV7T5NGNyJ4w8UcgisidJoW6tn0FZ8xzB/imWG+gHOpBQUiYBVjaB3D9r0XjWINf x3dHt7jhgmacU97TMUsDuLwCHvmSakA5wmHVs4K27zU1CL1Eoo89ISRWqURhyZRuhBbRkI vSic/LsfZVoJZjvXvg8prSKtZ2w== Received: from coldharbour ( [2a06:c701:4840:6800:1231:246:5c8b:b4ed]) by dsemy.com (OpenSMTPD) with ESMTPSA id 74a1b2a6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 2 Jul 2024 23:02:37 +0200 (CEST) From: Daniel Semyonov In-Reply-To: <86wmm4c7tp.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Jul 2024 15:11:14 +0300") References: <871q4c7k66.fsf@dsemy.com> <86wmm4c7tp.fsf@gnu.org> Date: Wed, 03 Jul 2024 00:01:57 +0300 Message-ID: <87v81njynu.fsf@dsemy.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> Eli Zaretskii writes: >> Date: Tue, 02 Jul 2024 02:43:29 +0300 >> From: Daniel Semyonov via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> I realized a few days ago I barely tested group descriptions in nnatom >> (and by extension nnfeed), and turns out they were in fact broken. >> Attached is a patch which should fix them. > Thanks, but please tell whether this is for the emacs-30 release > branch or for master. IOW, does the problem exist on emacs-30 or only > on master? Sorry, this problem exists on both emacs-30 and on master (it was unfortunately broken since nnfeed and nnatom were added to Emacs last year). I'm currently going over nnfeed and nnatom when I have free time to hopefully find any issues I missed before Emacs 30 is released (as it will be the first stable release to include them). From unknown Sat Aug 09 05:04:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jul 2024 10:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Semyonov Cc: 71888@debbugs.gnu.org Received: via spool by 71888-submit@debbugs.gnu.org id=B71888.17202607444105 (code B ref 71888); Sat, 06 Jul 2024 10:13:02 +0000 Received: (at 71888) by debbugs.gnu.org; 6 Jul 2024 10:12:24 +0000 Received: from localhost ([127.0.0.1]:45627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ2P2-000149-4E for submit@debbugs.gnu.org; Sat, 06 Jul 2024 06:12:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ2P0-00013u-6n for 71888@debbugs.gnu.org; Sat, 06 Jul 2024 06:12:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ2Or-0001Yu-8x; Sat, 06 Jul 2024 06:12:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VpmigBHVVSJ68UUdj4Ux9Oo9zeYfw4h24VVZ2YXnpp0=; b=TssNjayDw5WA QZ5sKxyMVO9eX9QGX2xrmLtSXh66OXpCe9K+F+Nv0RqvQ1hqVSVf3v820I35RiOUZRcG/2jIh0Pnb 61nkQdMcoK/I4qRXfKDgCsKmR/i0QB/0kS8eKU0t6MmMM20aJlG/Fy1zOipTW/pnQ8rxgAKGHThnn InqxkscXuZRorWSIr4U2KcK4QGLpRuQ2Qt5avr6tXnmOAXNb/6s3lPqZ5wjs5rRac/fqRDk5UuNtz 4YVUnv5Y4SxvF8zHHYSkoDtNcdihxWaheMtoA1JasZpF0TL5KFRcJQmSM+QCUC6FfrSt2q0bgEl5g rYV12rt+wa6xv7AFzwx9PQ==; Date: Sat, 06 Jul 2024 13:12:08 +0300 Message-Id: <86r0c64yo7.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87v81njynu.fsf@dsemy.com> (message from Daniel Semyonov on Wed, 03 Jul 2024 00:01:57 +0300) References: <871q4c7k66.fsf@dsemy.com> <86wmm4c7tp.fsf@gnu.org> <87v81njynu.fsf@dsemy.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Semyonov > Cc: 71888@debbugs.gnu.org > Date: Wed, 03 Jul 2024 00:01:57 +0300 > > >>>>> Eli Zaretskii writes: > > >> Date: Tue, 02 Jul 2024 02:43:29 +0300 > >> From: Daniel Semyonov via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> I realized a few days ago I barely tested group descriptions in nnatom > >> (and by extension nnfeed), and turns out they were in fact broken. > >> Attached is a patch which should fix them. > > > Thanks, but please tell whether this is for the emacs-30 release > > branch or for master. IOW, does the problem exist on emacs-30 or only > > on master? > > Sorry, this problem exists on both emacs-30 and on master (it was > unfortunately broken since nnfeed and nnatom were added to Emacs last > year). Thanks, so I've now installed the patch on the emacs-30 release branch. > I'm currently going over nnfeed and nnatom when I have free time to > hopefully find any issues I missed before Emacs 30 is released (as it > will be the first stable release to include them). So I'm not yet closing this bug, given that you say there's more to be done here. Thanks. From unknown Sat Aug 09 05:04:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2024 01:47:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 71888@debbugs.gnu.org, Daniel Semyonov Received: via spool by 71888-submit@debbugs.gnu.org id=B71888.17276607943628 (code B ref 71888); Mon, 30 Sep 2024 01:47:05 +0000 Received: (at 71888) by debbugs.gnu.org; 30 Sep 2024 01:46:34 +0000 Received: from localhost ([127.0.0.1]:43579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv5Ug-0000wS-8a for submit@debbugs.gnu.org; Sun, 29 Sep 2024 21:46:34 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:44438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv5Ud-0000v8-PB for 71888@debbugs.gnu.org; Sun, 29 Sep 2024 21:46:32 -0400 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5c8784e3bc8so4649930a12.1 for <71888@debbugs.gnu.org>; Sun, 29 Sep 2024 18:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727660694; x=1728265494; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=vRoNt0FmIMeV77bvY6HsJraRgeomKE9uG2w6DgxWWrk=; b=nsX/X5eunNvu3QJnMFWIFQBvQM/YKzk1vdgGeUItaMjLCib4hXGRoEqa+QVrj+OZeB GzMr42+kEQ0U37Dvj6VN9+kI3WmXHKe7dODzl3NNoARiOOGUMngNw4en0syly2zy0n/c Htm/Y4rE6PI/ojsR7pgP2lccgly59Rkj9fX4HbMyLz82dTVQiUypn+BxeXsh7dkdnUmK 3MYtEERE76wFrTV2EE2O3AaRWqNqZO0SmQxeyFW/RfnJqnMMC3Y/ecnx//Ceit4hCko5 vOSid0CIHvbgX9wDNjXDLOwsdAggXe9nMDxyqisd/BqB+Ee08/RfQlD+hssOtdcOxV7o 2mRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727660694; x=1728265494; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vRoNt0FmIMeV77bvY6HsJraRgeomKE9uG2w6DgxWWrk=; b=A08jnzomsstyye/nds9HZpafsd3ptEsKqiEhrnYtspAnaaa5XSDlPlQi1R+DrKwIoF M6ReKDmiEWBad11Cel78x/aPSj727rE7dQiKyJab+8woiDiDgxTVaf7B3Besi4C7Xc5Z 2v6MrTSyUAFBFGjvGT+gfgcVF4wFWKDi4t8eYiGGx8VWpShwp8Lex1sEDAUv3iS2V5pM tMTxQFudRpdMtU/5gd+z6TlayC3mJ8mlTJsROG9/S6BBXNhGECwBtCpvdwD2SiNiGoK1 W4gFWArxtAfR6J80sC2aAuwtlGaGX28WLVBqcnczkvU5nxCDYNRrv5Pj/U0xopW0mhz4 BK8A== X-Forwarded-Encrypted: i=1; AJvYcCXae0v4SWQuP4CS7yo0maaPZ9GOkk8uiwhjQNWzlEkL0eYbsGZy6wGlcBqJ97eVRT8LAiQiWA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxdn8kL+GpXrkK69IbXtS0t0sQfIHouz0kkr5keOVzUueAxU7dA KvhQwpzOwawhqaqdD1fcBFJAAB4fE2Dy6mlkRfG/RAXM/7T3LBd3bSp3VJPR8etzLq5XeSBDVy9 DlisKtuUz3v2RCdfBwVrT1lh5HrkBSw== X-Google-Smtp-Source: AGHT+IGNQIJ3kJpp3u1T8OiPnUpALMxY/UwwOFEBVwP0FXhQA7JzusGAgKKIUm1Kcjw242zpRwuxi+0+HzUeDdimckE= X-Received: by 2002:a05:6402:210b:b0:5c5:c447:e4c0 with SMTP id 4fb4d7f45d1cf-5c8824ccc05mr9349366a12.4.1727660694017; Sun, 29 Sep 2024 18:44:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 29 Sep 2024 18:44:53 -0700 From: Stefan Kangas In-Reply-To: <86r0c64yo7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jul 2024 13:12:08 +0300") References: <871q4c7k66.fsf@dsemy.com> <86wmm4c7tp.fsf@gnu.org> <87v81njynu.fsf@dsemy.com> <86r0c64yo7.fsf@gnu.org> MIME-Version: 1.0 Date: Sun, 29 Sep 2024 18:44:53 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) Eli Zaretskii writes: >> From: Daniel Semyonov >> Cc: 71888@debbugs.gnu.org >> Date: Wed, 03 Jul 2024 00:01:57 +0300 >> >> I'm currently going over nnfeed and nnatom when I have free time to >> hopefully find any issues I missed before Emacs 30 is released (as it >> will be the first stable release to include them). > > So I'm not yet closing this bug, given that you say there's more to be > done here. Any news here? Thanks. From unknown Sat Aug 09 05:04:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions Resent-From: Daniel Semyonov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Oct 2024 20:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: Eli Zaretskii , 71888@debbugs.gnu.org Received: via spool by 71888-submit@debbugs.gnu.org id=B71888.172893917722546 (code B ref 71888); Mon, 14 Oct 2024 20:53:01 +0000 Received: (at 71888) by debbugs.gnu.org; 14 Oct 2024 20:52:57 +0000 Received: from localhost ([127.0.0.1]:44523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0S3l-0005ra-B4 for submit@debbugs.gnu.org; Mon, 14 Oct 2024 16:52:57 -0400 Received: from dsemy.com ([46.23.89.208]:12901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0S3j-0005rK-3I for 71888@debbugs.gnu.org; Mon, 14 Oct 2024 16:52:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=dkim; bh=PSfw0sPacXy3s zEc2FiIdfIybHGdNkKFw1Jo3w8l5Fg=; h=date:references:in-reply-to: subject:cc:to:from; d=dsemy.com; b=shNi2z0dQZx1w06dALTZVOUCMlX//Rjc3n8 0FQ717cnl/dkJDDWYDCv9pv0dR9QbRA2uzLrisF60/0zRjxDrpE4880/3d0wYvAuK+cJgJ 64mbMDSTUWrBlVX/NVT05WZgf6a7xw/xvKo2QYLduK+o+Z2blacQHclbKg9ZLjyCV5boiE x1WF2fVpYn7wpSWQFtdjwM4x2bKQhPAbWB7YusfORhnWy+uAKzHfgj0Ac1qXQnpaeR+Ae0 hqQB3yCjfoab43KzGvqb0NdjVvvAz6mnxKRBqpqKF9PJGPNRlWhp/MoJngSFBq2Gdsdefm 4QmQl49QrT21GVzLVT4CM0zTDRw== Received: from coldharbour ( [2a06:c701:4848:1d00:370b:44c:dca:f302]) by dsemy.com (OpenSMTPD) with ESMTPSA id 7e815289 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 14 Oct 2024 22:52:30 +0200 (CEST) From: Daniel Semyonov In-Reply-To: (Stefan Kangas's message of "Sun, 29 Sep 2024 18:44:53 -0700") References: <871q4c7k66.fsf@dsemy.com> <86wmm4c7tp.fsf@gnu.org> <87v81njynu.fsf@dsemy.com> <86r0c64yo7.fsf@gnu.org> Date: Mon, 14 Oct 2024 23:49:41 +0300 Message-ID: <87msj64dga.fsf@dsemy.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> Stefan Kangas writes: > Eli Zaretskii writes: >>> From: Daniel Semyonov >>> Cc: 71888@debbugs.gnu.org >>> Date: Wed, 03 Jul 2024 00:01:57 +0300 >>> >>> I'm currently going over nnfeed and nnatom when I have free time to >>> hopefully find any issues I missed before Emacs 30 is released (as it >>> will be the first stable release to include them). >> >> So I'm not yet closing this bug, given that you say there's more to be >> done here. > Any news here? Thanks. Sorry but no, I really hoped I would have more time to spend on this but life has been getting in the way lately unfortunately. (Also, sorry for taking this long to respond) I don't think there are many issues remaining in the code FWIW, as I've been using it for years at this point so hopefully I already found and fixed most of them; I was mostly worried about parts of Gnus I don't use frequently interacting with my code in weird ways (and I have had time to test some of these parts at least, and they seem to work as expected). From unknown Sat Aug 09 05:04:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Oct 2024 21:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Semyonov Cc: Eli Zaretskii , 71888@debbugs.gnu.org Received: via spool by 71888-submit@debbugs.gnu.org id=B71888.17289427533884 (code B ref 71888); Mon, 14 Oct 2024 21:53:01 +0000 Received: (at 71888) by debbugs.gnu.org; 14 Oct 2024 21:52:33 +0000 Received: from localhost ([127.0.0.1]:44743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0SzQ-00010Y-Rt for submit@debbugs.gnu.org; Mon, 14 Oct 2024 17:52:33 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:61819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0SzO-0000zw-CS for 71888@debbugs.gnu.org; Mon, 14 Oct 2024 17:52:31 -0400 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5c9404c0d50so4778687a12.3 for <71888@debbugs.gnu.org>; Mon, 14 Oct 2024 14:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728942667; x=1729547467; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=LJdbSMMx3h7HdF/KfrpWha/0JaxA2+qSKONw3SOEgG8=; b=H8K0sefxktPuSHMkW1+Ss4Hd7IdHg4WpetlG949BNCLvYsTHcAfeY5g7hNrITML9Q1 eBmoQgoj/rDc35O2mYkIwbwHY7G1BQFBme2mA8Z2KT/erZWtVEKjxxlLntGb9QLwp0t7 Y9Z70zEf5kHOHWut4QvMQWt/kq/bwdmHlCwkc0qnOIR8G/lomLl13reEbw98dbopuBLX SmrU2Wm1HY3o2l94RNFJ5r6grIMgLVa65PIjklGXQp7Q/aqRCAgeJJfnMKQPFJhDUJg/ jDsny72U49fhovp82Gq2HEsgo71ocbRg72VrnvU23Klw7/spY/9buo12qqP7VSEzuoZY 586Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728942667; x=1729547467; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LJdbSMMx3h7HdF/KfrpWha/0JaxA2+qSKONw3SOEgG8=; b=Al/taKS3RhJjjNRAplv2/B0kNVZd6suHaS9G/M65lrpJ724TEEqfvmqILzwd00Ogbr Fcs76cAhxJ6Yjua+Vxfd6+tox6g9pesR9nWESa2XnRNOcrQrNcKr0Zmbk+FOytC05aqP sRNmN8gtzp3+kEtmXPNmEjLx6yTyR942CA6v/ioxYSm27Kn9lD03KzxLpmAP+CnZMKnv qByEV6fncGhSkU3dSOTV9CFE3kKisc/KDeZIsajNIK17a+DlFfniRK/Oan5lXPdaUa7G 7WIrOMnRmrbwgjy5JGix1wjgA+1yg5Sa4gosPLqyG7B25jv44aZukm6ugm5MXywIWFT1 FSJw== X-Forwarded-Encrypted: i=1; AJvYcCW9ZGtAsEIJg3tjd1tHRJsL1Z9GaNBL3br/I3eOo7pzqQwSzYmRu1ZWEK0QgDbo1FvoxJMAwg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywe2S92dWhvBB4jp0V5eqwLayZnDOAMeyYYc9kOZEKi7jbMMdq6 bYGZ9tkT1sxxS8gfryQ0IRn6oXTy/JskLjYHbfFN31Hx7vs2CiwaAuoTpZawqxrP5eY3j56A2qq DfYt/pqfzxFCl1Z9hgz6wKDRGoFU= X-Google-Smtp-Source: AGHT+IFigGsvb2nrV07LmUmtTTjxKlyR7cK4SpmLwR0DtrCrrfs1SoiX+pDQp1PvkbaHkIiREtVcW5lmV+qLZUoWT5M= X-Received: by 2002:a05:6402:234d:b0:5c9:753f:5a90 with SMTP id 4fb4d7f45d1cf-5c9753f5e45mr4611019a12.26.1728942666841; Mon, 14 Oct 2024 14:51:06 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 14 Oct 2024 14:51:06 -0700 From: Stefan Kangas In-Reply-To: <87msj64dga.fsf@dsemy.com> References: <871q4c7k66.fsf@dsemy.com> <86wmm4c7tp.fsf@gnu.org> <87v81njynu.fsf@dsemy.com> <86r0c64yo7.fsf@gnu.org> <87msj64dga.fsf@dsemy.com> MIME-Version: 1.0 Date: Mon, 14 Oct 2024 14:51:06 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Semyonov writes: > Sorry but no, I really hoped I would have more time to spend on this but > life has been getting in the way lately unfortunately. (Also, sorry for > taking this long to respond) Thanks, and no worries. We're all volunteers here. > I don't think there are many issues remaining in the code FWIW, as I've > been using it for years at this point so hopefully I already found and > fixed most of them; I was mostly worried about parts of Gnus I don't use > frequently interacting with my code in weird ways (and I have had time > to test some of these parts at least, and they seem to work as > expected). Should we perhaps close this bug, then? You could always open a new one if any new issues should arise. From unknown Sat Aug 09 05:04:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Daniel Semyonov Subject: bug#71888: closed (Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions) Message-ID: References: <871q4c7k66.fsf@dsemy.com> X-Gnu-PR-Message: they-closed 71888 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 71888@debbugs.gnu.org Date: Sun, 03 Nov 2024 06:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1730614322-6162-1" This is a multi-part message in MIME format... ------------=_1730614322-6162-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71888: [PATCH] nnfeed: (Mostly) fix group descriptions which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71888@debbugs.gnu.org. --=20 71888: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71888 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1730614322-6162-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71888-done) by debbugs.gnu.org; 3 Nov 2024 06:11:53 +0000 Received: from localhost ([127.0.0.1]:58239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7Tq4-0001b5-T3 for submit@debbugs.gnu.org; Sun, 03 Nov 2024 01:11:53 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:44451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t7Tq2-0001ax-Hq for 71888-done@debbugs.gnu.org; Sun, 03 Nov 2024 01:11:51 -0500 Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5ced377447bso525578a12.1 for <71888-done@debbugs.gnu.org>; Sat, 02 Nov 2024 23:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730614245; x=1731219045; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=zbACYr1JDgmlUYeCbWpoeFhRYjhq0d24LE/sKBUpnW8=; b=Gcwvt5aFfgNy4HCLWa/bv+Mr0JEvrwovhLgN6FGts88nF9/0i8GM5r/ad+4nO2PgPt SMMeOzWJHd9chjsUeyUy8iahfW7jJEx0p0HH7cPuN4u3YChVPc0uigM1k3as1PLXYHeP FY+ROQ/zmIIWpoD2Likzv4Y+EVCjEwv1jgNZ4eAyENj93eaxfLpUQ8+qx/MDesYGdqRD E4Jv0Cb5Dij7ZOWV00OfyKD66B2riSkWTWql8FHmIo3pby1t6AupatxmqQl5ZxkoZwsl MEWVdkV9AxtaTiY/n3gfJOscHQ6BJPilTy6fUtsp3dylxIExBT/WaQYlMic86naN3AMK 4pMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730614245; x=1731219045; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zbACYr1JDgmlUYeCbWpoeFhRYjhq0d24LE/sKBUpnW8=; b=rzwIG7OA13K53WEsNb025P2Ni8Xtkj2IbLnL6b+KqC3++Qewh11JhJYJgHK6q3kNFX Z7HjdgjJKRpPI9EnpNK2efPLDy98V4NI3yonezWFKpYvRTDjF66EdGODbzDmB/+wg//h fDU9qEoNGnJFffg/LfWPwopcDfCFNwyVe480U484gnW6cEJo7L9Xo5OONiETc4oraRz1 /PD8FCQ9DQjMUrCTY9PWrPYwJuHGwjHHRwvUEo1q9OhMtrwvwvb9U0bh3RLtjDMx2aTr +AJtG0pIwbsKvs+8OzNRGrW9LsT2bbWx7caGevHHmKmhdIDQuB7Rx4o6xwapH/mNt+l9 Baqw== X-Forwarded-Encrypted: i=1; AJvYcCXiElpoTWDKAmYO1YbnE4xTjUJaTV3jmXdL6ClVN1tWk4P9x0wehbvdgm3PuZauiah1RAIQFP4dNmwk@debbugs.gnu.org X-Gm-Message-State: AOJu0YyIyO62MgMMcAR8GNwpC+v0XObU8WJbAbBklpYTF82o2/8bqyUl Y550NrUFVAHOVjXT0a9yd82UL37TnSPLIVRvF6rQ3yDNHPtI0JBolGXDPwavknchNzbNtWaHe/n +1ufmmlHSdSNzluArjNnA/WfRzuM= X-Google-Smtp-Source: AGHT+IELd2sN7Doy+APT3/0gSlqNBWZyjrkCejPC2O9bXtymYTfYybRVviyoN7Z5hPDGJVhF66HM8Vsv6M7QAx9ChVg= X-Received: by 2002:a05:6402:440b:b0:5ce:c936:b72c with SMTP id 4fb4d7f45d1cf-5cec9371a6fmr3833656a12.28.1730614244730; Sat, 02 Nov 2024 23:10:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 2 Nov 2024 23:10:44 -0700 From: Stefan Kangas In-Reply-To: (Stefan Kangas's message of "Mon, 14 Oct 2024 14:51:06 -0700") References: <871q4c7k66.fsf@dsemy.com> <86wmm4c7tp.fsf@gnu.org> <87v81njynu.fsf@dsemy.com> <86r0c64yo7.fsf@gnu.org> <87msj64dga.fsf@dsemy.com> MIME-Version: 1.0 Date: Sat, 2 Nov 2024 23:10:44 -0700 Message-ID: Subject: Re: bug#71888: [PATCH] nnfeed: (Mostly) fix group descriptions To: Daniel Semyonov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71888-done Cc: Eli Zaretskii , 71888-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Daniel Semyonov writes: > >> Sorry but no, I really hoped I would have more time to spend on this but >> life has been getting in the way lately unfortunately. (Also, sorry for >> taking this long to respond) > > Thanks, and no worries. We're all volunteers here. > >> I don't think there are many issues remaining in the code FWIW, as I've >> been using it for years at this point so hopefully I already found and >> fixed most of them; I was mostly worried about parts of Gnus I don't use >> frequently interacting with my code in weird ways (and I have had time >> to test some of these parts at least, and they seem to work as >> expected). > > Should we perhaps close this bug, then? You could always open a new one > if any new issues should arise. That was 2 weeks ago, so I'm closing this bug report now. Thanks! ------------=_1730614322-6162-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Jul 2024 23:44:25 +0000 Received: from localhost ([127.0.0.1]:35123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOQh6-0004HM-Rb for submit@debbugs.gnu.org; Mon, 01 Jul 2024 19:44:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:57092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOQh4-0004HB-LD for submit@debbugs.gnu.org; Mon, 01 Jul 2024 19:44:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOQh3-0008AF-CG for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2024 19:44:21 -0400 Received: from dsemy.com ([46.23.89.208]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOQgy-000358-Qt for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2024 19:44:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=dkim; bh=agTdbxNOPFDwf +biaGXnXAn+Eef+eWpMo9rxj5UrqVo=; h=date:subject:to:from; d=dsemy.com; b=lkeOmZUSOya4wvR9wTMUvMdZmgfRFUK0Ep1XELETeqT64Dq2ZYYh7kmO34wVgofd3aOJ K4k6/xLNBYqeJ4Rn6nKa68LL38UE5fJHY3QsFvklVszHJiG7w/N7cRnhr/2r4JZPMlupSP jAvO++BWM5f99JjOQm6KlQXFh9lH6DGNh8VAyiThZIK4G2zZf46Gfl88kjt+mny6/oe2ML PUemOUyu/q9Fb+ugb2ULdsQWMKPi0IJdMm1DrP82OA6npMAQjQwWmQ6Z1KzNQfdxANRMdX Gi6oorc5EApZ961I5W74zx4JOBEsxLMsVK3+Fu2Zq4kHfymdNrFJl/45dj96xw8A== Received: from coldharbour ( [2a06:c701:4840:6800:1231:246:5c8b:b4ed]) by dsemy.com (OpenSMTPD) with ESMTPSA id eca93307 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 2 Jul 2024 01:44:11 +0200 (CEST) From: Daniel Semyonov To: bug-gnu-emacs@gnu.org Subject: [PATCH] nnfeed: (Mostly) fix group descriptions Date: Tue, 02 Jul 2024 02:43:29 +0300 Message-ID: <871q4c7k66.fsf@dsemy.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=46.23.89.208; envelope-from=daniel@dsemy.com; helo=dsemy.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch Hi, I realized a few days ago I barely tested group descriptions in nnatom (and by extension nnfeed), and turns out they were in fact broken. Attached is a patch which should fix them. Also, while working on this patch I found out the Gnus backend interface docs are slightly misleading on this subject - Gnus reads a group description per line inserted in the " *nntpd*" buffer, with each line containing a group's name followed by its description. Contrary to the docs, the separator between the name and its associated description is either a space or a tab (the docs only mention a tab). This is why this is "mostly" fixed, as groups with a space in their name will incorrectly include any part of the name after the first space in the description. I don't currently have time to go over all other backends to see if changing this to reflect the docs will break anything, so I just added a comment about it. Daniel In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-06-12 built on coldharbour Repository revision: 3905db6e3aa947b847c072259ad6d08c8a15e10e Repository branch: master System Description: Void Linux Configured using: 'configure -C --prefix=/opt/Emacs --without-x --with-pgtk --with-small-ja-dic --with-native-compilation 'CFLAGS=-march=native -O2'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-nnfeed-Mostly-fix-group-descriptions.patch >From b7cbb2d58cab74eb6137ad05d64466b249cbadf4 Mon Sep 17 00:00:00 2001 From: Daniel Semyonov Date: Tue, 2 Jul 2024 01:42:26 +0300 Subject: [PATCH] nnfeed: (Mostly) fix group descriptions * lisp/gnus/nnfeed.el (nnfeed--group-description): New function. (nnfeed-request-group-description) (nnfeed-request-list-newsgroups): Use `nnfeed--group-description' and always return t if group data is found. --- lisp/gnus/nnfeed.el | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lisp/gnus/nnfeed.el b/lisp/gnus/nnfeed.el index d6963b2e929..2d33d4c813b 100644 --- a/lisp/gnus/nnfeed.el +++ b/lisp/gnus/nnfeed.el @@ -630,12 +630,21 @@ nnfeed-retrieve-groups (deffoo nnfeed-request-type (_group &optional _article) 'unknown) +;; FIXME: Works incorrectly when a group name contains spaces as Gnus actually +;; separates the group name from the description with either a tab or a space. +(defun nnfeed--group-description (name group) + "Return a description line for a GROUP called NAME." + (when-let ((desc (aref group 5)) + ((not (string-blank-p desc)))) + (insert name "\t" desc "\n"))) + (deffoo nnfeed-request-group-description (group &optional server) (when-let ((server (or server (nnfeed--current-server-no-prefix))) (g (nnfeed--group-data group server))) (with-current-buffer nntp-server-buffer (erase-buffer) - (insert group " " (aref g 5) "\n")))) + (nnfeed--group-description group g) + t))) (deffoo nnfeed-request-list-newsgroups (&optional server) (when-let ((server (or server (nnfeed--current-server-no-prefix))) @@ -643,9 +652,8 @@ nnfeed-request-list-newsgroups ((hash-table-p s))) (with-current-buffer nntp-server-buffer (erase-buffer) - (maphash (lambda (group g) - (insert group " " (aref g 5) "\n")) - s)))) + (maphash #'nnfeed--group-description s) + t))) (deffoo nnfeed-request-rename-group (group new-name &optional server) (when-let ((server (or server (nnfeed--current-server-no-prefix))) -- 2.45.2 --=-=-=-- ------------=_1730614322-6162-1--