GNU bug report logs - #71883
[PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function

Previous Next

Full log

Message #82 received at 71883 <at> debbugs.gnu.org (full text, mbox):

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: Juri Linkov <juri <at> linkov.net>
Cc: adam <at> alphapapa.net, 71883 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 shipmints <at> gmail.com
Subject: Re: bug#71883: [PATCH] Fix tab-bar-auto-width with customized
 tab-bar-tab-face-function
Date: Mon, 19 Aug 2024 18:49:27 -0700

Juri Linkov <juri <at> linkov.net> writes:

> close 71883 31.0.50
> thanks
>
>>>> +(defun tab-bar-auto-width-predicate-default (item)
>>>> +  "Accepts tab ITEM and returns non-nil for tabs and tab groups."
>>>> +  (string-match-p
>>>> +   ;; (rx bos (or "current-tab" "current-group" "tab-" "group-"))
>>>> +   "\\`\\(?:current-\\(?:group\\|tab\\)\\|\\(?:group\\|tab\\)-\\)"
>>>> +   (symbol-name (nth 0 item))))
>>>
>>> In this part please remove the current group from the default implementation,
>>> because it looks too ugly, and it was not resized before this change, since
>>> tab-bar-auto-width-faces didn't contain the tab-bar-tab-group-current face.
>>
>> If the simpler change offers feature parity, that sounds good to me.
>
> Thanks for the patch, I pushed it to master, then ameliorated it
> to keep backwards-compatibility for users customized these faces,
> but by default using your predicate on symbols.

Thank you!  How would users have customized tab-bar-auto-width-faces
since it was not a defcustom?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.