GNU bug report logs - #71882
[PATCH] gnu: librewolf: Fix building on aarch64-linux.

Previous Next

Package: guix-patches;

Reported by: Remco van 't Veer <remco <at> remworks.net>

Date: Mon, 1 Jul 2024 19:55:02 UTC

Severity: normal

Tags: patch

Done: Andreas Enge <andreas <at> enge.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Enge <andreas <at> enge.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71882: closed ([PATCH] gnu: librewolf: Fix building on
 aarch64-linux.)
Date: Mon, 08 Jul 2024 08:57:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 8 Jul 2024 10:55:33 +0200
with message-id <ZouphUGFYPpDQVqT <at> jurong>
and subject line Closing one bug
has caused the debbugs.gnu.org bug report #71882,
regarding [PATCH] gnu: librewolf: Fix building on aarch64-linux.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71882: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71882
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Remco van 't Veer <remco <at> remworks.net>
To: guix-patches <at> gnu.org
Cc: Remco van 't Veer <remco <at> remworks.net>
Subject: [PATCH] gnu: librewolf: Fix building on aarch64-linux.
Date: Mon,  1 Jul 2024 21:53:22 +0200
* gnu/packages/librewolf.scm (librewolf)[arguments]: On non-x86-linux systems the "--disable-eme" switch is not available because EME is not available.

Change-Id: I0f397570249b1bc6a0182d2744a8d3c459c1bafa
---
 gnu/packages/librewolf.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm
index c84bcaf3ce..892f12565d 100644
--- a/gnu/packages/librewolf.scm
+++ b/gnu/packages/librewolf.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2022 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2023 Tomas Volf <wolf <at> wolfsden.cz>
 ;;; Copyright © 2023 Ian Eure <ian <at> retrospec.tv>
+;;; Copyright © 2024 Remco van 't Veer <remco <at> remworks.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -261,7 +262,10 @@ (define-public librewolf
                               "--disable-crashreporter"
                               "--allow-addon-sideload"
                               "--with-unsigned-addon-scopes=app,system"
-                              "--disable-eme"
+
+                              ;; switch only available on x86 and EME not
+                              ;; supported on other targets
+                              ,@(if #$(target-x86?) '("--disable-eme") '())
 
                               ;; Build details
                               "--disable-debug"

base-commit: ba6460900f052759fe82e4ceb606d25e19f02884
-- 
2.45.1



[Message part 3 (message/rfc822, inline)]
From: Andreas Enge <andreas <at> enge.fr>
To: 71882-done <at> debbugs.gnu.org, 71832 <at> debbugs.gnu.org
Subject: Closing one bug
Date: Mon, 8 Jul 2024 10:55:33 +0200
Hello,

I have pushed the patch of #71882 to fix the build on non-x86 architectures.
I could still build on x86_64, but could still not build on aarch64; but
the latter failure is probably due to a lack of memory (the configure phase
passes now, but the build fails later on with a SIGKILL).

As this means that the librewolf update of #71832 needs to be rebased,
I am cc-ing this bug.

Andreas



This bug report was last modified 1 year and 11 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.