From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 16:12:25 2024 Received: (at submit) by debbugs.gnu.org; 30 Jun 2024 20:12:25 +0000 Received: from localhost ([127.0.0.1]:59199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sO0uP-00046Q-3E for submit@debbugs.gnu.org; Sun, 30 Jun 2024 16:12:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:45750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sO0uM-00046I-VE for submit@debbugs.gnu.org; Sun, 30 Jun 2024 16:12:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sO0uM-0001ep-GD for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 16:12:22 -0400 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sO0uI-0005bi-TU for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 16:12:21 -0400 Received: by mail-oi1-x234.google.com with SMTP id 5614622812f47-3d5666a4860so1504899b6e.2 for ; Sun, 30 Jun 2024 13:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719778337; x=1720383137; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=kAeHtcp7Mg7ZZnT9HYaBlNvZrTVNcNmYU2VBR9Voqr0=; b=ljjr7uOSWzkFjKWjR/TfOC0z4JWjSh1JKfZgSD7JzDSEiH1O1E3NYPMLQuakWA2XMk AVOajd72e1bFFl0GDpK0nMYwvKyt52FWs1FlGIv/ipS+dDeTfAqKhL2YI4S+btS2xmzl ybbTr83y64Diq0HxfOhFzayAuDhcN9ZPyN/Up+sIEsu/2xO00KhBeypZ9lw0ku98Hg6P zNklTEr/oOkW2wRfUGzbAcjd39P60JypJSKme86ufPkJNgC6JA4bxIiipaICOD01Htdd T5if3FblgKHhi5c8+vD0WurNEDbAykxcsoHGkw1jaDcRaUIkn+Dsr9H09Q3iTL3b4thP PsSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719778337; x=1720383137; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kAeHtcp7Mg7ZZnT9HYaBlNvZrTVNcNmYU2VBR9Voqr0=; b=ZZH9RwCEgPm/cv7aOHKzftGlvGBe9G2X9wTQkyt0/4aquCI92eWepSUnKXGy4XIOMj l8qcmxy/h8+N20YuuuC+jScvkFYkPE65xZuFE4rKq5UirtolnjW9Tt5YU9OaGgV/Pvm4 QYKbeNvTqNa/80J+zw9ijjhqBCIaLaoVmwkiH3zTwG0XxrOh7mzJwfAT69Ub/WrMEeU7 St5zI07P7Jztl0dCOz4cSOifKuhAbKGE3/7sMnOhfZ3VlgI5X21m9h5WN8iKV9qnOF0V 2D1szAyIjn6HRO96PPLfPBiyWUesZIuib8vpX0xw4mxFo0OPRXWv4GeWhpPkpWm8EZNi 6oLQ== X-Gm-Message-State: AOJu0Yw3IXvydVoimeb9d/gX8lQPUSuiX2skGfHcKCwLJfpOsbHKZGG3 NibOUasGX3YlciA3DACNHDmbha8Wamf0k0iV9JTb4XcasRtbSpXNIWA8AVhX59bqwo6z6bDdEA5 iL3KTIACZzEamGPJvL6ycDGJyBGIJDPdu6SWI/Ybp X-Google-Smtp-Source: AGHT+IHFXzTx/fnvuSbOPo/3er9vnniLPdN64otGRZSeHlo139lQTl+gVFq3sgYwNnCCVWDb8qlX5/2cgm7efx7tEUc= X-Received: by 2002:a05:6870:d28e:b0:24f:c31a:5c29 with SMTP id 586e51a60fabf-25db3640694mr3574684fac.43.1719778336785; Sun, 30 Jun 2024 13:12:16 -0700 (PDT) MIME-Version: 1.0 From: Noah Peart Date: Sun, 30 Jun 2024 16:12:06 -0400 Message-ID: Subject: 31.0.50; Wrong argument type for treesit-query-range in treesit-update-ranges To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000db49db061c211839" Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=noah.v.peart@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000db49db061c211839 Content-Type: text/plain; charset="UTF-8" I just noticed this after building latest Emacs. In `treesit-update-ranges`, during redisplay, the first argument to `treesit-query-range` is a tree-sitter language symbol, not a node. At treesit.el:760 (let* ((host-lang (treesit-query-language query)) (parser (treesit-parser-create language)) (old-ranges (treesit-parser-included-ranges parser)) >>> host-lang isnt a node (new-ranges (treesit-query-range host-lang query beg end offset)) This causes a an error in modes that have set `treesit-range-settings` eg., `js-ts-mode`: > Error muted by safe_call: (treesit--font-lock-mark-ranges-to-fontify > ((1 . 940)) #) signaled > (wrong-type-argument treesit-node-p javascript) Error during > redisplay: (jit-lock-function 1) signaled (wrong-type-argument > treesit-node-p javascript) And in `syntax-propertize-function`, for example in `ruby-ts-mode`, > QuitError muted by safe_call: (internal--syntax-propertize 46) > signaled (wrong-type-argument treesit-node-p ruby) In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2024-06-30 built on nverno-XPS-8940 Repository revision: 7c8d4e96ba6db19bdca20a87bafed024a84eb517 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.4 LTS Configured using: 'configure --prefix=/usr/local --with-modules --with-tree-sitter --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls --with-json --with-mailutils --with-jpeg --with-png --with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 CXX=gcc-12' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ IMAGEMAGICK JPEG LCMS2 LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: JavaScript Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cl-seq typescript-ts-mode js c-ts-common json subr-x map byte-opt gv bytecomp byte-compile imenu cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs treesit cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads xwidget-internal dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 104084 13132) (symbols 48 8580 0) (strings 32 24764 2578) (string-bytes 1 884578) (vectors 16 14855) (vector-slots 8 188214 9981) (floats 8 28 203) (intervals 56 852 0) (buffers 992 12)) --000000000000db49db061c211839 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

I just noticed this after building latest Emacs. In`treesit-update-ranges`, during redisplay, the first argument to
`trees= it-query-range` is a tree-sitter language symbol, not a node.

At tre= esit.el:760

=C2=A0 =C2=A0 (let* ((host-lang (treesit-query-language = query))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(parser (treesit-parser= -create language))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(old-ranges = (treesit-parser-included-ranges parser))
>>> host-lang isnt a n= ode
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(new-ranges (treesit-query-= range
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 host-lang query beg end offset))


This causes a= an error in modes that have set `treesit-range-settings`
eg., `js-ts-mo= de`:

> Error muted by safe_call: (treesit--font-lock-mark-ranges= -to-fontify
> ((1 . 940)) #<treesit-parser for javascript>) sig= naled
> (wrong-type-argument treesit-node-p javascript) Error during<= br>> redisplay: (jit-lock-function 1) signaled (wrong-type-argument
&= gt; treesit-node-p javascript)


And in `syntax-propertize-functio= n`, for example in `ruby-ts-mode`,

> QuitError muted by safe_call= : (internal--syntax-propertize 46)
> signaled (wrong-type-argument tr= eesit-node-p ruby)



In GNU Emacs 31.0.50 (build 1, x86_64-pc= -linux-gnu, GTK+ Version
=C2=A03.24.33, cairo version 1.16.0) of 2024-06= -30 built on nverno-XPS-8940
Repository revision: 7c8d4e96ba6db19bdca20a= 87bafed024a84eb517
Repository branch: master
Windowing system distrib= utor 'The X.Org Foundation', version 11.0.12101004
System Descri= ption: Ubuntu 22.04.4 LTS

Configured using:
=C2=A0'configure = --prefix=3D/usr/local --with-modules --with-tree-sitter
=C2=A0--with-thr= eads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls
=C2=A0--with-= json --with-mailutils --with-jpeg --with-png --with-rsvg
=C2=A0--with-ti= ff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12
=C2=A0CXX=3Dgcc= -12'

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GN= UTLS GPM GSETTINGS HARFBUZZ
IMAGEMAGICK JPEG LCMS2 LIBSELINUX LIBXML2 MO= DULES NATIVE_COMP NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 = THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 X= PM XWIDGETS
GTK3 ZLIB

Important settings:
=C2=A0 value of $LAN= G: en_US.UTF-8
=C2=A0 value of $XMODIFIERS: @im=3Dibus
=C2=A0 locale-= coding-system: utf-8-unix

Major mode: JavaScript

Minor modes = in effect:
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2= =A0 show-paren-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wh= eel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0= file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font= -lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 minibuffer-regexp-mo= de: t
=C2=A0 line-number-mode: t
=C2=A0 indent-tabs-mode: t
=C2=A0= transient-mark-mode: t
=C2=A0 auto-composition-mode: t
=C2=A0 auto-e= ncryption-mode: t
=C2=A0 auto-compression-mode: t

Load-path shado= ws:
None found.

Features:
(shadow sort mail-extr emacsbug mess= age mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec pass= word-cache epa derived epg rfc6068
epg-config gnus-util text-property-se= arch time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbr= ev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail= -prsvr mail-utils cl-seq
typescript-ts-mode js c-ts-common json subr-x m= ap byte-opt gv bytecomp
byte-compile imenu cc-mode cc-fonts cc-guess cc-= menus cc-cmds cc-styles
cc-align cc-engine cc-vars cc-defs treesit cl-lo= addefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify= ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win<= br>term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt=
fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode<= br>register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select=
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colorsframe minibuffer nadvice seq simple cl-generic indonesian philippine
ch= am georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
ko= rean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
europe= an ethiopic indian cyrillic chinese composite emoji-zwj charscript
charp= rop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-pr= eloaded button loaddefs theme-loaddefs faces cus-face macroexp
files win= dow text-properties overlay sha1 md5 base64 format env
code-pages mule c= ustom widget keymap hashtable-print-readable backquote
threads xwidget-i= nternal dbusbind inotify lcms2 dynamic-setting
system-font-setting font-= render-setting cairo gtk x-toolkit xinput2 x
multi-tty move-toolbar make= -network-process native-compile emacs)

Memory information:
((cons= es 16 104084 13132) (symbols 48 8580 0) (strings 32 24764 2578)
=C2=A0(s= tring-bytes 1 884578) (vectors 16 14855)
=C2=A0(vector-slots 8 188214 99= 81) (floats 8 28 203) (intervals 56 852 0)
=C2=A0(buffers 992 12))
--000000000000db49db061c211839-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 16:37:20 2024 Received: (at submit) by debbugs.gnu.org; 30 Jun 2024 20:37:20 +0000 Received: from localhost ([127.0.0.1]:59257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sO1IW-0004lI-3o for submit@debbugs.gnu.org; Sun, 30 Jun 2024 16:37:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:58416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sO1IU-0004lB-MB for submit@debbugs.gnu.org; Sun, 30 Jun 2024 16:37:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sO1IU-0006Oa-8r for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 16:37:18 -0400 Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sO1IS-00018y-Tc for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 16:37:18 -0400 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-25cba5eea69so1121062fac.2 for ; Sun, 30 Jun 2024 13:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719779835; x=1720384635; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=KKDWHy2YaDSFFS0jN2LU3BiDtW2BAJtcKkQxhrCw4Z4=; b=i0MIG8OV5kwZH7U8NpaEjuYzQnxwx9aljwPzMv4gtEechen0UXq9HEvz4BCEVYG+sb IU0Gdb6sRFoAUGWwnHn8wYlkwACZwcBJ+ga08k1DhV660Zubh8b3ulQ37mAI+v+wWlvv lriOxFpkfxPSaO7qneJFL1cZdHhVjZhbpJoSGOo+zO/SgMwLvPwayN9S17m8mqe8lYJI i4NVs95XHQEZJ87Fz//zhsij9oiu8pz/3n0q8yYJtPjCMyTghtX28HNz5QBAo3+vGhIt 9n2cX3+k42DW6CjiGY+ovLkZEZsUSE4QzysLPNc4PReO5/nwNZoLSJ8uBMrW88Q7MWHp 2aGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719779835; x=1720384635; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KKDWHy2YaDSFFS0jN2LU3BiDtW2BAJtcKkQxhrCw4Z4=; b=VanFwrKhnSIEo5Mw79Qn843IEC1iKAHEzoiRRLsgOO3DasOdrUTKIVrTCSfLm4v8gY fiMRSGikzplR2WHRdsXoaGLMcapqXnGkq7Y6vEYFnpLtzGrbQW1nyY42+EZMh6QijAl8 q0YYozKNIGaQKS0KSq7x6zTJM6p+M2BF+ytBUxteAK5zGTIPBkKgekOeKBXQPGa5UAbE 0xEHf57/V/V8v+KE/txcmtawIlwTCnEcPgrTUrYAF1/+FCD24QVO+Q9wYhjkYAkEY+/e L8pl1KPGJ6FuaJfw/wNZo5wRu3McCkW3lE/eunlIUptJkgKMEHjURqskq75Yq/iozg6J vSSQ== X-Gm-Message-State: AOJu0YzX+vV0F8wX/71EjLX8nkZyDONULnzW1rbrlfLiO/gPJGXxoubP RbRdnGHxPI0mS5to6+KjOa4Kw9maTVGORkAhiwqrhxJsOMsfcZ4vhOcQa/uhEWe3JJmi+gTsDIS +z0YSnWew3e/w4JUjmpHkIauHnNie1z/Tcz0yPJlK X-Google-Smtp-Source: AGHT+IFNH9lfT0gq0YJDuVBOAVFb31FLzXcgeFtbpvGFcHXXpKanBG5Es195PiZWgn+YJ4Nq2cPneEmhi3nj+XiNUIY= X-Received: by 2002:a05:6870:d24e:b0:254:b8f5:c918 with SMTP id 586e51a60fabf-25db35db24fmr3465445fac.47.1719779835547; Sun, 30 Jun 2024 13:37:15 -0700 (PDT) MIME-Version: 1.0 From: Noah Peart Date: Sun, 30 Jun 2024 16:37:05 -0400 Message-ID: Subject: bug#71863: 31.0.50; Wrong argument type for treesit-query-range in treesit-update-ranges To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000309afc061c217251" Received-SPF: pass client-ip=2001:4860:4864:20::31; envelope-from=noah.v.peart@gmail.com; helo=mail-oa1-x31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000309afc061c217251 Content-Type: text/plain; charset="UTF-8" This is related to the new node check from commit 8819e5a45d5, not the functions I mentioned before! --000000000000309afc061c217251 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
<= div id=3D"gmail-:p8" class=3D"gmail-a3s gmail-aiL" style=3D"direction:initi= al;font-variant-numeric:normal;font-variant-east-asian:normal;font-variant-= alternates:normal;font-kerning:auto;font-feature-settings:normal;font-stret= ch:normal;font-size:small;line-height:1.5;font-family:Arial,Helvetica,sans-= serif;overflow:auto hidden">
This is related to the new nod= e check from commit=C2=A08819e5a45d5, not
the functions I mentioned bef= ore!
--000000000000309afc061c217251-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 04:38:33 2024 Received: (at 71863) by debbugs.gnu.org; 6 Jul 2024 08:38:33 +0000 Received: from localhost ([127.0.0.1]:45561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ0w4-00072p-7T for submit@debbugs.gnu.org; Sat, 06 Jul 2024 04:38:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ0w2-00072Z-2V for 71863@debbugs.gnu.org; Sat, 06 Jul 2024 04:38:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ0vt-00027a-8H; Sat, 06 Jul 2024 04:38:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vhJhnzcDW8E/Yfi55ANQ6d8nbEapsG12/MA7OURYADs=; b=QLc2ABrS5dFb w58vUKbMPsS05/4q01uLX/CfgE7hf4R0iOHoU/dVkK8k7tKYYsaiziT5VXCpx4e0ukppGnJ96Up56 XuT4o3ckf0Tt8r+wFkJOGwFOf7V6cKRbUqSgzaaOGv1hC2IB3lWUndHeUwbLYev0OmVFCwpWHTats Ts6A6K+tjJe5P0ubLfORPH5nRZjM2TzZawvIj9QpV+OucntUPx/W/iT7YAoQdSQ4CACi4N7JB0cFL badzp86vr6+PEVX/ovVDceeDQ4F0z+8I+Vl/AgUxNd86ry3FIHv9KSYfwoR3L/qzaPxEn2xTrsh/g t+KphPCtIafEsOBZT2oNcA==; Date: Sat, 06 Jul 2024 11:38:12 +0300 Message-Id: <86y16e530r.fsf@gnu.org> From: Eli Zaretskii To: Noah Peart , Yuan Fu In-Reply-To: (message from Noah Peart on Sun, 30 Jun 2024 16:12:06 -0400) Subject: Re: bug#71863: 31.0.50; Wrong argument type for treesit-query-range in treesit-update-ranges References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71863 Cc: 71863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noah Peart > Date: Sun, 30 Jun 2024 16:12:06 -0400 > > I just noticed this after building latest Emacs. In > `treesit-update-ranges`, during redisplay, the first argument to > `treesit-query-range` is a tree-sitter language symbol, not a node. > > At treesit.el:760 > > (let* ((host-lang (treesit-query-language query)) > (parser (treesit-parser-create language)) > (old-ranges (treesit-parser-included-ranges parser)) > >>> host-lang isnt a node > (new-ranges (treesit-query-range > host-lang query beg end offset)) > > This causes a an error in modes that have set `treesit-range-settings` > eg., `js-ts-mode`: > > > Error muted by safe_call: (treesit--font-lock-mark-ranges-to-fontify > > ((1 . 940)) #) signaled > > (wrong-type-argument treesit-node-p javascript) Error during > > redisplay: (jit-lock-function 1) signaled (wrong-type-argument > > treesit-node-p javascript) > > And in `syntax-propertize-function`, for example in `ruby-ts-mode`, > > > QuitError muted by safe_call: (internal--syntax-propertize 46) > > signaled (wrong-type-argument treesit-node-p ruby) Yuan, could you please look into this issue? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 16:51:34 2024 Received: (at 71863) by debbugs.gnu.org; 6 Jul 2024 20:51:34 +0000 Received: from localhost ([127.0.0.1]:46821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQCNa-0003yL-Cw for submit@debbugs.gnu.org; Sat, 06 Jul 2024 16:51:34 -0400 Received: from mail-oi1-f176.google.com ([209.85.167.176]:60699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQCNY-0003y8-Cf for 71863@debbugs.gnu.org; Sat, 06 Jul 2024 16:51:32 -0400 Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3d92aa0ade0so116290b6e.1 for <71863@debbugs.gnu.org>; Sat, 06 Jul 2024 13:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720299023; x=1720903823; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+K8QEcHGcVlYeVS0NFge06iGibBwpKnH9V93Ptt2mFw=; b=moWleIjzsgQtEkM1LYnAIsurX4vgw6ieSXzZLx0Efy/i2fcnKz7pptauisjUFkTqIq 79UdC+jDQU+ievAybbfajtFf9gC4+a+GvJw9QtSQdhGr1jM/+gG224OQYDipk1BQsTzz uYcmBJHmUirC6KXSClUhnRuAKOwT89/GLZu8gTxe7EwrKh/jNUxOeNFGwqSaUGMCP6iu a68rJjRbX5r7l1MHKjyKcEQMXHbk744OEtBko28XhAKiKN4A/Ix2v9rnl9NjysX6fNEE jh+Hu0CaaDvGxNRwxJ2tmT1OdAL1hyGYTYC/sfYEM7YizigINoDAvauSIO8mk04JvTcn AQtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720299023; x=1720903823; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+K8QEcHGcVlYeVS0NFge06iGibBwpKnH9V93Ptt2mFw=; b=EJJSCW1z93t9vPyKVwRPqeSIPt15hDAQ9JTfwlNvCgATVwUaM7YNSf3Ry/iUueH+Un e7b+RLRUrwBfja27Bf5pInyLwnHnsf8m6e+ahE4+Y6ciRc7qTLmBFUf3WAHt9O6yNO1L 2LlcUeNCTRKUVlKoP8pdQ0aH+trOSJCNmJd5IRJ9ELLWO5Chk1es8WoUbZrDBEenRRUP Fh9p0tIiG3MMhpcHU0JtrW9RXyWl4jRnvwVtiV9k+RI2k1y0tTFq581j0ys/E7X5wfeq SLWENnM962z9nc9ZP3MvHNMgPliIkZi8pIqDIHS4TBSmPTEesECs46ywgsOt5wOFaf0+ xZ/A== X-Forwarded-Encrypted: i=1; AJvYcCVXQ+f5Ufyg6fJFzZloFZbiofk8aJ7GIhmK8ivJfHEpC8jiFE7iWrEjEYXRCWxw8+BmBaEgLjwXAeaALGXQpO46kZ2S/oI= X-Gm-Message-State: AOJu0Yy3WR1qUwwx6TDaX90KD1tRfM32qYtLZBX5g93aoNqzO1h2ZGVC jwlZ+yqj7JhYvzn7i/H4DaxWViNriopLYuthbjmSfZ4F2+mHmYlL X-Google-Smtp-Source: AGHT+IE22ikVaDjVrnoBdRNKTEe8XVFMUu9+Wz3ZFQT9ueszx/30TdyG0CWN2PUdy+z8xbAuDtwDhg== X-Received: by 2002:a05:6808:211c:b0:3d9:20c3:cd99 with SMTP id 5614622812f47-3d920c3d1f2mr6019196b6e.5.1720299022882; Sat, 06 Jul 2024 13:50:22 -0700 (PDT) Received: from smtpclient.apple ([2601:646:8f81:6120:84a4:5f24:8a3e:a909]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70801e63abcsm16161571b3a.2.2024.07.06.13.50.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Jul 2024 13:50:22 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: bug#71863: 31.0.50; Wrong argument type for treesit-query-range in treesit-update-ranges From: Yuan Fu In-Reply-To: <86y16e530r.fsf@gnu.org> Date: Sat, 6 Jul 2024 13:50:10 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86y16e530r.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3774.600.62) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71863 Cc: Noah Peart , 71863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jul 6, 2024, at 1:38=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: Noah Peart >> Date: Sun, 30 Jun 2024 16:12:06 -0400 >>=20 >> I just noticed this after building latest Emacs. In >> `treesit-update-ranges`, during redisplay, the first argument to >> `treesit-query-range` is a tree-sitter language symbol, not a node. >>=20 >> At treesit.el:760 >>=20 >> (let* ((host-lang (treesit-query-language query)) >> (parser (treesit-parser-create language)) >> (old-ranges (treesit-parser-included-ranges parser)) >>>>> host-lang isnt a node >> (new-ranges (treesit-query-range >> host-lang query beg end offset)) >>=20 >> This causes a an error in modes that have set = `treesit-range-settings` >> eg., `js-ts-mode`: >>=20 >>> Error muted by safe_call: (treesit--font-lock-mark-ranges-to-fontify >>> ((1 . 940)) #) signaled >>> (wrong-type-argument treesit-node-p javascript) Error during >>> redisplay: (jit-lock-function 1) signaled (wrong-type-argument >>> treesit-node-p javascript) >>=20 >> And in `syntax-propertize-function`, for example in `ruby-ts-mode`, >>=20 >>> QuitError muted by safe_call: (internal--syntax-propertize 46) >>> signaled (wrong-type-argument treesit-node-p ruby)=20 >=20 > Yuan, could you please look into this issue? This is a bug I introduced on emacs-30 and later fixed. So once emacs-30 = is merged into master the issue should go away. Sorry for the trouble = :-( Yuan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 07 01:37:46 2024 Received: (at 71863) by debbugs.gnu.org; 7 Jul 2024 05:37:46 +0000 Received: from localhost ([127.0.0.1]:47088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQKan-0000Vk-Sk for submit@debbugs.gnu.org; Sun, 07 Jul 2024 01:37:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQKam-0000VZ-DU for 71863@debbugs.gnu.org; Sun, 07 Jul 2024 01:37:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQKYV-0004w9-Iz; Sun, 07 Jul 2024 01:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YBS2lE0o9/fnUS8m1WcX0rV+M8HsBQObmF4Gd36KCgA=; b=JvTCxcV5Z2z1BhQCAK/+ dtdrmMM0eVb50zU0eFqK38HEaX6HZ7ULbXNLgnXk78iAstgsyBPFx2mG6zezQjHVWXhskKLD/QWkl FMnAIg4HEjc6umrazJRxU+GMhycQ/TvGLswCDZhEl1uIMJBmxFd20fsKmwtzc3pBdRDphYvvqlYAb pV/dF/ZuqKzltTVWR8AjXf1P5ZU6/BA9oV+6BBEQz88Hlxg0oeFiN4CDuxKuoEvPOb/n0C1gHTD24 5EspsIg6HRQeFZ/0mUJhFFg6pXg4mDi3NTrou8eAGiCwW/CNv01lUvTEQQjPpUKlNvQmGFF03PDCx rdnNrOTIuvt8JA==; Date: Sun, 07 Jul 2024 08:35:21 +0300 Message-Id: <86ikxh3gti.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Sat, 6 Jul 2024 13:50:10 -0700) Subject: Re: bug#71863: 31.0.50; Wrong argument type for treesit-query-range in treesit-update-ranges References: <86y16e530r.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71863 Cc: noah.v.peart@gmail.com, 71863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sat, 6 Jul 2024 13:50:10 -0700 > Cc: Noah Peart , > 71863@debbugs.gnu.org > > > > > On Jul 6, 2024, at 1:38 AM, Eli Zaretskii wrote: > > > >> From: Noah Peart > >> Date: Sun, 30 Jun 2024 16:12:06 -0400 > >> > >> I just noticed this after building latest Emacs. In > >> `treesit-update-ranges`, during redisplay, the first argument to > >> `treesit-query-range` is a tree-sitter language symbol, not a node. > >> > >> At treesit.el:760 > >> > >> (let* ((host-lang (treesit-query-language query)) > >> (parser (treesit-parser-create language)) > >> (old-ranges (treesit-parser-included-ranges parser)) > >>>>> host-lang isnt a node > >> (new-ranges (treesit-query-range > >> host-lang query beg end offset)) > >> > >> This causes a an error in modes that have set `treesit-range-settings` > >> eg., `js-ts-mode`: > >> > >>> Error muted by safe_call: (treesit--font-lock-mark-ranges-to-fontify > >>> ((1 . 940)) #) signaled > >>> (wrong-type-argument treesit-node-p javascript) Error during > >>> redisplay: (jit-lock-function 1) signaled (wrong-type-argument > >>> treesit-node-p javascript) > >> > >> And in `syntax-propertize-function`, for example in `ruby-ts-mode`, > >> > >>> QuitError muted by safe_call: (internal--syntax-propertize 46) > >>> signaled (wrong-type-argument treesit-node-p ruby) > > > > Yuan, could you please look into this issue? > > This is a bug I introduced on emacs-30 and later fixed. So once emacs-30 is merged into master the issue should go away. Sorry for the trouble :-( When did you fix it on emacs-30? The merges to master happen very frequently lately; the last one was yesterday. Could it be that this is already fixed? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 15 02:19:36 2024 Received: (at 71863-done) by debbugs.gnu.org; 15 Jul 2024 06:19:36 +0000 Received: from localhost ([127.0.0.1]:58830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sTF3g-0006o9-5w for submit@debbugs.gnu.org; Mon, 15 Jul 2024 02:19:36 -0400 Received: from mail-pl1-f179.google.com ([209.85.214.179]:49251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sTF3e-0006o0-9z for 71863-done@debbugs.gnu.org; Mon, 15 Jul 2024 02:19:35 -0400 Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1fb05b0be01so27357345ad.2 for <71863-done@debbugs.gnu.org>; Sun, 14 Jul 2024 23:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721024311; x=1721629111; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JXLE3iukbD64gbNL4nDL4mbypf04YCKorSEYSFUObLo=; b=ejilgl3TutPSSl25M9gyWJVOcsKOXpX9fZnFETl26YQ1nTpbLsGXbB4xu8fziFBshZ H8l5JklaFkN2Wm6Kf08CmTNM5goTs8zE6Vhi9nbV6mdMzgpsWDFWfyrP1wMJ8VM1v6/7 BAby34IP73xapUvob3LvC5JsC/BHZlHhP0T3PN2YKRKMT+R2dDHXttzti7J6xKMRjI2U 7VeXLxTZkYFKr5nShi6u1fq/SRJ3dl/yLYTqn34C5ifX4HQPAjLRDbz5XDeCVEow9C0Z qXK3Th63BZRl7nopf1od1uOGXWw8fyvXWnJIrTuk+MJz1aXFDzj4AssToeZmHTX3+mJr hTjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721024311; x=1721629111; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JXLE3iukbD64gbNL4nDL4mbypf04YCKorSEYSFUObLo=; b=pkOPJ/Fa5FFsi9pR64os8VIvntQQvCd4bm6sHYiX3P5HIWRwlkcEgk7ZpuZlYmv+xF DkGeoSNFhAnaLwWZrpGuK84e5FAsehlf9n6jvf4xbAkOl85QtWOS9h5oZTbQGTPXUbut qmLG2cWFRRlQXgghwjxxWZEhVlJffKNv/NDWdMec8HIDYw9Z/r6IV9PDAiBs1EiLqhUi b8Z7lBycEOhw356n7PDo9XLu70nJCaz/Mz2vTKkXQSntn671gysbup62ziI9BPzPjOvb FhMZ43SSxFJdddrrAdBS2/7n2IaLRv+GZNF4SBr+zbyq2Dt+qAa+ES1SWrVHXgkv847T tWow== X-Forwarded-Encrypted: i=1; AJvYcCVzaHkzWPXZYysiDrnp3ODOTsMDEEserBJF6JWtoiy6sRp7la/Ap09u+vbmH5c3eqSedDkx35eXuWNLzIV08ZNr3kp4Ald0646wsg== X-Gm-Message-State: AOJu0YzgMd4A75jokBu9OS4YCd5FJJn81fWqIK6LeKZfhPZLD1Qg3Ndi akSRk3xWqxVE5a+Qvl7bN+vOZdNwH1Q8AYkn/221pEi0Q0U2BNlc X-Google-Smtp-Source: AGHT+IEPl75Cn3g3UKsZ9hg7bl1xc1ZXgyvtxeDKtrcbbMIjpY3XLP+hE91V7suQXuGXzZs0UgUO8w== X-Received: by 2002:a17:903:984:b0:1f8:6bae:28f with SMTP id d9443c01a7336-1fbb6d2ac8amr165923785ad.9.1721024311171; Sun, 14 Jul 2024 23:18:31 -0700 (PDT) Received: from smtpclient.apple ([2601:646:8f81:6120:c931:36dd:b6ff:8bfc]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bc285c5sm32584555ad.132.2024.07.14.23.18.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jul 2024 23:18:30 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: bug#71863: 31.0.50; Wrong argument type for treesit-query-range in treesit-update-ranges From: Yuan Fu In-Reply-To: <86ikxh3gti.fsf@gnu.org> Date: Sun, 14 Jul 2024 23:18:18 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86y16e530r.fsf@gnu.org> <86ikxh3gti.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3774.600.62) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71863-done Cc: Noah Peart , 71863-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jul 6, 2024, at 10:35=E2=80=AFPM, Eli Zaretskii = wrote: >=20 >> From: Yuan Fu >> Date: Sat, 6 Jul 2024 13:50:10 -0700 >> Cc: Noah Peart , >> 71863@debbugs.gnu.org >>=20 >>=20 >>=20 >>> On Jul 6, 2024, at 1:38=E2=80=AFAM, Eli Zaretskii = wrote: >>>=20 >>>> From: Noah Peart >>>> Date: Sun, 30 Jun 2024 16:12:06 -0400 >>>>=20 >>>> I just noticed this after building latest Emacs. In >>>> `treesit-update-ranges`, during redisplay, the first argument to >>>> `treesit-query-range` is a tree-sitter language symbol, not a node. >>>>=20 >>>> At treesit.el:760 >>>>=20 >>>> (let* ((host-lang (treesit-query-language query)) >>>> (parser (treesit-parser-create language)) >>>> (old-ranges (treesit-parser-included-ranges parser)) >>>>>>> host-lang isnt a node >>>> (new-ranges (treesit-query-range >>>> host-lang query beg end offset)) >>>>=20 >>>> This causes a an error in modes that have set = `treesit-range-settings` >>>> eg., `js-ts-mode`: >>>>=20 >>>>> Error muted by safe_call: = (treesit--font-lock-mark-ranges-to-fontify >>>>> ((1 . 940)) #) signaled >>>>> (wrong-type-argument treesit-node-p javascript) Error during >>>>> redisplay: (jit-lock-function 1) signaled (wrong-type-argument >>>>> treesit-node-p javascript) >>>>=20 >>>> And in `syntax-propertize-function`, for example in `ruby-ts-mode`, >>>>=20 >>>>> QuitError muted by safe_call: (internal--syntax-propertize 46) >>>>> signaled (wrong-type-argument treesit-node-p ruby)=20 >>>=20 >>> Yuan, could you please look into this issue? >>=20 >> This is a bug I introduced on emacs-30 and later fixed. So once = emacs-30 is merged into master the issue should go away. Sorry for the = trouble :-( >=20 > When did you fix it on emacs-30? The merges to master happen very > frequently lately; the last one was yesterday. Could it be that this > is already fixed? I checked with master (with php-ts-mode) and it=E2=80=99s working fine. = So I=E2=80=99m closing this report. Fell free to reopen if there=E2=80=99r= e problems. Yuan= From unknown Sat Jun 14 18:49:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 12 Aug 2024 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator