GNU bug report logs - #71850
[PATCH] macOS (Cocoa) alpha-background

Previous Next

To reply to this bug, email your comments to 71850 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] macOS (Cocoa) alpha-background
Date: Sat, 29 Jun 2024 22:09:18 -0700

[Message part 1 (text/plain, inline)]

Severity: wishlist

-------------------- Start of forwarded message --------------------
From: Jon Rubens <jonathan.rubens <at> gmail.com>
Date: Thu, 27 Jun 2024 17:38:29 -0700
Subject: Re: macOS (Cocoa) alpha-background
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Po Lu <luangruo <at> yahoo.com>, emacs-devel <at> gnu.org

[Message part 2 (text/plain, attachment)]

[0001-Add-alpha-background-feature-to-MacOS-Emacs.patch (text/x-patch, attachment)]

[Message part 4 (text/plain, attachment)]

Message #8 received at 71850 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: 71850 <at> debbugs.gnu.org
Subject: Re: macOS (Cocoa) alpha-background
Date: Thu, 20 Feb 2025 00:24:20 +0000

[Message part 1 (text/plain, inline)]

-------------------- Start of forwarded message --------------------
From: Jon Rubens <jonathan.rubens <at> gmail.com>
Date: Wed, 19 Feb 2025 09:53:42 -0800
Subject: Re: macOS (Cocoa) alpha-background
To: Alan Third <alan <at> idiocy.org>, Alexander Adolf
<alexander.adolf <at> condition-alpha.com>,
	Eli Zaretskii <eliz <at> gnu.org>, Rudolf Adamkovič <rudolf <at> adamkovic.org>,
	stefankangas <at> gmail.com, jonathanrubens <at> gmail.com, luangruo <at> yahoo.com,
	emacs-devel <at> gnu.org

[Message part 2 (text/plain, attachment)]

[0001-ns_alpha_background.patch (text/x-patch, attachment)]

[Message part 4 (text/plain, attachment)]

Message #11 received at 71850 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: 71850 <at> debbugs.gnu.org
Cc: jonathanrubens <at> gmail.com, alan <at> idiocy.org,
 alexander.adolf <at> condition-alpha.com, rudolf <at> adamkovic.org
Subject: Re: bug#71850: macOS (Cocoa) alpha-background
Date: Wed, 19 Feb 2025 16:29:21 -0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> The patch seeks to enable the alpha_background frame parameter for
> MacOS (and NS). Presently, that frame parameter does nothing on MacOS.
> Similar to the alpha frame parameter, this should enable transparency
> but not change the transparency of any text.

Could you please send some instructions for how to test the patch?
I'm looking for an easy-to-use recipe that would demonstrate the effect
before and after applying this patch.

Also, is there anything else you could add regarding the use case here?

Thanks in advance.

Message #14 received at 71850 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: jonathanrubens <at> gmail.com
Cc: rudolf <at> adamkovic.org, alan <at> idiocy.org, 71850 <at> debbugs.gnu.org,
 alexander.adolf <at> condition-alpha.com
Subject: Re: bug#71850: macOS (Cocoa) alpha-background
Date: Wed, 19 Feb 2025 19:57:53 -0600

Jon Rubens <jonathan.rubens <at> gmail.com> writes:

>> > The patch seeks to enable the alpha_background frame parameter for
>> > MacOS (and NS). Presently, that frame parameter does nothing on MacOS.
>> > Similar to the alpha frame parameter, this should enable transparency
>> > but not change the transparency of any text.
>
>> Could you please send some instructions for how to test the patch?
>> I'm looking for an easy-to-use recipe that would demonstrate the effect
>> before and after applying this patch.
>
> To test, run emacs with eval:
> emacs -Q --eval="(modify-all-frames-parameters '((alpha-background . 0.5)))"
> compare with changing "alpha" instead:
> emacs -Q --eval="(modify-all-frames-parameters '((alpha . 0.5)))"
> Notice that the text does not become transparent when alpha-background is used.
> Test with themes. Larger font size makes the effect more obvious.
>
>> Also, is there anything else you could add regarding the use case here?
> Emacs already has the alpha-background frame parameter. This patch
> enables the feature for MacOS to match X.

Thanks.  Your patch doesn't seem to apply cleanly against latest master:

patching file 'src/macfont.m'
patching file 'src/nsfns.m'
patching file 'src/nsfont.m'
1 out of 1 hunks failed--saving rejects to 'src/nsfont.m.rej'
patching file 'src/nsterm.m'
2 out of 14 hunks failed--saving rejects to 'src/nsterm.m.rej'

Could you please rebase on top of current master and resend the patch as
an attachment, created by:

    git format-patch -1

Please also add a ChangeLog entry for this change as per CONTRIBUTE, if
possible, and I think we need an entry in etc/NEWS.

Thanks in advance.

Message #17 received at 71850 <at> debbugs.gnu.org (full text, mbox):

From: Jon Rubens <jonathan.rubens <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: rudolf <at> adamkovic.org, alan <at> idiocy.org, 71850 <at> debbugs.gnu.org,
 alexander.adolf <at> condition-alpha.com
Subject: Re: bug#71850: macOS (Cocoa) alpha-background
Date: Wed, 19 Feb 2025 16:39:15 -0800

> > The patch seeks to enable the alpha_background frame parameter for
> > MacOS (and NS). Presently, that frame parameter does nothing on MacOS.
> > Similar to the alpha frame parameter, this should enable transparency
> > but not change the transparency of any text.

> Could you please send some instructions for how to test the patch?
> I'm looking for an easy-to-use recipe that would demonstrate the effect
> before and after applying this patch.

To test, run emacs with eval:
emacs -Q --eval="(modify-all-frames-parameters '((alpha-background . 0.5)))"
compare with changing "alpha" instead:
emacs -Q --eval="(modify-all-frames-parameters '((alpha . 0.5)))"
Notice that the text does not become transparent when alpha-background is used.
Test with themes. Larger font size makes the effect more obvious.

> Also, is there anything else you could add regarding the use case here?
Emacs already has the alpha-background frame parameter. This patch
enables the feature for MacOS to match X.

-- 
Jon

Message #22 received at 71850 <at> debbugs.gnu.org (full text, mbox):

From: Jon Rubens <jonathan.rubens <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: rudolf <at> adamkovic.org, alan <at> idiocy.org, 71850 <at> debbugs.gnu.org,
 alexander.adolf <at> condition-alpha.com
Subject: Re: bug#71850: macOS (Cocoa) alpha-background
Date: Tue, 27 May 2025 09:19:30 -0700

[Message part 1 (text/plain, inline)]

> Could you please rebase on top of current master

> Please also add a ChangeLog entry for this change as per CONTRIBUTE, if
> possible, and I think we need an entry in etc/NEWS.

I updated the patch with a etc/NEWS entry and verified it applies
cleanly on the master branch.

[0001-Add-alpha_background-feature-for-NS-MacOS.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.