From unknown Fri Aug 08 22:15:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive Resent-From: Matthew Bauer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2024 22:33:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 71844@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171970034414195 (code B ref -1); Sat, 29 Jun 2024 22:33:04 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jun 2024 22:32:24 +0000 Received: from localhost ([127.0.0.1]:53990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNgcJ-0003gm-Lv for submit@debbugs.gnu.org; Sat, 29 Jun 2024 18:32:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:56570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNgcD-0003ef-Fa for submit@debbugs.gnu.org; Sat, 29 Jun 2024 18:32:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNeAI-0007Pn-UC for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 15:55:19 -0400 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNeAE-0000mf-Br for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2024 15:55:16 -0400 Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7f3c5af0a04so88700839f.0 for ; Sat, 29 Jun 2024 12:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719690912; x=1720295712; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=TEK/P1XekNqLmUvkxygoy2IRKRrwnidLW2Q48gR0svA=; b=lb8xbsymMo4NEvlx5sYRSg8myd/Lg3zqrEEjeQAOlmByVA6iJFnjSHNiEjkmcRoAvM 5YST4WDU5S7rxtzK9JCmJqnvs3+idNrTXs1ATY6kSBIqsMSbpKC744IksB/LoRZdsoGl X0L6UcvpC3jUFg9zH8SGXzFzE5LPJBmwVQL+WcG6xWO44IFgMIA0LgiaTY/rk0WKqJWV tB/G6L9KDN4Eu0oo0bd9lqEwQZfmfoSadf8TIpPnLk/5/cnI0qEkM0+elGHHOipMSG1C JJzY2G0pyc0fk6Rxu6Go21L52OFCo6qcPqngmOfYlOwtfnkVqLYW/uJfstusArcX2LOB wkvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719690912; x=1720295712; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TEK/P1XekNqLmUvkxygoy2IRKRrwnidLW2Q48gR0svA=; b=eyRG0L9dgFkUfK9GuGiiU3p3Ecpwo2GtRYRqpXkbG5GJukTEfJ0G8LXpXwuWIcd0GY Tb5XToBVY+KeZtLLmHwLsgKtOg63PriahyIATkKo8Pk0Wd1ZvCrvhumh3UJ3SzPAjyrm oNzTk+S77A/Dxz/iqxbyVPYLaLJa00u0lDXj4+B3rcC4OWa71qk5EumfjVOCVr25HPQu NoO0OtU+MRF0QV8ATmNmufsTtxYhFXXDtX+9fPYf/3K1xad7tfh2eGsBu1Pu70sqZXS2 rVkgSZ2KCMLfWFs+1PZsiD9B0CY+yPxKL3znc89H4pvhnhHIV0I1jNzv4YX1W1YtRJob ZDrA== X-Gm-Message-State: AOJu0YzIKQ91Dx3b1Y9uQekoaT3B4GZbx/pmxRsfqKBEVp+HM9+qwgOa H4L70GS+IUbqEV5sTlViSRQqtA0WZ9cBR3J33LRiCh6v017kdefNSOx/KQ== X-Google-Smtp-Source: AGHT+IG5G5LGsqCmYA68uhVnfpJYzjTapGu3iaK4Xsmqq4F7dKJZzRhb9n3Z1fuv68mI5I5R+h/ikQ== X-Received: by 2002:a5d:8450:0:b0:7eb:7089:dfe4 with SMTP id ca18e2360f4ac-7f62ee74b4emr179520439f.15.1719690911863; Sat, 29 Jun 2024 12:55:11 -0700 (PDT) Received: from Matthews-MacBook-Pro.local ([2605:a601:acd7:b300:19a2:be01:2170:228b]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4bb73bb38a3sm1217185173.6.2024.06.29.12.55.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jun 2024 12:55:11 -0700 (PDT) From: Matthew Bauer Date: Sat, 29 Jun 2024 14:55:05 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::d29; envelope-from=mjbauer95@gmail.com; helo=mail-io1-xd29.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I believe this regex for cucumber is not precise enough. Specifically, it was picking up this indentation in an error message from GHC: Main.hs:195:1: error: [GHC-44432] The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanying= binding Suggested fix: Perhaps use one of these: =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1), =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1) It picked up this as being error messages which I believe it shouldn=E2=80= =99t have: =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 This change just ignores it if there is remaining space. Probably it still needs to be refined, but this at least avoids this false positive for me. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-Try-to-limit-false-positives-for-cucumber-compilatio.patch Content-Transfer-Encoding: quoted-printable Content-Description: Fix "cucumber" regexp >From 3a5e45ec2d836a38348e802c441d567e070b138c Mon Sep 17 00:00:00 2001 From: Matthew Bauer Date: Sat, 29 Jun 2024 14:45:35 -0500 Subject: [PATCH] Try to limit false positives for cucumber compilation MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit I believe this regex for cucumber is not precise enough. Specifically, it was picking up this indentation in an error message from GHC: Main.hs:195:1: error: [GHC-44432] The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanying= binding Suggested fix: Perhaps use one of these: =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1), =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1) It picked up this as being error messages which I believe it shouldn=E2=80= =99t have: =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 This change just ignores it if there is remaining space. Probably it still needs to be refined, but this at least avoids this false positive for me. --- lisp/progmodes/compile.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 2e4eb11811a..a03f1935971 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -473,7 +473,7 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1)) " ")) "#") " " - (group (not "(") (* nonl)) ; file + (group (not (in "( ")) (* nonl)) ; file ":" (group (in "1-9") (* (in "0-9")))) ; line 1 2) --=20 2.39.3 (Apple Git-146) --=-=-=-- From unknown Fri Aug 08 22:15:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2024 05:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Matthew Bauer Cc: 71844@debbugs.gnu.org Received: via spool by 71844-submit@debbugs.gnu.org id=B71844.171972397110475 (code B ref 71844); Sun, 30 Jun 2024 05:07:01 +0000 Received: (at 71844) by debbugs.gnu.org; 30 Jun 2024 05:06:11 +0000 Received: from localhost ([127.0.0.1]:54414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNmlN-0002iq-M8 for submit@debbugs.gnu.org; Sun, 30 Jun 2024 01:06:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNmlI-0002iD-Hc for 71844@debbugs.gnu.org; Sun, 30 Jun 2024 01:06:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNmlC-0007eA-A6; Sun, 30 Jun 2024 01:05:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2BHEA7o28a0qofNWtBbHELqyjX+JXGMV0sd62GhSR3g=; b=hi5V3aZXT1DKpAH8iR2Z g5qkvDxSmZ8C8kP8EkQxsFch05eF8N9iCQyqXMuqBiAa20ymevLSC/pipdgXdRjkdsnQxftQxrMcf gTIMJueE1xgFlKERzFCij/xuJmv0NWU37CzgQvWzuXaUTYrqG6r12BgIGLx4VebAYtxJ1aQ1miKTV gvNufEAFPK7+2IDaL2SVMyy9NguSlsvv5BKqaeJmYOtoRT+iphBgA36QaOSMI4uwGCZ2cTRdWTSNW 8/yDqWGkEwKIWoKFRpcO0J9rEQY/3lZZyXWjJLe0ibkRYvwcrK1V+++n+ZhyD9VjKELE5cqvr9rOa X4V6wVknnkw3iQ==; Date: Sun, 30 Jun 2024 08:05:54 +0300 Message-Id: <8634ovhvf1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Matthew Bauer on Sat, 29 Jun 2024 14:55:05 -0500) References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Matthew Bauer > Date: Sat, 29 Jun 2024 14:55:05 -0500 > > I believe this regex for cucumber is not precise enough. Specifically, > it was picking up this indentation in an error message from GHC: > > Main.hs:195:1: error: [GHC-44432] > The type signature for ‘apathway’ lacks an accompanying binding > Suggested fix: > Perhaps use one of these: > ‘foo’ (Defined at Main.hs:196:1), > ‘foo’ (Defined at Main.hs:216:1) > > It picked up this as being error messages which I believe it shouldn’t have: > > ‘foo’ (Defined at Main.hs:216 > ‘foo’ (Defined at Main.hs:216 Why not? don't you want to be able to visit the definitions to examine whether they are the right fix? More generally, compilation-mode doesn't (yet) support the "fix suggestion" features offered by some of the modern compilers. IMO, we should address this kind of situations in a general framework of supporting fix suggestions, not just by ad-hoc changes in the regexps that recognize error messages. Patches welcome. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 11 14:34:06 2025 Received: (at control) by debbugs.gnu.org; 11 Feb 2025 19:34:06 +0000 Received: from localhost ([127.0.0.1]:58744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1thw1G-0007Ci-AK for submit@debbugs.gnu.org; Tue, 11 Feb 2025 14:34:06 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:49543) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1thw1E-0007Bg-DS for control@debbugs.gnu.org; Tue, 11 Feb 2025 14:34:04 -0500 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5de5a853090so7812976a12.3 for ; Tue, 11 Feb 2025 11:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739302438; x=1739907238; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=ukfGiskPKjyIETreEilN/aD74JlxY22EGRPWM39pWic=; b=kjtLFMIfyq7bj7ZIl1eNIv1ny0KSjqBZz1Z97pL4VYp+0/A5D0OL/0n9bpj3iTbKlt LpR7if/hgP1m6rEWqYdzVlYjsENyxfe1dW4EhO717LqqSr1sg2Ch5+yZcwsgT68CXb8f sB/gkNkHtQXK6U2QCRHRvxKkTgEBcl1e8+g+FxbUc45mC/L0fuktXs/icN4zC0WJ4+gV DatdB7UZvs+VfmEpNxI6fzXjDeJ3T4WQgpnQ0DyZZGGgfD0bCWqjE7WWo58Z4rFPjHuE kGNJopgqdzsr5eDSBdvcDj6ePM4/lENBkjtEhjmYHVIE6RLpx+5mLHnrcrPpz0d4Hbln +1zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739302438; x=1739907238; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ukfGiskPKjyIETreEilN/aD74JlxY22EGRPWM39pWic=; b=M1Sc1TcgAH1w/XOw9WZGzTfmWt5YnfCqyZ3mg1Ypi6dnVUVVgRjHdiwGMzbWRZTCPr LFLyvNU+HPvnFc9YZP0ro54xT/+EOqfbmUhk2xaljQ4oI3pVp4vajxBtXn7HInSSpGLb vAhUNsl2UgrY5AWckAL4krswLJyx/rGipoW7SqOIS4cnHxryuZ9HNC0lQ4nY3Loqpaq3 Ypcejz6Dzh0KR2r5wPELRZkscpYOw3sFm0Z7Elx9cKyiOqf6ux9Cio4bVqOXIx1KbrE4 oVwlIg3BMUec61RmNyXCeZNNH3RbOTEt0hiD4G2TeVLEkoBhN8k5o04NXHajcZ/C9UZ4 yuIQ== X-Gm-Message-State: AOJu0Ywbc3vm/VrP2MoXKzStgJmexLDJSLHuJy9EBcVYrl6M9cC6OyZH P8CjIo6prq9u+Tf6kI5qCNp5VbDuWoFN+5jL9aoPYNYQiCexQPG8n7BrSj0s9OXRsBM0eAoI76G O6p1I+3QGWmLs76mcRfVd6EOzy3IIYT/hv1QQVw== X-Gm-Gg: ASbGncvAPMbUQZb+UUlfpczzkFfgkRP98DJWwLaTg9MevMgh2NHscAC0FKNF3F8hmsj jFOiSs/XG3ZEk01I/W6fF67KVlo20Rz7TaqWQJZRtX/zyl2IQNNlNYG2igYWW2avitu61X+EtCQ == X-Google-Smtp-Source: AGHT+IEYlnyhc4/7MLJdAafmtIBWlGbbzgWIhr3pIIBJe6f6is7v93oMTLNEbnOVWny2HME9MUlXCNhMAY2nRXOIJdI= X-Received: by 2002:a05:6402:2084:b0:5de:a7db:3a7c with SMTP id 4fb4d7f45d1cf-5deaddba613mr423539a12.17.1739302438236; Tue, 11 Feb 2025 11:33:58 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 11:33:57 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 11 Feb 2025 11:33:57 -0800 X-Gm-Features: AWEUYZlxyEdAYSob4xa0HCKLRr5GQji4yimlhNalnkTPXSVQDCxBmxVmQ4kcI0M Message-ID: Subject: control message for bug #71844 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 71844 wishlist quit From unknown Fri Aug 08 22:15:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Mar 2025 02:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Matthew Bauer Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 71844@debbugs.gnu.org Received: via spool by 71844-submit@debbugs.gnu.org id=B71844.174105452128112 (code B ref 71844); Tue, 04 Mar 2025 02:16:02 +0000 Received: (at 71844) by debbugs.gnu.org; 4 Mar 2025 02:15:21 +0000 Received: from localhost ([127.0.0.1]:53489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpHoW-0007I4-HM for submit@debbugs.gnu.org; Mon, 03 Mar 2025 21:15:21 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:53494) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tpHoT-0006qY-Mk for 71844@debbugs.gnu.org; Mon, 03 Mar 2025 21:15:18 -0500 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5e57c81d5d0so1434653a12.2 for <71844@debbugs.gnu.org>; Mon, 03 Mar 2025 18:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741054511; x=1741659311; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=DMq/kFGo5dLPyo0hNKcxZh4eHYjWe3PGl95xUCb7Hpk=; b=eK70wRpiHqoh5IxEfP0Ln9/laTW7iDfPMy/YNJsWNW+Vc0WxP9HOeSX+oNeaPfshRg 7eh9xW/f/NObY6HfmULtkvTEyI4gjjR5NgcxmTHPV/o+OnS0J7FftG28AG1HoQeLYXzm f6WttbBPCmrn1812rfxR5S1uNkeC48u3E+7jANdsD2sQwMFQS+Hktapz4H17YIKYAn1b EEfSZDjzSn1vQkK1IpkFmD2XivK/xMEosfh1qBVAoIy63NHjfzwQa7kjQvZYSujYlPJw xtRqsJRhNEm/FMnl33ZEOai+/92GGYQD7xp+jWC2T5BU/X3SM5n8FoZW96o7qwbZZbAy XZ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741054511; x=1741659311; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DMq/kFGo5dLPyo0hNKcxZh4eHYjWe3PGl95xUCb7Hpk=; b=LwG6BoMIp06SR2FJuCikS8sYDHmeCyABvVShzJTsdl9bJFYoqNOuctvDfqw2DiYrOO J3sXvK1qFQFMsbh0O3QbVekrvdCzwYCs2YzigIK6eBk3sEF0P792vy+IuG/rcSVQvqDW xR/V7aWZnYvMzRYyKBbKEqNiJ8J0lc+CLIhres1MtoBcB8n2QflhalTyxnsfPXvjicLe OcjfGA55KqQRVciOT9Jp4SbyElBCcya9vbr01ZuqSqSJR+m0p7sQsgNGB0R5pYupki3+ O0V8PvGjwri3QQR8az7ybyajFpKN1ANCvRkwETsoV+ibrnTaLeAJx9rNtB27XHWbdIEi X3cA== X-Gm-Message-State: AOJu0YwTyiBLN04bhyaSXb/mr/8isChS+2+CUHdjR/apuhxClJ1D9G6r r0zYmYq5fgrSCoCSaVxQK83ACPnVE3nv6qZPtZaMp4LNVP5wKz/mPaDEfzkm6VK8T2V81+Rmm2E Zm7couwoMXoChonNwMYoYYSn2aDlACMG/F6s= X-Gm-Gg: ASbGncvRe+B013ZIGhRxxcc/ZkWF3p+je7hFA/YORVSnwAjxHTZDnrgWLToWALcRc6A DpPooJCDR1vCo7R/xGXdZyaFpOY7yGwHCoeVLhvdeD03EMRabGPm3DRAMT6phuqPa8oTfUNT27W 4P4w08V6E62w2M+WYoq8+uHCLbTg== X-Google-Smtp-Source: AGHT+IFG/JJky8jD7lzTQ0KACUV1DCi7ftYFw3MZwCjcHvsqLHJpi8JsIuGqzt9xZpKQNcc0Okz92QQJ3aucAh5iVMM= X-Received: by 2002:a05:6402:42c8:b0:5df:25e8:26d2 with SMTP id 4fb4d7f45d1cf-5e4d6ac58fdmr37504138a12.5.1741054510972; Mon, 03 Mar 2025 18:15:10 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 4 Mar 2025 02:15:10 +0000 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Tue, 4 Mar 2025 02:15:10 +0000 X-Gm-Features: AQ5f1JqpW4RA2Ulakv2txOVru_I2Z2AxyJc7KbXiHv4XucBAMxFBmyKK7mUjTYE Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matthew Bauer writes: > I believe this regex for cucumber is not precise enough. Specifically, > it was picking up this indentation in an error message from GHC: > > Main.hs:195:1: error: [GHC-44432] > The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanyi= ng binding > Suggested fix: > Perhaps use one of these: > =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1), > =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1) > > It picked up this as being error messages which I believe it shouldn=E2= =80=99t have: > > =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 > =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 > > This change just ignores it if there is remaining space. Probably it > still needs to be refined, but this at least avoids this false positive > for me. Mattias, maybe you have some comments on this one? >>>From 3a5e45ec2d836a38348e802c441d567e070b138c Mon Sep 17 00:00:00 2001 > From: Matthew Bauer > Date: Sat, 29 Jun 2024 14:45:35 -0500 > Subject: [PATCH] Try to limit false positives for cucumber compilation > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > I believe this regex for cucumber is not precise enough. Specifically, > it was picking up this indentation in an error message from GHC: > > Main.hs:195:1: error: [GHC-44432] > The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanyi= ng binding > Suggested fix: > Perhaps use one of these: > =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1), > =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1) > > It picked up this as being error messages which I believe it shouldn=E2= =80=99t have: > > =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 > =E2=80=98foo=E2=80=99 (Defined at Main.hs:216 > > This change just ignores it if there is remaining space. Probably it > still needs to be refined, but this at least avoids this false positive > for me. > --- > lisp/progmodes/compile.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index 2e4eb11811a..a03f1935971 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -473,7 +473,7 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1= )) > " ")) > "#") > " " > - (group (not "(") (* nonl)) ; file > + (group (not (in "( ")) (* nonl)) ; file > ":" > (group (in "1-9") (* (in "0-9")))) ; line > 1 2)