From unknown Sat Jun 21 10:40:03 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#71825] [PATCH] gnu: Fix virt-manager for systems with no GTK cursor. Resent-From: Karl Hallsby Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 Jun 2024 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71825 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71825@debbugs.gnu.org Cc: Karl Hallsby X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171959493416036 (code B ref -1); Fri, 28 Jun 2024 17:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jun 2024 17:15:34 +0000 Received: from localhost ([127.0.0.1]:46282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNFC9-0004AY-FZ for submit@debbugs.gnu.org; Fri, 28 Jun 2024 13:15:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:41948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNFC7-0004AR-W7 for submit@debbugs.gnu.org; Fri, 28 Jun 2024 13:15:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNFC7-0000ZG-Dn for guix-patches@gnu.org; Fri, 28 Jun 2024 13:15:31 -0400 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNFC5-0001EH-FW for guix-patches@gnu.org; Fri, 28 Jun 2024 13:15:31 -0400 Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7f3cd64e71cso24312339f.3 for ; Fri, 28 Jun 2024 10:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hallsby.com; s=google; t=1719594927; x=1720199727; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+g51LbAeUXJACA5+aETfakMLFS6/5OYMBzUwBoomrwk=; b=E9728msF5KT63dPYlEs4O7Bupz4HZ7/PQ+vikqoBTrs2k69V+wJCLVqmWWhrzl4Lg1 ooM2CpvmR1kj6q8OZRl6cLiLMRv+Amec6yAec/MUpjkOPcf0MTkzjfJlbyvFUj0kSIxF MXLvcBnfjM2oGS3Hjv5VThkSUWmhhy36wwkQ5iC8ML5ywsix+GkGijAfbCr1lP1NO7qf 0VhK3BBOmzm5xV6Y38SJgq1mnVIt48CqwHYA9sAZYEUWJe8JOK2MQIMxyD2LAlnm+I3s 6ZDrh4FH5fXUFOEEkyEglfZC3g2CPN3Bz3C+9iQkL7YSzWasuYFHGZVq/23rCSm65qP7 xvPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594927; x=1720199727; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+g51LbAeUXJACA5+aETfakMLFS6/5OYMBzUwBoomrwk=; b=oSZ8wKO5Af9T/IHVnMWUC4bMbi0fEChuB041Vca9RStjgWZjCuJTh+33Yk6loprfUt Qbv3bGt1/RV9VK28l7HB6tS8hjHkW6Pu1zAW7btFQxbnfkvuFHNnYJj+0TMTGs3rKWW2 Hes7e2p7vevuWnl0rZ529DHrJANX1necnzQUHiBzZmDecywTXKLlyAChSXDkH/WnBXiP ZdwAXYQbRTKh97sdj4o1nOaCuJIcx4GFRtPuFAFWgXUatiCNEANwI3EHYafaTHtoDwvz d+QXCKU66gw98PfCaWWkLBhzE7RdFdjUf6m4JOM58OG4QWVNfJsDzXsxzsFA/jS57Kqq 16Tw== X-Gm-Message-State: AOJu0YzPUeTp0Q9c+BFL98d/1/AwC+fZGucj5bqmRGKavs9V1gug0VDb MCBHMEBxfmUjhgurXzzm2UJYPHo7snxgWIcb6yb1dnoypy8fxR2+s/WSi1QfTLhr6DHi370eiYM = X-Google-Smtp-Source: AGHT+IF4QuLwLd7nGzyJt2omKjet54SpCGKIGngKvNr3IVtnEQN8EyutWZITFFZx+jtFzslUlVrpcA== X-Received: by 2002:a05:6602:3f87:b0:7f3:a7d9:5922 with SMTP id ca18e2360f4ac-7f3a7d95ce7mr2114003739f.8.1719594927192; Fri, 28 Jun 2024 10:15:27 -0700 (PDT) Received: from avocato.wireless.northwestern.private (wireless-165-124-85-63.nuwlan.northwestern.edu. [165.124.85.63]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4bb73e08ec1sm628802173.79.2024.06.28.10.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 10:15:26 -0700 (PDT) From: Karl Hallsby Date: Fri, 28 Jun 2024 12:11:37 -0500 Message-ID: <0a50bb4e0f82808a4edd2884871d45fdc1540870.1719594662.git.karl@hallsby.com> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::d29; envelope-from=karl@hallsby.com; helo=mail-io1-xd29.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch: New file. * gnu/local.mk (dist_patch_DATA): Register file. * gnu/packages/virtualization.scm (virt-manager)[source]: Add patch. Change-Id: I4db2015a5d4ac3eca3cfa5d3eec20b357c2d3ff9 --- This patch fixes an issue in virt-manager 4.1.0 where it errors and returns a stack trace. Namely, Gdk.Cursor.new_from_name yields a "constructor returned NULL" error, which causes a "'NoneType' object has no attribute 'conn'" error later. gnu/local.mk | 1 + ...anager-fix-gtk-cursor-theme-backtace.patch | 27 +++++++++++++++++++ gnu/packages/virtualization.scm | 4 ++- 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch diff --git a/gnu/local.mk b/gnu/local.mk index e20ed2be7e..7c626cabf1 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -2214,6 +2214,7 @@ dist_patch_DATA = \ %D%/packages/patches/vinagre-newer-freerdp.patch \ %D%/packages/patches/vinagre-newer-rdp-parameters.patch \ %D%/packages/patches/virtuoso-ose-remove-pre-built-jar-files.patch \ + %D%/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch \ %D%/packages/patches/vsearch-unbundle-cityhash.patch \ %D%/packages/patches/vte-CVE-2012-2738-pt1.patch \ %D%/packages/patches/vte-CVE-2012-2738-pt2.patch \ diff --git a/gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch b/gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch new file mode 100644 index 0000000000..f0b34bc4e4 --- /dev/null +++ b/gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch @@ -0,0 +1,27 @@ +From cc4a39ea94f42bc92765eb3bb56e2b7f9198be67 Mon Sep 17 00:00:00 2001 +From: Cole Robinson +Date: Thu, 19 Jan 2023 11:13:56 -0500 +Subject: [PATCH] asyncjob: Fix backtrace when no cursor theme installed + +Fixes: https://github.com/virt-manager/virt-manager/issues/479 + +Signed-off-by: Cole Robinson +--- + virtManager/asyncjob.py | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +diff --git a/virtManager/asyncjob.py b/virtManager/asyncjob.py +index 32d9c0a16..46692acea 100644 +--- a/virtManager/asyncjob.py ++++ b/virtManager/asyncjob.py +@@ -265,9 +265,7 @@ def run(self): + self.topwin.present() + + if not self.cancel_cb and self.show_progress: +- gdk_window = self.topwin.get_window() +- gdk_window.set_cursor( +- Gdk.Cursor.new_from_name(gdk_window.get_display(), "progress")) ++ self._set_cursor("progress") + self._bg_thread.start() + + diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm index 16c2b75510..3136db33b5 100644 --- a/gnu/packages/virtualization.scm +++ b/gnu/packages/virtualization.scm @@ -33,6 +33,7 @@ ;;; Copyright © 2023 Sharlatan Hellseher ;;; Copyright © 2023, 2024 Hartmut Goebel ;;; Copyright © 2024 Janneke Nieuwenhuizen +;;; Copyright © 2024 Raven Hallsby ;;; ;;; This file is part of GNU Guix. ;;; @@ -1663,7 +1664,8 @@ (define-public virt-manager version ".tar.gz")) (sha256 (base32 - "18lhlnd3gmyzhbnjc16gdyzhjcd33prlxnca4xlidiidngbq21lm")))) + "18lhlnd3gmyzhbnjc16gdyzhjcd33prlxnca4xlidiidngbq21lm")) + (patches (search-patches "virt-manager-fix-gtk-cursor-theme-backtace.patch")))) (build-system python-build-system) (arguments (list #:use-setuptools? #f ; uses custom distutils 'install' command base-commit: ae55410e0752000268b31c71dddea58e6106522a -- 2.45.1 From unknown Sat Jun 21 10:40:03 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#71825] [PATCH] gnu: Fix virt-manager for systems with no GTK cursor. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Jul 2024 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71825 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71825@debbugs.gnu.org Cc: 71825-done@debbugs.gnu.org, Karl Hallsby X-Debbugs-Original-To: Karl Hallsby via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.172123630927091 (code B ref -1); Wed, 17 Jul 2024 17:12:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Jul 2024 17:11:49 +0000 Received: from localhost ([127.0.0.1]:36137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU8Bw-00072s-PS for submit@debbugs.gnu.org; Wed, 17 Jul 2024 13:11:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:49142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU8Bs-00072X-Mx for submit@debbugs.gnu.org; Wed, 17 Jul 2024 13:11:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sU8Bp-0000bD-5p for guix-patches@gnu.org; Wed, 17 Jul 2024 13:11:41 -0400 Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sU8Bn-0002JN-1s for guix-patches@gnu.org; Wed, 17 Jul 2024 13:11:40 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 3763811400F2; Wed, 17 Jul 2024 13:11:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 17 Jul 2024 13:11:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1721236298; x= 1721322698; bh=j3qA2tWI7sEWdmmR3g0e+YVbOnR1bbdiDZgsX4nejgU=; b=l YVxnZkxqpGY1n9uez1tlpyTbhMZcoSNACNvMmy2HDJ7UlwEP3S1TAU/jvgpajIzk CT0i9Jse9bkbF9N9G3JdySdl5CtvoHC8x5JWPRLfD2F21QABaR9QK+ZF2r1QwEhA 06TWHF2vDJH7yFLbyxHyR9YTaxn50LNOEaDGYr55jA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1721236298; x=1721322698; bh=j3qA2tWI7sEWdmmR3g0e+YVbOnR1 bbdiDZgsX4nejgU=; b=Nv4KQFc6wXqrdUwgEsEYr4Ud1KEqiDiUa+e8o2cNLMFy Ov3yi3Z9eRhc4N0Hsok1JMma3PBAFXvtHSjSP7Nd2ON7vrYKmRGMjlli5dx3JO99 jM8UqM8ZZ/hgFP32D1/nblKypO5bkEtel0q/QGLKZ/Kp6Rnac2CfNrHNeziBm65K vulskNeQ7gHdj4w4ovp3SWFtI4WJlfBL5Es8xQmjCMbiQ3pnhX9lMg7wFeMT0eE8 ugVH/Xm1YCiETMlT0nKs+GEXwZdzErGqnKn5iF97hGnwuCBK5/cBGW88sIh0P6Yj Q8lbodWi8VWWGYEncIMiolq9snOP2zgxK7AoGiz/lA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrgeejgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeuhfeffffgueduleehvdejleei teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Jul 2024 13:11:36 -0400 (EDT) Date: Wed, 17 Jul 2024 13:11:34 -0400 From: Leo Famulari Message-ID: References: <0a50bb4e0f82808a4edd2884871d45fdc1540870.1719594662.git.karl@hallsby.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a50bb4e0f82808a4edd2884871d45fdc1540870.1719594662.git.karl@hallsby.com> Received-SPF: pass client-ip=103.168.172.157; envelope-from=leo@famulari.name; helo=fhigh6-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On Fri, Jun 28, 2024 at 12:11:37PM -0500, Karl Hallsby via Guix-patches via wrote: > * gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch: New file. > * gnu/local.mk (dist_patch_DATA): Register file. > * gnu/packages/virtualization.scm (virt-manager)[source]: Add patch. Thanks! I added some annotation to the patch file and pushed as 6cfc88e3be73904fc87443cdd5c7d7961923e848 From unknown Sat Jun 21 10:40:03 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Karl Hallsby Subject: bug#71825: closed (Re: [bug#71825] [PATCH] gnu: Fix virt-manager for systems with no GTK cursor.) Message-ID: References: <0a50bb4e0f82808a4edd2884871d45fdc1540870.1719594662.git.karl@hallsby.com> X-Gnu-PR-Message: they-closed 71825 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 71825@debbugs.gnu.org Date: Wed, 17 Jul 2024 17:12:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1721236323-27119-1" This is a multi-part message in MIME format... ------------=_1721236323-27119-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71825: [PATCH] gnu: Fix virt-manager for systems with no GTK cursor. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71825@debbugs.gnu.org. --=20 71825: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71825 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1721236323-27119-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71825-done) by debbugs.gnu.org; 17 Jul 2024 17:11:48 +0000 Received: from localhost ([127.0.0.1]:36135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU8Bw-00072l-DG for submit@debbugs.gnu.org; Wed, 17 Jul 2024 13:11:48 -0400 Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]:60065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU8Bu-00072S-KW for 71825-done@debbugs.gnu.org; Wed, 17 Jul 2024 13:11:46 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 3763811400F2; Wed, 17 Jul 2024 13:11:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 17 Jul 2024 13:11:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1721236298; x= 1721322698; bh=j3qA2tWI7sEWdmmR3g0e+YVbOnR1bbdiDZgsX4nejgU=; b=l YVxnZkxqpGY1n9uez1tlpyTbhMZcoSNACNvMmy2HDJ7UlwEP3S1TAU/jvgpajIzk CT0i9Jse9bkbF9N9G3JdySdl5CtvoHC8x5JWPRLfD2F21QABaR9QK+ZF2r1QwEhA 06TWHF2vDJH7yFLbyxHyR9YTaxn50LNOEaDGYr55jA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1721236298; x=1721322698; bh=j3qA2tWI7sEWdmmR3g0e+YVbOnR1 bbdiDZgsX4nejgU=; b=Nv4KQFc6wXqrdUwgEsEYr4Ud1KEqiDiUa+e8o2cNLMFy Ov3yi3Z9eRhc4N0Hsok1JMma3PBAFXvtHSjSP7Nd2ON7vrYKmRGMjlli5dx3JO99 jM8UqM8ZZ/hgFP32D1/nblKypO5bkEtel0q/QGLKZ/Kp6Rnac2CfNrHNeziBm65K vulskNeQ7gHdj4w4ovp3SWFtI4WJlfBL5Es8xQmjCMbiQ3pnhX9lMg7wFeMT0eE8 ugVH/Xm1YCiETMlT0nKs+GEXwZdzErGqnKn5iF97hGnwuCBK5/cBGW88sIh0P6Yj Q8lbodWi8VWWGYEncIMiolq9snOP2zgxK7AoGiz/lA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrgeejgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeuhfeffffgueduleehvdejleei teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Jul 2024 13:11:36 -0400 (EDT) Date: Wed, 17 Jul 2024 13:11:34 -0400 From: Leo Famulari To: Karl Hallsby via Guix-patches via Subject: Re: [bug#71825] [PATCH] gnu: Fix virt-manager for systems with no GTK cursor. Message-ID: References: <0a50bb4e0f82808a4edd2884871d45fdc1540870.1719594662.git.karl@hallsby.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a50bb4e0f82808a4edd2884871d45fdc1540870.1719594662.git.karl@hallsby.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71825-done Cc: 71825-done@debbugs.gnu.org, Karl Hallsby X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Jun 28, 2024 at 12:11:37PM -0500, Karl Hallsby via Guix-patches via wrote: > * gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch: New file. > * gnu/local.mk (dist_patch_DATA): Register file. > * gnu/packages/virtualization.scm (virt-manager)[source]: Add patch. Thanks! I added some annotation to the patch file and pushed as 6cfc88e3be73904fc87443cdd5c7d7961923e848 ------------=_1721236323-27119-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jun 2024 17:15:34 +0000 Received: from localhost ([127.0.0.1]:46282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNFC9-0004AY-FZ for submit@debbugs.gnu.org; Fri, 28 Jun 2024 13:15:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:41948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNFC7-0004AR-W7 for submit@debbugs.gnu.org; Fri, 28 Jun 2024 13:15:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNFC7-0000ZG-Dn for guix-patches@gnu.org; Fri, 28 Jun 2024 13:15:31 -0400 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNFC5-0001EH-FW for guix-patches@gnu.org; Fri, 28 Jun 2024 13:15:31 -0400 Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7f3cd64e71cso24312339f.3 for ; Fri, 28 Jun 2024 10:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hallsby.com; s=google; t=1719594927; x=1720199727; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+g51LbAeUXJACA5+aETfakMLFS6/5OYMBzUwBoomrwk=; b=E9728msF5KT63dPYlEs4O7Bupz4HZ7/PQ+vikqoBTrs2k69V+wJCLVqmWWhrzl4Lg1 ooM2CpvmR1kj6q8OZRl6cLiLMRv+Amec6yAec/MUpjkOPcf0MTkzjfJlbyvFUj0kSIxF MXLvcBnfjM2oGS3Hjv5VThkSUWmhhy36wwkQ5iC8ML5ywsix+GkGijAfbCr1lP1NO7qf 0VhK3BBOmzm5xV6Y38SJgq1mnVIt48CqwHYA9sAZYEUWJe8JOK2MQIMxyD2LAlnm+I3s 6ZDrh4FH5fXUFOEEkyEglfZC3g2CPN3Bz3C+9iQkL7YSzWasuYFHGZVq/23rCSm65qP7 xvPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719594927; x=1720199727; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+g51LbAeUXJACA5+aETfakMLFS6/5OYMBzUwBoomrwk=; b=oSZ8wKO5Af9T/IHVnMWUC4bMbi0fEChuB041Vca9RStjgWZjCuJTh+33Yk6loprfUt Qbv3bGt1/RV9VK28l7HB6tS8hjHkW6Pu1zAW7btFQxbnfkvuFHNnYJj+0TMTGs3rKWW2 Hes7e2p7vevuWnl0rZ529DHrJANX1necnzQUHiBzZmDecywTXKLlyAChSXDkH/WnBXiP ZdwAXYQbRTKh97sdj4o1nOaCuJIcx4GFRtPuFAFWgXUatiCNEANwI3EHYafaTHtoDwvz d+QXCKU66gw98PfCaWWkLBhzE7RdFdjUf6m4JOM58OG4QWVNfJsDzXsxzsFA/jS57Kqq 16Tw== X-Gm-Message-State: AOJu0YzPUeTp0Q9c+BFL98d/1/AwC+fZGucj5bqmRGKavs9V1gug0VDb MCBHMEBxfmUjhgurXzzm2UJYPHo7snxgWIcb6yb1dnoypy8fxR2+s/WSi1QfTLhr6DHi370eiYM = X-Google-Smtp-Source: AGHT+IF4QuLwLd7nGzyJt2omKjet54SpCGKIGngKvNr3IVtnEQN8EyutWZITFFZx+jtFzslUlVrpcA== X-Received: by 2002:a05:6602:3f87:b0:7f3:a7d9:5922 with SMTP id ca18e2360f4ac-7f3a7d95ce7mr2114003739f.8.1719594927192; Fri, 28 Jun 2024 10:15:27 -0700 (PDT) Received: from avocato.wireless.northwestern.private (wireless-165-124-85-63.nuwlan.northwestern.edu. [165.124.85.63]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4bb73e08ec1sm628802173.79.2024.06.28.10.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 10:15:26 -0700 (PDT) From: Karl Hallsby To: guix-patches@gnu.org Subject: [PATCH] gnu: Fix virt-manager for systems with no GTK cursor. Date: Fri, 28 Jun 2024 12:11:37 -0500 Message-ID: <0a50bb4e0f82808a4edd2884871d45fdc1540870.1719594662.git.karl@hallsby.com> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::d29; envelope-from=karl@hallsby.com; helo=mail-io1-xd29.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Karl Hallsby X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch: New file. * gnu/local.mk (dist_patch_DATA): Register file. * gnu/packages/virtualization.scm (virt-manager)[source]: Add patch. Change-Id: I4db2015a5d4ac3eca3cfa5d3eec20b357c2d3ff9 --- This patch fixes an issue in virt-manager 4.1.0 where it errors and returns a stack trace. Namely, Gdk.Cursor.new_from_name yields a "constructor returned NULL" error, which causes a "'NoneType' object has no attribute 'conn'" error later. gnu/local.mk | 1 + ...anager-fix-gtk-cursor-theme-backtace.patch | 27 +++++++++++++++++++ gnu/packages/virtualization.scm | 4 ++- 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch diff --git a/gnu/local.mk b/gnu/local.mk index e20ed2be7e..7c626cabf1 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -2214,6 +2214,7 @@ dist_patch_DATA = \ %D%/packages/patches/vinagre-newer-freerdp.patch \ %D%/packages/patches/vinagre-newer-rdp-parameters.patch \ %D%/packages/patches/virtuoso-ose-remove-pre-built-jar-files.patch \ + %D%/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch \ %D%/packages/patches/vsearch-unbundle-cityhash.patch \ %D%/packages/patches/vte-CVE-2012-2738-pt1.patch \ %D%/packages/patches/vte-CVE-2012-2738-pt2.patch \ diff --git a/gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch b/gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch new file mode 100644 index 0000000000..f0b34bc4e4 --- /dev/null +++ b/gnu/packages/patches/virt-manager-fix-gtk-cursor-theme-backtace.patch @@ -0,0 +1,27 @@ +From cc4a39ea94f42bc92765eb3bb56e2b7f9198be67 Mon Sep 17 00:00:00 2001 +From: Cole Robinson +Date: Thu, 19 Jan 2023 11:13:56 -0500 +Subject: [PATCH] asyncjob: Fix backtrace when no cursor theme installed + +Fixes: https://github.com/virt-manager/virt-manager/issues/479 + +Signed-off-by: Cole Robinson +--- + virtManager/asyncjob.py | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +diff --git a/virtManager/asyncjob.py b/virtManager/asyncjob.py +index 32d9c0a16..46692acea 100644 +--- a/virtManager/asyncjob.py ++++ b/virtManager/asyncjob.py +@@ -265,9 +265,7 @@ def run(self): + self.topwin.present() + + if not self.cancel_cb and self.show_progress: +- gdk_window = self.topwin.get_window() +- gdk_window.set_cursor( +- Gdk.Cursor.new_from_name(gdk_window.get_display(), "progress")) ++ self._set_cursor("progress") + self._bg_thread.start() + + diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm index 16c2b75510..3136db33b5 100644 --- a/gnu/packages/virtualization.scm +++ b/gnu/packages/virtualization.scm @@ -33,6 +33,7 @@ ;;; Copyright © 2023 Sharlatan Hellseher ;;; Copyright © 2023, 2024 Hartmut Goebel ;;; Copyright © 2024 Janneke Nieuwenhuizen +;;; Copyright © 2024 Raven Hallsby ;;; ;;; This file is part of GNU Guix. ;;; @@ -1663,7 +1664,8 @@ (define-public virt-manager version ".tar.gz")) (sha256 (base32 - "18lhlnd3gmyzhbnjc16gdyzhjcd33prlxnca4xlidiidngbq21lm")))) + "18lhlnd3gmyzhbnjc16gdyzhjcd33prlxnca4xlidiidngbq21lm")) + (patches (search-patches "virt-manager-fix-gtk-cursor-theme-backtace.patch")))) (build-system python-build-system) (arguments (list #:use-setuptools? #f ; uses custom distutils 'install' command base-commit: ae55410e0752000268b31c71dddea58e6106522a -- 2.45.1 ------------=_1721236323-27119-1--