From unknown Mon Aug 11 18:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71812: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable Resent-From: Jules Tamagnan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2024 06:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71812 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 71812@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17195546623025 (code B ref -1); Fri, 28 Jun 2024 06:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jun 2024 06:04:22 +0000 Received: from localhost ([127.0.0.1]:51420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4ib-0000mh-Ss for submit@debbugs.gnu.org; Fri, 28 Jun 2024 02:04:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:51160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4iX-0000mL-Rk for submit@debbugs.gnu.org; Fri, 28 Jun 2024 02:04:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sN45f-0002Pk-Gn for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 01:24:07 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sN45c-0000w5-U6 for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 01:24:07 -0400 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-71816f36d4dso127822a12.2 for ; Thu, 27 Jun 2024 22:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719552243; x=1720157043; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=hc5LPWVUIHmcWHuEi4phAOnei2WvaoiB0QZruD3OI34=; b=V2BJsCESxP45nO1OpPB3IKGOojRxph6/KxbDeBe/Ult/DxzzDBPV/oB8Hw/CZwRiAc vEorXS+7IZjUBRNp2229dSYWTiOwsV26JG3cXLBpEryPIz5F1heqrG2KXiGgyJFTTke5 o9j/f09K6PmTDE1SCJwo5hyfKw3AM6geS2VdxSBs+c2oHiZ5fTpOiYuPsdNdlNmtojMm 5TkMiky38naxNbvhWU8NpnseL1OiqPRAs6+9DfpeAN7t5J/KQakmjpW5TOb8XixNh630 W/HsnTCne1Usxu4PbVdyfh/d/KaCemspJPrhhiTm0AVWrviJRgTZfbX0eBGP0XIJL1JH Zkqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719552243; x=1720157043; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hc5LPWVUIHmcWHuEi4phAOnei2WvaoiB0QZruD3OI34=; b=vfoK9yejVpVawILOm4doKDsPk7J2f/Fn4LSHqr0GnXk/utYUxsU0M2DpTmVfVPxhsb eF83fjyE1HshOrf8xoms3ROI8g32EIwkdc3pF4e9dePPsDYQ4FHouRXk3YuuZrwvt7YW pu01ca1lFPHIXvBiBtBPObW/ujOCS5IYSDzYz1IV5274uSlQrBrL/fDPyWY3CWDg1TAw Ox6iRjsC8mNQlmXDeqn3gZeXvf3ZKCap/qTjB5JEn01B7F9+z6vSNiHPYw3O1uM6gX4d 00UQ8409AerTXFbCRT/PPQCSFJXIndZ/3FtrFI8kwgvDoLeDNBvy72G1t555EAglAs2R /1Tg== X-Gm-Message-State: AOJu0Yxr19GYLHXHTVOE5KICnyi5cYovCHGAsdZVdiPnEEO9rDtFYHxL VxuziD5GTaJsT3IjgNPmyzEF09f4w4UMYINsbXEsJ/Vx4LecVdB5gs4pMw== X-Google-Smtp-Source: AGHT+IGamrYudEmuRtm3LTnTnDmr7F7S4/d2Y2oX310e3w4aNc22hnHzGR6EMaHomo5RJwhqqpwBHQ== X-Received: by 2002:a05:6a20:3514:b0:1bd:24f9:1124 with SMTP id adf61e73a8af0-1bd24f9124fmr9461408637.27.1719552242772; Thu, 27 Jun 2024 22:24:02 -0700 (PDT) Received: from jat-framework (c-73-189-85-43.hsd1.ca.comcast.net. [73.189.85.43]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac11d8695sm6592165ad.109.2024.06.27.22.24.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 22:24:02 -0700 (PDT) From: Jules Tamagnan Date: Thu, 27 Jun 2024 22:23:59 -0700 Message-ID: <87v81ttzbk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=jtamagnan@gmail.com; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch * Problem Recently I was collaborating on a package that provided a .dir-locals.el file where this `checkdoc-package-keywords-flag' was being set. I then had to figure out what variable was considered unsafe and decide whether it was unsafe or not. This caused some extra mental overhead and development friction. * Solution It would be great if this variable were already considered safe to reduce overhead on developers. * Implementation After looking at how this variable was used I noticed that it was only consumed in `checkdoc-current-buffer' and that it seemed safe to mark as safe. I added a single autoload line as is done throughout the rest of the file for similar variables --- Best, Jules --- In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.42, cairo version 1.18.0) Repository revision: 9cb2a2040888c28587bed2b0902d9da90720f9a0 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: NixOS 24.11 (Vicuna) Configured using: 'configure --prefix=/nix/store/93m6yix8f6pcg75418xjx7k81lrj5a6s-emacs-git-20240626.0 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-cairo --with-xft --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --with-mailutils --without-small-ja-dic --with-tree-sitter --with-xinput2 --with-xwidgets --with-dbus --with-selinux' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=safe.patch >From 96c335bb5ab68b7fcf2d3079df15045ad79d19d3 Mon Sep 17 00:00:00 2001 From: Jules Tamagnan Date: Thu, 27 Jun 2024 22:04:58 -0700 Subject: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable * lisp/emacs-lisp/checkdoc.el: Mark 'checkdoc-package-keywords-flag' as a safe local variable. --- lisp/emacs-lisp/checkdoc.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index c22dfb2eb26..bda5150cf07 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -289,6 +289,7 @@ checkdoc-package-keywords-flag Currently, all recognized keywords must be on `finder-known-keywords'." :version "25.1" :type 'boolean) +;;;###autoload(put 'checkdoc-package-keywords-flag 'safe-local-variable #'booleanp) (defvar checkdoc-style-functions nil "Hook run after the standard style check is completed. -- 2.45.1 --=-=-=-- From unknown Mon Aug 11 18:15:39 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jules Tamagnan Subject: bug#71812: closed (Re: bug#71812: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable) Message-ID: References: <87v81ttzbk.fsf@gmail.com> X-Gnu-PR-Message: they-closed 71812 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 71812@debbugs.gnu.org Date: Sat, 29 Jun 2024 03:39:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1719632342-455-1" This is a multi-part message in MIME format... ------------=_1719632342-455-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71812: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71812@debbugs.gnu.org. --=20 71812: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71812 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1719632342-455-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71812-done) by debbugs.gnu.org; 29 Jun 2024 03:38:48 +0000 Received: from localhost ([127.0.0.1]:36570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOvI-00006s-JT for submit@debbugs.gnu.org; Fri, 28 Jun 2024 23:38:48 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:47198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOvG-00006d-LO for 71812-done@debbugs.gnu.org; Fri, 28 Jun 2024 23:38:47 -0400 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-57d26a4ee65so1452440a12.2 for <71812-done@debbugs.gnu.org>; Fri, 28 Jun 2024 20:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719632261; x=1720237061; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=wBMuZ2p5m1pp4plVeKDKuocG4jXQKDpBDTE77FB4k1A=; b=ZtZEC6utMOLBVpo2GjUS/PUhWDs8Uz02xldwiumgCMgRwSHko30mZKW/sWc1xlTop2 ngB1qMEg9+timsYgbSHepyFSE6HlY4JizQrm32Aa5Gx8HaYx2VSUhf6M1os+Uf6eCemn hXUBaNcFXeaxK3vaRV/rpSLVP2nDro9XarYDsvqlS91vX60AWcdg+eRYmGacX1PIDqTi cIZNGzp7TLNcN45MzYctlSA/OWgH/F2hqY/OecHwrvUB8KKTpkMQAxIOdHB0DtXtGaFp 3Dq9YNk3mCC2KkGrj9u0wFhLPBXuLlXlcnkaCOczd1foQtR2AOnvcECupoqHVAixuyd8 eDgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719632261; x=1720237061; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wBMuZ2p5m1pp4plVeKDKuocG4jXQKDpBDTE77FB4k1A=; b=rINPlQ20UlBws7OxQqo0tpjZk0krCr/Pqz8MkMDsVNk96AXZOqsDV7pnAQdhkjZxP1 U452V6totMtJ9kCcDXSEK0TmBbWBfy/TQJyigmU3Rnu/Xg5XNFiwsxGCcXFrWRnWFSHp qAM5eZThTSIBsINbOC8Oe+0W2I7IkB+RBN85I+HGzqhN0YzMEz1jicliBQb7x9q9WZHA GgJuhHCJYbthUsZYKHJZhUKjkiWmj+FR4BNG50fIZ7bDzD6lYLT9Gev49ot5wp7EPWAe bksA+uW7lOvzt1hdin7QvJcT+zvpd4QH1vHJDb+4xQiqJu6RXji/f3KpmWsTMxEXDMJ5 th2Q== X-Forwarded-Encrypted: i=1; AJvYcCWzwcsQJzBUzJ2n0AcCVY2iT0TkEhqb/HkYKHhZWQN2YHRSsBVsawFfK8mF0Cosqq0SRTpj9Y2fyYBpphfvD52SmR/JPq7tz16yWA== X-Gm-Message-State: AOJu0YwG4ChmeyE3/SiAmtRBygWcAUm4QXIgqomqonezURYRzKKxtncV uVsxzO9SvAd3dsg0BbQVBSSxs02iX/n6MSiw1rwoIxcJmN8C+plcX5AFdR9bd/FPjWWVL7Thx08 pILQEPFT5N7oke6MN+aKYslbfKOgxIUMOdqs= X-Google-Smtp-Source: AGHT+IEfvYUKUaKX6BunE9zXvXwXz55XfbbgXWf8PxnkxtUPn4XY0ZOhDZcv4XeUAsthx71v0r+Sm5fqCnP4IGl7DfY= X-Received: by 2002:a05:6402:2787:b0:587:2dce:7514 with SMTP id 4fb4d7f45d1cf-5872dce7802mr1105191a12.36.1719632261314; Fri, 28 Jun 2024 20:37:41 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Jun 2024 20:37:41 -0700 From: Stefan Kangas In-Reply-To: <87v81ttzbk.fsf@gmail.com> References: <87v81ttzbk.fsf@gmail.com> MIME-Version: 1.0 Date: Fri, 28 Jun 2024 20:37:41 -0700 Message-ID: Subject: Re: bug#71812: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable To: Jules Tamagnan , 71812-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71812-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Jules Tamagnan writes: > From 96c335bb5ab68b7fcf2d3079df15045ad79d19d3 Mon Sep 17 00:00:00 2001 > From: Jules Tamagnan > Date: Thu, 27 Jun 2024 22:04:58 -0700 > Subject: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable > > * lisp/emacs-lisp/checkdoc.el: Mark 'checkdoc-package-keywords-flag' > as a safe local variable. > --- > lisp/emacs-lisp/checkdoc.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el > index c22dfb2eb26..bda5150cf07 100644 > --- a/lisp/emacs-lisp/checkdoc.el > +++ b/lisp/emacs-lisp/checkdoc.el > @@ -289,6 +289,7 @@ checkdoc-package-keywords-flag > Currently, all recognized keywords must be on `finder-known-keywords'." > :version "25.1" > :type 'boolean) > +;;;###autoload(put 'checkdoc-package-keywords-flag 'safe-local-variable #'booleanp) > > (defvar checkdoc-style-functions nil > "Hook run after the standard style check is completed. > -- > 2.45.1 Thanks, installed on master as commit d3b100d4192. ------------=_1719632342-455-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jun 2024 06:04:22 +0000 Received: from localhost ([127.0.0.1]:51420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4ib-0000mh-Ss for submit@debbugs.gnu.org; Fri, 28 Jun 2024 02:04:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:51160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4iX-0000mL-Rk for submit@debbugs.gnu.org; Fri, 28 Jun 2024 02:04:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sN45f-0002Pk-Gn for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 01:24:07 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sN45c-0000w5-U6 for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 01:24:07 -0400 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-71816f36d4dso127822a12.2 for ; Thu, 27 Jun 2024 22:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719552243; x=1720157043; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=hc5LPWVUIHmcWHuEi4phAOnei2WvaoiB0QZruD3OI34=; b=V2BJsCESxP45nO1OpPB3IKGOojRxph6/KxbDeBe/Ult/DxzzDBPV/oB8Hw/CZwRiAc vEorXS+7IZjUBRNp2229dSYWTiOwsV26JG3cXLBpEryPIz5F1heqrG2KXiGgyJFTTke5 o9j/f09K6PmTDE1SCJwo5hyfKw3AM6geS2VdxSBs+c2oHiZ5fTpOiYuPsdNdlNmtojMm 5TkMiky38naxNbvhWU8NpnseL1OiqPRAs6+9DfpeAN7t5J/KQakmjpW5TOb8XixNh630 W/HsnTCne1Usxu4PbVdyfh/d/KaCemspJPrhhiTm0AVWrviJRgTZfbX0eBGP0XIJL1JH Zkqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719552243; x=1720157043; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hc5LPWVUIHmcWHuEi4phAOnei2WvaoiB0QZruD3OI34=; b=vfoK9yejVpVawILOm4doKDsPk7J2f/Fn4LSHqr0GnXk/utYUxsU0M2DpTmVfVPxhsb eF83fjyE1HshOrf8xoms3ROI8g32EIwkdc3pF4e9dePPsDYQ4FHouRXk3YuuZrwvt7YW pu01ca1lFPHIXvBiBtBPObW/ujOCS5IYSDzYz1IV5274uSlQrBrL/fDPyWY3CWDg1TAw Ox6iRjsC8mNQlmXDeqn3gZeXvf3ZKCap/qTjB5JEn01B7F9+z6vSNiHPYw3O1uM6gX4d 00UQ8409AerTXFbCRT/PPQCSFJXIndZ/3FtrFI8kwgvDoLeDNBvy72G1t555EAglAs2R /1Tg== X-Gm-Message-State: AOJu0Yxr19GYLHXHTVOE5KICnyi5cYovCHGAsdZVdiPnEEO9rDtFYHxL VxuziD5GTaJsT3IjgNPmyzEF09f4w4UMYINsbXEsJ/Vx4LecVdB5gs4pMw== X-Google-Smtp-Source: AGHT+IGamrYudEmuRtm3LTnTnDmr7F7S4/d2Y2oX310e3w4aNc22hnHzGR6EMaHomo5RJwhqqpwBHQ== X-Received: by 2002:a05:6a20:3514:b0:1bd:24f9:1124 with SMTP id adf61e73a8af0-1bd24f9124fmr9461408637.27.1719552242772; Thu, 27 Jun 2024 22:24:02 -0700 (PDT) Received: from jat-framework (c-73-189-85-43.hsd1.ca.comcast.net. [73.189.85.43]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac11d8695sm6592165ad.109.2024.06.27.22.24.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 22:24:02 -0700 (PDT) From: Jules Tamagnan To: bug-gnu-emacs@gnu.org Subject: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable Date: Thu, 27 Jun 2024 22:23:59 -0700 Message-ID: <87v81ttzbk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=jtamagnan@gmail.com; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch * Problem Recently I was collaborating on a package that provided a .dir-locals.el file where this `checkdoc-package-keywords-flag' was being set. I then had to figure out what variable was considered unsafe and decide whether it was unsafe or not. This caused some extra mental overhead and development friction. * Solution It would be great if this variable were already considered safe to reduce overhead on developers. * Implementation After looking at how this variable was used I noticed that it was only consumed in `checkdoc-current-buffer' and that it seemed safe to mark as safe. I added a single autoload line as is done throughout the rest of the file for similar variables --- Best, Jules --- In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.42, cairo version 1.18.0) Repository revision: 9cb2a2040888c28587bed2b0902d9da90720f9a0 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: NixOS 24.11 (Vicuna) Configured using: 'configure --prefix=/nix/store/93m6yix8f6pcg75418xjx7k81lrj5a6s-emacs-git-20240626.0 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-cairo --with-xft --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --with-mailutils --without-small-ja-dic --with-tree-sitter --with-xinput2 --with-xwidgets --with-dbus --with-selinux' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=safe.patch >From 96c335bb5ab68b7fcf2d3079df15045ad79d19d3 Mon Sep 17 00:00:00 2001 From: Jules Tamagnan Date: Thu, 27 Jun 2024 22:04:58 -0700 Subject: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable * lisp/emacs-lisp/checkdoc.el: Mark 'checkdoc-package-keywords-flag' as a safe local variable. --- lisp/emacs-lisp/checkdoc.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index c22dfb2eb26..bda5150cf07 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -289,6 +289,7 @@ checkdoc-package-keywords-flag Currently, all recognized keywords must be on `finder-known-keywords'." :version "25.1" :type 'boolean) +;;;###autoload(put 'checkdoc-package-keywords-flag 'safe-local-variable #'booleanp) (defvar checkdoc-style-functions nil "Hook run after the standard style check is completed. -- 2.45.1 --=-=-=-- ------------=_1719632342-455-1-- From unknown Mon Aug 11 18:15:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71812: [PATCH] Flag checkdoc-package-keywords-flag as a :safe variable Resent-From: Jules Tamagnan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2024 21:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71812 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 71812-done@debbugs.gnu.org Received: via spool by 71812-done@debbugs.gnu.org id=D71812.17196953193307 (code D ref 71812); Sat, 29 Jun 2024 21:09:02 +0000 Received: (at 71812-done) by debbugs.gnu.org; 29 Jun 2024 21:08:39 +0000 Received: from localhost ([127.0.0.1]:53761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNfJG-0000rG-UW for submit@debbugs.gnu.org; Sat, 29 Jun 2024 17:08:39 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:60808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNfJF-0000r4-0S for 71812-done@debbugs.gnu.org; Sat, 29 Jun 2024 17:08:37 -0400 Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3d5d7fa3485so1131508b6e.1 for <71812-done@debbugs.gnu.org>; Sat, 29 Jun 2024 14:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719695251; x=1720300051; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=5Mt/vzddLdRHrfu0iNBWQPVYOitsXAbrgFGJzAhpP/E=; b=KW9WqJaFQds2iF62iHeN46TFzlJUoBFR5JuTVlf3x1yHOGppqdEq4JmTW3da9V4TVG IvATIhOF3dr9jBHgFCVS4gUdQCy8MYCmZfCQYRfLntPUnZfpgSC9hcMdaBxzFeHfr5XT 2IKHhkKiZAZSEd6btF+HoG1Be5wiO4j2ct+FZJJLpdAgCw90o3tiS0FteQDbsnf4iqTV crow/iA1DbU6dw2NXIUZeMFauaiG9WvJ6zk7shEJscMD5k6XeGtHrYMwJQdfyGooP7TD 7rvQBhA9Im/z9e/gb4YxVYma/loiEc1lTymjND+qBQRmRn7M6h6Do1X7UJRiiVhybr0L BRKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719695251; x=1720300051; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5Mt/vzddLdRHrfu0iNBWQPVYOitsXAbrgFGJzAhpP/E=; b=nGxdvGmsTWBu0KSiEoFbPt9fBO1UPb0Q480ebNTmZR7gxWciWkICpLnXDKl/bVMQq8 X7hAUplKxF+MSA4u/ppsUh+qR2SrfJ9Ez1J16kY/7IpXzICiHlsoUluFDIH5yoJXtYRc hkJQ++RJ+yUFQRDxW/bAljVNe+LFuyIQaAxEL0bZ+iIDCiZ1kuTR4l5MtvibLatwMUtX pQEBi04pvZenlFmP9HNI9OEOgZHPyc0WrbHAGPewj9YN7RIo8IQdvCPWxks00ihwRGfn ahztsu1AMpcW+xWoyqzmd7DNagy8J5lfdTGAfcdsaIEgXQ+2J+o/DVebp/1ucrNKyW+j XIHg== X-Gm-Message-State: AOJu0YxGuGMX7TFwJTXn0MOL2/E6u57qM1KewVWYEgZ8rOj38kualcnn 5HYQXBPw/yK70QBADfVwQ/5PlSvem79YCue3361knyeHOJrtMUvK9xg4hw== X-Google-Smtp-Source: AGHT+IEb8EehHM+bbJIQ6QyM8t6D8wd2IBAz0M0WONI1LydGL3658TAPnUesjcHtGKmOPTtVnICyJw== X-Received: by 2002:a05:6808:14ca:b0:3d2:2721:8a85 with SMTP id 5614622812f47-3d6b2b2402emr2697668b6e.12.1719695251494; Sat, 29 Jun 2024 14:07:31 -0700 (PDT) Received: from jat-framework (c-73-189-85-43.hsd1.ca.comcast.net. [73.189.85.43]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6a8dbb2fsm2476606a12.31.2024.06.29.14.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jun 2024 14:07:30 -0700 (PDT) From: Jules Tamagnan In-Reply-To: (Stefan Kangas's message of "Fri, 28 Jun 2024 20:37:41 -0700") References: <87v81ttzbk.fsf@gmail.com> Date: Sat, 29 Jun 2024 14:07:28 -0700 Message-ID: <875xtrpien.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Version: 31.1 > > ... > > Thanks, installed on master as commit d3b100d4192. Brilliant, thank you for the super quick response and integration. I really appreciate it! Best, Jules