Subject: bug#71793: closed (Re: [bug#71793] [PATCH] ui: Write down the unwritten rule.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 04 Sep 2024 13:58:02 +0000

Your bug report

#71793: [PATCH] ui: Write down the unwritten rule.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
71793: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71793
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#71793] [PATCH] ui: Write down the unwritten rule.
From: Ludovic Courtès <[email-masked]>
To: Tomas Volf <[email-masked]>
Cc: Josselin Poiret <[email-masked]>, Simon Tournier <[email-masked]>, Mathieu Othacehe <[email-masked]>, Tobias Geerinckx-Rice <[email-masked]>, [email-masked], Christopher Baines <[email-masked]>
Date: Wed, 04 Sep 2024 15:56:12 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Tomas Volf <[email-masked]> skribis:

> Quote from Ludovic:
>
>> [..] there’s the unwritten rule that non-UI modules should not load (guix
>> ui) [..]
>
> This commit turns it into a written rule.
>
> * guix/ui.scm: Document the import policy.
>
> Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2

I committed a variant of this patch, thanks.

Ludo’.

Subject: [PATCH] ui: Write down the unwritten rule.
From: Tomas Volf <[email-masked]>
To: [email-masked]
Cc: Tomas Volf <[email-masked]>
Date: Thu, 27 Jun 2024 13:44:10 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Quote from Ludovic:

> [..] there’s the unwritten rule that non-UI modules should not load (guix
> ui) [..]

This commit turns it into a written rule.

* guix/ui.scm: Document the import policy.

Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2
---
 guix/ui.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guix/ui.scm b/guix/ui.scm
index d82fa533cc..d24886d156 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -35,6 +35,10 @@
 ;;; You should have received a copy of the GNU General Public License
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
+;;; !!!!
+;;; !!!! This module shall not be imported from non-UI modules.
+;;; !!!!
+
 (define-module (guix ui)
   #:use-module (guix i18n)
   #:use-module (guix colors)
-- 
2.45.1