From unknown Tue Aug 19 01:58:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71792: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards Resent-From: George Huebner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 08:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71792 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 71792@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171947644827577 (code B ref -1); Thu, 27 Jun 2024 08:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2024 08:20:48 +0000 Received: from localhost ([127.0.0.1]:40930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkN5-0007Ai-Jz for submit@debbugs.gnu.org; Thu, 27 Jun 2024 04:20:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:48428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMju0-0006Nb-5z for submit@debbugs.gnu.org; Thu, 27 Jun 2024 03:50:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMjtw-0001cm-Gt for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:50:41 -0400 Received: from mail-qv1-f49.google.com ([209.85.219.49]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMjtu-0004a3-Ur for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:50:40 -0400 Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6b4fdf56903so29242286d6.1 for ; Thu, 27 Jun 2024 00:50:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719474637; x=1720079437; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nIR0rCAcGHbBulS7KADMN06E5EZagSTPJhjW4RgOxlY=; b=BLLuFX3AiFO84GgXP2L0PsJpD+ibyLV692bc77pFqNY64YwOoZjLNeiWkAia3CWIyq SRmO+nZl3lJzlgbt/WOrVzqtLoNypvDkgRXui2t5EqAT/SMeaqbj+oD6qVb1LjJ9sC+w H18iMm4TRLJnp6oQUpugIpEERcfXWS3epSvwLsqcLQ2JtNzDFQhX2FKzGS0N/8RItLbJ tIA5G1IP80P6Pe4A8qTvBITzAu5eSgf8HZq1+Z4hym+9328goqBo04Z55ettcFSsWQei 4SSqshQ76tv2dfKMc9XQKKtj2env2u8nzXG1GelfUcmfq4hBNpcZ8r0Q2h26KOakZKW1 WgIQ== X-Gm-Message-State: AOJu0YxZ6pxPO5jnNDk0GFChaFnaiG3nh9I2YrX4Pnr5MCYSiz6ikAJH lp6QmcO3sxVOPQJ13GA/0CO8t7Q7ABoF/6WW/u86uq01xpTy0qrrrReucw== X-Google-Smtp-Source: AGHT+IEYRjkVA9KcpR+KOgJPdp8Qu9Hhg/pXu5IsyAhakqD9YY/uJ/cGU8MLjwQjzoJjxUBBPtJzww== X-Received: by 2002:ad4:576a:0:b0:6b5:4526:8be9 with SMTP id 6a1803df08f44-6b545268ee8mr146563606d6.51.1719474636564; Thu, 27 Jun 2024 00:50:36 -0700 (PDT) Received: from localhost (s-29-93.flex.volo.net. [76.191.29.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b5925139efsm3099586d6.57.2024.06.27.00.50.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 00:50:36 -0700 (PDT) From: George Huebner Date: Thu, 27 Jun 2024 02:50:35 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=209.85.219.49; envelope-from=ghubs25@gmail.com; helo=mail-qv1-f49.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Mailman-Approved-At: Thu, 27 Jun 2024 04:20:45 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --=-=-= Content-Type: text/plain; format=flowed Fixed a typo; this is consistent with the definition of xwidget-webkit-scroll-down. In GNU Emacs 29.1 (build 1, aarch64-apple-darwin23.4.0, Carbon Version 170 AppKit 2487.5) Windowing system distributor 'Apple Inc.', version 14.4.0 System Description: macOS 14.4 Configured using: 'configure --prefix=/nix/store/ismv7jzf3hcqziq5bpjfs54zd4qfjjn7-emacs-mac-macport-29.1 --disable-build-details --with-modules --without-gif --without-jpeg --without-png --without-tiff --without-x --without-xpm '--enable-mac-app=$$out/Applications' --with-gnutls --with-mac --with-xml2 --without-ns --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --with-mailutils --without-small-ja-dic --with-tree-sitter --without-xinput2 --without-xwidgets --without-dbus --without-selinux --with-xwidgets' --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-make-xwidget-webkit-scroll-backward-scroll-backw.patch >From d40761c0c26d28587187fd3f147804adac365563 Mon Sep 17 00:00:00 2001 From: George Huebner Date: Tue, 18 Jun 2024 17:14:41 -0500 Subject: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards * lisp/xwidget.el (xwidget-webkit-scroll-backward): Move hyphen out of %-formatter, changing semantics from a padding specifier to a negative sign. --- lisp/xwidget.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/xwidget.el b/lisp/xwidget.el index cca01c8..bf5987d 100644 --- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -378,7 +378,7 @@ one char." (> (window-hscroll) 0)) (set-window-hscroll nil (- (window-hscroll) n)) (xwidget-webkit-execute-script session - (format "window.scrollBy(%-d, 0);" + (format "window.scrollBy(-%d, 0);" (* n (window-font-width))))))) (defun xwidget-webkit-scroll-top () -- 2.44.1 --=-=-=-- From unknown Tue Aug 19 01:58:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: George Huebner Subject: bug#71792: closed (Re: bug#71792: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards) Message-ID: References: <8634owj65n.fsf@gnu.org> X-Gnu-PR-Message: they-closed 71792 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 71792@debbugs.gnu.org Date: Sat, 29 Jun 2024 12:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1719663422-23914-1" This is a multi-part message in MIME format... ------------=_1719663422-23914-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71792: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71792@debbugs.gnu.org. --=20 71792: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71792 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1719663422-23914-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71792-done) by debbugs.gnu.org; 29 Jun 2024 12:16:33 +0000 Received: from localhost ([127.0.0.1]:37304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNX0K-0006Cy-U3 for submit@debbugs.gnu.org; Sat, 29 Jun 2024 08:16:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNX0J-0006Cj-23 for 71792-done@debbugs.gnu.org; Sat, 29 Jun 2024 08:16:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNX0C-0004CA-FP; Sat, 29 Jun 2024 08:16:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VqovF/ejQvaX1g7m17RU11dZpEZVXt8aNOniJs5kI7o=; b=DUUUdeea5CD4 K2uC6L5PoDLt/SY0iL8haS8W98P5uqUZWLFOwfnoE43Pl7Do1EwBtgDnIi1C/hZqO2g/yE5Zq7hew Qb47fpYt0quKp0wmLLbCPfJFfMuI8irbeOrVp9E0xkDVKwP3fDShyxrAurbmxhoSa4RRNGwNxGcPn QpShvn0Z8qx/r+gQth45uf/mgGEcS6nHV5j8cZaor1JbwScXcB07JDZZ5VrtAwhyBU7UPwLe7ec1K qTOktDG1sqZNQPKwcm00co5R0ni4y6KrdmIDCVtpe8caeNNsMdLZT55bD55Sxu/qyJ98F+UTZHM5c IXk3ySHaTeZc+NFrwODV/g==; Date: Sat, 29 Jun 2024 15:16:20 +0300 Message-Id: <8634owj65n.fsf@gnu.org> From: Eli Zaretskii To: George Huebner In-Reply-To: (message from George Huebner on Thu, 27 Jun 2024 02:50:35 -0500) Subject: Re: bug#71792: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71792-done Cc: 71792-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: George Huebner > Date: Thu, 27 Jun 2024 02:50:35 -0500 > > Fixed a typo; this is consistent with the definition of > xwidget-webkit-scroll-down. Thanks, installed on the emacs-30 branch, and closing the bug. ------------=_1719663422-23914-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Jun 2024 08:20:48 +0000 Received: from localhost ([127.0.0.1]:40930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkN5-0007Ai-Jz for submit@debbugs.gnu.org; Thu, 27 Jun 2024 04:20:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:48428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMju0-0006Nb-5z for submit@debbugs.gnu.org; Thu, 27 Jun 2024 03:50:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMjtw-0001cm-Gt for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:50:41 -0400 Received: from mail-qv1-f49.google.com ([209.85.219.49]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMjtu-0004a3-Ur for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 03:50:40 -0400 Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6b4fdf56903so29242286d6.1 for ; Thu, 27 Jun 2024 00:50:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719474637; x=1720079437; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nIR0rCAcGHbBulS7KADMN06E5EZagSTPJhjW4RgOxlY=; b=BLLuFX3AiFO84GgXP2L0PsJpD+ibyLV692bc77pFqNY64YwOoZjLNeiWkAia3CWIyq SRmO+nZl3lJzlgbt/WOrVzqtLoNypvDkgRXui2t5EqAT/SMeaqbj+oD6qVb1LjJ9sC+w H18iMm4TRLJnp6oQUpugIpEERcfXWS3epSvwLsqcLQ2JtNzDFQhX2FKzGS0N/8RItLbJ tIA5G1IP80P6Pe4A8qTvBITzAu5eSgf8HZq1+Z4hym+9328goqBo04Z55ettcFSsWQei 4SSqshQ76tv2dfKMc9XQKKtj2env2u8nzXG1GelfUcmfq4hBNpcZ8r0Q2h26KOakZKW1 WgIQ== X-Gm-Message-State: AOJu0YxZ6pxPO5jnNDk0GFChaFnaiG3nh9I2YrX4Pnr5MCYSiz6ikAJH lp6QmcO3sxVOPQJ13GA/0CO8t7Q7ABoF/6WW/u86uq01xpTy0qrrrReucw== X-Google-Smtp-Source: AGHT+IEYRjkVA9KcpR+KOgJPdp8Qu9Hhg/pXu5IsyAhakqD9YY/uJ/cGU8MLjwQjzoJjxUBBPtJzww== X-Received: by 2002:ad4:576a:0:b0:6b5:4526:8be9 with SMTP id 6a1803df08f44-6b545268ee8mr146563606d6.51.1719474636564; Thu, 27 Jun 2024 00:50:36 -0700 (PDT) Received: from localhost (s-29-93.flex.volo.net. [76.191.29.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b5925139efsm3099586d6.57.2024.06.27.00.50.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 00:50:36 -0700 (PDT) From: George Huebner To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards Date: Thu, 27 Jun 2024 02:50:35 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=209.85.219.49; envelope-from=ghubs25@gmail.com; helo=mail-qv1-f49.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 27 Jun 2024 04:20:45 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --=-=-= Content-Type: text/plain; format=flowed Fixed a typo; this is consistent with the definition of xwidget-webkit-scroll-down. In GNU Emacs 29.1 (build 1, aarch64-apple-darwin23.4.0, Carbon Version 170 AppKit 2487.5) Windowing system distributor 'Apple Inc.', version 14.4.0 System Description: macOS 14.4 Configured using: 'configure --prefix=/nix/store/ismv7jzf3hcqziq5bpjfs54zd4qfjjn7-emacs-mac-macport-29.1 --disable-build-details --with-modules --without-gif --without-jpeg --without-png --without-tiff --without-x --without-xpm '--enable-mac-app=$$out/Applications' --with-gnutls --with-mac --with-xml2 --without-ns --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --with-mailutils --without-small-ja-dic --with-tree-sitter --without-xinput2 --without-xwidgets --without-dbus --without-selinux --with-xwidgets' --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-make-xwidget-webkit-scroll-backward-scroll-backw.patch >From d40761c0c26d28587187fd3f147804adac365563 Mon Sep 17 00:00:00 2001 From: George Huebner Date: Tue, 18 Jun 2024 17:14:41 -0500 Subject: [PATCH] Fix: make xwidget-webkit-scroll-backward scroll backwards * lisp/xwidget.el (xwidget-webkit-scroll-backward): Move hyphen out of %-formatter, changing semantics from a padding specifier to a negative sign. --- lisp/xwidget.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/xwidget.el b/lisp/xwidget.el index cca01c8..bf5987d 100644 --- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -378,7 +378,7 @@ one char." (> (window-hscroll) 0)) (set-window-hscroll nil (- (window-hscroll) n)) (xwidget-webkit-execute-script session - (format "window.scrollBy(%-d, 0);" + (format "window.scrollBy(-%d, 0);" (* n (window-font-width))))))) (defun xwidget-webkit-scroll-top () -- 2.44.1 --=-=-=-- ------------=_1719663422-23914-1--