GNU bug report logs - #71786
30.0.60; Compiler warnings in the Cygwin-w32 build

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ken Brown <kbrown <at> cornell.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71786: closed (30.0.60; Compiler warnings in the Cygwin-w32
 build)
Date: Wed, 26 Jun 2024 20:03:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 26 Jun 2024 16:01:52 -0400
with message-id <9fbf7847-a05a-4fe3-a1e8-bd4c72b2ed69 <at> cornell.edu>
and subject line Re: bug#71786: 30.0.60; Compiler warnings in the Cygwin-w32 build
has caused the debbugs.gnu.org bug report #71786,
regarding 30.0.60; Compiler warnings in the Cygwin-w32 build
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71786: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71786
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.60; Compiler warnings in the Cygwin-w32 build
Date: Wed, 26 Jun 2024 14:22:43 -0400

The following warnings occur in the Cygwin-w32 build, on both the
emacs-30 and the master branch:

../../src/w32fns.c: At top level:
../../src/w32fns.c:10581:1: warning: no previous prototype for ‘w32_get_resource’ 
[-Wmissing-prototypes]
10581 | w32_get_resource (const char *key, const char *name, LPDWORD lpdwtype)
      | ^~~~~~~~~~~~~~~~
../../src/w32fns.c:11288: warning: macro "DEFAULT_IMAGE_BASE" is not used [-Wunused-macros]
11288 | # define DEFAULT_IMAGE_BASE (ptrdiff_t)0x01000000
      |

This fixes them on both branches:

diff --git a/src/cygw32.h b/src/cygw32.h
index cc3414a39d92..2f265cab4adf 100644
--- a/src/cygw32.h
+++ b/src/cygw32.h
@@ -35,5 +35,6 @@ #define CYGW32_H

 extern void syms_of_cygw32 (void);
 extern char * w32_strerror (int error_no);
+extern LPBYTE w32_get_resource (const char * key, const char * name, LPDWORD type);

 #endif /* CYGW32_H */
diff --git a/src/w32fns.c b/src/w32fns.c
index b784a9a563d7..4c2f18abd084 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -11284,7 +11284,7 @@ #define BACKTRACE_LIMIT_MAX 62
    configure.ac.  */
 #if defined MINGW_W64 && EMACS_INT_MAX > LONG_MAX
 # define DEFAULT_IMAGE_BASE (ptrdiff_t)0x400000000
-#else  /* 32-bit MinGW build */
+#elif !defined CYGWIN  /* 32-bit MinGW build */
 # define DEFAULT_IMAGE_BASE (ptrdiff_t)0x01000000
 #endif

OK for the emacs-30 branch?

Ken

[Message part 3 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71786-done <at> debbugs.gnu.org
Subject: Re: bug#71786: 30.0.60; Compiler warnings in the Cygwin-w32 build
Date: Wed, 26 Jun 2024 16:01:52 -0400

On 6/26/2024 2:41 PM, Eli Zaretskii wrote:
>> Date: Wed, 26 Jun 2024 14:22:43 -0400
>> From: Ken Brown <kbrown <at> cornell.edu>
>> OK for the emacs-30 branch?
> 
> Yes, thanks.

Done. Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.