Subject: Re: [PATCH v3 14/29] gnu: caja-extensions: update to 1.28.0.

From: Liliana Marie Prikler <[email-masked]>
Date: Sun, 07 Jul 2024 10:02:40 +0200

Am Freitag, dem 28.06.2024 um 07:05 -0700 schrieb Andy Tai:
> * gnu/packages/mate.scm (caja-extensions): Update to 1.28.0
>   [arguments](configure-flags): Disable AV support as needed
> gstreamer
>   components are Rust packages not in Guix at this time.
It's [arguments]<#:configure-flags> --- or [#:configure-flags] for
short.  Also please don't indent the ChangeLog.

>  gnu/packages/mate.scm | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
> index b99c15dd94..6fc20181d8 100644
> --- a/gnu/packages/mate.scm
> +++ b/gnu/packages/mate.scm
> @@ -51,6 +51,7 @@ (define-module (gnu packages mate)
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages gnupg)
> +  #:use-module (gnu packages gstreamer)
>    #:use-module (gnu packages gtk)
>    #:use-module (gnu packages image)
>    #:use-module (gnu packages imagemagick)
> @@ -846,14 +847,14 @@ (define-public caja
>  (define-public caja-extensions
>    (package
>      (name "caja-extensions")
> -    (version "1.26.1")
> +    (version "1.28.0")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (string-append "mirror://mate/" (version-major+minor
> version) "/"
>                             "caja-extensions-" version ".tar.xz"))
>         (sha256
> -        (base32
> "086mw7650n8blnr2wkg9xdb6lhwqamcbkk5575i2s90hzbiik72q"))))
> +        (base32
> "0x9ikq8biaq08wzj0qqpmy8k5w7axqimigfgf7i5z0s00xg6r66j"))))
>      (build-system glib-or-gtk-build-system)
>      (arguments
>       `(#:configure-flags (list "--enable-sendto"
> @@ -864,6 +865,11 @@ (define-public caja-extensions
>                                 "--enable-image-converter"
>                                 "--enable-open-terminal" "--enable-
> share"
>                                 "--enable-wallpaper" "--enable-xattr-
> tags"
> +                               "--enable-av=no"
> +                               ; Guix does not have rust packages
> +                                               ; gstreamer-tag-1.0
> +                                           ; gstreamer-pbutils-1.0
> +                               ; so disable search for them
These lines will likely not render as expected once anyone hits C-;
You might want to add them *before* the flag, too.

Cheers