GNU bug report logs - #71776
31.0.50; [PATCH] js-ts-mode: conforming use of font lock faces in jsdoc.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71776 in the body.
You can then email your comments to 71776 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50;
 [PATCH] js-ts-mode: conforming use of font lock faces in jsdoc.
Date: Tue, 25 Jun 2024 16:16:21 +0200

[Message part 1 (text/plain, inline)]

Hi,
The use of font lock faces by jsdoc in js-ts-mode is different from that done in 
other major-modes such as java-mode or c++-mode. This patch makes them more similar.

Thanks.
Vincenzo

[0001-Conforming-use-of-font-lock-faces-in-jsdoc.patch (text/x-patch, attachment)]

Message #8 received at 71776 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>, Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 71776 <at> debbugs.gnu.org
Subject: Re: bug#71776: 31.0.50;
 [PATCH] js-ts-mode: conforming use of font lock faces in jsdoc.
Date: Thu, 27 Jun 2024 12:47:20 +0300

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Date: Tue, 25 Jun 2024 16:16:21 +0200
> 
> The use of font lock faces by jsdoc in js-ts-mode is different from that done in 
> other major-modes such as java-mode or c++-mode. This patch makes them more similar.

Thanks.

Dmitry, any comments?  On which branch should we install this, if you
agree with the changes?

Message #11 received at 71776 <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 71776 <at> debbugs.gnu.org
Subject: Re: bug#71776: 31.0.50;
 [PATCH] js-ts-mode: conforming use of font lock faces in jsdoc.
Date: Thu, 27 Jun 2024 12:33:15 +0200

In data giovedì 27 giugno 2024 11:47:20 CEST, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > Date: Tue, 25 Jun 2024 16:16:21 +0200
> > 
> > The use of font lock faces by jsdoc in js-ts-mode is different from that
> > done in other major-modes such as java-mode or c++-mode. This patch makes
> > them more similar.
> Thanks.
> 
> Dmitry, any comments?  On which branch should we install this, if you
> agree with the changes?
Please wait. I noticed this morning that there are problems with multiple 
comment blocks in the same file. 

Thanks.
V.

Message #14 received at 71776 <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 71776 <at> debbugs.gnu.org
Subject: Re: bug#71776: 31.0.50;
 [PATCH] js-ts-mode: conforming use of font lock faces in jsdoc.
Date: Thu, 27 Jun 2024 21:20:32 +0200

[Message part 1 (text/plain, inline)]

In data giovedì 27 giugno 2024 12:33:15 CEST, Vincenzo Pupillo ha scritto:
> In data giovedì 27 giugno 2024 11:47:20 CEST, Eli Zaretskii ha scritto:
> > > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > > Date: Tue, 25 Jun 2024 16:16:21 +0200
> > > 
> > > The use of font lock faces by jsdoc in js-ts-mode is different from that
> > > done in other major-modes such as java-mode or c++-mode. This patch
> > > makes
> > > them more similar.
> > 
> > Thanks.
> > 
> > Dmitry, any comments?  On which branch should we install this, if you
> > agree with the changes?
> 
> Please wait. I noticed this morning that there are problems with multiple
> comment blocks in the same file.
> 
> Thanks.
> V.

Hi, this patch fix the treesit range rule for the jsdoc parser. 
As you can see from the attached screenshots, with the previous rule the 
parser throws an error (look at the modeline). With the new one, it doesn't 
happen anymore, and now the font lock is correct (I applied both patches I 
sent for this bug).

Thanks.
Vincenzo

[0001-Fix-treesit-range-rule-for-jsdoc.patch (text/x-patch, attachment)]

[js-jsdoc-master.png (image/png, attachment)]

[js_jsdoc_with_patch.png (image/png, attachment)]

Message #17 received at 71776 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: Damien Cassou <damien <at> cassou.me>, 71776 <at> debbugs.gnu.org
Subject: Re: bug#71776: 31.0.50; [PATCH] js-ts-mode: conforming use of font
 lock faces in jsdoc.
Date: Fri, 28 Jun 2024 03:50:10 +0300

Hi!

On 27/06/2024 12:47, Eli Zaretskii wrote:
>> From: Vincenzo Pupillo<v.pupillo <at> gmail.com>
>> Date: Tue, 25 Jun 2024 16:16:21 +0200
>>
>> The use of font lock faces by jsdoc in js-ts-mode is different from that done in
>> other major-modes such as java-mode or c++-mode. This patch makes them more similar.
> Thanks.
> 
> Dmitry, any comments?  On which branch should we install this, if you
> agree with the changes?

It looks like an improvement (thanks!), and as a change to the feature 
added just recently, should go to emacs-30 - the second revision of the 
patch, naturally.

Also Cc'ing Damien who did the original work.

Message #22 received at 71776 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dmitry <at> gutov.dev>, damien <at> cassou.me
Cc: 71776 <at> debbugs.gnu.org, v.pupillo <at> gmail.com
Subject: Re: bug#71776: 31.0.50; [PATCH] js-ts-mode: conforming use of font
 lock faces in jsdoc.
Date: Sat, 06 Jul 2024 10:54:11 +0300

Ping! Damien, would you please chime in and comment on the patch?

> Date: Fri, 28 Jun 2024 03:50:10 +0300
> Cc: 71776 <at> debbugs.gnu.org, Damien Cassou <damien <at> cassou.me>
> From: Dmitry Gutov <dmitry <at> gutov.dev>
> 
> Hi!
> 
> On 27/06/2024 12:47, Eli Zaretskii wrote:
> >> From: Vincenzo Pupillo<v.pupillo <at> gmail.com>
> >> Date: Tue, 25 Jun 2024 16:16:21 +0200
> >>
> >> The use of font lock faces by jsdoc in js-ts-mode is different from that done in
> >> other major-modes such as java-mode or c++-mode. This patch makes them more similar.
> > Thanks.
> > 
> > Dmitry, any comments?  On which branch should we install this, if you
> > agree with the changes?
> 
> It looks like an improvement (thanks!), and as a change to the feature 
> added just recently, should go to emacs-30 - the second revision of the 
> patch, naturally.
> 
> Also Cc'ing Damien who did the original work.

Message #25 received at 71776 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Eli Zaretskii <eliz <at> gnu.org>, Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 71776 <at> debbugs.gnu.org, v.pupillo <at> gmail.com
Subject: Re: bug#71776: 31.0.50; [PATCH] js-ts-mode: conforming use of font
 lock faces in jsdoc.
Date: Sat, 06 Jul 2024 10:51:53 +0200

Hi Eli,

Eli Zaretskii <eliz <at> gnu.org> writes:
> Ping! Damien, would you please chime in and comment on the patch?

I did that privately last week, sorry :-). The patch looks good to me.

Thank you everyone for your work.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Message #30 received at 71776-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Damien Cassou <damien <at> cassou.me>
Cc: dmitry <at> gutov.dev, v.pupillo <at> gmail.com, 71776-done <at> debbugs.gnu.org
Subject: Re: bug#71776: 31.0.50; [PATCH] js-ts-mode: conforming use of font
 lock faces in jsdoc.
Date: Sat, 06 Jul 2024 13:57:11 +0300

> From: Damien Cassou <damien <at> cassou.me>
> Cc: v.pupillo <at> gmail.com, 71776 <at> debbugs.gnu.org
> Date: Sat, 06 Jul 2024 10:51:53 +0200
> 
> Hi Eli,
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> > Ping! Damien, would you please chime in and comment on the patch?
> 
> I did that privately last week, sorry :-). The patch looks good to me.
> 
> Thank you everyone for your work.

Thanks, installed on the emacs-3w0 release branch, and closing the
bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.