GNU bug report logs - #71760
31.0.50; Filling jsdoc text doesn't work in js-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Damien Cassou <damien <at> cassou.me>, 71760 <at> debbugs.gnu.org
Subject: bug#71760: [PATCH] js-ts-mode: Fix filling of jsdoc blocks
Date: Sat, 3 Aug 2024 00:34:24 -0700

> On Aug 1, 2024, at 2:26 PM, Dmitry Gutov <dmitry <at> gutov.dev> wrote:
> 
> Hi Yuan,
> 
> On 01/08/2024 10:36, Yuan Fu wrote:
>> Actually, the original patch is perfectly good. The “simplification” I have in mind is more or less unnecessary.
> 
> I think Damien is saying that patch#2 from his submission is not necessary with your fix (commit 74bb1e5897f, IIUC).
> 
> So do you think it's a good idea to backport it to emacs-30?

I’d rather apply Damien’s patch to emacs-30, that’s a simple fix and doesn’t change the filling behavior. The change I applied to master is more substantial, and apparently introduced another regression that I now need to fix :-(

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.