GNU bug report logs - #71736
Small cleanup patches for lua-ts-mode

Previous Next

Full log

Message #28 received at 71736-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: 71736-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode
Date: Fri, 28 Jun 2024 12:56:09 -0700

Version: 30.1

john muhl <jm <at> pub.pink> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> I think patch 2 should go to master, but it doesn't apply cleanly.
>> John, could you please rebase it and resend?
>
> Oops, I see now it included a bit of unrelated local changes.
>
> Here’s another try. I rebased it and checked that it applies to
> emacs-30 and master.

Thanks!

> Out of curiousity, what makes it unfit for the emacs-30 branch?

We prefer not to put code cleanups on the release branch.

So I've now pushed it to `master`, and I'm closing this bug report.

BTW, is there any reason not to use `defvar-keymap' in lua-ts-mode.el?
Does it need to be compatible with Emacs 28?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.