From unknown Sun Sep 21 01:08:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71736 <71736@debbugs.gnu.org> To: bug#71736 <71736@debbugs.gnu.org> Subject: Status: Small cleanup patches for lua-ts-mode Reply-To: bug#71736 <71736@debbugs.gnu.org> Date: Sun, 21 Sep 2025 08:08:29 +0000 retitle 71736 Small cleanup patches for lua-ts-mode reassign 71736 emacs submitter 71736 john muhl severity 71736 normal tag 71736 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 10:43:24 2024 Received: (at submit) by debbugs.gnu.org; 23 Jun 2024 14:43:25 +0000 Received: from localhost ([127.0.0.1]:35399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLORA-0006Xi-F5 for submit@debbugs.gnu.org; Sun, 23 Jun 2024 10:43:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:56394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLOR8-0006XU-5S for submit@debbugs.gnu.org; Sun, 23 Jun 2024 10:43:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLOP1-0001Qj-5v for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 10:41:11 -0400 Received: from fhigh1-smtp.messagingengine.com ([103.168.172.152]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLOOz-0003WI-Np for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 10:41:10 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id C11B31140102 for ; Sun, 23 Jun 2024 10:41:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 23 Jun 2024 10:41:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1; t=1719153668; x=1719240068; bh=Hi2/mXf4MA9RKkoGM++GbVI0Rf3L+rYj SgrdHmZUtOY=; b=OZF9vzMAFjuMYkWUAA93FWNXFhClJjTlgWKj1G/YmiGIA3Ug y0860R46+lceGqTogVSvrNLmQVzOTi/9duRakxG0sZLn7hJWRfrTIhaov66NfSFe YRR5TgjXZIXdstIMx0v2xDMro8kAjvpRAe/PiMAX/tkd+ChZUdox92pbqNZYy9Qy lPq8ypspG5vM0bymQbRAKOBgsUXizmaTyjzKxG2Dbgf9ougz570G+koH874vRd2U fHR9YKewXOjJYsumNvkcCyelDZ5Ii29ABx2qg52M0EBWyOjr3u5reuC39Zw8GJBf tHvokPOe5Q2y1Z1M1TRwfwrOgsatFERJWVlnjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1719153668; x=1719240068; bh=Hi2/mXf4MA9RKkoGM++GbVI0Rf3L+rYjSgr dHmZUtOY=; b=bipENZb8WgPhJuWTdTVFNMh6+GR0wgXDh+yirL/o0DH74aLtuVV orYV8cD6Rix17CFex01YZT5lafZthiu9fvpg78Cv5GuT94Cx8veqzudUu6FR9ZB0 YzUW5CY90OcRRzt9i5dRWKEiULandHgQm425U2oj49CCoxoBWE1Ss2c26RBxODfz YUvHDhgpf7atcq3Bgg59gDgXWvAxwQKGZupCPnuBQhmhdbkyCHFhdyq1TOVmpv/R VX05sGloy7izsyktgOZpKnv3biC5vw79LIkEulMHmHwSt2GsVoIWhTS1kxjQ7BRf 1a1zLceI8c+J13pDP43/Km7X4oOEDRzs/tQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeefledgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehttdertddttd dtnecuhfhrohhmpehjohhhnhcumhhuhhhluceojhhmsehpuhgsrdhpihhnkheqnecuggft rfgrthhtvghrnhepgefhudekueehudeugffhgfegfeevhfetjeehhfeuleffgfeguedtff dvteeutedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepjhhmsehpuhgsrdhpihhnkh X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 23 Jun 2024 10:41:08 -0400 (EDT) From: john muhl To: bug-gnu-emacs@gnu.org Subject: Small cleanup patches for lua-ts-mode Date: Sun, 23 Jun 2024 09:41:06 -0500 Message-ID: <87ikxzafi5.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=103.168.172.152; envelope-from=jm@pub.pink; helo=fhigh1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Tags: patch Following up with a few trivial cleanups in lua-ts-mode. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 10:59:08 2024 Received: (at 71736) by debbugs.gnu.org; 23 Jun 2024 14:59:08 +0000 Received: from localhost ([127.0.0.1]:36056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLOgO-0007AF-2l for submit@debbugs.gnu.org; Sun, 23 Jun 2024 10:59:08 -0400 Received: from fhigh1-smtp.messagingengine.com ([103.168.172.152]:32979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLOgM-00079c-AT for 71736@debbugs.gnu.org; Sun, 23 Jun 2024 10:59:07 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 85AF31140100 for <71736@debbugs.gnu.org>; Sun, 23 Jun 2024 10:59:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 23 Jun 2024 10:59:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1719154740; x=1719241140; bh=2ehC+Lnw+T s8RPbATLnrCf696d7jYnp/N4jzJZxuEF8=; b=o6EYq4rfRK+I7WkLWcHgNVtqY3 Nga8sZmLn4Yr41mDRnhIx8aDMOOeEQ/XDaj0/z+mu9qhtuJpTdbji6tgll8p7uMp +olMM1MkYHj1OUi3hM3LGJ4GFkC5NDME3oy1u7J3J2V6lnJWQVSnLYXoR4BpKdAO dErbyQBCFhZNUc3P91wqTt+dMbo33vZaQgj7GC8Bv6G2ai8dcQKkEXVY5WzTJ5Hq 6tpyeGtcZDRACdfxJeONRN4uqAet3Eased7D/ZUrPZlJqa2twt2RDkVtNJqdp6u5 D7L6s64Y3lN00c3Mg8mPdQbOhJgF1oI1MRxhUZcDqvv6ZdDtiKLTCpjMZhxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719154740; x=1719241140; bh=2ehC+Lnw+Ts8RPbATLnrCf696d7j Ynp/N4jzJZxuEF8=; b=k3i3LHc8B/oGjeE7e50Z7k1cz+u22Ubp0/usjOOjxSwU 5PdVfprj2kpu0Oma4YCkUZQhyncT/yCus9NWvOzNZ5VHLkojBenYDZaIsmaZDGpN iYgXVWgDo4/6JS5RfOuPBBlkFoIb4Y7Of76P7csmP+0oLoXcwt8NTYN39RJQt7Sc E69R9SAj7d9xHyu+4KRjUWLEBoQjbEQtfo/ejHkoVNG5FLJISEWUBckQDter7tZU xmd+MzQS5/xw/X6d0p463nGCr0/91rikjgnOeM64N3zXshKqJl6fbLDDNB3X+u3y 8W9bz/uxLGa7kGrU6Lb2UTKdt2HgT4w+Fn9dgH6baw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeefledgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesmhdtre ertdertdenucfhrhhomhepjhhohhhnuchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeen ucggtffrrghtthgvrhhnpefgleehkeehveevtdefjedtuddviefhgfekudelveeuheekge ffleeuvdetheetueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehjmhesphhusgdrphhinhhk X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <71736@debbugs.gnu.org>; Sun, 23 Jun 2024 10:58:59 -0400 (EDT) From: john muhl To: 71736@debbugs.gnu.org Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode In-Reply-To: <87ikxzafi5.fsf@pub.pink> (john muhl's message of "Sun, 23 Jun 2024 09:41:06 -0500") References: <87ikxzafi5.fsf@pub.pink> User-Agent: mu4e 1.12.1; emacs 30.0.50 Date: Sun, 23 Jun 2024 09:58:59 -0500 Message-ID: <877cefaeoc.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71736 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain john muhl writes: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-eglot-ensure-option-to-lua-ts-mode-hook.patch >From ffb8a2be042c887a77b7fa2ff2640e5f68925c9d Mon Sep 17 00:00:00 2001 From: john muhl Date: Wed, 15 Nov 2023 12:45:18 -0600 Subject: [PATCH 1/4] ; Add 'eglot-ensure' option to 'lua-ts-mode-hook' * lisp/progmodes/lua-ts-mode.el (lua-ts-mode-hook): Add an option to enable Eglot from the lua-ts-mode-hook. (bug#71736) --- lisp/progmodes/lua-ts-mode.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 57dba5e5568..9801f339fdf 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -58,7 +58,8 @@ lua-ts (defcustom lua-ts-mode-hook nil "Hook run after entering `lua-ts-mode'." :type 'hook - :options '(flymake-mode + :options '(eglot-ensure + flymake-mode hs-minor-mode outline-minor-mode) :version "30.1") -- 2.45.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-Use-keymap-set-in-lua-ts-mode-bug-71736.patch >From 1d627c785ca84498b7616a498b6d9f899915cf7b Mon Sep 17 00:00:00 2001 From: john muhl Date: Wed, 22 May 2024 12:23:19 -0500 Subject: [PATCH 2/4] ; Use 'keymap-set' in 'lua-ts-mode' (bug#71736) * lisp/progmodes/lua-ts-mode.el (lua-ts-mode-map): Replace 'define-key' with 'keymap-set'. --- lisp/progmodes/lua-ts-mode.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 9801f339fdf..1d995e20df4 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -740,11 +740,11 @@ lua-ts-inferior--write-history (defvar lua-ts-mode-map (let ((map (make-sparse-keymap "Lua"))) - (define-key map "\C-c\C-n" 'lua-ts-inferior-lua) - (define-key map "\C-c\C-c" 'lua-ts-send-buffer) - (define-key map "\C-c\C-l" 'lua-ts-send-file) - (define-key map "\C-c\C-r" 'lua-ts-send-region) - (define-key map "\C-c\C-t" 'lua-ts-send-thing) + (keymap-set map "C-c C-n" 'lua-ts-inferior-lua) + (keymap-set map "C-c C-c" 'lua-ts-send-buffer) + (keymap-set map "C-c C-l" 'lua-ts-send-file) + (keymap-set map "C-c C-r" 'lua-ts-send-region) + (keymap-set map "C-c C-t" 'lua-ts-send-thing) map) "Keymap for `lua-ts-mode' buffers.") -- 2.45.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0003-lua-ts-mode.el-Reword-doc.-bug-71736.patch >From ebb8f0f29a13034e6626dfd23f50945cd5dcbd0e Mon Sep 17 00:00:00 2001 From: john muhl Date: Wed, 12 Jun 2024 10:41:03 -0500 Subject: [PATCH 3/4] ; * lua-ts-mode.el: Reword doc. (bug#71736) --- lisp/progmodes/lua-ts-mode.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 1d995e20df4..79fbde1f2d4 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -117,7 +117,7 @@ lua-ts-inferior-history (defcustom lua-ts-indent-continuation-lines t "Controls how multi-line if/else statements are aligned. -If t, then continuation lines are indented by `lua-ts-indent-offset': +If non-nil, then continuation lines are indented by `lua-ts-indent-offset': if a and b then -- 2.45.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0004-Remove-useless-require-of-rx-in-lua-ts-mode.patch >From abecae7d631f4b313fe8510f47e480f1a82bb4ad Mon Sep 17 00:00:00 2001 From: john muhl Date: Thu, 13 Jun 2024 15:19:04 -0500 Subject: [PATCH 4/4] ; Remove useless require of 'rx' in 'lua-ts-mode' * lisp/progmodes/lua-ts-mode.el: No need to require 'rx' since it is preloaded. (bug#71736) --- lisp/progmodes/lua-ts-mode.el | 3 --- 1 file changed, 3 deletions(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 79fbde1f2d4..5a73a9fc01c 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -34,9 +34,6 @@ (require 'comint) (require 'treesit) -(eval-when-compile - (require 'rx)) - (declare-function treesit-induce-sparse-tree "treesit.c") (declare-function treesit-node-child-by-field-name "treesit.c") (declare-function treesit-node-child-count "treesit.c") -- 2.45.2 --=-=-= Content-Type: text/plain > Tags: patch > > Following up with a few trivial cleanups in lua-ts-mode. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 11:52:18 2024 Received: (at 71736) by debbugs.gnu.org; 23 Jun 2024 15:52:18 +0000 Received: from localhost ([127.0.0.1]:38275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLPVq-0000mn-4g for submit@debbugs.gnu.org; Sun, 23 Jun 2024 11:52:18 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:56708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLPVn-0000mP-Qg for 71736@debbugs.gnu.org; Sun, 23 Jun 2024 11:52:16 -0400 Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-57cd26347d3so3666482a12.1 for <71736@debbugs.gnu.org>; Sun, 23 Jun 2024 08:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719157869; x=1719762669; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=DyGAjDwbp96J4aOLO0Q139F6Q5+xjE/fo55uOuI2kYk=; b=D+ZtcQxERwfmH6nvxoSisvoyAxjh6A8WfXyUG1GDy0WxlnDZe/tfRgYSYqfJ7oIIQs e6LoSdWe5eHs02DBKYeBb7qez1vq4Ft46mS6kukRnSRI1ViPAVfYlInD/hM4M4F+Jdo5 uiKfI43PMDN9YyYZNIA8bXa34ByBBUEYwmAFItXYhkb/gybla+tlEoty5V7+1Mnqsxfx QKJbA+L3sNa2Nl6LyXPWNapTHhgnpJOuOHdE0fMlozmidfvfoOwEA8tGRXwga67nei53 6UutFAeltO/d+082Co4ptGzcVv4tpjBAoQ7Z/ScBIP+F5eLo+O1axXugUS990fWidoFO ag7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719157869; x=1719762669; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DyGAjDwbp96J4aOLO0Q139F6Q5+xjE/fo55uOuI2kYk=; b=o0O/TLJ2JQrMTZy+DzHBbdDkM72g91K39/m+BTvzJL2ezzhZeAmeDUyvVkTqMsrRf5 J9CgOcSo/yBTARMn1EjSsbxKeiRZfpS4USPXwiIIPGZ0gDZFcl9jrRuz0PhYrsxiSGDP lCMNzYNkncRu0Dw5sqL5NRA+i0wqBvf98mXFKXE8vmif3YsIXE5o1LXI3UnFBE+C/Sl5 hdRl7yXmuA4KEdzcrP4nrwOWinAsvoIWam7e663OvX56DGduB57Lmuag6DNlnXncj3Ru rW6cNbWK5dNCAFJeoLNYaphYYXBcBnV6QVBj41HJ5s95F7Vy7A7M6/CM7hhQc8URPVn9 N/cQ== X-Forwarded-Encrypted: i=1; AJvYcCXVE4gqhH3Uy7yYTG/qBIy6Gkja53lPZkpR1GZAScv1VqtPy/p6SXZdlygU5/uoDOEuf9EWPxHlnNTg/HfdkDO4ImEQAE4= X-Gm-Message-State: AOJu0YyLLdRs5O007J4KrsLsYe99+kxNe1LDNo7VwdmV13eE0JVKwsxG 6c1e4OCDwGmPv5Y6TQ63fmaDYMs0QCNocHyQRRU8t2WBTpFREM+rcuonKY633vNW3D6ZDF73Cfq qezXzvRumvYLbrl0GJi4rX3l0HPQ= X-Google-Smtp-Source: AGHT+IGjmlR3QSrHAJmbL/z4upcWZi1LvoDvwhERZsVXgINUrG43r1gnd6Nrd5NhfE83zmzhrcb1xOnr+3FnrOWbzNw= X-Received: by 2002:a50:c303:0:b0:57c:6861:d72b with SMTP id 4fb4d7f45d1cf-57d4bd56331mr1262325a12.9.1719157869145; Sun, 23 Jun 2024 08:51:09 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 23 Jun 2024 08:51:08 -0700 From: Stefan Kangas In-Reply-To: <877cefaeoc.fsf@pub.pink> References: <87ikxzafi5.fsf@pub.pink> <877cefaeoc.fsf@pub.pink> MIME-Version: 1.0 Date: Sun, 23 Jun 2024 08:51:08 -0700 Message-ID: Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode To: john muhl , 71736@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71736 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) john muhl writes: > From abecae7d631f4b313fe8510f47e480f1a82bb4ad Mon Sep 17 00:00:00 2001 > From: john muhl > Date: Thu, 13 Jun 2024 15:19:04 -0500 > Subject: [PATCH 4/4] ; Remove useless require of 'rx' in 'lua-ts-mode' > > * lisp/progmodes/lua-ts-mode.el: No need to require 'rx' since it > is preloaded. (bug#71736) I don't think "rx" is preloaded. In emacs -Q, (featurep 'rx) is nil. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 12:12:33 2024 Received: (at 71736) by debbugs.gnu.org; 23 Jun 2024 16:12:33 +0000 Received: from localhost ([127.0.0.1]:39055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLPpR-0001Sl-3J for submit@debbugs.gnu.org; Sun, 23 Jun 2024 12:12:33 -0400 Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153]:42911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLPpO-0001SP-Te for 71736@debbugs.gnu.org; Sun, 23 Jun 2024 12:12:32 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 030BA11400AC; Sun, 23 Jun 2024 12:12:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 23 Jun 2024 12:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1719159143; x=1719245543; bh=WvCiQRA7Gucz63i8cnt91G9RTI89coFyT//iR0RYtnk=; b= rLfdgGoWJiStGCLIeS2Evr98W8qFnKqDYn3KVWwY9O7UeXJWlf9Jvz6CjYQ1cD9f Kob98NEIk170Rj87jjtNFhfojEakWHfgZPIH8VW9BBvDKyfjFTO+dCQsanLJMA97 0yHETnbygTFbB3mck0VaOLDkkygy47ji3kFZfKy0vcVme9guxS14oR1y2fnkw59x dJLtwqMMRbDxeHN6ZLnYjlkQraOPID7awuzZzSLVIFbpE5gOOmatSmEMQ/vH6J7P kllIy/SUX9nfGTtk5mEs86CvK3V29BZ8Sugj51DeAMeGiXujTd1dKA2ACl5rYoKw qrufy/hIQvb3RHCp85YX/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1719159143; x= 1719245543; bh=WvCiQRA7Gucz63i8cnt91G9RTI89coFyT//iR0RYtnk=; b=h hhrtnnXZ1gfDJ5BU7t6qQvVmP/Y9aMYjhglzkl2oXlUjqEO8eRFQgk7LyXINJiQc XTi/QJQMvutV+SF3LVVSxyuKR/uzzWRKKJ+6/zvj6kqyatxqOYp33/QHoJN+DZiw WWav59Zc+hg7pV4b9L+IaWoRy4axpB/QQRUH4/8/eEa9J4nvKJQqf7rxAGeiMzmP mjcoDO13aw8F7ewLIxzZcb5t+dgXWj+kps9QoNQENGiLGxnXHJfWLi9xM0zeFTuY e6vOigo9XqqDakxnO0rXTZuAhCxQaUqw2kDHWUhr/aECeL9YO3eJC34dClXR6QAD lFieGzbGvamrJ4g+ju7Yg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeefledgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpehjohhh nhcumhhuhhhluceojhhmsehpuhgsrdhpihhnkheqnecuggftrfgrthhtvghrnhepgeevhe dvtdetvdekuddvtddthefhvdfggfdvgfeitdejudehhfffjedtvdevveeknecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhmsehpuhgsrdhpih hnkh X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Jun 2024 12:12:22 -0400 (EDT) From: john muhl To: Stefan Kangas Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode In-Reply-To: (Stefan Kangas's message of "Sun, 23 Jun 2024 08:51:08 -0700") References: <87ikxzafi5.fsf@pub.pink> <877cefaeoc.fsf@pub.pink> User-Agent: mu4e 1.12.1; emacs 30.0.50 Date: Sun, 23 Jun 2024 11:12:21 -0500 Message-ID: <87bk3r8wpm.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71736 Cc: 71736@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: > john muhl writes: > >> From abecae7d631f4b313fe8510f47e480f1a82bb4ad Mon Sep 17 00:00:00 2001 >> From: john muhl >> Date: Thu, 13 Jun 2024 15:19:04 -0500 >> Subject: [PATCH 4/4] ; Remove useless require of 'rx' in 'lua-ts-mode' >> >> * lisp/progmodes/lua-ts-mode.el: No need to require 'rx' since it >> is preloaded. (bug#71736) > > I don't think "rx" is preloaded. In emacs -Q, (featurep 'rx) is nil. I guess I got confused. I tried: $ src/emacs -Q -batch -eval '(message "%s" (rx bos "heyo" eos))' \`heyo\` which led me to think it didn=E2=80=99t need to be required. Feel free to discard. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 05:02:23 2024 Received: (at 71736) by debbugs.gnu.org; 27 Jun 2024 09:02:23 +0000 Received: from localhost ([127.0.0.1]:40978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMl1K-0008Fl-UM for submit@debbugs.gnu.org; Thu, 27 Jun 2024 05:02:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMl1I-0008FX-UQ for 71736@debbugs.gnu.org; Thu, 27 Jun 2024 05:02:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMl19-0001rg-U4; Thu, 27 Jun 2024 05:02:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=1VlF8hjHSHQttuUsZIiPJydDQcmXod3GFeekwxp/do4=; b=nfrxypse4v4eSQrAcC9d PGL26yjCU6APL2Or8Ue7MxSuMnFpEdfasQqKR6g+8OdeV6A18HGfnmoJDntUkVc9N1vy+L+g2i+rx Fuy7a/QDM7w7K1Xkpyxq6bUCQP/7uSmOvHyzFVdGlg5l+8MTXTj+LkmcBBUn7vwsZVOhBJhkmr7Fe k2zzUqsrXpzQVzfhlTjynhN0swICR7LAbLzkeIUVRuTvLPCPMGxHUVwG7OHa+ogiaiclTOHIAVGBV cDxNZQMaD7ZuBgfXS2p3y20MhV2+Q2BTYJmBjoQSFs/bTs+fy2Wtznq+Xrp9ezK8fzk4RdovtPL0R Gmqcy58dyu0QMA==; Date: Thu, 27 Jun 2024 12:02:06 +0300 Message-Id: <86msn669o1.fsf@gnu.org> From: Eli Zaretskii To: john muhl In-Reply-To: <87bk3r8wpm.fsf@pub.pink> (message from john muhl on Sun, 23 Jun 2024 11:12:21 -0500) Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode References: <87ikxzafi5.fsf@pub.pink> <877cefaeoc.fsf@pub.pink> <87bk3r8wpm.fsf@pub.pink> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71736 Cc: stefankangas@gmail.com, 71736@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 71736@debbugs.gnu.org > From: john muhl > Date: Sun, 23 Jun 2024 11:12:21 -0500 > > Stefan Kangas writes: > > > john muhl writes: > > > >> From abecae7d631f4b313fe8510f47e480f1a82bb4ad Mon Sep 17 00:00:00 2001 > >> From: john muhl > >> Date: Thu, 13 Jun 2024 15:19:04 -0500 > >> Subject: [PATCH 4/4] ; Remove useless require of 'rx' in 'lua-ts-mode' > >> > >> * lisp/progmodes/lua-ts-mode.el: No need to require 'rx' since it > >> is preloaded. (bug#71736) > > > > I don't think "rx" is preloaded. In emacs -Q, (featurep 'rx) is nil. > > I guess I got confused. I tried: > > $ src/emacs -Q -batch -eval '(message "%s" (rx bos "heyo" eos))' > \`heyo\` > > which led me to think it didn’t need to be required. Feel free to > discard. Discard all of the patches or just that 4/4 part? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 01:59:41 2024 Received: (at 71736) by debbugs.gnu.org; 28 Jun 2024 05:59:41 +0000 Received: from localhost ([127.0.0.1]:51401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4e5-0000dL-4i for submit@debbugs.gnu.org; Fri, 28 Jun 2024 01:59:41 -0400 Received: from mail-lf1-f44.google.com ([209.85.167.44]:51415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4e3-0000d9-Cg for 71736@debbugs.gnu.org; Fri, 28 Jun 2024 01:59:40 -0400 Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-52cdcd26d61so218076e87.2 for <71736@debbugs.gnu.org>; Thu, 27 Jun 2024 22:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719554315; x=1720159115; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=VR6NQZqIYMBvXqpOzdkRQ1vSRKChPYLZU7wFOaTdftU=; b=kW4tN9ekYWoKZgW5qa3irRKO0B6FeZeZrNxF2WYqYmP4x+QJmPYwChdYt+sMZogF/O vkOlBjGhaTT6DUiJfcBBvXQFbXuhpavEudsclNToId6wkMX+e8+QhwuLgW18h3MZzZzV Z9nES8/6CrjXwU/xLHPMgxYFQ2yFHnnaIkWCWZ3oz+X2fmp/FuEQbwWH+GvZ+Z/exBIZ mQ8xn+gXvHIJTDJ8HH7YCSsRbWRrh7PsADLxeaqDFJveGMeKgBcxteyE1Vlt/KFvphyZ mdv5LwVjb3xrHqAI3JRh/MOu+ryczmYuSYQJgwoxh6HHmOMrmhoVpHBRxhhHUFLiETvX Mf/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719554315; x=1720159115; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VR6NQZqIYMBvXqpOzdkRQ1vSRKChPYLZU7wFOaTdftU=; b=JHCkkqXPVuR65osL8fFtxKTYI3IDWpPgcWe/vAwSQpsL4ocziwKuJyUBsJltWSUw4W /IavK7paR78DCIMbyRFxVOApyEyZULcQiTYrAVHItZJUdna/8AjlF4l5uKTVCHwyP094 PWlrWF4BlUlIV+Jh379pRWHyqLbVEk0pkry6UELMMJHmSHfoHA0Glj7C7qKwftZjwhTc ASAVoAx0DFaRGvXK2+kXYTXaTk4Fsdpabnkv77wHleoxVLuA5nY7tK/mpQqCaDwXW0PF vzr0Resu/OYd6yKZbpDX8Mh7Jy7RwKIU8TI9t/wYHh7YUS5FqSqjSSi8Z7s2WMsUXDWw SdwQ== X-Gm-Message-State: AOJu0YzU8tWzHhOKt10FaI+4hwx0XMo2nqHMrIFg7wN9k6DjNQr9KSSJ iBIjFWlwmgC1LxVvPmfrqPii3TU7EGauv6Vg8hz3OuLuJck/OxOIyhfMlYxFkMZ++UmhvOkb+D9 PilexA8yjYBS7i7n1oyg6h1kiI+Tu7vXwPjY= X-Google-Smtp-Source: AGHT+IHetSlVrNoNzt94Y4tcNYWb31WonsHZ+eJpx9Q8opWgEAKHJPCkXIG1zNwHHDF9mf5eWn6t2F+k2nleRJ0DBWE= X-Received: by 2002:a50:a688:0:b0:57d:10c:6c40 with SMTP id 4fb4d7f45d1cf-57d4bd569a0mr9898813a12.7.1719529504544; Thu, 27 Jun 2024 16:05:04 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 27 Jun 2024 16:05:03 -0700 From: Stefan Kangas In-Reply-To: <86msn669o1.fsf@gnu.org> References: <87ikxzafi5.fsf@pub.pink> <877cefaeoc.fsf@pub.pink> <87bk3r8wpm.fsf@pub.pink> <86msn669o1.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 27 Jun 2024 16:05:03 -0700 Message-ID: Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode To: Eli Zaretskii , john muhl Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: > Discard all of the patches or just that 4/4 part? I think just the 4/4 part, indeed, so I've installed patches 1 and 3 on emacs-30. Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.44 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 1.1 DATE_IN_PAST_06_12 Date: is 6 to 12 hours before Received: date -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.44 listed in wl.mailspike.net] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: 71736 Cc: 71736@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Eli Zaretskii writes: > Discard all of the patches or just that 4/4 part? I think just the 4/4 part, indeed, so I've installed patches 1 and 3 on emacs-30. I think patch 2 should go to master, but it doesn't apply cleanly. John, could you please rebase it and resend? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 12:48:12 2024 Received: (at 71736) by debbugs.gnu.org; 28 Jun 2024 16:48:12 +0000 Received: from localhost ([127.0.0.1]:46241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNElg-0003Gw-5e for submit@debbugs.gnu.org; Fri, 28 Jun 2024 12:48:12 -0400 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]:54183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNEld-0003Gf-HM for 71736@debbugs.gnu.org; Fri, 28 Jun 2024 12:48:10 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 26DF31140217; Fri, 28 Jun 2024 12:48:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 28 Jun 2024 12:48:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1719593284; x=1719679684; bh=S+8fD0ZdBq 8oeOP2ulDExTXXknanBpD/BvLI84/ow0o=; b=Cldr58TSxXVKfx8QnQsixHom1s nrFQuXL5//HVGE7fhRHSIVnw44+oYOMhV3sMeA5DWHylxfsQtOKUJe5Wf+h7Mf+P CCeYGKhYmIQNe+GkpVjTeRHklMqWY5faUo6OuRPk7+pZJSvEZ6QFJ0zB+SA/+Rqk HWGJx64jPh+Iv0ozHonyJpAM9rJV1u9DkPO91fMzN68RAT5MZMCU0fND8Qg7xGT7 74SEFCrz2AqizjJwmEJJATaRD6N3U0lP+d/YsLHPyAZV9BjZujZUNAMtFIKmNwUU Tw93XYXOXxFhcnDJxU4w9jPpml7lf7HbIvFv+pJHTQVXZ/itd5MKr6kNvoww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719593284; x=1719679684; bh=S+8fD0ZdBq8oeOP2ulDExTXXknan BpD/BvLI84/ow0o=; b=qs82cUQb4sGn/55TAPpjVJ4pbi6fGn7OvVhPYjnFLwza yplPIOvyvpXycCampvtK4dmUdIINl+7m6IRIZFDyRVkieGWrupRmp+38stfqghIW XrJOoUN0jAwAVZscSE6ME9l1HS/uLc30LLj2DGdps6VFGZpBUhLdaHCiQnQhr1M9 BYX2v1E6q2zuGQI8p7eHfeImnU6RpTOWuYXLr/9UndpCU5/ZbAOgsPdBW7ZxalRa e98eWmXs0M9DFeRSo+Vo+xQtWTRZ2+hkfvwXrWYzcTkeE9lgnS53+u4IUgxbYSom dUJSirfjvK7OvNVWCRCxNSVfTN0y+eRapwzHjL/yxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdejgdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjffhffgfkgggtsehmtderredtreejnecuhfhrohhmpehjohhhnhcu mhhuhhhluceojhhmsehpuhgsrdhpihhnkheqnecuggftrfgrthhtvghrnhepjedvleduge elfeeigedtudetvedvleeifffghfduhfdugffhgeevvdegffdvhfevnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhmsehpuhgsrdhpihhnkh X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jun 2024 12:48:03 -0400 (EDT) From: john muhl To: Stefan Kangas Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode In-Reply-To: (Stefan Kangas's message of "Thu, 27 Jun 2024 16:05:03 -0700") Date: Fri, 28 Jun 2024 11:24:41 -0500 References: <87ikxzafi5.fsf@pub.pink> <877cefaeoc.fsf@pub.pink> <87bk3r8wpm.fsf@pub.pink> <86msn669o1.fsf@gnu.org> User-Agent: mu4e 1.12.1; emacs 30.0.50 Message-ID: <871q4h3tfi.fsf@pub.pink> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71736 Cc: Eli Zaretskii , 71736@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Kangas writes: > Eli Zaretskii writes: > >> Discard all of the patches or just that 4/4 part? > > I think just the 4/4 part, indeed, so I've installed patches 1 and 3 on > emacs-30. Yep. I meant just the one part but of course you can always discard whatever you like :) > I think patch 2 should go to master, but it doesn't apply cleanly. > John, could you please rebase it and resend? Oops, I see now it included a bit of unrelated local changes. Here=E2=80=99s another try. I rebased it and checked that it applies to emacs-30 and master. Out of curiousity, what makes it unfit for the emacs-30 branch? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-keymap-set-in-lua-ts-mode-bug-71736.patch >From 8a1ba22c7c52f5b35e4ffcc292cef3bd35722a66 Mon Sep 17 00:00:00 2001 From: john muhl Date: Wed, 22 May 2024 12:23:19 -0500 Subject: [PATCH] ; Use 'keymap-set' in 'lua-ts-mode' (bug#71736) * lisp/progmodes/lua-ts-mode.el (lua-ts-mode-map): Replace 'define-key' with 'keymap-set'. --- lisp/progmodes/lua-ts-mode.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index 8d0f49c2d89..06daadbc1fd 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -722,10 +722,10 @@ lua-ts-inferior--write-history (defvar lua-ts-mode-map (let ((map (make-sparse-keymap "Lua"))) - (define-key map "\C-c\C-n" 'lua-ts-inferior-lua) - (define-key map "\C-c\C-c" 'lua-ts-send-buffer) - (define-key map "\C-c\C-l" 'lua-ts-send-file) - (define-key map "\C-c\C-r" 'lua-ts-send-region) + (keymap-set map "C-c C-n" 'lua-ts-inferior-lua) + (keymap-set map "C-c C-c" 'lua-ts-send-buffer) + (keymap-set map "C-c C-l" 'lua-ts-send-file) + (keymap-set map "C-c C-r" 'lua-ts-send-region) map) "Keymap for `lua-ts-mode' buffers.") -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 15:57:18 2024 Received: (at 71736-done) by debbugs.gnu.org; 28 Jun 2024 19:57:18 +0000 Received: from localhost ([127.0.0.1]:46497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNHig-0000A1-FC for submit@debbugs.gnu.org; Fri, 28 Jun 2024 15:57:18 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:53699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNHie-00009l-R4 for 71736-done@debbugs.gnu.org; Fri, 28 Jun 2024 15:57:17 -0400 Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-57ccd1111b0so646953a12.3 for <71736-done@debbugs.gnu.org>; Fri, 28 Jun 2024 12:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719604571; x=1720209371; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=4KMY/UWt0cp3RMMYbNQH6ciCao+RZZMvK0GyG0clQK4=; b=kXDBSRoKLdUh29gGcGJBONIL6MHGm2uDZaK0iHSMPGi516ORctdMK1ljUIOf92BI1C 6DXtc5kMXLfOK45g2qWJXRSlgHE1jpG3vohjvnMijK88/Sx6tq2dNXHNNnBarnVpO2Xr w5Vef0HoDFIyJZayYBVDAel5Jj65wp8ptXMmJNeu3f0dfY645JMssPOncEiAp3klt1HF Vs9aiCMo+omSmwKYuU4bZBKF6GuHOmZnKMcBs1aFakQp9/hokuiwC6pQY2SgO4hVhvkR UsEt6GhQMSBPTwdnGTyB7qB3t53I6jPCVa+vtpQXTGbBtPN4Sk3ljKoMjBWLPPIaQSiY SXKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719604571; x=1720209371; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4KMY/UWt0cp3RMMYbNQH6ciCao+RZZMvK0GyG0clQK4=; b=ZYSJANcK5WoKRdSZLU+9O6xTKgkrOTSLQJF4RBZMcwsAQNS36euQT7T9grT+CuW7T7 yYOTASDHEbsgq9rRDJ7GJHuPREJX1AQ+yApRlnIQFoh0LoZsW/MnyFvt5EjUNt2WyBcK RBIphQM90YayYYxwUP8qcbpJNlJg5UudysTn9/RF6Fl2m+V0bUDqiQwJes6kUtUeTxWZ hO/HknafWdhLYlsN6ok9FhGc9G/188ZkNehGMEr3SS95Xeg2VV8AAvJHz7Ne+6Yx/eH3 tSmciFipyCLUSkpQ+kxoPknMzTI48LU9hjdV5crnnRviLy0mcch3XZ4o0h4Yi9Sb1C86 Zn0w== X-Forwarded-Encrypted: i=1; AJvYcCXD7FzNzLTMCUe9UndiJ3tEPK7EWS17EzQcTq7rqlH+r4wsyRt+pzOe1KrF6Z8ov29XplPEVn9vpTUCpXd1cNPTdrO4Kj/O3osEYQ== X-Gm-Message-State: AOJu0YzgR0suLWuVwAn+m5VpKQC520mRG+Aa9L93fF1onNNEF9HLWKf9 iqfL3ZtOCmgMZLKotIp5UJmeKzKdVBJVJXOoi3qRYq0NGuf9yh03XBOBXvgxH8wuR7hcXe5Octp rw519P/DClfusLPuV/kjvsWJ5dQU= X-Google-Smtp-Source: AGHT+IFa8sgHteftNpluTVVzQPi6qDVj++qv3VDr7E9/PBKN6fBaBisiSSFhxqGUQp6q48qMWE4lWkDQKAulYVzbiJ4= X-Received: by 2002:a50:c35b:0:b0:57a:3046:1cd8 with SMTP id 4fb4d7f45d1cf-57d4bd5a0ddmr12994530a12.7.1719604570434; Fri, 28 Jun 2024 12:56:10 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Jun 2024 12:56:09 -0700 From: Stefan Kangas In-Reply-To: <871q4h3tfi.fsf@pub.pink> References: <87ikxzafi5.fsf@pub.pink> <877cefaeoc.fsf@pub.pink> <87bk3r8wpm.fsf@pub.pink> <86msn669o1.fsf@gnu.org> <871q4h3tfi.fsf@pub.pink> MIME-Version: 1.0 Date: Fri, 28 Jun 2024 12:56:09 -0700 Message-ID: Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode To: john muhl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71736-done Cc: 71736-done@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 john muhl writes: > Stefan Kangas writes: > >> I think patch 2 should go to master, but it doesn't apply cleanly. >> John, could you please rebase it and resend? > > Oops, I see now it included a bit of unrelated local changes. > > Here=E2=80=99s another try. I rebased it and checked that it applies to > emacs-30 and master. Thanks! > Out of curiousity, what makes it unfit for the emacs-30 branch? We prefer not to put code cleanups on the release branch. So I've now pushed it to `master`, and I'm closing this bug report. BTW, is there any reason not to use `defvar-keymap' in lua-ts-mode.el? Does it need to be compatible with Emacs 28? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 18:26:13 2024 Received: (at 71736) by debbugs.gnu.org; 28 Jun 2024 22:26:13 +0000 Received: from localhost ([127.0.0.1]:36288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNK2n-0000U7-9e for submit@debbugs.gnu.org; Fri, 28 Jun 2024 18:26:13 -0400 Received: from fout3-smtp.messagingengine.com ([103.168.172.146]:59619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNK2k-0000Ts-UV for 71736@debbugs.gnu.org; Fri, 28 Jun 2024 18:26:12 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id 5CFFA138022D; Fri, 28 Jun 2024 18:16:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 28 Jun 2024 18:16:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1719612998; x=1719699398; bh=FQknr26VkEbDmtVbjRlVO/iMyEMMo30JzlXFX6u/oWo=; b= O/14heTFpFrNK9/gbOzilC8PVnQcXhyFGXFZgAEVJz9tP+bylUx97KDNcdVwz7Z4 Q5ADbfd+cs5vpaIRe8FRFy/S1zVKH3jwswfzK+tO5FD32cBndhbm5fwpZ3hYN11S xDUv6Pwej+wHVt5xQFy3A50eBXkBCCtgEve6vhFmR1uIwTohIlxllhKbo3nUIenY CDGzGxRKEDKvOMf3je7zLNURWMoYRE0sqvkYTbOvLKrZGEYAHkmpPl0o2bv46dfn aRLOn8uZtGPCrO/Ftu2fvM/ixSnLEGFd/5VqjQMdLha2Gf94pQ0HaqDlkzpEVGjd 0gdEjjHJ2jQnv7/1qH30RQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1719612998; x= 1719699398; bh=FQknr26VkEbDmtVbjRlVO/iMyEMMo30JzlXFX6u/oWo=; b=t 5q428mC1vrMrk1B4ZlXKtUCL46ZUxeUuxDjZKO6FOKh5XQphY/5OW6D8iPwFg25d p+R0zB4JkpMVc0KMANIbIxF2B1xhOYtlqS3PWH7SWy1ojn5wR/PQJtTNf9IXHPOe 382JE1YOmu6dQNe7pHXzvOtwU+lapOdAYZSks+qP7bchzGl6S5lh4PHpBHOIgtrS kNtTvh0UaEDpT2HZSSUoiBKX0DHJYtQPRuOBrH8Map8Tm9mXIGII8A8hIXdNvX8K eQjT2hMx/zZ2uaKuxdG5piynNPJqQ5O2So/8Hjx6LHfNiqnpmK8YzkTGgF9t9HKt qJmIJnLW8SXdYKqPKtV2Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdekgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujghffgffkfggtgfgsehtqh ertddtreejnecuhfhrohhmpehjohhhnhcumhhuhhhluceojhhmsehpuhgsrdhpihhnkheq necuggftrfgrthhtvghrnhepgeevhedvtdetvdekuddvtddthefhvdfggfdvgfeitdejud ehhfffjedtvdevveeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepjhhmsehpuhgsrdhpihhnkh X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jun 2024 18:16:37 -0400 (EDT) From: john muhl To: 71736@debbugs.gnu.org Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode In-Reply-To: (Stefan Kangas's message of "Fri, 28 Jun 2024 12:56:09 -0700") References: <87ikxzafi5.fsf@pub.pink> <877cefaeoc.fsf@pub.pink> <87bk3r8wpm.fsf@pub.pink> <86msn669o1.fsf@gnu.org> <871q4h3tfi.fsf@pub.pink> User-Agent: mu4e 1.12.1; emacs 30.0.50 Date: Fri, 28 Jun 2024 17:16:36 -0500 Message-ID: <875xtssofv.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71736 Cc: stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: > BTW, is there any reason not to use `defvar-keymap' in > lua-ts-mode.el? Probably I did not remember (or know) it was available. I=E2=80=99ll change it. > Does it need to be compatible with Emacs 28? Let=E2=80=99s hope not. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 23:00:38 2024 Received: (at 71736) by debbugs.gnu.org; 29 Jun 2024 03:00:38 +0000 Received: from localhost ([127.0.0.1]:36532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOKM-0007ZJ-Eh for submit@debbugs.gnu.org; Fri, 28 Jun 2024 23:00:38 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:49198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOKL-0007Z6-0j for 71736@debbugs.gnu.org; Fri, 28 Jun 2024 23:00:37 -0400 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5854ac817afso1528141a12.2 for <71736@debbugs.gnu.org>; Fri, 28 Jun 2024 20:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719629971; x=1720234771; darn=debbugs.gnu.org; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=R0ZTELMMcua/CTB1T253O6RffJ2vCUtoDxR2ZiQyJj8=; b=Y3eANxozt06DMfgHvEsnclB8R96lICFkDh51/yo1YQhvaohAzUkzGtR+DcyJ3kaaIm bHsmYS3PQYGoZ6wQ3ZmFDjyooSiTY88wMoOeFrF+kveIDFL285HqmXdoNByp2SeqXvbY Vdt1sMBLyXa+XrmvMTeo5xH+HkzAc5znXVfaOJHy22iKPvGG7AHFchPtDLSYb7jdRs8P kQwMJEXHfq2v/9jxeQRffWmVfPuyQIODALsg7SMBRjuvgWRjAeJRZKFOZ7GDOzMtHe+s VCn0VZXvnNGqQZ8mk+tGhglchLlGBkPj0C6HSS7OlWjzIabIYUvQytta7wa9K6f92iDo Ic6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719629971; x=1720234771; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=R0ZTELMMcua/CTB1T253O6RffJ2vCUtoDxR2ZiQyJj8=; b=mn+ZORBsjeu4BANiICd5K0vHp6XvV7YVFEME6x4/4Lh0CdrWZmXMyqepmakeuR1UTW bdE/6lD/PvgMGGxiS702xkqeh/z9Is9WvZFzfKsSCzTsrLrsJ/dOPF/Z2uBMnzxNzPMk 3Yl5rEVpouyf9FEy7Lsuh+35vlpxEckYBwUcW8t6IfE0ue7N+ZShjIxVq70Z0y9BIQ1t DlJdX/LZMTKe/Z3f8vYkCNNwvFMsLZ1vw+/z8kK39nSjLTIwDGFzW96mHjV9qKxr6FdF 1SsnKmssLZ1X0Xh/M+Quo1c24ly5dLMrePEDOY8MvSAnrkY5AgdKC/KAAx1KctKuBUDO 3eXg== X-Forwarded-Encrypted: i=1; AJvYcCVm3jXsq9gArYu6kBuzyVjUQcWD3K4Qn0ZaaOpNmtVDVjuXBPe5PJY9lWFwqydKS8ybJG9qWshukNwTJeniB2w86IpHpGA= X-Gm-Message-State: AOJu0YwqLJbgGrYn9+5SrCyQKsH8BKNWstu0CwISB+wwRnbUV62kVugM nbijHbuR/anALmwSXxbPt1PNqNp5uMcFTUgbexq6JhpETKHuhd+aKseKyKX5/FYDMRe9RGmCuTn 5GLi0HVjpN0UgiwyHYfPgSO0V++o= X-Google-Smtp-Source: AGHT+IFb7RHE4U9ggW9azdX6Ub8Gs/padQchkfEElslTjo/tlcQ5MVTZQo1dbwDpruYp0ylVRFzxU7j7HmuCEihmSZc= X-Received: by 2002:a50:aa96:0:b0:57d:f84:11a9 with SMTP id 4fb4d7f45d1cf-57d4a28e2e3mr15983401a12.22.1719629971260; Fri, 28 Jun 2024 19:59:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Jun 2024 19:59:30 -0700 From: Stefan Kangas In-Reply-To: <875xtssofv.fsf@pub.pink> References: <87ikxzafi5.fsf@pub.pink> <877cefaeoc.fsf@pub.pink> <87bk3r8wpm.fsf@pub.pink> <86msn669o1.fsf@gnu.org> <871q4h3tfi.fsf@pub.pink> <875xtssofv.fsf@pub.pink> MIME-Version: 1.0 Date: Fri, 28 Jun 2024 19:59:30 -0700 Message-ID: Subject: Re: bug#71736: Small cleanup patches for lua-ts-mode To: john muhl , 71736@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71736 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) john muhl writes: > Stefan Kangas writes: > >> BTW, is there any reason not to use `defvar-keymap' in >> lua-ts-mode.el? > > Probably I did not remember (or know) it was available. I=E2=80=99ll > change it. Thanks. From unknown Sun Sep 21 01:08:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Jul 2024 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator