From unknown Thu Jun 19 14:07:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71735 <71735@debbugs.gnu.org> To: bug#71735 <71735@debbugs.gnu.org> Subject: Status: [PATCH] services: mpd: fix log to file Reply-To: bug#71735 <71735@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:07:24 +0000 retitle 71735 [PATCH] services: mpd: fix log to file reassign 71735 guix-patches submitter 71735 Yarl Baudig severity 71735 normal tag 71735 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 10:17:09 2024 Received: (at submit) by debbugs.gnu.org; 23 Jun 2024 14:17:09 +0000 Received: from localhost ([127.0.0.1]:34315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLO1l-0005bW-5n for submit@debbugs.gnu.org; Sun, 23 Jun 2024 10:17:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:34234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLO1j-0005bN-J9 for submit@debbugs.gnu.org; Sun, 23 Jun 2024 10:17:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLO1i-0001Gi-Jw for guix-patches@gnu.org; Sun, 23 Jun 2024 10:17:06 -0400 Received: from msg-4.mailo.com ([213.182.54.15] helo=mailo.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLO1g-0006Px-Ne for guix-patches@gnu.org; Sun, 23 Jun 2024 10:17:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailoo.org; s=mailo; t=1719152220; bh=XIIdJE2NOpv+nM2IsIU2ttte5nywc0/aHm5p46sylyg=; h=X-EA-Auth:From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding; b=XgVFuFWXR0F0BD75ZvSCKS+3dPm/8+RBauG3Se3fnlwE/1ewaDhZtiGdZwiSVjLa2 A9OORpOMxwZSHCE8D3yAorKpbUCgXw8njqg0pJBwZd/d1so8QDaV72hmdYGl5G+PKb 17USvbCjQtSx8PsY07kTte3KUEAPXWnPJ0ChhDIM= Received: by b221-3.in.mailobj.net [192.168.90.23] with ESMTP via ip-20.mailobj.net [213.182.54.20] Sun, 23 Jun 2024 16:17:00 +0200 (CEST) X-EA-Auth: 2+0Ek67p73dpP2anWkfRPZ8k76m89VVYXCt0D9ZaMUgBRWqtoF8Nizk0cqb5JcI8CCt9O8Kk/cvy8TJWKoKZTTd8g85yc7BZ8JMxR3wXl0I= From: Yarl Baudig To: guix-patches@gnu.org Subject: [PATCH] services: mpd: fix log to file Date: Sun, 23 Jun 2024 16:15:58 +0200 Message-ID: <20240623141657.61044-1-yarl-baudig@mailoo.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=213.182.54.15; envelope-from=yarl-baudig@mailoo.org; helo=mailo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Yarl Baudig X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) (match value (%unset-value ...)) is equivalent here to (match value (_ ...)). Even if you set 'log-file to some path, it's always "syslog" in the configuration file. * gnu/services/audio.scm (mpd): fix buggy 'match'. --- gnu/services/audio.scm | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm index ae991ced4d..2c8af138e7 100644 --- a/gnu/services/audio.scm +++ b/gnu/services/audio.scm @@ -251,16 +251,12 @@ (define (mpd-group-sanitizer value) (configuration-field-error #f 'group value)))) (define (mpd-log-file-sanitizer value) - (match value - (%unset-value - ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is - ;; supposed to cause logging to happen via systemd (elogind provides a - ;; compatible interface), this doesn't work (nothing gets logged); use - ;; syslog instead. - "syslog") - ((? string?) - value) - (_ (configuration-field-error #f 'log-file value)))) + ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is + ;; supposed to cause logging to happen via systemd (elogind provides a + ;; compatible interface), this doesn't work (nothing gets logged); use + ;; syslog instead. + (let ((value (maybe-value value "syslog"))) + (if (string? value) value (configuration-field-error #f 'log-file value)))) ;;; -- 2.45.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 21:46:35 2024 Received: (at 71735-done) by debbugs.gnu.org; 24 Jun 2024 01:46:35 +0000 Received: from localhost ([127.0.0.1]:60843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLYmx-0005UJ-5h for submit@debbugs.gnu.org; Sun, 23 Jun 2024 21:46:35 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:55329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLYmv-0005Tv-0o for 71735-done@debbugs.gnu.org; Sun, 23 Jun 2024 21:46:33 -0400 Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-44051a577easo18615121cf.2 for <71735-done@debbugs.gnu.org>; Sun, 23 Jun 2024 18:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719193526; x=1719798326; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=jTJzt4/kymk8StDbrQ83ZiGap33uQhztK2dTlwIdKzg=; b=MGgl3xGt0NEdY5Pt2HThsO01r30FnsIEVxhbTs7//guNBgRPOD0BCg2RkHecFT7y/i RjKiRritXC3pqi/mfmhR5QSwb0nSBfHJrhhIJ8r0TxWsLZs15U+h1wVgKJwlQyc6VYAZ IfRJpDacNbtACHXCPvDb1dXsFj3nThv9CGFVCMYVbfVqzBBIm2fQ8PV75uAgi5cyuX71 NMzUKUogKhSOXPUZjTee7PXJ5sU9NWgAkQOMCNcxNm2Ol59GqUgJHmbBkhM6+WIrwyMS SRFjaY4FLrmAfUMEC/2IoLvFkAcyUJwsD/q6JWUld0dvIftb/yhVKl7hUDR/6xluYlIs nyJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719193526; x=1719798326; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jTJzt4/kymk8StDbrQ83ZiGap33uQhztK2dTlwIdKzg=; b=Rxmn6OEIpmvTCtFFTVH4TbLSUUnYtQVq+xgUSlECjNpbAsJtZtUdXRgWpHewDMmvoD vW1ldD+HDHWSOAB1okciyhZoPeL4A+TZ4ZUG4XVYQdI/x7qqRGEBlkjRBBVLRtMgnd7Z 50VsvSmyrDO3dIN+ySglHUjIJONIXK7M1Y1wLkwhx6YxlTQsjzG5uTGPSjwEbPANTJ3x RJMNCPWeTS2GMnVTAeq/0oHjFoNhqfRXdOpanvOrwF6FBvMT79KJCYPNRnb9qj/NUCH0 U8xtJu7vzmRvK17tiiDebE//hYhuw8WF/ffe/2ynch8A9gGT4goIKMw9Bp0COLMA5YEr uuoQ== X-Gm-Message-State: AOJu0Yyvn9/C/AbRGMakCcUZjZmxgb58z4Wvdd5+MZ7RKcQelgtpgy4D ewmdHKxOW7bAVS+yOfU2VPx3Ac7aLZviyoswtX0JxVV8EboVOYzmGzCVlRY/ X-Google-Smtp-Source: AGHT+IGvyUzQu+sHlLVKRWmFyJSEnsOyYiOREhMW4jEDPQEjUzPJLQfmfEdokND3ntV85vPqYru7KA== X-Received: by 2002:ac8:5fcd:0:b0:441:531f:e06c with SMTP id d75a77b69052e-444d9218d2fmr44685601cf.30.1719193525581; Sun, 23 Jun 2024 18:45:25 -0700 (PDT) Received: from hurd (dsl-205-233-124-241.b2b2c.ca. [205.233.124.241]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-444c2ba38edsm37282601cf.53.2024.06.23.18.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jun 2024 18:45:24 -0700 (PDT) From: Maxim Cournoyer To: Yarl Baudig Subject: Re: [bug#71735] [PATCH] services: mpd: fix log to file In-Reply-To: <20240623141657.61044-1-yarl-baudig@mailoo.org> (Yarl Baudig's message of "Sun, 23 Jun 2024 16:15:58 +0200") References: <20240623141657.61044-1-yarl-baudig@mailoo.org> Date: Sun, 23 Jun 2024 21:45:23 -0400 Message-ID: <87v81z9kr0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71735-done Cc: 71735-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Yarl, Yarl Baudig writes: > (match value (%unset-value ...)) is equivalent here to > (match value (_ ...)). Even if you set 'log-file to some path, it's always > "syslog" in the configuration file. Interesting! It seems like using a variable in the pattern doesn't work as I had expected... Thanks for the fix. > * gnu/services/audio.scm (mpd): fix buggy 'match'. > --- > gnu/services/audio.scm | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm > index ae991ced4d..2c8af138e7 100644 > --- a/gnu/services/audio.scm > +++ b/gnu/services/audio.scm > @@ -251,16 +251,12 @@ (define (mpd-group-sanitizer value) > (configuration-field-error #f 'group value)))) > > (define (mpd-log-file-sanitizer value) > - (match value > - (%unset-value > - ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is > - ;; supposed to cause logging to happen via systemd (elogind provides a > - ;; compatible interface), this doesn't work (nothing gets logged); use > - ;; syslog instead. > - "syslog") > - ((? string?) > - value) > - (_ (configuration-field-error #f 'log-file value)))) > + ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is > + ;; supposed to cause logging to happen via systemd (elogind provides a > + ;; compatible interface), this doesn't work (nothing gets logged); use > + ;; syslog instead. > + (let ((value (maybe-value value "syslog"))) > + (if (string? value) value (configuration-field-error #f 'log-file value)))) Applied, closing! -- Thanks, Maxim From unknown Thu Jun 19 14:07:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Jul 2024 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator