From unknown Tue Jun 17 22:23:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71734: 30.0.50; eww interprets make errors as URLs Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2024 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 71734@debbugs.gnu.org Cc: Lars Ingebrigtsen X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Lars Ingebrigtsen Received: via spool by submit@debbugs.gnu.org id=B.171914832910330 (code B ref -1); Sun, 23 Jun 2024 13:13:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jun 2024 13:12:09 +0000 Received: from localhost ([127.0.0.1]:58724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLN0q-0002gX-Ov for submit@debbugs.gnu.org; Sun, 23 Jun 2024 09:12:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:57220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLN0n-0002gO-M9 for submit@debbugs.gnu.org; Sun, 23 Jun 2024 09:12:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLN0m-0005ju-Ec for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 09:12:04 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLN0k-0000lB-1Y for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2024 09:12:04 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2ec50d4e47bso18434021fa.2 for ; Sun, 23 Jun 2024 06:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719148318; x=1719753118; darn=gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=7fBTMW1gzziI5r8gMZ4NLN6yLfouFERuBcZrWIcu1JQ=; b=P6zABDyF5qFCVhZAINTO79C9ayReeZy0ByTEOvvDwtLh5I0p7xDGatswvWEqaXIFDl Fp7AC+bnPTgc97cin7yH0ZN6JG91Hpv1xpoH8ZE6YlFgZC47wMW1YjGegWVJHI6Or2ky 23wrA6WIXzFPyPr+ICf8P5dk2KE1G4aK48N8y/jPDWRZtMQ4JIyzqib0jf9TnKUFk21K 2B30Bp6z79jKVm6c0FtLX9zLNv40Hn1sDWY263CkOYgxgS8AB4n/Nay+/a1KaM+XLE6/ J/ddMKzpmaKajke54VkB1S61ZZAFRsfWNEBfict0WyaQlt+f7S2RYG+pu+DEb2yGYao0 r0zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719148318; x=1719753118; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7fBTMW1gzziI5r8gMZ4NLN6yLfouFERuBcZrWIcu1JQ=; b=iX6n2gabDKzPn2aMrrwjhxeQLfsmhsxoYoGtCRV/moTOgPqUXxpfkwf5N9KakEsUAU G3SpPQVVBOa9CXOe8IEYfdCKtf+c0UCRmEPhbC1NfCbbNMYAexXiCckXLAEgWVTCt97E uCdD3M6yZwG66bG6J4C67W5UOzSbSrq9U6wYfU0upcNtyA0kW4PFj4zzkaQt/tZ4yU02 oSPIy3IlpnD8z2S+1xDyd4ADbU7JnYGV1wxFhLeTzxHc5/pLMUrmYvy1TznMy/KzSn+e V191FN9vCTzYt7REou8HbcSVpqiBL5+envsNXW4/HJZcw77G3Rvqyp4fz4CMbte6zSIu RlHw== X-Gm-Message-State: AOJu0YxQCPn0m8ukTH7M5BWj07UR1jWzRRMT+549fIklGDvKimF5CYJ9 qYbNuXyVeX6LlmA/tkeKbMdMnG0tq63FmGUV7fTzRlziM5xKF49SLynS38QBgMmi4iFgJHAsTuK 0ilVZ6NJUc6xg0UMhmODngOUSEmzlA392nN0= X-Google-Smtp-Source: AGHT+IFhokDCADUSPVkJn4LFkrydto0VfryAPw2D7TofmxO0B5zfjh7UYTrxUWOycdMMRYOZmeHGhK4uKF/uBPEk3ck= X-Received: by 2002:a2e:9590:0:b0:2ec:5075:83cc with SMTP id 38308e7fff4ca-2ec5b27e833mr11432981fa.19.1719148318390; Sun, 23 Jun 2024 06:11:58 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 23 Jun 2024 06:11:57 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 23 Jun 2024 06:11:57 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=stefankangas@gmail.com; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) `M-x eww` currently interprets this as a URL: make: *** [Makefile:240: __sub-make] Error 2 I think this is due to the below commit: ``` commit 4113ac253456027c4b54b92a617e0c2b3003a049 Author: Lars Ingebrigtsen Date: Sun Jan 11 15:58:10 2015 +0100 Further eww URL DWIM tweaks * net/eww.el (eww): Interpret anything that looks like a protocol designator as a full URL. diff --git a/lisp/net/eww.el b/lisp/net/eww.el --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -258,29 +258,31 @@ - (if (or (string-match "\\`https?:" url) + ;; Anything that starts with something that vaguely looks + ;; like a protocol designator is interpreted as a full URL. + (if (or (string-match "\\`[A-Za-z]+:" url) ``` I think that this is much too dwim-y, and we should go back to the old code. But I have no idea why Lars made the above change in the first place, so I'd like to check here first. If the intention is to support the various protocols that Emacs supports, then we should look for exactly those and nothing else. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-06-22 built on xxxxx Repository revision: 014aab9847a0d3d898cb8cbc7224143f2d741abb Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux 12 (bookworm) From unknown Tue Jun 17 22:23:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71734: 30.0.50; eww interprets make errors as URLs Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 09:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: larsi@gnus.org, 71734@debbugs.gnu.org Received: via spool by 71734-submit@debbugs.gnu.org id=B71734.171947884931567 (code B ref 71734); Thu, 27 Jun 2024 09:01:01 +0000 Received: (at 71734) by debbugs.gnu.org; 27 Jun 2024 09:00:49 +0000 Received: from localhost ([127.0.0.1]:40973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkzp-0008D5-FW for submit@debbugs.gnu.org; Thu, 27 Jun 2024 05:00:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkzn-0008Ct-Is for 71734@debbugs.gnu.org; Thu, 27 Jun 2024 05:00:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMkze-0001iB-RG; Thu, 27 Jun 2024 05:00:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=B5gouYg6fQC0TUT/Q4NqunGe72qRfFoOwnVbsFBPAHw=; b=XT9hV+3HYhBb vqqFWrwRzQbx1AsU1rBzRYBGWH/ozN4Ud0VtlBkkFb+7g06jhYp3eYFAXeXWLEwpmrusGQKf5Y9nI AgMuRoCkeKLIJWZzmbC/pZClPgq54d9FbeQQNFceI0aCfdO6f7O8p60j03zgM4welTenZzbUAWtve r/tf7/rJaL3odFCYkqT1kgIma3n7HRgGFpdopqv1D4V+11MiiFCA//7At1Mj2YfNnSVifEs+wYwTP 3e/eyuJ5rNQWyQIAaoqjyI4BvOaxT6iK0JsE15HFbd6tOEbMX5TdHZqbvw4EOBLT5qDGb00r/9OPc 8QQg815q4lTtySMtQYQKCg==; Date: Thu, 27 Jun 2024 12:00:33 +0300 Message-Id: <86o77m69qm.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Sun, 23 Jun 2024 06:11:57 -0700) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Lars Ingebrigtsen > From: Stefan Kangas > Date: Sun, 23 Jun 2024 06:11:57 -0700 > > `M-x eww` currently interprets this as a URL: > > make: *** [Makefile:240: __sub-make] Error 2 > > I think this is due to the below commit: > > ``` > commit 4113ac253456027c4b54b92a617e0c2b3003a049 > Author: Lars Ingebrigtsen > Date: Sun Jan 11 15:58:10 2015 +0100 > > Further eww URL DWIM tweaks > > * net/eww.el (eww): Interpret anything that looks like a protocol > designator as a full URL. > > diff --git a/lisp/net/eww.el b/lisp/net/eww.el > --- a/lisp/net/eww.el > +++ b/lisp/net/eww.el > @@ -258,29 +258,31 @@ > - (if (or (string-match "\\`https?:" url) > + ;; Anything that starts with something that vaguely looks > + ;; like a protocol designator is interpreted as a full URL. > + (if (or (string-match "\\`[A-Za-z]+:" url) > ``` > > I think that this is much too dwim-y, and we should go back to the old > code. OTOH, expecting "M-x eww" to do something sensible in the above case is a bit far-fetched, IMHO. I think the question we should ask ourselves is whether the use cases fixed by Lars's change are more important to keep supported than fixing the case above. From unknown Tue Jun 17 22:23:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71734: 30.0.50; eww interprets make errors as URLs Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2024 06:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas , 71734@debbugs.gnu.org Cc: Lars Ingebrigtsen Received: via spool by 71734-submit@debbugs.gnu.org id=B71734.17195547153387 (code B ref 71734); Fri, 28 Jun 2024 06:06:02 +0000 Received: (at 71734) by debbugs.gnu.org; 28 Jun 2024 06:05:15 +0000 Received: from localhost ([127.0.0.1]:51504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4jS-0000sU-Kf for submit@debbugs.gnu.org; Fri, 28 Jun 2024 02:05:14 -0400 Received: from mail-vs1-f41.google.com ([209.85.217.41]:51489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sN4jP-0000rc-75 for 71734@debbugs.gnu.org; Fri, 28 Jun 2024 02:05:11 -0400 Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-48f59584cbbso81193137.3 for <71734@debbugs.gnu.org>; Thu, 27 Jun 2024 23:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719554652; x=1720159452; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=j77mN0dJG+19aCe/mjHADvY34kB9ZHNIY6IRoVNeYKA=; b=ZT3++aGOm5qtUypioFctymn8YYKbm6VoMpqCTB5EF8HJTR83qqfXCPOBgalU+inzTC C+tja5DENLzIMT4YAc0ssmQpoyXOcAFTuYUEnCXm2xvfq5JExtoILWH/hoeEedonGzKz ActH9Ybi3cKa7b2TFpsLc3dhk7EWE13S1xLuE490yw7pSZvnY3s3rc2dkPlJ6r9r+dBC YtciGkOJU9gvelwXCT8u5453v9sF+5n/JfxwbRHEslAiY2Q3cGhA4QjA6R+lz+gV9oRP LTWZOlzenKOwA9EPjHsHUChIGWrMRgpXSUfGbtZGdGwUxvFMpTs35Vvgpq7hHtwdVYnl LjEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719554652; x=1720159452; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j77mN0dJG+19aCe/mjHADvY34kB9ZHNIY6IRoVNeYKA=; b=JXTmDfQTWH7jSjEswHemZuhJFTNbYsCC3dskBCK2UBJiXdw2GhfyMWJmUQJ0MeZySV MYHKXlcMDE9d6k5wd1n7yI9tFYUoNDRj69Zv98K4MTVIcxDjeEW3Hw0mTcfYPsbFsiwO l7KB3VuBToQIjHglDWEYpiIlIFL4W3AVQ4vXGtgO9Dypy4sbLefOUZF17QQp2VFgdbuw zSmtBkcQDHiJvr8+v00JJNjv9dCF4OhVMy8QTELsgogqTHyOfEE/6pThMfnih+caYnTL 2fMiP4zWuGMEwpN89l0o2COOD0xeeTZ+aZSCpqDI18Piu1DgIm37fAeh886gceONiK4y L32Q== X-Forwarded-Encrypted: i=1; AJvYcCUARYFDOru6QSGFAoBJ+0GNhIWJbM8Dzg6RXIQOs7NuE224lWt1G0dwi98M6UPbtLuWSDPluq8QhL+/jyoxatwog5B7ljQ= X-Gm-Message-State: AOJu0Yx8/kBD+0mFgO/9z7EIaQWVIllHbTY8X4GZ5K4Sp38yxuZ275qS cNwI4vIWZhVmKd6/DWQqCn/N74sbdWI8GPpwGHtrGMSfMrp07ef6kS+YUw== X-Google-Smtp-Source: AGHT+IFPL+qMslgfKW7+jaeqGR9hRiKm1ZfPKT2PCRQIBzU4iIM+eqqwVUgu4OMWzs2+KVXN4MIEKw== X-Received: by 2002:a62:e70b:0:b0:706:5a4a:dcd0 with SMTP id d2e1a72fcca58-7067475f15bmr14427484b3a.34.1719547788618; Thu, 27 Jun 2024 21:09:48 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-72c6c7f761fsm454378a12.62.2024.06.27.21.09.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jun 2024 21:09:48 -0700 (PDT) Message-ID: Date: Thu, 27 Jun 2024 21:09:48 -0700 MIME-Version: 1.0 Content-Language: en-US References: From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/23/2024 6:11 AM, Stefan Kangas wrote: > `M-x eww` currently interprets this as a URL: > > make: *** [Makefile:240: __sub-make] Error 2 Interprets it how? I can't seem to reproduce the issue. I tried putting point on various spots in that line and calling M-x eww, but EWW never tried to turn anything from that line into the default URL for the prompt. Maybe I'm just not doing the same thing you did; could you list the steps to reproduce this?