GNU bug report logs - #71724
30.0.50; [PATCH] php-ts-mode: Colorize CSS property value like `css--fontify-region'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71724 in the body.
You can then email your comments to 71724 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50;
 [PATCH] php-ts-mode: Colorize CSS property value like `css--fontify-region'
Date: Sat, 22 Jun 2024 23:36:13 +0200

[Message part 1 (text/plain, inline)]

Hi, 
this patch adds a new feature to colorize a property when it's value is a text 
that represents a CSS color. It will be fontified such that its background is 
the color itself, like in 'cs-ts-mode'.
A new custom var 'php-ts-mode-css-fontify-colors' can be used to toggle this 
behavior.

Thanks.
Vincenzo

[0001-Colorize-CSS-property-value-like-css-fontify-region.patch (text/x-patch, attachment)]

Message #10 received at 71724-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 71724-done <at> debbugs.gnu.org
Subject: Re: bug#71724: 30.0.50;
 [PATCH] php-ts-mode: Colorize CSS property value like
 `css--fontify-region'
Date: Sun, 23 Jun 2024 08:06:10 +0300

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Date: Sat, 22 Jun 2024 23:36:13 +0200
> 
> this patch adds a new feature to colorize a property when it's value is a text 
> that represents a CSS color. It will be fontified such that its background is 
> the color itself, like in 'cs-ts-mode'.
> A new custom var 'php-ts-mode-css-fontify-colors' can be used to toggle this 
> behavior.

Thanks, installed, and closing the bug.

Please in the future observe our conventions for the commit log
messages:

> Subject: [PATCH] Colorize CSS property value like `css--fontify-region'
> 
> If the value of a property is text representing a CSS color, it will be
> fontified such that its background is the color itself.
> 'php-ts-mode-css-fontify-colors' can be used to disable this behaviour.

These lines are too long.  They will be indented by a TAB in the
generated ChangeLog file, so they should preferably be no longer than
65 characters.

> * lisp/progmodes/php-ts-mode.el (php-ts-mode-css-fontify-colors):
>   New custom var.
 ^^^
Please don't leave this whitespace at the beginning of lines.

> * lisp/progmodes/php-ts-mode.el (php-ts-mode): Use the new function.

This line is also too long.

I usually correct any log messages that need it, but if you observe
these conventions better, it will make my job easier.

Thanks.

Message #13 received at 71724-done <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71724-done <at> debbugs.gnu.org
Subject: Re: bug#71724: 30.0.50;
 [PATCH] php-ts-mode: Colorize CSS property value like `css--fontify-region'
Date: Sun, 23 Jun 2024 12:11:07 +0200

In data domenica 23 giugno 2024 07:06:10 CEST, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > Date: Sat, 22 Jun 2024 23:36:13 +0200
> > 
> > this patch adds a new feature to colorize a property when it's value is a
> > text that represents a CSS color. It will be fontified such that its
> > background is the color itself, like in 'cs-ts-mode'.
> > A new custom var 'php-ts-mode-css-fontify-colors' can be used to toggle
> > this behavior.
> 
> Thanks, installed, and closing the bug.
> 
> Please in the future observe our conventions for the commit log
> 
> messages:
> > Subject: [PATCH] Colorize CSS property value like `css--fontify-region'
> > 
> > If the value of a property is text representing a CSS color, it will be
> > fontified such that its background is the color itself.
> > 'php-ts-mode-css-fontify-colors' can be used to disable this behaviour.
> 
> These lines are too long.  They will be indented by a TAB in the
> generated ChangeLog file, so they should preferably be no longer than
> 65 characters.
> 
> > * lisp/progmodes/php-ts-mode.el (php-ts-mode-css-fontify-colors):
> >   New custom var.
> 
>  ^^^
> Please don't leave this whitespace at the beginning of lines.
> 
> > * lisp/progmodes/php-ts-mode.el (php-ts-mode): Use the new function.
> 
> This line is also too long.
> 
> I usually correct any log messages that need it, but if you observe
> these conventions better, it will make my job easier.
> 
> Thanks.
I apologize, I will be more accurate with the commit log messages.
Thank you very much Eli.

Vincenzo

Message #16 received at 71724 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 71724 <at> debbugs.gnu.org
Subject: Re: bug#71724: 30.0.50;
 [PATCH] php-ts-mode: Colorize CSS property value like `css--fontify-region'
Date: Sun, 23 Jun 2024 13:15:52 +0300

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Cc: 71724-done <at> debbugs.gnu.org
> Date: Sun, 23 Jun 2024 12:11:07 +0200
> 
> I apologize, I will be more accurate with the commit log messages.

No need to apologize, we aren't born with this knowledge.

Thank you for you continuing contributions.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.